Fix grpc server error mark by amarziali · Pull Request #7505 · DataDog/dd-trace-java

amarziali · 2024-08-26T09:39:56Z

What Does This Do

This PR fixes the way the grpc server spans are marked as errored.

In fact, in case a server service was returning a status through a StatusException or StatusRuntimeException, the span was marked as errored (because onError generally does it) despite the fact that dd.grpc.server.error.statuses was excluding it.

Now the setError on the span is called always. For info, a similar issue occurred for the http server decorator in the past and was due to the same buggy setError conditional logic.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-12919

pr-commenter · 2024-08-26T10:09:37Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/grpcstatus
git_commit_date	1724659573	1724665104
git_commit_sha	`074bc9b`	447a295d32
release_version	1.39.0-SNAPSHOT~074bc9bc4e	1.39.0-SNAPSHOT~447a295d32

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1724667379	1724667379
ci_job_id	616622257	616622257
ci_pipeline_id	42790444	42790444
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047285
Total [baseline] (8.484 s) : 0, 8484150
Agent [candidate] (1.051 s) : 0, 1051189
Total [candidate] (8.519 s) : 0, 8518953
section iast
Agent [baseline] (1.171 s) : 0, 1171041
Total [baseline] (8.942 s) : 0, 8942496
Agent [candidate] (1.173 s) : 0, 1172514
Total [candidate] (8.953 s) : 0, 8953488
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174060
Total [baseline] (8.94 s) : 0, 8940238
Agent [candidate] (1.175 s) : 0, 1175447
Total [candidate] (8.997 s) : 0, 8997022
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168735
Total [baseline] (8.942 s) : 0, 8942456
Agent [candidate] (1.177 s) : 0, 1176624
Total [candidate] (8.968 s) : 0, 8967812

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.171 s	123.756 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	126.775 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.169 s	121.45 ms (11.6%)
Total	tracing	8.484 s	-
Total	iast	8.942 s	458.346 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	8.94 s	456.088 ms (5.4%)
Total	iast_TELEMETRY_OFF	8.942 s	458.306 ms (5.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	iast	1.173 s	121.325 ms (11.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.175 s	124.258 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.177 s	125.435 ms (11.9%)
Total	tracing	8.519 s	-
Total	iast	8.953 s	434.535 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	8.997 s	478.069 ms (5.6%)
Total	iast_TELEMETRY_OFF	8.968 s	448.859 ms (5.3%)

gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.239 ms) : 0, 668239
BytebuddyAgent [candidate] (669.799 ms) : 0, 669799
GlobalTracer [baseline] (306.37 ms) : 0, 306370
GlobalTracer [candidate] (307.818 ms) : 0, 307818
AppSec [baseline] (51.194 ms) : 0, 51194
AppSec [candidate] (51.864 ms) : 0, 51864
Remote Config [baseline] (669.871 µs) : 0, 670
Remote Config [candidate] (674.307 µs) : 0, 674
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (7.561 ms) : 0, 7561
section iast
BytebuddyAgent [baseline] (778.296 ms) : 0, 778296
BytebuddyAgent [candidate] (778.168 ms) : 0, 778168
GlobalTracer [baseline] (295.767 ms) : 0, 295767
GlobalTracer [candidate] (296.115 ms) : 0, 296115
AppSec [baseline] (51.685 ms) : 0, 51685
AppSec [candidate] (50.527 ms) : 0, 50527
Remote Config [baseline] (594.331 µs) : 0, 594
Remote Config [candidate] (589.554 µs) : 0, 590
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (9.535 ms) : 0, 9535
IAST [baseline] (22.557 ms) : 0, 22557
IAST [candidate] (24.121 ms) : 0, 24121
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.683 ms) : 0, 779683
BytebuddyAgent [candidate] (779.69 ms) : 0, 779690
GlobalTracer [baseline] (296.998 ms) : 0, 296998
GlobalTracer [candidate] (296.765 ms) : 0, 296765
AppSec [baseline] (48.983 ms) : 0, 48983
AppSec [candidate] (49.833 ms) : 0, 49833
Remote Config [baseline] (588.334 µs) : 0, 588
Remote Config [candidate] (613.585 µs) : 0, 614
Telemetry [baseline] (10.151 ms) : 0, 10151
Telemetry [candidate] (10.442 ms) : 0, 10442
IAST [baseline] (24.182 ms) : 0, 24182
IAST [candidate] (24.637 ms) : 0, 24637
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.87 ms) : 0, 775870
BytebuddyAgent [candidate] (780.827 ms) : 0, 780827
GlobalTracer [baseline] (295.923 ms) : 0, 295923
GlobalTracer [candidate] (298.642 ms) : 0, 298642
AppSec [baseline] (48.555 ms) : 0, 48555
AppSec [candidate] (49.818 ms) : 0, 49818
Remote Config [baseline] (605.037 µs) : 0, 605
Remote Config [candidate] (598.409 µs) : 0, 598
Telemetry [baseline] (10.963 ms) : 0, 10963
Telemetry [candidate] (8.759 ms) : 0, 8759
IAST [baseline] (23.379 ms) : 0, 23379
IAST [candidate] (24.396 ms) : 0, 24396

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048651
Total [baseline] (10.407 s) : 0, 10406970
Agent [candidate] (1.056 s) : 0, 1055892
Total [candidate] (10.416 s) : 0, 10415560
section appsec
Agent [baseline] (1.176 s) : 0, 1175792
Total [baseline] (10.46 s) : 0, 10459674
Agent [candidate] (1.172 s) : 0, 1171522
Total [candidate] (10.46 s) : 0, 10460058
section iast
Agent [baseline] (1.171 s) : 0, 1171025
Total [baseline] (10.769 s) : 0, 10768913
Agent [candidate] (1.174 s) : 0, 1174472
Total [candidate] (10.888 s) : 0, 10887612
section profiling
Agent [baseline] (1.254 s) : 0, 1253898
Total [baseline] (10.65 s) : 0, 10650127
Agent [candidate] (1.247 s) : 0, 1246722
Total [candidate] (10.61 s) : 0, 10609725

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.176 s	127.141 ms (12.1%)
Agent	iast	1.171 s	122.374 ms (11.7%)
Agent	profiling	1.254 s	205.247 ms (19.6%)
Total	tracing	10.407 s	-
Total	appsec	10.46 s	52.705 ms (0.5%)
Total	iast	10.769 s	361.943 ms (3.5%)
Total	profiling	10.65 s	243.157 ms (2.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	appsec	1.172 s	115.63 ms (11.0%)
Agent	iast	1.174 s	118.58 ms (11.2%)
Agent	profiling	1.247 s	190.83 ms (18.1%)
Total	tracing	10.416 s	-
Total	appsec	10.46 s	44.498 ms (0.4%)
Total	iast	10.888 s	472.052 ms (4.5%)
Total	profiling	10.61 s	194.165 ms (1.9%)

gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.902 ms) : 0, 668902
BytebuddyAgent [candidate] (673.909 ms) : 0, 673909
GlobalTracer [baseline] (306.921 ms) : 0, 306921
GlobalTracer [candidate] (308.543 ms) : 0, 308543
AppSec [baseline] (51.27 ms) : 0, 51270
AppSec [candidate] (51.678 ms) : 0, 51678
Remote Config [baseline] (669.931 µs) : 0, 670
Remote Config [candidate] (682.886 µs) : 0, 683
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.524 ms) : 0, 7524
section appsec
BytebuddyAgent [baseline] (681.232 ms) : 0, 681232
BytebuddyAgent [candidate] (680.021 ms) : 0, 680021
GlobalTracer [baseline] (302.341 ms) : 0, 302341
GlobalTracer [candidate] (301.28 ms) : 0, 301280
AppSec [baseline] (161.685 ms) : 0, 161685
AppSec [candidate] (159.799 ms) : 0, 159799
Remote Config [baseline] (643.452 µs) : 0, 643
Remote Config [candidate] (637.805 µs) : 0, 638
Telemetry [baseline] (7.133 ms) : 0, 7133
Telemetry [candidate] (7.141 ms) : 0, 7141
IAST [baseline] (18.468 ms) : 0, 18468
IAST [candidate] (18.295 ms) : 0, 18295
section iast
BytebuddyAgent [baseline] (778.403 ms) : 0, 778403
BytebuddyAgent [candidate] (779.174 ms) : 0, 779174
GlobalTracer [baseline] (296.5 ms) : 0, 296500
GlobalTracer [candidate] (296.644 ms) : 0, 296644
AppSec [baseline] (51.498 ms) : 0, 51498
AppSec [candidate] (49.897 ms) : 0, 49897
Remote Config [baseline] (596.645 µs) : 0, 597
Remote Config [candidate] (591.408 µs) : 0, 591
Telemetry [baseline] (7.937 ms) : 0, 7937
Telemetry [candidate] (8.723 ms) : 0, 8723
IAST [baseline] (22.619 ms) : 0, 22619
IAST [candidate] (25.928 ms) : 0, 25928
section profiling
BytebuddyAgent [baseline] (665.804 ms) : 0, 665804
BytebuddyAgent [candidate] (664.595 ms) : 0, 664595
GlobalTracer [baseline] (392.784 ms) : 0, 392784
GlobalTracer [candidate] (389.315 ms) : 0, 389315
AppSec [baseline] (52.751 ms) : 0, 52751
AppSec [candidate] (52.25 ms) : 0, 52250
Remote Config [baseline] (694.132 µs) : 0, 694
Remote Config [candidate] (681.468 µs) : 0, 681
Telemetry [baseline] (7.445 ms) : 0, 7445
Telemetry [candidate] (7.336 ms) : 0, 7336
ProfilingAgent [baseline] (97.03 ms) : 0, 97030
ProfilingAgent [candidate] (95.234 ms) : 0, 95234
Profiling [baseline] (97.054 ms) : 0, 97054
Profiling [candidate] (95.257 ms) : 0, 95257

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-26T09:47:04	2024-08-26T09:53:52
git_branch	master	andrea.marziali/grpcstatus
git_commit_date	1724659573	1724665104
git_commit_sha	`074bc9b`	447a295d32
release_version	1.39.0-SNAPSHOT~074bc9bc4e	1.39.0-SNAPSHOT~447a295d32
start_time	2024-08-26T09:46:50	2024-08-26T09:53:39

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1724666376	1724666376
ci_job_id	616622258	616622258
ci_pipeline_id	42790444	42790444
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 20 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (361.768 µs) : 343, 381
. : milestone, 362,
iast (477.955 µs) : 456, 500
. : milestone, 478,
iast_FULL (547.673 µs) : 527, 569
. : milestone, 548,
iast_GLOBAL (507.258 µs) : 486, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (480.146 µs) : 458, 502
. : milestone, 480,
iast_INACTIVE (440.189 µs) : 419, 461
. : milestone, 440,
iast_TELEMETRY_OFF (470.961 µs) : 448, 493
. : milestone, 471,
tracing (434.193 µs) : 414, 455
. : milestone, 434,
section candidate
no_agent (370.664 µs) : 350, 391
. : milestone, 371,
iast (478.498 µs) : 456, 501
. : milestone, 478,
iast_FULL (547.829 µs) : 527, 569
. : milestone, 548,
iast_GLOBAL (503.965 µs) : 482, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (481.232 µs) : 459, 504
. : milestone, 481,
iast_INACTIVE (450.9 µs) : 429, 472
. : milestone, 451,
iast_TELEMETRY_OFF (466.596 µs) : 444, 489
. : milestone, 467,
tracing (436.118 µs) : 416, 457
. : milestone, 436,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	361.768 µs [342.527 µs, 381.01 µs]	-
iast	477.955 µs [455.729 µs, 500.181 µs]	116.186 µs (32.1%)
iast_FULL	547.673 µs [526.787 µs, 568.559 µs]	185.905 µs (51.4%)
iast_GLOBAL	507.258 µs [485.834 µs, 528.683 µs]	145.49 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED	480.146 µs [457.827 µs, 502.464 µs]	118.377 µs (32.7%)
iast_INACTIVE	440.189 µs [419.198 µs, 461.18 µs]	78.421 µs (21.7%)
iast_TELEMETRY_OFF	470.961 µs [448.428 µs, 493.494 µs]	109.192 µs (30.2%)
tracing	434.193 µs [413.728 µs, 454.657 µs]	72.424 µs (20.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.664 µs [350.409 µs, 390.918 µs]	-
iast	478.498 µs [455.721 µs, 501.275 µs]	107.834 µs (29.1%)
iast_FULL	547.829 µs [526.955 µs, 568.704 µs]	177.166 µs (47.8%)
iast_GLOBAL	503.965 µs [481.79 µs, 526.139 µs]	133.301 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED	481.232 µs [458.906 µs, 503.557 µs]	110.568 µs (29.8%)
iast_INACTIVE	450.9 µs [429.371 µs, 472.429 µs]	80.236 µs (21.6%)
iast_TELEMETRY_OFF	466.596 µs [444.026 µs, 489.167 µs]	95.933 µs (25.9%)
tracing	436.118 µs [415.676 µs, 456.559 µs]	65.454 µs (17.7%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1365
. : milestone, 1345,
appsec (1.725 ms) : 1702, 1748
. : milestone, 1725,
appsec_no_iast (1.741 ms) : 1718, 1765
. : milestone, 1741,
iast (1.481 ms) : 1458, 1504
. : milestone, 1481,
profiling (1.483 ms) : 1457, 1508
. : milestone, 1483,
tracing (1.472 ms) : 1448, 1496
. : milestone, 1472,
section candidate
no_agent (1.344 ms) : 1324, 1363
. : milestone, 1344,
appsec (1.724 ms) : 1699, 1749
. : milestone, 1724,
appsec_no_iast (1.732 ms) : 1709, 1756
. : milestone, 1732,
iast (1.467 ms) : 1445, 1490
. : milestone, 1467,
profiling (1.478 ms) : 1453, 1503
. : milestone, 1478,
tracing (1.473 ms) : 1449, 1498
. : milestone, 1473,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.325 ms, 1.365 ms]	-
appsec	1.725 ms [1.702 ms, 1.748 ms]	379.795 µs (28.2%)
appsec_no_iast	1.741 ms [1.718 ms, 1.765 ms]	396.325 µs (29.5%)
iast	1.481 ms [1.458 ms, 1.504 ms]	136.157 µs (10.1%)
profiling	1.483 ms [1.457 ms, 1.508 ms]	137.383 µs (10.2%)
tracing	1.472 ms [1.448 ms, 1.496 ms]	126.713 µs (9.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.344 ms [1.324 ms, 1.363 ms]	-
appsec	1.724 ms [1.699 ms, 1.749 ms]	380.344 µs (28.3%)
appsec_no_iast	1.732 ms [1.709 ms, 1.756 ms]	388.572 µs (28.9%)
iast	1.467 ms [1.445 ms, 1.49 ms]	123.785 µs (9.2%)
profiling	1.478 ms [1.453 ms, 1.503 ms]	134.297 µs (10.0%)
tracing	1.473 ms [1.449 ms, 1.498 ms]	129.792 µs (9.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/grpcstatus
git_commit_date	1724659573	1724665104
git_commit_sha	`074bc9b`	447a295d32
release_version	1.39.0-SNAPSHOT~074bc9bc4e	1.39.0-SNAPSHOT~447a295d32

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1724667003	1724667003
ci_job_id	616622259	616622259
ci_pipeline_id	42790444	42790444
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.222 ms) : 2187, 2257
. : milestone, 2222,
iast (1.993 ms) : 1949, 2037
. : milestone, 1993,
iast_GLOBAL (2.029 ms) : 1985, 2073
. : milestone, 2029,
profiling (1.857 ms) : 1823, 1891
. : milestone, 1857,
tracing (1.832 ms) : 1800, 1865
. : milestone, 1832,
section candidate
no_agent (1.457 ms) : 1445, 1468
. : milestone, 1457,
appsec (2.23 ms) : 2195, 2266
. : milestone, 2230,
iast (1.992 ms) : 1949, 2035
. : milestone, 1992,
iast_GLOBAL (2.02 ms) : 1975, 2064
. : milestone, 2020,
profiling (1.861 ms) : 1827, 1896
. : milestone, 1861,
tracing (1.836 ms) : 1803, 1869
. : milestone, 1836,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.461 ms [1.45 ms, 1.473 ms]	-
appsec	2.222 ms [2.187 ms, 2.257 ms]	760.69 µs (52.1%)
iast	1.993 ms [1.949 ms, 2.037 ms]	531.809 µs (36.4%)
iast_GLOBAL	2.029 ms [1.985 ms, 2.073 ms]	567.614 µs (38.8%)
profiling	1.857 ms [1.823 ms, 1.891 ms]	396.051 µs (27.1%)
tracing	1.832 ms [1.8 ms, 1.865 ms]	371.324 µs (25.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.457 ms [1.445 ms, 1.468 ms]	-
appsec	2.23 ms [2.195 ms, 2.266 ms]	773.9 µs (53.1%)
iast	1.992 ms [1.949 ms, 2.035 ms]	535.253 µs (36.7%)
iast_GLOBAL	2.02 ms [1.975 ms, 2.064 ms]	562.987 µs (38.7%)
profiling	1.861 ms [1.827 ms, 1.896 ms]	404.669 µs (27.8%)
tracing	1.836 ms [1.803 ms, 1.869 ms]	379.429 µs (26.1%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~447a295d32, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
appsec (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
iast (18.555 s) : 18555000, 18555000
. : milestone, 18555000,
iast_GLOBAL (17.921 s) : 17921000, 17921000
. : milestone, 17921000,
profiling (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
tracing (15.192 s) : 15192000, 15192000
. : milestone, 15192000,
section candidate
no_agent (15.267 s) : 15267000, 15267000
. : milestone, 15267000,
appsec (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
iast (18.813 s) : 18813000, 18813000
. : milestone, 18813000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (15.51 s) : 15510000, 15510000
. : milestone, 15510000,
tracing (14.934 s) : 14934000, 14934000
. : milestone, 14934000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.351 s [15.351 s, 15.351 s]	-
appsec	14.87 s [14.87 s, 14.87 s]	-481.0 ms (-3.1%)
iast	18.555 s [18.555 s, 18.555 s]	3.204 s (20.9%)
iast_GLOBAL	17.921 s [17.921 s, 17.921 s]	2.57 s (16.7%)
profiling	15.351 s [15.351 s, 15.351 s]	0.0 µs (0.0%)
tracing	15.192 s [15.192 s, 15.192 s]	-159.0 ms (-1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.267 s [15.267 s, 15.267 s]	-
appsec	15.434 s [15.434 s, 15.434 s]	167.0 ms (1.1%)
iast	18.813 s [18.813 s, 18.813 s]	3.546 s (23.2%)
iast_GLOBAL	17.948 s [17.948 s, 17.948 s]	2.681 s (17.6%)
profiling	15.51 s [15.51 s, 15.51 s]	243.0 ms (1.6%)
tracing	14.934 s [14.934 s, 14.934 s]	-333.0 ms (-2.2%)

PerfectSlayer

That looks okay 👍

amarziali added type: bug fix Bug fix inst: grpc gRPC instrumentation labels Aug 26, 2024

amarziali requested a review from a team as a code owner August 26, 2024 09:39

vandonr approved these changes Aug 26, 2024
View reviewed changes

PerfectSlayer approved these changes Aug 26, 2024
View reviewed changes

Fix grpc server error mark
3e63ae0

amarziali force-pushed the andrea.marziali/grpcstatus branch from 447a295 to 3e63ae0Compare August 26, 2024 15:01

amarziali enabled auto-merge (squash) August 26, 2024 15:02

amarziali merged commit 445bbe4 into masterAug 26, 2024

amarziali deleted the andrea.marziali/grpcstatus branch August 26, 2024 16:08

github-actionsBot added this to the 1.39.0 milestone Aug 26, 2024

sdwa0 mentioned this pull request Dec 2, 2024
Error flag manually set to a gRPC server span gets overwritten #8042
Closed

Navigation Menu

Uh oh!

Fix grpc server error mark - #7505

Fix grpc server error mark#7505
amarziali merged 1 commit into
masterfrom
andrea.marziali/grpcstatus

amarziali commented Aug 26, 2024•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Aug 26, 2024•
edited
Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amarziali commented Aug 26, 2024• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Aug 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amarziali commented Aug 26, 2024•
edited by atlassian Bot
Loading

pr-commenterBot commented Aug 26, 2024•
edited
Loading