Protect mdb from instrumenting multiple time the same event by amarziali · Pull Request #8062 · DataDog/dd-trace-java

amarziali · 2024-12-06T08:26:26Z

What Does This Do

Ensure that we do not create multiple span for jms.consume if proxies are delegating the same method call in a nested way

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2024-12-06T08:26:40Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2024-12-06T09:08:37Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/mdb2
git_commit_date	1733416735	1733473542
git_commit_sha	`2b24697`	`8a5ca20`
release_version	1.44.0-SNAPSHOT~2b246971a1	1.44.0-SNAPSHOT~8a5ca20be8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733476071	1733476071
ci_job_id	728921791	728921791
ci_pipeline_id	50442519	50442519
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095101
Total [baseline] (10.476 s) : 0, 10476235
Agent [candidate] (1.102 s) : 0, 1101796
Total [candidate] (10.425 s) : 0, 10424806
section appsec
Agent [baseline] (1.227 s) : 0, 1227146
Total [baseline] (10.711 s) : 0, 10711136
Agent [candidate] (1.225 s) : 0, 1224980
Total [candidate] (10.697 s) : 0, 10696612
section iast
Agent [baseline] (1.22 s) : 0, 1219546
Total [baseline] (10.954 s) : 0, 10953569
Agent [candidate] (1.229 s) : 0, 1228532
Total [candidate] (10.922 s) : 0, 10921871
section profiling
Agent [baseline] (1.316 s) : 0, 1315979
Total [baseline] (10.767 s) : 0, 10767057
Agent [candidate] (1.317 s) : 0, 1316520
Total [candidate] (10.764 s) : 0, 10764174

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.227 s	132.044 ms (12.1%)
Agent	iast	1.22 s	124.444 ms (11.4%)
Agent	profiling	1.316 s	220.877 ms (20.2%)
Total	tracing	10.476 s	-
Total	appsec	10.711 s	234.9 ms (2.2%)
Total	iast	10.954 s	477.334 ms (4.6%)
Total	profiling	10.767 s	290.822 ms (2.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.102 s	-
Agent	appsec	1.225 s	123.184 ms (11.2%)
Agent	iast	1.229 s	126.736 ms (11.5%)
Agent	profiling	1.317 s	214.724 ms (19.5%)
Total	tracing	10.425 s	-
Total	appsec	10.697 s	271.806 ms (2.6%)
Total	iast	10.922 s	497.064 ms (4.8%)
Total	profiling	10.764 s	339.368 ms (3.3%)

gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.082 ms) : 0, 698082
BytebuddyAgent [candidate] (703.238 ms) : 0, 703238
GlobalTracer [baseline] (317.155 ms) : 0, 317155
GlobalTracer [candidate] (318.485 ms) : 0, 318485
AppSec [baseline] (54.858 ms) : 0, 54858
AppSec [candidate] (54.982 ms) : 0, 54982
Remote Config [baseline] (675.435 µs) : 0, 675
Remote Config [candidate] (703.776 µs) : 0, 704
Telemetry [baseline] (10.488 ms) : 0, 10488
Telemetry [candidate] (10.476 ms) : 0, 10476
section appsec
BytebuddyAgent [baseline] (712.963 ms) : 0, 712963
BytebuddyAgent [candidate] (711.77 ms) : 0, 711770
GlobalTracer [baseline] (314.524 ms) : 0, 314524
GlobalTracer [candidate] (313.916 ms) : 0, 313916
AppSec [baseline] (166.147 ms) : 0, 166147
AppSec [candidate] (167.312 ms) : 0, 167312
Remote Config [baseline] (1.007 ms) : 0, 1007
Remote Config [candidate] (665.071 µs) : 0, 665
Telemetry [baseline] (8.886 ms) : 0, 8886
Telemetry [candidate] (7.766 ms) : 0, 7766
IAST [baseline] (19.712 ms) : 0, 19712
IAST [candidate] (19.593 ms) : 0, 19593
section iast
BytebuddyAgent [baseline] (813.212 ms) : 0, 813212
BytebuddyAgent [candidate] (819.643 ms) : 0, 819643
GlobalTracer [baseline] (305.726 ms) : 0, 305726
GlobalTracer [candidate] (307.215 ms) : 0, 307215
AppSec [baseline] (57.748 ms) : 0, 57748
AppSec [candidate] (58.143 ms) : 0, 58143
Remote Config [baseline] (648.669 µs) : 0, 649
Remote Config [candidate] (663.887 µs) : 0, 664
Telemetry [baseline] (7.556 ms) : 0, 7556
Telemetry [candidate] (7.639 ms) : 0, 7639
IAST [baseline] (20.912 ms) : 0, 20912
IAST [candidate] (21.336 ms) : 0, 21336
section profiling
BytebuddyAgent [baseline] (688.657 ms) : 0, 688657
BytebuddyAgent [candidate] (689.282 ms) : 0, 689282
GlobalTracer [baseline] (433.078 ms) : 0, 433078
GlobalTracer [candidate] (432.382 ms) : 0, 432382
AppSec [baseline] (53.65 ms) : 0, 53650
AppSec [candidate] (53.545 ms) : 0, 53545
Remote Config [baseline] (693.653 µs) : 0, 694
Remote Config [candidate] (662.359 µs) : 0, 662
Telemetry [baseline] (7.717 ms) : 0, 7717
Telemetry [candidate] (7.761 ms) : 0, 7761
ProfilingAgent [baseline] (93.148 ms) : 0, 93148
ProfilingAgent [candidate] (93.819 ms) : 0, 93819
Profiling [baseline] (93.171 ms) : 0, 93171
Profiling [candidate] (93.843 ms) : 0, 93843

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1095944
Total [baseline] (8.676 s) : 0, 8675847
Agent [candidate] (1.093 s) : 0, 1092909
Total [candidate] (8.642 s) : 0, 8641880
section iast
Agent [baseline] (1.224 s) : 0, 1223807
Total [baseline] (9.228 s) : 0, 9228093
Agent [candidate] (1.22 s) : 0, 1219558
Total [candidate] (9.206 s) : 0, 9206136
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1218101
Total [baseline] (9.189 s) : 0, 9189386
Agent [candidate] (1.22 s) : 0, 1220166
Total [candidate] (9.164 s) : 0, 9163678
section iast_TELEMETRY_OFF
Agent [baseline] (1.222 s) : 0, 1221851
Total [baseline] (9.197 s) : 0, 9196693
Agent [candidate] (1.218 s) : 0, 1218134
Total [candidate] (9.218 s) : 0, 9217814

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	iast	1.224 s	127.863 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.218 s	122.157 ms (11.1%)
Agent	iast_TELEMETRY_OFF	1.222 s	125.907 ms (11.5%)
Total	tracing	8.676 s	-
Total	iast	9.228 s	552.246 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.189 s	513.539 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.197 s	520.846 ms (6.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	iast	1.22 s	126.648 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.22 s	127.257 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.218 s	125.225 ms (11.5%)
Total	tracing	8.642 s	-
Total	iast	9.206 s	564.256 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.164 s	521.798 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.218 s	575.934 ms (6.7%)

gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.275 ms) : 0, 696275
BytebuddyAgent [candidate] (695.468 ms) : 0, 695468
GlobalTracer [baseline] (319.078 ms) : 0, 319078
GlobalTracer [candidate] (317.589 ms) : 0, 317589
AppSec [baseline] (55.042 ms) : 0, 55042
AppSec [candidate] (54.905 ms) : 0, 54905
Remote Config [baseline] (717.632 µs) : 0, 718
Remote Config [candidate] (696.589 µs) : 0, 697
Telemetry [baseline] (11.051 ms) : 0, 11051
Telemetry [candidate] (10.438 ms) : 0, 10438
section iast
BytebuddyAgent [baseline] (814.923 ms) : 0, 814923
BytebuddyAgent [candidate] (812.452 ms) : 0, 812452
GlobalTracer [baseline] (307.55 ms) : 0, 307550
GlobalTracer [candidate] (305.964 ms) : 0, 305964
AppSec [baseline] (58.133 ms) : 0, 58133
AppSec [candidate] (58.417 ms) : 0, 58417
Remote Config [baseline] (650.722 µs) : 0, 651
Remote Config [candidate] (635.39 µs) : 0, 635
Telemetry [baseline] (7.646 ms) : 0, 7646
Telemetry [candidate] (7.536 ms) : 0, 7536
IAST [baseline] (21.144 ms) : 0, 21144
IAST [candidate] (20.784 ms) : 0, 20784
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.024 ms) : 0, 812024
BytebuddyAgent [candidate] (812.98 ms) : 0, 812980
GlobalTracer [baseline] (305.275 ms) : 0, 305275
GlobalTracer [candidate] (305.994 ms) : 0, 305994
AppSec [baseline] (56.371 ms) : 0, 56371
AppSec [candidate] (57.212 ms) : 0, 57212
Remote Config [baseline] (644.965 µs) : 0, 645
Remote Config [candidate] (651.012 µs) : 0, 651
Telemetry [baseline] (7.534 ms) : 0, 7534
Telemetry [candidate] (7.61 ms) : 0, 7610
IAST [baseline] (22.503 ms) : 0, 22503
IAST [candidate] (21.93 ms) : 0, 21930
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (814.553 ms) : 0, 814553
BytebuddyAgent [candidate] (809.693 ms) : 0, 809693
GlobalTracer [baseline] (306.79 ms) : 0, 306790
GlobalTracer [candidate] (307.291 ms) : 0, 307291
AppSec [baseline] (56.381 ms) : 0, 56381
AppSec [candidate] (57.791 ms) : 0, 57791
Remote Config [baseline] (614.337 µs) : 0, 614
Remote Config [candidate] (642.462 µs) : 0, 642
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.522 ms) : 0, 7522
IAST [baseline] (22.264 ms) : 0, 22264
IAST [candidate] (21.459 ms) : 0, 21459

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-06T08:37:57	2024-12-06T08:44:58
git_branch	master	andrea.marziali/mdb2
git_commit_date	1733416735	1733473542
git_commit_sha	`2b24697`	`8a5ca20`
release_version	1.44.0-SNAPSHOT~2b246971a1	1.44.0-SNAPSHOT~8a5ca20be8
start_time	2024-12-06T08:37:44	2024-12-06T08:44:45

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733475054	1733475054
ci_job_id	728921792	728921792
ci_pipeline_id	50442519	50442519
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section baseline
no_agent (382.032 µs) : 361, 403
. : milestone, 382,
iast (498.371 µs) : 476, 520
. : milestone, 498,
iast_FULL (654.98 µs) : 633, 676
. : milestone, 655,
iast_GLOBAL (524.316 µs) : 503, 546
. : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (510.3 µs) : 489, 532
. : milestone, 510,
iast_INACTIVE (450.634 µs) : 430, 471
. : milestone, 451,
iast_TELEMETRY_OFF (486.932 µs) : 465, 509
. : milestone, 487,
tracing (455.23 µs) : 434, 476
. : milestone, 455,
section candidate
no_agent (379.532 µs) : 359, 400
. : milestone, 380,
iast (494.389 µs) : 473, 516
. : milestone, 494,
iast_FULL (657.228 µs) : 636, 679
. : milestone, 657,
iast_GLOBAL (532.395 µs) : 509, 555
. : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (496.021 µs) : 474, 518
. : milestone, 496,
iast_INACTIVE (455.798 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (486.576 µs) : 465, 508
. : milestone, 487,
tracing (449.663 µs) : 429, 470
. : milestone, 450,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.032 µs [361.015 µs, 403.048 µs]	-
iast	498.371 µs [476.418 µs, 520.323 µs]	116.339 µs (30.5%)
iast_FULL	654.98 µs [633.471 µs, 676.489 µs]	272.948 µs (71.4%)
iast_GLOBAL	524.316 µs [502.911 µs, 545.72 µs]	142.284 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	510.3 µs [488.691 µs, 531.908 µs]	128.268 µs (33.6%)
iast_INACTIVE	450.634 µs [429.929 µs, 471.34 µs]	68.603 µs (18.0%)
iast_TELEMETRY_OFF	486.932 µs [465.192 µs, 508.673 µs]	104.901 µs (27.5%)
tracing	455.23 µs [434.177 µs, 476.283 µs]	73.199 µs (19.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.532 µs [359.225 µs, 399.839 µs]	-
iast	494.389 µs [473.03 µs, 515.748 µs]	114.857 µs (30.3%)
iast_FULL	657.228 µs [635.783 µs, 678.674 µs]	277.696 µs (73.2%)
iast_GLOBAL	532.395 µs [509.499 µs, 555.291 µs]	152.863 µs (40.3%)
iast_HARDCODED_SECRET_DISABLED	496.021 µs [474.365 µs, 517.678 µs]	116.489 µs (30.7%)
iast_INACTIVE	455.798 µs [434.923 µs, 476.672 µs]	76.266 µs (20.1%)
iast_TELEMETRY_OFF	486.576 µs [465.156 µs, 507.995 µs]	107.043 µs (28.2%)
tracing	449.663 µs [428.935 µs, 470.391 µs]	70.131 µs (18.5%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1376
. : milestone, 1355,
appsec (1.759 ms) : 1735, 1784
. : milestone, 1759,
appsec_no_iast (1.772 ms) : 1746, 1797
. : milestone, 1772,
iast (1.499 ms) : 1475, 1522
. : milestone, 1499,
profiling (1.578 ms) : 1553, 1603
. : milestone, 1578,
tracing (1.482 ms) : 1457, 1507
. : milestone, 1482,
section candidate
no_agent (1.351 ms) : 1331, 1370
. : milestone, 1351,
appsec (1.791 ms) : 1766, 1816
. : milestone, 1791,
appsec_no_iast (1.755 ms) : 1730, 1779
. : milestone, 1755,
iast (1.516 ms) : 1493, 1540
. : milestone, 1516,
profiling (1.524 ms) : 1501, 1546
. : milestone, 1524,
tracing (1.499 ms) : 1473, 1525
. : milestone, 1499,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.376 ms]	-
appsec	1.759 ms [1.735 ms, 1.784 ms]	403.942 µs (29.8%)
appsec_no_iast	1.772 ms [1.746 ms, 1.797 ms]	416.104 µs (30.7%)
iast	1.499 ms [1.475 ms, 1.522 ms]	143.134 µs (10.6%)
profiling	1.578 ms [1.553 ms, 1.603 ms]	222.301 µs (16.4%)
tracing	1.482 ms [1.457 ms, 1.507 ms]	126.81 µs (9.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.331 ms, 1.37 ms]	-
appsec	1.791 ms [1.766 ms, 1.816 ms]	439.992 µs (32.6%)
appsec_no_iast	1.755 ms [1.73 ms, 1.779 ms]	403.926 µs (29.9%)
iast	1.516 ms [1.493 ms, 1.54 ms]	165.706 µs (12.3%)
profiling	1.524 ms [1.501 ms, 1.546 ms]	172.905 µs (12.8%)
tracing	1.499 ms [1.473 ms, 1.525 ms]	148.196 µs (11.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/mdb2
git_commit_date	1733416735	1733473542
git_commit_sha	`2b24697`	`8a5ca20`
release_version	1.44.0-SNAPSHOT~2b246971a1	1.44.0-SNAPSHOT~8a5ca20be8

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1733475636	1733475636
ci_job_id	728921793	728921793
ci_pipeline_id	50442519	50442519
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section baseline
no_agent (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
appsec (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
iast (19.063 s) : 19063000, 19063000
. : milestone, 19063000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
. : milestone, 18053000,
profiling (15.241 s) : 15241000, 15241000
. : milestone, 15241000,
tracing (15.213 s) : 15213000, 15213000
. : milestone, 15213000,
section candidate
no_agent (15.371 s) : 15371000, 15371000
. : milestone, 15371000,
appsec (14.783 s) : 14783000, 14783000
. : milestone, 14783000,
iast (18.947 s) : 18947000, 18947000
. : milestone, 18947000,
iast_GLOBAL (18.039 s) : 18039000, 18039000
. : milestone, 18039000,
profiling (15.585 s) : 15585000, 15585000
. : milestone, 15585000,
tracing (14.635 s) : 14635000, 14635000
. : milestone, 14635000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.977 s [14.977 s, 14.977 s]	-
appsec	14.997 s [14.997 s, 14.997 s]	20.0 ms (0.1%)
iast	19.063 s [19.063 s, 19.063 s]	4.086 s (27.3%)
iast_GLOBAL	18.053 s [18.053 s, 18.053 s]	3.076 s (20.5%)
profiling	15.241 s [15.241 s, 15.241 s]	264.0 ms (1.8%)
tracing	15.213 s [15.213 s, 15.213 s]	236.0 ms (1.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.371 s [15.371 s, 15.371 s]	-
appsec	14.783 s [14.783 s, 14.783 s]	-588.0 ms (-3.8%)
iast	18.947 s [18.947 s, 18.947 s]	3.576 s (23.3%)
iast_GLOBAL	18.039 s [18.039 s, 18.039 s]	2.668 s (17.4%)
profiling	15.585 s [15.585 s, 15.585 s]	214.0 ms (1.4%)
tracing	14.635 s [14.635 s, 14.635 s]	-736.0 ms (-4.8%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~8a5ca20be8, baseline=1.44.0-SNAPSHOT~2b246971a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.344 ms) : 2303, 2386
. : milestone, 2344,
iast (2.09 ms) : 2037, 2143
. : milestone, 2090,
iast_GLOBAL (2.134 ms) : 2081, 2187
. : milestone, 2134,
profiling (1.955 ms) : 1913, 1997
. : milestone, 1955,
tracing (1.928 ms) : 1888, 1968
. : milestone, 1928,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.345 ms) : 2304, 2386
. : milestone, 2345,
iast (2.079 ms) : 2027, 2132
. : milestone, 2079,
iast_GLOBAL (2.134 ms) : 2081, 2187
. : milestone, 2134,
profiling (1.958 ms) : 1915, 2001
. : milestone, 1958,
tracing (1.933 ms) : 1892, 1974
. : milestone, 1933,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.344 ms [2.303 ms, 2.386 ms]	874.906 µs (59.6%)
iast	2.09 ms [2.037 ms, 2.143 ms]	620.991 µs (42.3%)
iast_GLOBAL	2.134 ms [2.081 ms, 2.187 ms]	664.713 µs (45.2%)
profiling	1.955 ms [1.913 ms, 1.997 ms]	485.599 µs (33.1%)
tracing	1.928 ms [1.888 ms, 1.968 ms]	459.015 µs (31.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.345 ms [2.304 ms, 2.386 ms]	875.428 µs (59.6%)
iast	2.079 ms [2.027 ms, 2.132 ms]	609.864 µs (41.5%)
iast_GLOBAL	2.134 ms [2.081 ms, 2.187 ms]	664.144 µs (45.2%)
profiling	1.958 ms [1.915 ms, 2.001 ms]	488.719 µs (33.3%)
tracing	1.933 ms [1.892 ms, 1.974 ms]	463.484 µs (31.5%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

Protect mdb from instrumenting multiple time the same event
8a5ca20

amarziali requested a review from a team as a code owner December 6, 2024 08:26

amarziali added type: bug fix Bug fix inst: jms JMS instrumentation labels Dec 6, 2024

vandonr approved these changes Dec 6, 2024
View reviewed changes

amarziali merged commit 32c64c4 into masterDec 6, 2024

amarziali deleted the andrea.marziali/mdb2 branch December 6, 2024 09:19

github-actionsBot added this to the 1.44.0 milestone Dec 6, 2024

Navigation Menu

Uh oh!

Protect mdb from instrumenting multiple time the same event - #8062

Protect mdb from instrumenting multiple time the same event#8062
amarziali merged 1 commit into
masterfrom
andrea.marziali/mdb2

amarziali commented Dec 6, 2024

Uh oh!

github-actionsBot commented Dec 6, 2024

Uh oh!

pr-commenterBot commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

amarziali commented Dec 6, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actionsBot commented Dec 6, 2024

Uh oh!

pr-commenterBot commented Dec 6, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants