Uh oh!
There was an error while loading. Please reload this page.
Add vertx postgresql client instrumentation - #8457
Conversation
onkar-dream11
commented
Feb 28, 2025
@PerfectSlayer@gary-huang can you please help me identify why the checks are failing?? |
PerfectSlayer
commented
Feb 28, 2025
Hello @onkar-dream11 👋 First, thanks for you contribution. |
vandonr
left a comment
There was a problem hiding this comment.
looks ok, but most of the code has been duplicated compared to the existing mysql integration. I think it'd be better to have only the Pg* classes in this package, do the same for mysql, and put the common code in a vertex-sql-common to avoid that.
I can let you do it, or I can take your commits in a branch I own and do it if you prefer.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
onkar-dream11
commented
Feb 28, 2025
@vandonr I have resolved the given comments, and regarding common code I thought of it having in |
vandonr
commented
Feb 28, 2025
TIL I can push to a branch on a fork |
vandonr
commented
Feb 28, 2025
OK I think I may need to push on my own branch anyway for the CI to run properly |
vandonr
commented
Feb 28, 2025
closing in favor of #8471 |
- Assert exactly 18 metrics (was missing jvm.file_descriptor.count/limit) - Assert no DD-proprietary names present - Matches .NET PR #8457 test pattern Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Assert exactly 18 metrics (was missing jvm.file_descriptor.count/limit) - Assert no DD-proprietary names present - Matches .NET PR #8457 test pattern Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
What Does This Do
This PR adds support for automatic tracing of PostgreSQL queries when using the Vert.x PostgreSQL Client in a Vert.x 4 application, enabling Datadog APM to capture query execution times and database interactions.
Motivation
Datadog APM currently doesn't automatically trace PostgreSQL queries executed via the Vert.x PostgreSQL Client, leading to a lack of visibility into database operations. This fix addresses that gap.
Additional Notes
The PR ensures that PostgreSQL queries are automatically instrumented and visible in Datadog APM.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]