Don't instrument trigger probes if the distributed debugger is disabled by evanchooly · Pull Request #8458 · DataDog/dd-trace-java

evanchooly · 2025-02-26T18:50:15Z

What Does This Do

If the distributed debugger is disabled for a service, do not instrument any trigger probe definitions received from the backend.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3547

pr-commenter · 2025-02-26T19:12:19Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1740760818	1740761188
end_time	2025-02-28T16:41:36	2025-02-28T16:47:45
git_branch	master	evanchooly/DEBUG-3547
git_commit_sha	`19d8832`	`88a893c`
start_time	2025-02-28T16:40:19	2025-02-28T16:46:29

See matching parameters

	Baseline	Candidate
ci_job_id	828114728	828114728
ci_pipeline_id	57366617	57366617
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1740760195	1740760195

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 5 metrics, 6 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	worse [+304.968µs; +380.566µs] or [+3.059%; +3.818%]	worse [+290.506µs; +416.430µs] or [+2.868%; +4.111%]	worse [+257.613µs; +417.674µs] or [+2.517%; +4.082%]	same	worse [-4.304op/s; -2.100op/s] or [-4.412%; -2.153%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-30532.354ns; +28925.555ns] or [-11.075%; +10.492%]	unstable [-44296.495ns; +42983.468ns] or [-13.956%; +13.542%]	unstable [-56034.035ns; +56820.990ns] or [-16.871%; +17.108%]	unstable [-86.444µs; +122.143µs] or [-14.641%; +20.688%]	same
scenario:basic	same	same	same	unstable [-41.172µs; +57.524µs] or [-7.556%; +10.557%]	unstable [-97.374op/s; +225.579op/s] or [-3.895%; +9.023%]

Request duration reports for reports

gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (317.406 µs) : 278, 357
. : milestone, 317,
basic (311.996 µs) : 302, 322
. : milestone, 312,
loop (10.129 ms) : 10080, 10177
. : milestone, 10129,
section candidate
noprobe (316.75 µs) : 273, 360
. : milestone, 317,
basic (304.098 µs) : 294, 314
. : milestone, 304,
loop (10.482 ms) : 10415, 10549
. : milestone, 10482,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	317.406 µs [277.768 µs, 357.045 µs]
basic	311.996 µs [302.195 µs, 321.796 µs]
loop	10.129 ms [10.08 ms, 10.177 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	316.75 µs [273.294 µs, 360.206 µs]
basic	304.098 µs [293.721 µs, 314.475 µs]
loop	10.482 ms [10.415 ms, 10.549 ms]

pr-commenter · 2025-02-26T19:33:32Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3547
git_commit_date	1740758111	1740760195
git_commit_sha	`19d8832`	`88a893c`
release_version	1.47.0-SNAPSHOT~19d8832a9d	1.47.0-SNAPSHOT~88a893c3ef

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740762543	1740762543
ci_job_id	828114722	828114722
ci_pipeline_id	57366617	57366617
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cxumtg-z-project-304-concurrent-1-blvovez3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cxumtg-z-project-304-concurrent-1-blvovez3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047076
Total [baseline] (10.467 s) : 0, 10466807
Agent [candidate] (1.039 s) : 0, 1038553
Total [candidate] (10.504 s) : 0, 10503548
section appsec
Agent [baseline] (1.184 s) : 0, 1184471
Total [baseline] (10.719 s) : 0, 10719432
Agent [candidate] (1.181 s) : 0, 1180501
Total [candidate] (10.726 s) : 0, 10726021
section iast
Agent [baseline] (1.171 s) : 0, 1171078
Total [baseline] (11.025 s) : 0, 11024947
Agent [candidate] (1.175 s) : 0, 1175248
Total [candidate] (11.014 s) : 0, 11013963
section profiling
Agent [baseline] (1.262 s) : 0, 1261641
Total [baseline] (10.83 s) : 0, 10830379
Agent [candidate] (1.268 s) : 0, 1267750
Total [candidate] (10.921 s) : 0, 10920855

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.184 s	137.395 ms (13.1%)
Agent	iast	1.171 s	124.002 ms (11.8%)
Agent	profiling	1.262 s	214.565 ms (20.5%)
Total	tracing	10.467 s	-
Total	appsec	10.719 s	252.626 ms (2.4%)
Total	iast	11.025 s	558.14 ms (5.3%)
Total	profiling	10.83 s	363.572 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	appsec	1.181 s	141.949 ms (13.7%)
Agent	iast	1.175 s	136.695 ms (13.2%)
Agent	profiling	1.268 s	229.198 ms (22.1%)
Total	tracing	10.504 s	-
Total	appsec	10.726 s	222.474 ms (2.1%)
Total	iast	11.014 s	510.415 ms (4.9%)
Total	profiling	10.921 s	417.307 ms (4.0%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.179 ms) : 0, 722179
BytebuddyAgent [candidate] (716.507 ms) : 0, 716507
GlobalTracer [baseline] (241.102 ms) : 0, 241102
GlobalTracer [candidate] (239.166 ms) : 0, 239166
AppSec [baseline] (56.272 ms) : 0, 56272
AppSec [candidate] (55.569 ms) : 0, 55569
Remote Config [baseline] (700.476 µs) : 0, 700
Remote Config [candidate] (712.849 µs) : 0, 713
Telemetry [baseline] (11.629 ms) : 0, 11629
Telemetry [candidate] (11.611 ms) : 0, 11611
section appsec
BytebuddyAgent [baseline] (735.993 ms) : 0, 735993
BytebuddyAgent [candidate] (733.549 ms) : 0, 733549
GlobalTracer [baseline] (236.196 ms) : 0, 236196
GlobalTracer [candidate] (235.966 ms) : 0, 235966
AppSec [baseline] (177.141 ms) : 0, 177141
AppSec [candidate] (175.973 ms) : 0, 175973
Remote Config [baseline] (661.843 µs) : 0, 662
Remote Config [candidate] (658.507 µs) : 0, 659
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.642 ms) : 0, 8642
IAST [baseline] (21.83 ms) : 0, 21830
IAST [candidate] (21.549 ms) : 0, 21549
section iast
BytebuddyAgent [baseline] (837.092 ms) : 0, 837092
BytebuddyAgent [candidate] (840.087 ms) : 0, 840087
GlobalTracer [baseline] (230.153 ms) : 0, 230153
GlobalTracer [candidate] (230.743 ms) : 0, 230743
AppSec [baseline] (57.008 ms) : 0, 57008
AppSec [candidate] (56.967 ms) : 0, 56967
Remote Config [baseline] (591.56 µs) : 0, 592
Remote Config [candidate] (606.183 µs) : 0, 606
Telemetry [baseline] (8.637 ms) : 0, 8637
Telemetry [candidate] (8.731 ms) : 0, 8731
IAST [baseline] (22.658 ms) : 0, 22658
IAST [candidate] (23.036 ms) : 0, 23036
section profiling
BytebuddyAgent [baseline] (709.906 ms) : 0, 709906
BytebuddyAgent [candidate] (714.238 ms) : 0, 714238
GlobalTracer [baseline] (350.006 ms) : 0, 350006
GlobalTracer [candidate] (351.961 ms) : 0, 351961
AppSec [baseline] (55.381 ms) : 0, 55381
AppSec [candidate] (54.687 ms) : 0, 54687
Remote Config [baseline] (678.1 µs) : 0, 678
Remote Config [candidate] (685.622 µs) : 0, 686
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (8.996 ms) : 0, 8996
ProfilingAgent [baseline] (96.444 ms) : 0, 96444
ProfilingAgent [candidate] (96.633 ms) : 0, 96633
Profiling [baseline] (96.467 ms) : 0, 96467
Profiling [candidate] (96.657 ms) : 0, 96657

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038425
Total [baseline] (8.649 s) : 0, 8649029
Agent [candidate] (1.038 s) : 0, 1038370
Total [candidate] (8.66 s) : 0, 8660342
section iast
Agent [baseline] (1.17 s) : 0, 1169945
Total [baseline] (9.265 s) : 0, 9264854
Agent [candidate] (1.173 s) : 0, 1172937
Total [candidate] (9.234 s) : 0, 9234325
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172396
Total [baseline] (9.218 s) : 0, 9217628
Agent [candidate] (1.176 s) : 0, 1176224
Total [candidate] (9.246 s) : 0, 9245610
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166851
Total [baseline] (9.239 s) : 0, 9238651
Agent [candidate] (1.174 s) : 0, 1174360
Total [candidate] (9.25 s) : 0, 9249739

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	iast	1.17 s	131.52 ms (12.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	133.97 ms (12.9%)
Agent	iast_TELEMETRY_OFF	1.167 s	128.426 ms (12.4%)
Total	tracing	8.649 s	-
Total	iast	9.265 s	615.825 ms (7.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.218 s	568.599 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.239 s	589.622 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	iast	1.173 s	134.567 ms (13.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	137.854 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.174 s	135.99 ms (13.1%)
Total	tracing	8.66 s	-
Total	iast	9.234 s	573.983 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.246 s	585.267 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.25 s	589.396 ms (6.8%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.185 ms) : 0, 716185
BytebuddyAgent [candidate] (714.974 ms) : 0, 714974
GlobalTracer [baseline] (238.936 ms) : 0, 238936
GlobalTracer [candidate] (238.747 ms) : 0, 238747
AppSec [baseline] (55.475 ms) : 0, 55475
AppSec [candidate] (55.297 ms) : 0, 55297
Remote Config [baseline] (693.111 µs) : 0, 693
Remote Config [candidate] (694.997 µs) : 0, 695
Telemetry [baseline] (12.203 ms) : 0, 12203
Telemetry [candidate] (13.684 ms) : 0, 13684
section iast
BytebuddyAgent [baseline] (836.275 ms) : 0, 836275
BytebuddyAgent [candidate] (838.665 ms) : 0, 838665
GlobalTracer [baseline] (229.824 ms) : 0, 229824
GlobalTracer [candidate] (229.912 ms) : 0, 229912
IAST [baseline] (22.808 ms) : 0, 22808
IAST [candidate] (22.928 ms) : 0, 22928
AppSec [baseline] (56.814 ms) : 0, 56814
AppSec [candidate] (57.009 ms) : 0, 57009
Remote Config [baseline] (616.042 µs) : 0, 616
Remote Config [candidate] (613.014 µs) : 0, 613
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.744 ms) : 0, 8744
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.571 ms) : 0, 837571
BytebuddyAgent [candidate] (840.517 ms) : 0, 840517
GlobalTracer [baseline] (230.547 ms) : 0, 230547
GlobalTracer [candidate] (230.83 ms) : 0, 230830
IAST [baseline] (23.44 ms) : 0, 23440
IAST [candidate] (23.197 ms) : 0, 23197
AppSec [baseline] (56.529 ms) : 0, 56529
AppSec [candidate] (57.148 ms) : 0, 57148
Remote Config [baseline] (606.179 µs) : 0, 606
Remote Config [candidate] (620.002 µs) : 0, 620
Telemetry [baseline] (8.704 ms) : 0, 8704
Telemetry [candidate] (8.875 ms) : 0, 8875
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.341 ms) : 0, 833341
BytebuddyAgent [candidate] (838.923 ms) : 0, 838923
GlobalTracer [baseline] (229.577 ms) : 0, 229577
GlobalTracer [candidate] (231.191 ms) : 0, 231191
IAST [baseline] (25.609 ms) : 0, 25609
IAST [candidate] (26.6 ms) : 0, 26600
AppSec [baseline] (54.14 ms) : 0, 54140
AppSec [candidate] (53.262 ms) : 0, 53262
Remote Config [baseline] (617.946 µs) : 0, 618
Remote Config [candidate] (614.105 µs) : 0, 614
Telemetry [baseline] (8.607 ms) : 0, 8607
Telemetry [candidate] (8.675 ms) : 0, 8675

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-28T16:41:17	2025-02-28T16:49:01
git_branch	master	evanchooly/DEBUG-3547
git_commit_date	1740758111	1740760195
git_commit_sha	`19d8832`	`88a893c`
release_version	1.47.0-SNAPSHOT~19d8832a9d	1.47.0-SNAPSHOT~88a893c3ef
start_time	2025-02-28T16:41:03	2025-02-28T16:48:47

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740761739	1740761739
ci_job_id	828114723	828114723
ci_pipeline_id	57366617	57366617
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cxumtg-z-project-304-concurrent-2-25qllryk 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cxumtg-z-project-304-concurrent-2-25qllryk 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section baseline
no_agent (380.187 µs) : 359, 401
. : milestone, 380,
iast (505.411 µs) : 483, 528
. : milestone, 505,
iast_FULL (728.869 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (559.451 µs) : 536, 583
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (510.37 µs) : 488, 532
. : milestone, 510,
iast_INACTIVE (464.059 µs) : 443, 485
. : milestone, 464,
iast_TELEMETRY_OFF (495.627 µs) : 473, 519
. : milestone, 496,
tracing (455.452 µs) : 434, 477
. : milestone, 455,
section candidate
no_agent (380.648 µs) : 360, 401
. : milestone, 381,
iast (511.136 µs) : 488, 534
. : milestone, 511,
iast_FULL (720.491 µs) : 699, 742
. : milestone, 720,
iast_GLOBAL (554.516 µs) : 532, 577
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (509.012 µs) : 487, 531
. : milestone, 509,
iast_INACTIVE (458.478 µs) : 437, 480
. : milestone, 458,
iast_TELEMETRY_OFF (493.062 µs) : 470, 516
. : milestone, 493,
tracing (454.521 µs) : 433, 476
. : milestone, 455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.187 µs [359.348 µs, 401.027 µs]	-
iast	505.411 µs [483.114 µs, 527.707 µs]	125.224 µs (32.9%)
iast_FULL	728.869 µs [706.815 µs, 750.923 µs]	348.682 µs (91.7%)
iast_GLOBAL	559.451 µs [536.199 µs, 582.703 µs]	179.264 µs (47.2%)
iast_HARDCODED_SECRET_DISABLED	510.37 µs [488.271 µs, 532.469 µs]	130.183 µs (34.2%)
iast_INACTIVE	464.059 µs [442.96 µs, 485.157 µs]	83.871 µs (22.1%)
iast_TELEMETRY_OFF	495.627 µs [472.555 µs, 518.699 µs]	115.44 µs (30.4%)
tracing	455.452 µs [434.397 µs, 476.506 µs]	75.264 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.648 µs [360.471 µs, 400.825 µs]	-
iast	511.136 µs [488.41 µs, 533.862 µs]	130.489 µs (34.3%)
iast_FULL	720.491 µs [698.642 µs, 742.341 µs]	339.844 µs (89.3%)
iast_GLOBAL	554.516 µs [532.209 µs, 576.824 µs]	173.869 µs (45.7%)
iast_HARDCODED_SECRET_DISABLED	509.012 µs [487.322 µs, 530.701 µs]	128.364 µs (33.7%)
iast_INACTIVE	458.478 µs [437.205 µs, 479.75 µs]	77.83 µs (20.4%)
iast_TELEMETRY_OFF	493.062 µs [469.954 µs, 516.17 µs]	112.414 µs (29.5%)
tracing	454.521 µs [433.358 µs, 475.683 µs]	73.873 µs (19.4%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1378
. : milestone, 1358,
appsec (1.733 ms) : 1709, 1756
. : milestone, 1733,
appsec_no_iast (1.723 ms) : 1698, 1749
. : milestone, 1723,
code_origins (1.671 ms) : 1638, 1703
. : milestone, 1671,
iast (1.514 ms) : 1490, 1539
. : milestone, 1514,
profiling (1.549 ms) : 1523, 1574
. : milestone, 1549,
tracing (1.489 ms) : 1465, 1513
. : milestone, 1489,
section candidate
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.75 ms) : 1726, 1774
. : milestone, 1750,
appsec_no_iast (1.776 ms) : 1751, 1802
. : milestone, 1776,
code_origins (1.69 ms) : 1657, 1723
. : milestone, 1690,
iast (1.511 ms) : 1487, 1535
. : milestone, 1511,
profiling (1.545 ms) : 1520, 1569
. : milestone, 1545,
tracing (1.477 ms) : 1452, 1502
. : milestone, 1477,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.378 ms]	-
appsec	1.733 ms [1.709 ms, 1.756 ms]	374.053 µs (27.5%)
appsec_no_iast	1.723 ms [1.698 ms, 1.749 ms]	364.978 µs (26.9%)
code_origins	1.671 ms [1.638 ms, 1.703 ms]	312.196 µs (23.0%)
iast	1.514 ms [1.49 ms, 1.539 ms]	156.01 µs (11.5%)
profiling	1.549 ms [1.523 ms, 1.574 ms]	190.194 µs (14.0%)
tracing	1.489 ms [1.465 ms, 1.513 ms]	130.526 µs (9.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.33 ms, 1.368 ms]	-
appsec	1.75 ms [1.726 ms, 1.774 ms]	400.659 µs (29.7%)
appsec_no_iast	1.776 ms [1.751 ms, 1.802 ms]	427.108 µs (31.7%)
code_origins	1.69 ms [1.657 ms, 1.723 ms]	340.569 µs (25.2%)
iast	1.511 ms [1.487 ms, 1.535 ms]	161.866 µs (12.0%)
profiling	1.545 ms [1.52 ms, 1.569 ms]	195.204 µs (14.5%)
tracing	1.477 ms [1.452 ms, 1.502 ms]	127.194 µs (9.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3547
git_commit_date	1740758111	1740760195
git_commit_sha	`19d8832`	`88a893c`
release_version	1.47.0-SNAPSHOT~19d8832a9d	1.47.0-SNAPSHOT~88a893c3ef

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1740762086	1740762086
ci_job_id	828114724	828114724
ci_pipeline_id	57366617	57366617
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cxumtg-z-project-304-concurrent-3-55dgtdwo 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cxumtg-z-project-304-concurrent-3-55dgtdwo 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.338 ms) : 2295, 2382
. : milestone, 2338,
iast (2.119 ms) : 2064, 2174
. : milestone, 2119,
iast_GLOBAL (2.163 ms) : 2108, 2218
. : milestone, 2163,
profiling (1.989 ms) : 1944, 2034
. : milestone, 1989,
tracing (1.959 ms) : 1916, 2002
. : milestone, 1959,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.366 ms) : 2322, 2409
. : milestone, 2366,
iast (2.122 ms) : 2066, 2177
. : milestone, 2122,
iast_GLOBAL (2.173 ms) : 2117, 2229
. : milestone, 2173,
profiling (1.971 ms) : 1927, 2015
. : milestone, 1971,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	2.338 ms [2.295 ms, 2.382 ms]	863.512 µs (58.6%)
iast	2.119 ms [2.064 ms, 2.174 ms]	644.51 µs (43.7%)
iast_GLOBAL	2.163 ms [2.108 ms, 2.218 ms]	688.448 µs (46.7%)
profiling	1.989 ms [1.944 ms, 2.034 ms]	514.195 µs (34.9%)
tracing	1.959 ms [1.916 ms, 2.002 ms]	484.13 µs (32.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.366 ms [2.322 ms, 2.409 ms]	893.249 µs (60.7%)
iast	2.122 ms [2.066 ms, 2.177 ms]	649.243 µs (44.1%)
iast_GLOBAL	2.173 ms [2.117 ms, 2.229 ms]	700.774 µs (47.6%)
profiling	1.971 ms [1.927 ms, 2.015 ms]	498.749 µs (33.9%)
tracing	1.953 ms [1.911 ms, 1.995 ms]	480.719 µs (32.7%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~88a893c3ef, baseline=1.47.0-SNAPSHOT~19d8832a9d
dateFormat X
axisFormat %s
section baseline
no_agent (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
appsec (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
iast (18.937 s) : 18937000, 18937000
. : milestone, 18937000,
iast_GLOBAL (18.211 s) : 18211000, 18211000
. : milestone, 18211000,
profiling (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
section candidate
no_agent (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
appsec (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
iast (18.66 s) : 18660000, 18660000
. : milestone, 18660000,
iast_GLOBAL (17.652 s) : 17652000, 17652000
. : milestone, 17652000,
profiling (15.278 s) : 15278000, 15278000
. : milestone, 15278000,
tracing (14.946 s) : 14946000, 14946000
. : milestone, 14946000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.03 s [15.03 s, 15.03 s]	-
appsec	15.032 s [15.032 s, 15.032 s]	2.0 ms (0.0%)
iast	18.937 s [18.937 s, 18.937 s]	3.907 s (26.0%)
iast_GLOBAL	18.211 s [18.211 s, 18.211 s]	3.181 s (21.2%)
profiling	14.909 s [14.909 s, 14.909 s]	-121.0 ms (-0.8%)
tracing	14.95 s [14.95 s, 14.95 s]	-80.0 ms (-0.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.911 s [14.911 s, 14.911 s]	-
appsec	14.778 s [14.778 s, 14.778 s]	-133.0 ms (-0.9%)
iast	18.66 s [18.66 s, 18.66 s]	3.749 s (25.1%)
iast_GLOBAL	17.652 s [17.652 s, 17.652 s]	2.741 s (18.4%)
profiling	15.278 s [15.278 s, 15.278 s]	367.0 ms (2.5%)
tracing	14.946 s [14.946 s, 14.946 s]	35.0 ms (0.2%)

another test case for jacoco

don't instrument trigger probes if the distributed debugger is disabled
7381c04

evanchooly added tag: no release notes Changes to exclude from release notes comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation labels Feb 26, 2025

evanchooly requested a review from a team as a code owner February 26, 2025 18:50

evanchooly requested review from a team, jpbempel and shatzi and removed request for a teamFebruary 26, 2025 18:50

jpbempel approved these changes Feb 27, 2025
View reviewed changes

Comment thread...nt/agent-debugger/debugger-el/src/main/java/com/datadog/debugger/el/EvaluationException.java Outdated
Comment threaddd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/TriggerProbe.java

evanchooly added 2 commits February 28, 2025 08:59

include the message in exception hash for symmetry with equals()
3656177
another test case for jacoco

exclude exception from coverage checks
88a893c

evanchooly added the type: feature Enhancements and improvements label Feb 28, 2025

evanchooly merged commit be03ce5 into masterFeb 28, 2025

evanchooly deleted the evanchooly/DEBUG-3547 branch February 28, 2025 17:18

github-actionsBot added this to the 1.47.0 milestone Feb 28, 2025

Navigation Menu

Uh oh!

Don't instrument trigger probes if the distributed debugger is disabled - #8458

Don't instrument trigger probes if the distributed debugger is disabled#8458
evanchooly merged 3 commits into
masterfrom
evanchooly/DEBUG-3547

evanchooly commented Feb 26, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Feb 26, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Feb 26, 2025•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

evanchooly commented Feb 26, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Feb 26, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenterBot commented Feb 26, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

evanchooly commented Feb 26, 2025•
edited by atlassian Bot
Loading

pr-commenterBot commented Feb 26, 2025•
edited
Loading

pr-commenterBot commented Feb 26, 2025•
edited
Loading