Skip to content

Prefer using activeSpan() over activeScope() - #8492

Merged
mcculls merged 1 commit into
masterfrom
mcculls/more-reduce-active-scope-usage
Mar 4, 2025
Merged

Prefer using activeSpan() over activeScope()#8492
mcculls merged 1 commit into
masterfrom
mcculls/more-reduce-active-scope-usage

Conversation

@mcculls

@mccullsmcculls commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Motivation

Continuation of #8470 - most of the time we're only interested in whether there's an active span - we don't need the actual closeable handle.

Contributor Checklist

Jira ticket: APMAPI-956

@mccullsmcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 3, 2025
@pr-commenter

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermcculls/more-reduce-active-scope-usage
git_commit_date17410291301741038811
git_commit_shaebb0e552fc7d24
release_version1.47.0-SNAPSHOT~ebb0e552901.47.0-SNAPSHOT~2fc7d24f08
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17410414841741041484
ci_job_id830813652830813652
ci_pipeline_id5757657257576572
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-8ksbllmc-project-304-concurrent-0-jln1qy86 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-8ksbllmc-project-304-concurrent-0-jln1qy86 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone
variantiastiast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics.

Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.152 s) : 0, 1152096
Total [baseline] (9.379 s) : 0, 9378984
Agent [candidate] (1.134 s) : 0, 1134198
Total [candidate] (9.252 s) : 0, 9251689
section iast
Agent [baseline] (1.257 s) : 0, 1257469
Total [baseline] (9.857 s) : 0, 9856736
Agent [candidate] (1.258 s) : 0, 1258155
Total [candidate] (9.885 s) : 0, 9884598
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.256 s) : 0, 1256188
Total [baseline] (9.843 s) : 0, 9842739
Agent [candidate] (1.267 s) : 0, 1266996
Total [candidate] (9.884 s) : 0, 9883551
section iast_TELEMETRY_OFF
Agent [baseline] (1.251 s) : 0, 1250666
Total [baseline] (9.866 s) : 0, 9866104
Agent [candidate] (1.253 s) : 0, 1253249
Total [candidate] (9.909 s) : 0, 9909236
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.152 s-
Agentiast1.257 s105.373 ms (9.1%)
Agentiast_HARDCODED_SECRET_DISABLED1.256 s104.092 ms (9.0%)
Agentiast_TELEMETRY_OFF1.251 s98.57 ms (8.6%)
Totaltracing9.379 s-
Totaliast9.857 s477.753 ms (5.1%)
Totaliast_HARDCODED_SECRET_DISABLED9.843 s463.756 ms (4.9%)
Totaliast_TELEMETRY_OFF9.866 s487.12 ms (5.2%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.134 s-
Agentiast1.258 s123.957 ms (10.9%)
Agentiast_HARDCODED_SECRET_DISABLED1.267 s132.798 ms (11.7%)
Agentiast_TELEMETRY_OFF1.253 s119.051 ms (10.5%)
Totaltracing9.252 s-
Totaliast9.885 s632.909 ms (6.8%)
Totaliast_HARDCODED_SECRET_DISABLED9.884 s631.862 ms (6.8%)
Totaliast_TELEMETRY_OFF9.909 s657.547 ms (7.1%)
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (728.004 ms) : 0, 728004
BytebuddyAgent [candidate] (715.633 ms) : 0, 715633
GlobalTracer [baseline] (243.627 ms) : 0, 243627
GlobalTracer [candidate] (239.614 ms) : 0, 239614
AppSec [baseline] (56.391 ms) : 0, 56391
AppSec [candidate] (55.382 ms) : 0, 55382
Debugger [baseline] (95.671 ms) : 0, 95671
Debugger [candidate] (95.492 ms) : 0, 95492
Remote Config [baseline] (588.84 µs) : 0, 589
Remote Config [candidate] (586.63 µs) : 0, 587
Telemetry [baseline] (12.579 ms) : 0, 12579
Telemetry [candidate] (12.501 ms) : 0, 12501
section iast
BytebuddyAgent [baseline] (836.133 ms) : 0, 836133
BytebuddyAgent [candidate] (835.751 ms) : 0, 835751
GlobalTracer [baseline] (230.258 ms) : 0, 230258
GlobalTracer [candidate] (230.712 ms) : 0, 230712
IAST [baseline] (22.623 ms) : 0, 22623
IAST [candidate] (22.758 ms) : 0, 22758
AppSec [baseline] (57.228 ms) : 0, 57228
AppSec [candidate] (57.187 ms) : 0, 57187
Debugger [baseline] (83.458 ms) : 0, 83458
Debugger [candidate] (83.359 ms) : 0, 83359
Remote Config [baseline] (513.48 µs) : 0, 513
Remote Config [candidate] (517.115 µs) : 0, 517
Telemetry [baseline] (12.251 ms) : 0, 12251
Telemetry [candidate] (12.852 ms) : 0, 12852
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.431 ms) : 0, 833431
BytebuddyAgent [candidate] (840.953 ms) : 0, 840953
GlobalTracer [baseline] (230.309 ms) : 0, 230309
GlobalTracer [candidate] (231.473 ms) : 0, 231473
IAST [baseline] (22.757 ms) : 0, 22757
IAST [candidate] (23.209 ms) : 0, 23209
AppSec [baseline] (56.92 ms) : 0, 56920
AppSec [candidate] (57.402 ms) : 0, 57402
Debugger [baseline] (83.734 ms) : 0, 83734
Debugger [candidate] (84.045 ms) : 0, 84045
Remote Config [baseline] (511.825 µs) : 0, 512
Remote Config [candidate] (526.666 µs) : 0, 527
Telemetry [baseline] (13.537 ms) : 0, 13537
Telemetry [candidate] (14.235 ms) : 0, 14235
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.934 ms) : 0, 830934
BytebuddyAgent [candidate] (831.748 ms) : 0, 831748
GlobalTracer [baseline] (230.169 ms) : 0, 230169
GlobalTracer [candidate] (230.744 ms) : 0, 230744
IAST [baseline] (24.335 ms) : 0, 24335
IAST [candidate] (22.317 ms) : 0, 22317
AppSec [baseline] (54.452 ms) : 0, 54452
AppSec [candidate] (57.207 ms) : 0, 57207
Debugger [baseline] (83.259 ms) : 0, 83259
Debugger [candidate] (83.687 ms) : 0, 83687
Remote Config [baseline] (512.321 µs) : 0, 512
Remote Config [candidate] (514.383 µs) : 0, 514
Telemetry [baseline] (12.085 ms) : 0, 12085
Telemetry [candidate] (12.0 ms) : 0, 12000
Loading
Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.137 s) : 0, 1136687
Total [baseline] (11.454 s) : 0, 11454064
Agent [candidate] (1.141 s) : 0, 1140582
Total [candidate] (11.508 s) : 0, 11507549
section appsec
Agent [baseline] (1.273 s) : 0, 1272776
Total [baseline] (11.635 s) : 0, 11634958
Agent [candidate] (1.272 s) : 0, 1272466
Total [candidate] (11.7 s) : 0, 11700284
section iast
Agent [baseline] (1.268 s) : 0, 1267967
Total [baseline] (12.003 s) : 0, 12003097
Agent [candidate] (1.261 s) : 0, 1261083
Total [candidate] (11.976 s) : 0, 11976429
section profiling
Agent [baseline] (1.389 s) : 0, 1389467
Total [baseline] (11.719 s) : 0, 11719374
Agent [candidate] (1.38 s) : 0, 1379718
Total [candidate] (11.862 s) : 0, 11862020
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.137 s-
Agentappsec1.273 s136.089 ms (12.0%)
Agentiast1.268 s131.28 ms (11.5%)
Agentprofiling1.389 s252.78 ms (22.2%)
Totaltracing11.454 s-
Totalappsec11.635 s180.894 ms (1.6%)
Totaliast12.003 s549.033 ms (4.8%)
Totalprofiling11.719 s265.31 ms (2.3%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.141 s-
Agentappsec1.272 s131.884 ms (11.6%)
Agentiast1.261 s120.501 ms (10.6%)
Agentprofiling1.38 s239.136 ms (21.0%)
Totaltracing11.508 s-
Totalappsec11.7 s192.735 ms (1.7%)
Totaliast11.976 s468.879 ms (4.1%)
Totalprofiling11.862 s354.471 ms (3.1%)
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.471 ms) : 0, 718471
BytebuddyAgent [candidate] (720.891 ms) : 0, 720891
GlobalTracer [baseline] (239.379 ms) : 0, 239379
GlobalTracer [candidate] (240.245 ms) : 0, 240245
AppSec [baseline] (55.339 ms) : 0, 55339
AppSec [candidate] (55.873 ms) : 0, 55873
Debugger [baseline] (95.335 ms) : 0, 95335
Debugger [candidate] (95.293 ms) : 0, 95293
Remote Config [baseline] (594.036 µs) : 0, 594
Remote Config [candidate] (584.621 µs) : 0, 585
Telemetry [baseline] (12.485 ms) : 0, 12485
Telemetry [candidate] (12.634 ms) : 0, 12634
section appsec
BytebuddyAgent [baseline] (734.942 ms) : 0, 734942
BytebuddyAgent [candidate] (734.669 ms) : 0, 734669
GlobalTracer [baseline] (236.968 ms) : 0, 236968
GlobalTracer [candidate] (236.462 ms) : 0, 236462
AppSec [baseline] (177.603 ms) : 0, 177603
AppSec [candidate] (178.302 ms) : 0, 178302
Debugger [baseline] (84.576 ms) : 0, 84576
Debugger [candidate] (84.28 ms) : 0, 84280
Remote Config [baseline] (636.218 µs) : 0, 636
Remote Config [candidate] (630.619 µs) : 0, 631
Telemetry [baseline] (12.311 ms) : 0, 12311
Telemetry [candidate] (12.368 ms) : 0, 12368
IAST [baseline] (21.429 ms) : 0, 21429
IAST [candidate] (21.368 ms) : 0, 21368
section iast
BytebuddyAgent [baseline] (842.04 ms) : 0, 842040
BytebuddyAgent [candidate] (837.565 ms) : 0, 837565
GlobalTracer [baseline] (231.964 ms) : 0, 231964
GlobalTracer [candidate] (230.914 ms) : 0, 230914
AppSec [baseline] (57.454 ms) : 0, 57454
AppSec [candidate] (57.091 ms) : 0, 57091
Debugger [baseline] (84.028 ms) : 0, 84028
Debugger [candidate] (83.709 ms) : 0, 83709
Remote Config [baseline] (518.118 µs) : 0, 518
Remote Config [candidate] (510.664 µs) : 0, 511
Telemetry [baseline] (13.623 ms) : 0, 13623
Telemetry [candidate] (13.467 ms) : 0, 13467
IAST [baseline] (23.102 ms) : 0, 23102
IAST [candidate] (22.619 ms) : 0, 22619
section profiling
BytebuddyAgent [baseline] (714.648 ms) : 0, 714648
BytebuddyAgent [candidate] (708.954 ms) : 0, 708954
GlobalTracer [baseline] (353.043 ms) : 0, 353043
GlobalTracer [candidate] (351.061 ms) : 0, 351061
AppSec [baseline] (55.717 ms) : 0, 55717
AppSec [candidate] (54.082 ms) : 0, 54082
Debugger [baseline] (88.708 ms) : 0, 88708
Debugger [candidate] (88.001 ms) : 0, 88001
Remote Config [baseline] (617.972 µs) : 0, 618
Remote Config [candidate] (617.644 µs) : 0, 618
Telemetry [baseline] (12.655 ms) : 0, 12655
Telemetry [candidate] (12.622 ms) : 0, 12622
ProfilingAgent [baseline] (123.301 ms) : 0, 123301
ProfilingAgent [candidate] (123.951 ms) : 0, 123951
Profiling [baseline] (123.321 ms) : 0, 123321
Profiling [candidate] (123.972 ms) : 0, 123972
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
end_time2025-03-03T22:03:562025-03-03T22:11:54
git_branchmastermcculls/more-reduce-active-scope-usage
git_commit_date17410291301741038811
git_commit_shaebb0e552fc7d24
release_version1.47.0-SNAPSHOT~ebb0e552901.47.0-SNAPSHOT~2fc7d24f08
start_time2025-03-03T22:03:422025-03-03T22:11:39
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17410403241741040324
ci_job_id830813653830813653
ci_pipeline_id5757657257576572
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-8ksbllmc-project-304-concurrent-1-x7v0t9k7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-8ksbllmc-project-304-concurrent-1-x7v0t9k7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variantiastiast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1390
. : milestone, 1370,
appsec (1.741 ms) : 1717, 1765
. : milestone, 1741,
appsec_no_iast (1.72 ms) : 1696, 1745
. : milestone, 1720,
code_origins (1.703 ms) : 1670, 1735
. : milestone, 1703,
iast (1.533 ms) : 1509, 1558
. : milestone, 1533,
profiling (1.508 ms) : 1483, 1533
. : milestone, 1508,
tracing (1.507 ms) : 1484, 1531
. : milestone, 1507,
section candidate
no_agent (1.362 ms) : 1343, 1382
. : milestone, 1362,
appsec (1.74 ms) : 1716, 1764
. : milestone, 1740,
appsec_no_iast (1.757 ms) : 1733, 1781
. : milestone, 1757,
code_origins (1.695 ms) : 1662, 1727
. : milestone, 1695,
iast (1.545 ms) : 1520, 1571
. : milestone, 1545,
profiling (1.534 ms) : 1510, 1558
. : milestone, 1534,
tracing (1.503 ms) : 1480, 1526
. : milestone, 1503,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.37 ms [1.35 ms, 1.39 ms]-
appsec1.741 ms [1.717 ms, 1.765 ms]370.967 µs (27.1%)
appsec_no_iast1.72 ms [1.696 ms, 1.745 ms]350.064 µs (25.6%)
code_origins1.703 ms [1.67 ms, 1.735 ms]332.744 µs (24.3%)
iast1.533 ms [1.509 ms, 1.558 ms]163.481 µs (11.9%)
profiling1.508 ms [1.483 ms, 1.533 ms]138.122 µs (10.1%)
tracing1.507 ms [1.484 ms, 1.531 ms]137.211 µs (10.0%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.362 ms [1.343 ms, 1.382 ms]-
appsec1.74 ms [1.716 ms, 1.764 ms]378.243 µs (27.8%)
appsec_no_iast1.757 ms [1.733 ms, 1.781 ms]395.159 µs (29.0%)
code_origins1.695 ms [1.662 ms, 1.727 ms]332.632 µs (24.4%)
iast1.545 ms [1.52 ms, 1.571 ms]183.208 µs (13.4%)
profiling1.534 ms [1.51 ms, 1.558 ms]171.822 µs (12.6%)
tracing1.503 ms [1.48 ms, 1.526 ms]140.733 µs (10.3%)
Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section baseline
no_agent (386.671 µs) : 366, 407
. : milestone, 387,
iast (518.83 µs) : 497, 541
. : milestone, 519,
iast_FULL (741.861 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (572.526 µs) : 551, 594
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (524.131 µs) : 502, 547
. : milestone, 524,
iast_INACTIVE (469.831 µs) : 448, 492
. : milestone, 470,
iast_TELEMETRY_OFF (504.821 µs) : 483, 527
. : milestone, 505,
tracing (462.707 µs) : 442, 484
. : milestone, 463,
section candidate
no_agent (385.758 µs) : 365, 406
. : milestone, 386,
iast (521.278 µs) : 500, 543
. : milestone, 521,
iast_FULL (739.6 µs) : 717, 762
. : milestone, 740,
iast_GLOBAL (568.756 µs) : 547, 591
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (520.34 µs) : 498, 542
. : milestone, 520,
iast_INACTIVE (473.834 µs) : 452, 495
. : milestone, 474,
iast_TELEMETRY_OFF (515.468 µs) : 493, 538
. : milestone, 515,
tracing (464.063 µs) : 443, 485
. : milestone, 464,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent386.671 µs [366.463 µs, 406.88 µs]-
iast518.83 µs [496.898 µs, 540.763 µs]132.159 µs (34.2%)
iast_FULL741.861 µs [719.67 µs, 764.051 µs]355.189 µs (91.9%)
iast_GLOBAL572.526 µs [550.844 µs, 594.207 µs]185.855 µs (48.1%)
iast_HARDCODED_SECRET_DISABLED524.131 µs [501.633 µs, 546.63 µs]137.46 µs (35.5%)
iast_INACTIVE469.831 µs [447.978 µs, 491.683 µs]83.159 µs (21.5%)
iast_TELEMETRY_OFF504.821 µs [482.966 µs, 526.675 µs]118.15 µs (30.6%)
tracing462.707 µs [441.622 µs, 483.792 µs]76.036 µs (19.7%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent385.758 µs [365.288 µs, 406.227 µs]-
iast521.278 µs [499.646 µs, 542.909 µs]135.52 µs (35.1%)
iast_FULL739.6 µs [717.144 µs, 762.057 µs]353.843 µs (91.7%)
iast_GLOBAL568.756 µs [546.814 µs, 590.699 µs]182.999 µs (47.4%)
iast_HARDCODED_SECRET_DISABLED520.34 µs [498.479 µs, 542.201 µs]134.582 µs (34.9%)
iast_INACTIVE473.834 µs [452.38 µs, 495.288 µs]88.076 µs (22.8%)
iast_TELEMETRY_OFF515.468 µs [493.091 µs, 537.845 µs]129.711 µs (33.6%)
tracing464.063 µs [443.111 µs, 485.016 µs]78.305 µs (20.3%)

Dacapo

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermcculls/more-reduce-active-scope-usage
git_commit_date17410291301741038811
git_commit_shaebb0e552fc7d24
release_version1.47.0-SNAPSHOT~ebb0e552901.47.0-SNAPSHOT~2fc7d24f08
See matching parameters
BaselineCandidate
applicationbiojavabiojava
ci_job_date17410408541741040854
ci_job_id830813654830813654
ci_pipeline_id5757657257576572
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-8ksbllmc-project-304-concurrent-2-mg919l5z 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-8ksbllmc-project-304-concurrent-2-mg919l5z 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variantappsecappsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1486
. : milestone, 1474,
appsec (2.344 ms) : 2300, 2388
. : milestone, 2344,
iast (2.118 ms) : 2062, 2173
. : milestone, 2118,
iast_GLOBAL (2.162 ms) : 2106, 2217
. : milestone, 2162,
profiling (1.981 ms) : 1936, 2025
. : milestone, 1981,
tracing (1.957 ms) : 1915, 2000
. : milestone, 1957,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.342 ms) : 2298, 2386
. : milestone, 2342,
iast (2.113 ms) : 2058, 2169
. : milestone, 2113,
iast_GLOBAL (2.163 ms) : 2107, 2219
. : milestone, 2163,
profiling (1.969 ms) : 1925, 2012
. : milestone, 1969,
tracing (1.948 ms) : 1906, 1990
. : milestone, 1948,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.474 ms [1.462 ms, 1.486 ms]-
appsec2.344 ms [2.3 ms, 2.388 ms]870.039 µs (59.0%)
iast2.118 ms [2.062 ms, 2.173 ms]643.873 µs (43.7%)
iast_GLOBAL2.162 ms [2.106 ms, 2.217 ms]687.604 µs (46.6%)
profiling1.981 ms [1.936 ms, 2.025 ms]506.577 µs (34.4%)
tracing1.957 ms [1.915 ms, 2.0 ms]483.491 µs (32.8%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.474 ms [1.462 ms, 1.485 ms]-
appsec2.342 ms [2.298 ms, 2.386 ms]868.523 µs (58.9%)
iast2.113 ms [2.058 ms, 2.169 ms]639.597 µs (43.4%)
iast_GLOBAL2.163 ms [2.107 ms, 2.219 ms]689.262 µs (46.8%)
profiling1.969 ms [1.925 ms, 2.012 ms]494.798 µs (33.6%)
tracing1.948 ms [1.906 ms, 1.99 ms]474.002 µs (32.2%)
Execution time for biojava
gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~2fc7d24f08, baseline=1.47.0-SNAPSHOT~ebb0e55290
dateFormat X
axisFormat %s
section baseline
no_agent (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
appsec (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
iast (18.929 s) : 18929000, 18929000
. : milestone, 18929000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
profiling (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
tracing (14.772 s) : 14772000, 14772000
. : milestone, 14772000,
section candidate
no_agent (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
appsec (14.762 s) : 14762000, 14762000
. : milestone, 14762000,
iast (18.911 s) : 18911000, 18911000
. : milestone, 18911000,
iast_GLOBAL (17.764 s) : 17764000, 17764000
. : milestone, 17764000,
profiling (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
tracing (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent14.833 s [14.833 s, 14.833 s]-
appsec14.981 s [14.981 s, 14.981 s]148.0 ms (1.0%)
iast18.929 s [18.929 s, 18.929 s]4.096 s (27.6%)
iast_GLOBAL18.143 s [18.143 s, 18.143 s]3.31 s (22.3%)
profiling15.087 s [15.087 s, 15.087 s]254.0 ms (1.7%)
tracing14.772 s [14.772 s, 14.772 s]-61.0 ms (-0.4%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent14.941 s [14.941 s, 14.941 s]-
appsec14.762 s [14.762 s, 14.762 s]-179.0 ms (-1.2%)
iast18.911 s [18.911 s, 18.911 s]3.97 s (26.6%)
iast_GLOBAL17.764 s [17.764 s, 17.764 s]2.823 s (18.9%)
profiling15.093 s [15.093 s, 15.093 s]152.0 ms (1.0%)
tracing15.048 s [15.048 s, 15.048 s]107.0 ms (0.7%)

@mcculls
mcculls marked this pull request as ready for review March 3, 2025 22:45
@mcculls
mcculls requested a review from a team as a code ownerMarch 3, 2025 22:45

@PerfectSlayerPerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for the refactoring 👍

@mcculls
mcculls merged commit 8f945b0 into masterMar 4, 2025
@mcculls
mcculls deleted the mcculls/more-reduce-active-scope-usage branch March 4, 2025 10:06
@github-actionsgithub-actionsBot added this to the 1.47.0 milestone Mar 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: coreTracer coretag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls@smola@PerfectSlayer