Migrate kotlin coroutines instrumentation to new Context API by mcculls · Pull Request #8528 · DataDog/dd-trace-java

mcculls · 2025-03-08T22:38:37Z

Additional Notes

Tests are expected to fail while the scope manager has not yet been replaced.

That's why the final target of this stacked PR is the project/context feature branch.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-963

pr-commenter · 2025-03-08T23:15:33Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/use-context-in-kotlin-coroutines
git_commit_date	1741423605	1741473423
git_commit_sha	`04b1afd`	f3c421a0fe
release_version	1.48.0-SNAPSHOT~04b1afde28	1.48.0-SNAPSHOT~f3c421a0fe

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741475686	1741475686
ci_job_id	839247961	839247961
ci_pipeline_id	58202233	58202233
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-2wkmbgws-project-304-concurrent-1-f9we1jwe 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-2wkmbgws-project-304-concurrent-1-f9we1jwe 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047168
Total [baseline] (8.663 s) : 0, 8662959
Agent [candidate] (1.041 s) : 0, 1040933
Total [candidate] (8.745 s) : 0, 8745164
section iast
Agent [baseline] (1.172 s) : 0, 1172108
Total [baseline] (9.256 s) : 0, 9256251
Agent [candidate] (1.186 s) : 0, 1186370
Total [candidate] (9.265 s) : 0, 9264852
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173544
Total [baseline] (9.207 s) : 0, 9206861
Agent [candidate] (1.172 s) : 0, 1171630
Total [candidate] (9.236 s) : 0, 9236014
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169040
Total [baseline] (9.21 s) : 0, 9209648
Agent [candidate] (1.17 s) : 0, 1169581
Total [candidate] (9.234 s) : 0, 9233657

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.172 s	124.94 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	126.375 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.169 s	121.872 ms (11.6%)
Total	tracing	8.663 s	-
Total	iast	9.256 s	593.292 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.207 s	543.902 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.21 s	546.69 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.186 s	145.436 ms (14.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	130.697 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.17 s	128.648 ms (12.4%)
Total	tracing	8.745 s	-
Total	iast	9.265 s	519.688 ms (5.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.236 s	490.85 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.234 s	488.493 ms (5.6%)

gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.137 ms) : 0, 721137
BytebuddyAgent [candidate] (717.692 ms) : 0, 717692
GlobalTracer [baseline] (240.429 ms) : 0, 240429
GlobalTracer [candidate] (240.651 ms) : 0, 240651
AppSec [baseline] (55.572 ms) : 0, 55572
AppSec [candidate] (55.4 ms) : 0, 55400
Remote Config [baseline] (700.764 µs) : 0, 701
Remote Config [candidate] (690.47 µs) : 0, 690
Telemetry [baseline] (14.331 ms) : 0, 14331
Telemetry [candidate] (11.524 ms) : 0, 11524
section iast
BytebuddyAgent [baseline] (837.076 ms) : 0, 837076
BytebuddyAgent [candidate] (848.988 ms) : 0, 848988
GlobalTracer [baseline] (230.466 ms) : 0, 230466
GlobalTracer [candidate] (232.636 ms) : 0, 232636
IAST [baseline] (22.975 ms) : 0, 22975
IAST [candidate] (23.026 ms) : 0, 23026
AppSec [baseline] (57.232 ms) : 0, 57232
AppSec [candidate] (57.2 ms) : 0, 57200
Remote Config [baseline] (617.007 µs) : 0, 617
Remote Config [candidate] (611.798 µs) : 0, 612
Telemetry [baseline] (8.812 ms) : 0, 8812
Telemetry [candidate] (8.751 ms) : 0, 8751
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.265 ms) : 0, 838265
BytebuddyAgent [candidate] (836.942 ms) : 0, 836942
GlobalTracer [baseline] (231.039 ms) : 0, 231039
GlobalTracer [candidate] (231.147 ms) : 0, 231147
IAST [baseline] (22.774 ms) : 0, 22774
IAST [candidate] (22.755 ms) : 0, 22755
AppSec [baseline] (57.12 ms) : 0, 57120
AppSec [candidate] (56.588 ms) : 0, 56588
Remote Config [baseline] (605.022 µs) : 0, 605
Remote Config [candidate] (593.119 µs) : 0, 593
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.591 ms) : 0, 8591
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.704 ms) : 0, 834704
BytebuddyAgent [candidate] (835.013 ms) : 0, 835013
GlobalTracer [baseline] (230.862 ms) : 0, 230862
GlobalTracer [candidate] (230.967 ms) : 0, 230967
IAST [baseline] (22.568 ms) : 0, 22568
IAST [candidate] (22.385 ms) : 0, 22385
AppSec [baseline] (56.781 ms) : 0, 56781
AppSec [candidate] (57.003 ms) : 0, 57003
Remote Config [baseline] (612.993 µs) : 0, 613
Remote Config [candidate] (612.842 µs) : 0, 613
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.677 ms) : 0, 8677

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059737
Total [baseline] (10.569 s) : 0, 10569026
Agent [candidate] (1.042 s) : 0, 1042077
Total [candidate] (10.507 s) : 0, 10506810
section appsec
Agent [baseline] (1.183 s) : 0, 1182619
Total [baseline] (10.721 s) : 0, 10721274
Agent [candidate] (1.187 s) : 0, 1187497
Total [candidate] (10.791 s) : 0, 10791211
section iast
Agent [baseline] (1.173 s) : 0, 1173215
Total [baseline] (11.003 s) : 0, 11003324
Agent [candidate] (1.175 s) : 0, 1175124
Total [candidate] (10.99 s) : 0, 10989582
section profiling
Agent [baseline] (1.26 s) : 0, 1260360
Total [baseline] (10.936 s) : 0, 10936446
Agent [candidate] (1.273 s) : 0, 1273163
Total [candidate] (10.907 s) : 0, 10907075

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	appsec	1.183 s	122.881 ms (11.6%)
Agent	iast	1.173 s	113.477 ms (10.7%)
Agent	profiling	1.26 s	200.622 ms (18.9%)
Total	tracing	10.569 s	-
Total	appsec	10.721 s	152.248 ms (1.4%)
Total	iast	11.003 s	434.297 ms (4.1%)
Total	profiling	10.936 s	367.42 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.187 s	145.419 ms (14.0%)
Agent	iast	1.175 s	133.047 ms (12.8%)
Agent	profiling	1.273 s	231.085 ms (22.2%)
Total	tracing	10.507 s	-
Total	appsec	10.791 s	284.401 ms (2.7%)
Total	iast	10.99 s	482.772 ms (4.6%)
Total	profiling	10.907 s	400.265 ms (3.8%)

gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (731.576 ms) : 0, 731576
BytebuddyAgent [candidate] (717.962 ms) : 0, 717962
GlobalTracer [baseline] (243.442 ms) : 0, 243442
GlobalTracer [candidate] (239.839 ms) : 0, 239839
AppSec [baseline] (56.339 ms) : 0, 56339
AppSec [candidate] (55.258 ms) : 0, 55258
Remote Config [baseline] (701.155 µs) : 0, 701
Remote Config [candidate] (684.923 µs) : 0, 685
Telemetry [baseline] (12.454 ms) : 0, 12454
Telemetry [candidate] (13.487 ms) : 0, 13487
section appsec
BytebuddyAgent [baseline] (735.032 ms) : 0, 735032
BytebuddyAgent [candidate] (738.473 ms) : 0, 738473
GlobalTracer [baseline] (236.822 ms) : 0, 236822
GlobalTracer [candidate] (237.597 ms) : 0, 237597
IAST [baseline] (21.329 ms) : 0, 21329
IAST [candidate] (21.503 ms) : 0, 21503
AppSec [baseline] (175.868 ms) : 0, 175868
AppSec [candidate] (176.773 ms) : 0, 176773
Remote Config [baseline] (659.301 µs) : 0, 659
Remote Config [candidate] (657.809 µs) : 0, 658
Telemetry [baseline] (8.623 ms) : 0, 8623
Telemetry [candidate] (8.31 ms) : 0, 8310
section iast
BytebuddyAgent [baseline] (838.141 ms) : 0, 838141
BytebuddyAgent [candidate] (839.332 ms) : 0, 839332
GlobalTracer [baseline] (230.849 ms) : 0, 230849
GlobalTracer [candidate] (231.57 ms) : 0, 231570
IAST [baseline] (22.828 ms) : 0, 22828
IAST [candidate] (23.0 ms) : 0, 23000
AppSec [baseline] (56.954 ms) : 0, 56954
AppSec [candidate] (56.8 ms) : 0, 56800
Remote Config [baseline] (611.669 µs) : 0, 612
Remote Config [candidate] (604.499 µs) : 0, 604
Telemetry [baseline] (8.837 ms) : 0, 8837
Telemetry [candidate] (8.755 ms) : 0, 8755
section profiling
BytebuddyAgent [baseline] (708.903 ms) : 0, 708903
BytebuddyAgent [candidate] (719.266 ms) : 0, 719266
GlobalTracer [baseline] (349.444 ms) : 0, 349444
GlobalTracer [candidate] (351.626 ms) : 0, 351626
AppSec [baseline] (54.93 ms) : 0, 54930
AppSec [candidate] (54.6 ms) : 0, 54600
Remote Config [baseline] (675.487 µs) : 0, 675
Remote Config [candidate] (675.543 µs) : 0, 676
Telemetry [baseline] (8.96 ms) : 0, 8960
Telemetry [candidate] (9.04 ms) : 0, 9040
ProfilingAgent [baseline] (97.112 ms) : 0, 97112
ProfilingAgent [candidate] (96.998 ms) : 0, 96998
Profiling [baseline] (97.137 ms) : 0, 97137
Profiling [candidate] (97.023 ms) : 0, 97023

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-08T22:47:14	2025-03-08T22:54:58
git_branch	master	mcculls/use-context-in-kotlin-coroutines
git_commit_date	1741423605	1741473423
git_commit_sha	`04b1afd`	f3c421a0fe
release_version	1.48.0-SNAPSHOT~04b1afde28	1.48.0-SNAPSHOT~f3c421a0fe
start_time	2025-03-08T22:47:00	2025-03-08T22:54:44

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741474896	1741474896
ci_job_id	839247962	839247962
ci_pipeline_id	58202233	58202233
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-2wkmbgws-project-304-concurrent-3-igmdop7n 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-2wkmbgws-project-304-concurrent-3-igmdop7n 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1331, 1370
. : milestone, 1351,
appsec (1.752 ms) : 1728, 1776
. : milestone, 1752,
appsec_no_iast (1.746 ms) : 1721, 1772
. : milestone, 1746,
code_origins (1.673 ms) : 1639, 1707
. : milestone, 1673,
iast (1.51 ms) : 1486, 1534
. : milestone, 1510,
profiling (1.523 ms) : 1499, 1547
. : milestone, 1523,
tracing (1.49 ms) : 1466, 1514
. : milestone, 1490,
section candidate
no_agent (1.351 ms) : 1332, 1371
. : milestone, 1351,
appsec (1.706 ms) : 1682, 1730
. : milestone, 1706,
appsec_no_iast (1.719 ms) : 1695, 1744
. : milestone, 1719,
code_origins (1.686 ms) : 1652, 1720
. : milestone, 1686,
iast (1.509 ms) : 1485, 1533
. : milestone, 1509,
profiling (1.561 ms) : 1536, 1586
. : milestone, 1561,
tracing (1.486 ms) : 1461, 1511
. : milestone, 1486,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.331 ms, 1.37 ms]	-
appsec	1.752 ms [1.728 ms, 1.776 ms]	401.415 µs (29.7%)
appsec_no_iast	1.746 ms [1.721 ms, 1.772 ms]	395.837 µs (29.3%)
code_origins	1.673 ms [1.639 ms, 1.707 ms]	322.293 µs (23.9%)
iast	1.51 ms [1.486 ms, 1.534 ms]	159.397 µs (11.8%)
profiling	1.523 ms [1.499 ms, 1.547 ms]	172.094 µs (12.7%)
tracing	1.49 ms [1.466 ms, 1.514 ms]	139.851 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.332 ms, 1.371 ms]	-
appsec	1.706 ms [1.682 ms, 1.73 ms]	354.436 µs (26.2%)
appsec_no_iast	1.719 ms [1.695 ms, 1.744 ms]	367.97 µs (27.2%)
code_origins	1.686 ms [1.652 ms, 1.72 ms]	334.16 µs (24.7%)
iast	1.509 ms [1.485 ms, 1.533 ms]	157.759 µs (11.7%)
profiling	1.561 ms [1.536 ms, 1.586 ms]	209.486 µs (15.5%)
tracing	1.486 ms [1.461 ms, 1.511 ms]	134.337 µs (9.9%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section baseline
no_agent (384.715 µs) : 365, 405
. : milestone, 385,
iast (510.574 µs) : 489, 533
. : milestone, 511,
iast_FULL (727.157 µs) : 705, 749
. : milestone, 727,
iast_GLOBAL (552.337 µs) : 531, 574
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (511.027 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (465.953 µs) : 444, 488
. : milestone, 466,
iast_TELEMETRY_OFF (495.364 µs) : 473, 518
. : milestone, 495,
tracing (457.849 µs) : 437, 479
. : milestone, 458,
section candidate
no_agent (380.748 µs) : 360, 402
. : milestone, 381,
iast (510.4 µs) : 489, 532
. : milestone, 510,
iast_FULL (730.03 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (555.788 µs) : 534, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (515.166 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (460.673 µs) : 439, 482
. : milestone, 461,
iast_TELEMETRY_OFF (499.722 µs) : 477, 522
. : milestone, 500,
tracing (455.667 µs) : 435, 477
. : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	384.715 µs [364.695 µs, 404.735 µs]	-
iast	510.574 µs [488.619 µs, 532.53 µs]	125.859 µs (32.7%)
iast_FULL	727.157 µs [705.056 µs, 749.259 µs]	342.443 µs (89.0%)
iast_GLOBAL	552.337 µs [530.73 µs, 573.944 µs]	167.622 µs (43.6%)
iast_HARDCODED_SECRET_DISABLED	511.027 µs [489.446 µs, 532.607 µs]	126.312 µs (32.8%)
iast_INACTIVE	465.953 µs [444.179 µs, 487.726 µs]	81.238 µs (21.1%)
iast_TELEMETRY_OFF	495.364 µs [473.12 µs, 517.607 µs]	110.649 µs (28.8%)
tracing	457.849 µs [436.54 µs, 479.159 µs]	73.134 µs (19.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.748 µs [359.963 µs, 401.532 µs]	-
iast	510.4 µs [488.545 µs, 532.255 µs]	129.652 µs (34.1%)
iast_FULL	730.03 µs [708.171 µs, 751.888 µs]	349.282 µs (91.7%)
iast_GLOBAL	555.788 µs [533.867 µs, 577.71 µs]	175.04 µs (46.0%)
iast_HARDCODED_SECRET_DISABLED	515.166 µs [493.138 µs, 537.195 µs]	134.419 µs (35.3%)
iast_INACTIVE	460.673 µs [438.962 µs, 482.384 µs]	79.925 µs (21.0%)
iast_TELEMETRY_OFF	499.722 µs [477.124 µs, 522.32 µs]	118.974 µs (31.2%)
tracing	455.667 µs [434.645 µs, 476.689 µs]	74.919 µs (19.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/use-context-in-kotlin-coroutines
git_commit_date	1741423605	1741473423
git_commit_sha	`04b1afd`	f3c421a0fe
release_version	1.48.0-SNAPSHOT~04b1afde28	1.48.0-SNAPSHOT~f3c421a0fe

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1741475381	1741475381
ci_job_id	839247963	839247963
ci_pipeline_id	58202233	58202233
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-2wkmbgws-project-304-concurrent-4-c3gnvbjk 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-2wkmbgws-project-304-concurrent-4-c3gnvbjk 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.327 ms) : 2284, 2370
. : milestone, 2327,
iast (2.101 ms) : 2047, 2156
. : milestone, 2101,
iast_GLOBAL (2.154 ms) : 2099, 2209
. : milestone, 2154,
profiling (1.965 ms) : 1922, 2008
. : milestone, 1965,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.322 ms) : 2279, 2365
. : milestone, 2322,
iast (2.109 ms) : 2054, 2164
. : milestone, 2109,
iast_GLOBAL (2.149 ms) : 2094, 2204
. : milestone, 2149,
profiling (1.96 ms) : 1917, 2003
. : milestone, 1960,
tracing (1.945 ms) : 1903, 1987
. : milestone, 1945,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.327 ms [2.284 ms, 2.37 ms]	856.76 µs (58.3%)
iast	2.101 ms [2.047 ms, 2.156 ms]	630.976 µs (42.9%)
iast_GLOBAL	2.154 ms [2.099 ms, 2.209 ms]	683.178 µs (46.5%)
profiling	1.965 ms [1.922 ms, 2.008 ms]	494.678 µs (33.6%)
tracing	1.949 ms [1.907 ms, 1.991 ms]	478.254 µs (32.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.322 ms [2.279 ms, 2.365 ms]	850.821 µs (57.8%)
iast	2.109 ms [2.054 ms, 2.164 ms]	637.811 µs (43.4%)
iast_GLOBAL	2.149 ms [2.094 ms, 2.204 ms]	677.727 µs (46.1%)
profiling	1.96 ms [1.917 ms, 2.003 ms]	488.891 µs (33.2%)
tracing	1.945 ms [1.903 ms, 1.987 ms]	474.273 µs (32.2%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~f3c421a0fe, baseline=1.48.0-SNAPSHOT~04b1afde28
dateFormat X
axisFormat %s
section baseline
no_agent (15.448 s) : 15448000, 15448000
. : milestone, 15448000,
appsec (14.727 s) : 14727000, 14727000
. : milestone, 14727000,
iast (18.361 s) : 18361000, 18361000
. : milestone, 18361000,
iast_GLOBAL (17.933 s) : 17933000, 17933000
. : milestone, 17933000,
profiling (15.117 s) : 15117000, 15117000
. : milestone, 15117000,
tracing (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
section candidate
no_agent (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
appsec (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
iast (18.386 s) : 18386000, 18386000
. : milestone, 18386000,
iast_GLOBAL (17.721 s) : 17721000, 17721000
. : milestone, 17721000,
profiling (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
tracing (14.757 s) : 14757000, 14757000
. : milestone, 14757000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.448 s [15.448 s, 15.448 s]	-
appsec	14.727 s [14.727 s, 14.727 s]	-721.0 ms (-4.7%)
iast	18.361 s [18.361 s, 18.361 s]	2.913 s (18.9%)
iast_GLOBAL	17.933 s [17.933 s, 17.933 s]	2.485 s (16.1%)
profiling	15.117 s [15.117 s, 15.117 s]	-331.0 ms (-2.1%)
tracing	14.83 s [14.83 s, 14.83 s]	-618.0 ms (-4.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.746 s [14.746 s, 14.746 s]	-
appsec	15.217 s [15.217 s, 15.217 s]	471.0 ms (3.2%)
iast	18.386 s [18.386 s, 18.386 s]	3.64 s (24.7%)
iast_GLOBAL	17.721 s [17.721 s, 17.721 s]	2.975 s (20.2%)
profiling	14.967 s [14.967 s, 14.967 s]	221.0 ms (1.5%)
tracing	14.757 s [14.757 s, 14.757 s]	11.0 ms (0.1%)

PerfectSlayer

A bit hard to review the change without running them but it looks good to be merged into project branch! 👍
New Context API seems to simplify things a bit. Glad to see things starting to take shape.

mcculls added tag: no release notes Changes to exclude from release notes type: refactoring inst: kotlin Kotlin instrumentation labels Mar 8, 2025

mcculls requested a review from PerfectSlayer March 9, 2025 22:25

PerfectSlayer approved these changes Mar 10, 2025
View reviewed changes

Base automatically changed from mcculls/use-context-in-zio-fibers to project/contextMarch 10, 2025 13:03

Migrate kotlin coroutines instrumentation to new Context API
8861c68

mcculls force-pushed the mcculls/use-context-in-kotlin-coroutines branch from f3c421a to 8861c68Compare March 10, 2025 13:03

mcculls marked this pull request as ready for review March 10, 2025 13:04

mcculls requested a review from a team as a code owner March 10, 2025 13:04

mcculls merged commit d64fddc into project/contextMar 10, 2025

mcculls deleted the mcculls/use-context-in-kotlin-coroutines branch March 10, 2025 13:05

mcculls added a commit that referenced this pull request Mar 26, 2025
Migrate kotlin coroutines instrumentation to new Context API (#8528)
81ece91

Navigation Menu

Uh oh!

Migrate kotlin coroutines instrumentation to new Context API - #8528

Migrate kotlin coroutines instrumentation to new Context API#8528
mcculls merged 1 commit into
project/contextfrom
mcculls/use-context-in-kotlin-coroutines

mcculls commented Mar 8, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Mar 8, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mcculls commented Mar 8, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Mar 8, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcculls commented Mar 8, 2025•
edited by atlassian Bot
Loading