Uh oh!
There was an error while loading. Please reload this page.
Migrate OtelContext wrapper to new Context API - #8530
Merged
Conversation
BenchmarksStartupLoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~8305d628cb, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.378 ms) : 1358, 1398
. : milestone, 1378,
appsec (1.733 ms) : 1709, 1757
. : milestone, 1733,
appsec_no_iast (1.769 ms) : 1745, 1793
. : milestone, 1769,
code_origins (1.687 ms) : 1654, 1720
. : milestone, 1687,
iast (1.52 ms) : 1495, 1544
. : milestone, 1520,
profiling (1.533 ms) : 1510, 1556
. : milestone, 1533,
tracing (1.486 ms) : 1460, 1512
. : milestone, 1486,
section candidate
no_agent (1.368 ms) : 1348, 1388
. : milestone, 1368,
appsec (1.738 ms) : 1713, 1762
. : milestone, 1738,
appsec_no_iast (1.753 ms) : 1729, 1777
. : milestone, 1753,
code_origins (1.688 ms) : 1656, 1721
. : milestone, 1688,
iast (1.518 ms) : 1493, 1542
. : milestone, 1518,
profiling (1.563 ms) : 1538, 1588
. : milestone, 1563,
tracing (1.502 ms) : 1477, 1526
. : milestone, 1502,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~8305d628cb, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (386.367 µs) : 367, 406
. : milestone, 386,
iast (519.741 µs) : 498, 541
. : milestone, 520,
iast_FULL (738.583 µs) : 717, 761
. : milestone, 739,
iast_GLOBAL (567.537 µs) : 545, 590
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (520.411 µs) : 499, 542
. : milestone, 520,
iast_INACTIVE (471.656 µs) : 450, 493
. : milestone, 472,
iast_TELEMETRY_OFF (512.497 µs) : 490, 535
. : milestone, 512,
tracing (467.317 µs) : 446, 489
. : milestone, 467,
section candidate
no_agent (387.373 µs) : 367, 407
. : milestone, 387,
iast (522.817 µs) : 500, 546
. : milestone, 523,
iast_FULL (735.848 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (565.841 µs) : 543, 588
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (518.734 µs) : 497, 540
. : milestone, 519,
iast_INACTIVE (469.796 µs) : 449, 491
. : milestone, 470,
iast_TELEMETRY_OFF (501.849 µs) : 480, 523
. : milestone, 502,
tracing (471.13 µs) : 450, 492
. : milestone, 471,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~8305d628cb, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
appsec (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
iast (18.98 s) : 18980000, 18980000
. : milestone, 18980000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
. : milestone, 17936000,
profiling (15.665 s) : 15665000, 15665000
. : milestone, 15665000,
tracing (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
section candidate
no_agent (15.364 s) : 15364000, 15364000
. : milestone, 15364000,
appsec (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
iast (18.355 s) : 18355000, 18355000
. : milestone, 18355000,
iast_GLOBAL (17.805 s) : 17805000, 17805000
. : milestone, 17805000,
profiling (15.66 s) : 15660000, 15660000
. : milestone, 15660000,
tracing (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~8305d628cb, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.325 ms) : 2281, 2369
. : milestone, 2325,
iast (2.113 ms) : 2057, 2169
. : milestone, 2113,
iast_GLOBAL (2.159 ms) : 2103, 2215
. : milestone, 2159,
profiling (1.964 ms) : 1920, 2008
. : milestone, 1964,
tracing (1.953 ms) : 1910, 1996
. : milestone, 1953,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.328 ms) : 2285, 2372
. : milestone, 2328,
iast (2.105 ms) : 2050, 2159
. : milestone, 2105,
iast_GLOBAL (2.154 ms) : 2099, 2210
. : milestone, 2154,
profiling (1.96 ms) : 1917, 2003
. : milestone, 1960,
tracing (1.949 ms) : 1907, 1992
. : milestone, 1949,
|
PerfectSlayer
left a comment
Collaborator
There was a problem hiding this comment.
I left few minor comments.
About the test changes, are they put in place because context tracking is missing and resources are leaking as the tests can run to the end? Because the cleanup seem to be already part of the test steps.
If so, should we really merge them as it will get confusing once the tests are working again properly?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mccullsforce-pushed
the
mcculls/remove-scopestateaware-api
branch
from
March 10, 2025 13:05
5e870d7 to
7724a95Compare
Base automatically changed from
mcculls/remove-scopestateaware-api to
project/contextMarch 10, 2025 13:06
mccullsforce-pushed
the
mcculls/use-context-for-otel-shim
branch
from
March 10, 2025 13:06
5c793f8 to
591efc8CompareContributorAuthor
So the test changes here are adding missing cleanup of scopes/spans that's done for other tests in the class but was missed here. These tests will fail at the moment because we haven't finished the span <-> context coupling, so while However there's a difference between a test failing (which helps us focus on what remains to be fixed) and it causing unrelated failures in other tests (which would pass without the bad scope state leaking from the failing tests.) So these are really test fixes, to ensure failing tests don't cause unrelated tests to fail. ( in other words, we'd still want to keep them because they make sure test failures don't leak to the other tests ) |
mcculls
marked this pull request as ready for review
March 10, 2025 15:20
mcculls added a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Notes
Tests are expected to fail while the scope manager has not yet been replaced.
That's why the final target of this stacked PR is the
project/contextfeature branch.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-855