Skip to content

Upgrade libddwaf java to 14.0.0 - #8654

Merged
sezen-datadog merged 1 commit into
masterfrom
sezen.leblay/upgrade-libddwaf-java-1.23
Jun 24, 2025
Merged

Upgrade libddwaf java to 14.0.0#8654
sezen-datadog merged 1 commit into
masterfrom
sezen.leblay/upgrade-libddwaf-java-1.23

Conversation

@sezen-datadog

@sezen-datadogsezen-datadog commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

Integrates upgrade of libddwaf java to version 14.0.0 (major upgrade because of libddwaf upgrade to version 1.24.1 in DataDog/libddwaf-java#159) The most important changes include upgrading the libsqreen dependency, replacing the AppSecConfig and AppSecConfigDeserializer classes with a new WAF configuration approach (use of raw configurations in map formats), and refactoring the AppSecSystem and WafBenchmark classes to integrate with the updated WAF system.

Motivation

Remote config errors are now reported per each remote config file independently.

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55502

@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch 6 times, most recently from 54f9c5d to 71046f9CompareApril 10, 2025 09:11
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch 5 times, most recently from a5ff9ce to 88e240eCompareApril 23, 2025 12:28
@sezen-datadog
sezen-datadog marked this pull request as ready for review April 23, 2025 12:32
@sezen-datadog
sezen-datadog requested a review from a team as a code ownerApril 23, 2025 12:32
@github-actions

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@sezen-datadogsezen-datadog added comp: asm iast Application Security Management (IAST) comp: asm waf Application Security Management (WAF) type: feature Enhancements and improvements and removed comp: asm iast Application Security Management (IAST) labels Apr 23, 2025
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch from e706341 to 8a9e7c1CompareApril 25, 2025 08:04
@sezen-datadog
sezen-datadog requested review from a team as code ownersApril 25, 2025 08:10
@sezen-datadog
sezen-datadog requested review from evanchooly and removed request for a teamApril 25, 2025 08:10
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch 2 times, most recently from af04cd6 to ec2a6fbCompareApril 25, 2025 08:13
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch 5 times, most recently from 2edb032 to 90b6580CompareMay 23, 2025 11:42

@smolasmola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks suggest we're still initializing the WAF too early (eager on AppSec start, rather than lazily later).

Comment threaddd-java-agent/appsec/build.gradle Outdated
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch 5 times, most recently from 335eff4 to f1ebe51CompareMay 27, 2025 13:27
Comment threaddd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java Outdated
Comment threaddd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java Outdated
Comment threaddd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java Outdated
Comment threaddd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java Outdated
Comment threaddd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java Outdated
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch 6 times, most recently from 2ff3f40 to e6fe1bdCompareMay 30, 2025 13:45
@sezen-datadog
sezen-datadogforce-pushed the sezen.leblay/upgrade-libddwaf-java-1.23 branch from 6614e65 to 63c8a1eCompareJune 2, 2025 08:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm wafApplication Security Management (WAF)type: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sezen-datadog@smola@PerfectSlayer@jandro996