Skip to content

Baggage E2E "failing" - #8700

Closed
mhlidd wants to merge 5 commits into
masterfrom
mhlidd/visibility_baggage_e2e_failing
Closed

Baggage E2E "failing"#8700
mhlidd wants to merge 5 commits into
masterfrom
mhlidd/visibility_baggage_e2e_failing

Conversation

@mhlidd

Copy link
Copy Markdown
Contributor

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhliddmhlidd added the tag: do not merge Do not merge changes label Apr 15, 2025
@mhlidd

mhlidd commented Apr 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@PerfectSlayer The issue seems to be that there are multiple sets of headers that are being extracted in consecutive calls. Whenever there is a set of headers that come in without any information we can extract (i.e. trace headers, baggage headers, etc) we extract an empty context and attach that to the context scope. That seems to be causing a NPE in the Tomcat instrumentation logging, but I'm not sure where that is happening. I will DM you some logs regarding this.

Seems like I had a small error in setting the context 🤦

@pr-commenter

pr-commenterBot commented Apr 15, 2025

Copy link
Copy Markdown

Benchmarks

Startup

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
end_time2025-05-14T19:39:122025-05-14T19:46:56
git_branchmastermhlidd/visibility_baggage_e2e_failing
git_commit_date17472292431747250502
git_commit_sha7c80dbeaceb45d
release_version1.50.0-SNAPSHOT~7c80dbede31.48.0-SNAPSHOT~aceb45d0c6
start_time2025-05-14T19:39:012025-05-14T19:46:45
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17472522881747252288
ci_job_id938807194938807194
ci_pipeline_id6512607465126074
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-xnwlpqwj-project-304-concurrent-0-76sl1e94 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-xnwlpqwj-project-304-concurrent-0-76sl1e94 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variantno_agentno_agent

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 2 unstable metrics.

Dacapo

@mhliddmhlidd closed this Apr 22, 2025
@mhliddmhlidd reopened this May 14, 2025
@mhliddmhlidd closed this May 20, 2025
@mhlidd
mhlidd deleted the mhlidd/visibility_baggage_e2e_failing branch August 14, 2025 17:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: do not mergeDo not merge changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mhlidd