Added graphql span events for errors by nayeem-kamal · Pull Request #8721 · DataDog/dd-trace-java

nayeem-kamal · 2025-04-22T18:52:29Z

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>

pr-commenter · 2025-04-22T19:40:46Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nayeem-kamal/graphql-errors-2
git_commit_date	1745847396	1745867443
git_commit_sha	`bd7a9c8`	`175e6e4`
release_version	1.49.0-SNAPSHOT~bd7a9c8502	1.48.0-SNAPSHOT~175e6e4b57

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745870734	1745870734
ci_job_id	915843245	915843245
ci_pipeline_id	63549073	63549073
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-syfpehly-project-304-concurrent-0-ti7rqqpq 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-syfpehly-project-304-concurrent-0-ti7rqqpq 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 8 performance improvements and 22 performance regressions! Performance is the same for 37 metrics, 4 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast:Agent.start	worse [+38.567ms; +44.392ms] or [+3.392%; +3.904%]	1.178s	1.137s
scenario:startup:insecure-bank:iast:BytebuddyAgent	worse [+47.087ms; +51.442ms] or [+5.957%; +6.508%]	839.658ms	790.394ms
scenario:startup:insecure-bank:iast:Debugger	better [-1.817ms; -1.612ms] or [-30.964%; -27.469%]	4.154ms	5.868ms
scenario:startup:insecure-bank:iast:Telemetry	worse [+684.870µs; +933.031µs] or [+8.614%; +11.736%]	8.759ms	7.950ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Agent.start	worse [+33.632ms; +65.617ms] or [+2.965%; +5.785%]	1.184s	1.134s
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:BytebuddyAgent	worse [+43.108ms; +68.151ms] or [+5.470%; +8.647%]	843.773ms	788.144ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Debugger	better [-1.779ms; -1.579ms] or [-30.407%; -26.990%]	4.171ms	5.850ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry	worse [+0.822ms; +1.186ms] or [+10.416%; +15.035%]	8.894ms	7.890ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Agent.start	worse [+36.507ms; +65.410ms] or [+3.227%; +5.783%]	1.182s	1.131s
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:BytebuddyAgent	worse [+44.987ms; +67.710ms] or [+5.726%; +8.618%]	842.012ms	785.664ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Debugger	better [-1.848ms; -1.711ms] or [-31.307%; -28.985%]	4.123ms	5.902ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry	worse [+698.023µs; +971.933µs] or [+8.948%; +12.460%]	8.636ms	7.801ms
scenario:startup:insecure-bank:tracing:BytebuddyAgent	worse [+23.906ms; +48.645ms] or [+3.510%; +7.143%]	717.287ms	681.011ms
scenario:startup:petclinic:appsec:Agent.start	worse [+34.888ms; +59.819ms] or [+3.039%; +5.210%]	1.195s	1.148s
scenario:startup:petclinic:appsec:BytebuddyAgent	worse [+44.873ms; +61.601ms] or [+6.526%; +8.959%]	740.823ms	687.586ms
scenario:startup:petclinic:appsec:Debugger	better [-1.616ms; -1.490ms] or [-27.510%; -25.369%]	4.320ms	5.873ms
scenario:startup:petclinic:iast:Agent.start	worse [+36.077ms; +45.168ms] or [+3.180%; +3.981%]	1.175s	1.135s
scenario:startup:petclinic:iast:BytebuddyAgent	worse [+46.597ms; +52.485ms] or [+5.914%; +6.662%]	837.418ms	787.877ms
scenario:startup:petclinic:iast:Debugger	better [-1.736ms; -1.593ms] or [-29.860%; -27.389%]	4.150ms	5.815ms
scenario:startup:petclinic:iast:Telemetry	worse [+750.255µs; +1041.807µs] or [+9.599%; +13.329%]	8.712ms	7.816ms
scenario:startup:petclinic:profiling:ProfilingAgent	worse [+4.565ms; +6.288ms] or [+4.739%; +6.528%]	101.739ms	96.313ms
scenario:startup:petclinic:profiling:BytebuddyAgent	worse [+45.243ms; +50.439ms] or [+6.840%; +7.626%]	709.288ms	661.447ms
scenario:startup:petclinic:profiling:GlobalTracer	better [-24.449ms; -21.511ms] or [-6.543%; -5.757%]	350.690ms	373.671ms
scenario:startup:petclinic:profiling:Debugger	better [-1.952ms; -1.821ms] or [-31.832%; -29.698%]	4.245ms	6.131ms
scenario:startup:petclinic:profiling:Remote Config	worse [+36.440µs; +73.448µs] or [+5.647%; +11.381%]	700.278µs	645.335µs
scenario:startup:petclinic:profiling:Telemetry	worse [+577.956µs; +904.322µs] or [+7.105%; +11.118%]	8.875ms	8.134ms
scenario:startup:petclinic:profiling:Profiling	worse [+4.569ms; +6.291ms] or [+4.743%; +6.531%]	101.768ms	96.337ms
scenario:startup:petclinic:tracing:Agent.start	worse [+36.949ms; +62.624ms] or [+3.682%; +6.240%]	1.053s	1.004s
scenario:startup:petclinic:tracing:BytebuddyAgent	worse [+46.101ms; +68.619ms] or [+6.893%; +10.261%]	726.124ms	668.764ms
scenario:startup:petclinic:tracing:Debugger	better [-1.873ms; -1.696ms] or [-30.489%; -27.607%]	4.359ms	6.144ms

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020760
Total [baseline] (8.655 s) : 0, 8654581
Agent [candidate] (1.049 s) : 0, 1048551
Total [candidate] (8.648 s) : 0, 8648230
section iast
Agent [baseline] (1.137 s) : 0, 1136981
Total [baseline] (9.174 s) : 0, 9173922
Agent [candidate] (1.178 s) : 0, 1178461
Total [candidate] (9.281 s) : 0, 9281224
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.134 s) : 0, 1134341
Total [baseline] (9.179 s) : 0, 9179062
Agent [candidate] (1.184 s) : 0, 1183965
Total [candidate] (9.193 s) : 0, 9192873
section iast_TELEMETRY_OFF
Agent [baseline] (1.131 s) : 0, 1131162
Total [baseline] (9.19 s) : 0, 9190353
Agent [candidate] (1.182 s) : 0, 1182121
Total [candidate] (9.225 s) : 0, 9224747

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	iast	1.137 s	116.221 ms (11.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.134 s	113.58 ms (11.1%)
Agent	iast_TELEMETRY_OFF	1.131 s	110.402 ms (10.8%)
Total	tracing	8.655 s	-
Total	iast	9.174 s	519.342 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.179 s	524.481 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.19 s	535.773 ms (6.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	iast	1.178 s	129.91 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.184 s	135.414 ms (12.9%)
Agent	iast_TELEMETRY_OFF	1.182 s	133.57 ms (12.7%)
Total	tracing	8.648 s	-
Total	iast	9.281 s	632.995 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.193 s	544.643 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.225 s	576.517 ms (6.7%)

gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.011 ms) : 0, 681011
BytebuddyAgent [candidate] (717.287 ms) : 0, 717287
GlobalTracer [baseline] (243.525 ms) : 0, 243525
GlobalTracer [candidate] (239.745 ms) : 0, 239745
AppSec [baseline] (55.648 ms) : 0, 55648
AppSec [candidate] (54.675 ms) : 0, 54675
Debugger [baseline] (6.917 ms) : 0, 6917
Debugger [candidate] (4.364 ms) : 0, 4364
Remote Config [baseline] (713.59 µs) : 0, 714
Remote Config [candidate] (704.628 µs) : 0, 705
Telemetry [baseline] (9.357 ms) : 0, 9357
Telemetry [candidate] (15.761 ms) : 0, 15761
section iast
BytebuddyAgent [baseline] (790.394 ms) : 0, 790394
BytebuddyAgent [candidate] (839.658 ms) : 0, 839658
GlobalTracer [baseline] (230.055 ms) : 0, 230055
GlobalTracer [candidate] (230.687 ms) : 0, 230687
IAST [baseline] (22.633 ms) : 0, 22633
IAST [candidate] (22.832 ms) : 0, 22832
AppSec [baseline] (56.092 ms) : 0, 56092
AppSec [candidate] (55.835 ms) : 0, 55835
Debugger [baseline] (5.868 ms) : 0, 5868
Debugger [candidate] (4.154 ms) : 0, 4154
Remote Config [baseline] (576.855 µs) : 0, 577
Remote Config [candidate] (605.181 µs) : 0, 605
Telemetry [baseline] (7.95 ms) : 0, 7950
Telemetry [candidate] (8.759 ms) : 0, 8759
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.144 ms) : 0, 788144
BytebuddyAgent [candidate] (843.773 ms) : 0, 843773
GlobalTracer [baseline] (229.418 ms) : 0, 229418
GlobalTracer [candidate] (231.279 ms) : 0, 231279
IAST [baseline] (22.811 ms) : 0, 22811
IAST [candidate] (22.914 ms) : 0, 22914
AppSec [baseline] (56.324 ms) : 0, 56324
AppSec [candidate] (56.264 ms) : 0, 56264
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (4.171 ms) : 0, 4171
Remote Config [baseline] (592.781 µs) : 0, 593
Remote Config [candidate] (604.751 µs) : 0, 605
Telemetry [baseline] (7.89 ms) : 0, 7890
Telemetry [candidate] (8.894 ms) : 0, 8894
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (785.664 ms) : 0, 785664
BytebuddyAgent [candidate] (842.012 ms) : 0, 842012
GlobalTracer [baseline] (229.598 ms) : 0, 229598
GlobalTracer [candidate] (231.861 ms) : 0, 231861
IAST [baseline] (22.233 ms) : 0, 22233
IAST [candidate] (22.638 ms) : 0, 22638
AppSec [baseline] (55.978 ms) : 0, 55978
AppSec [candidate] (56.052 ms) : 0, 56052
Debugger [baseline] (5.902 ms) : 0, 5902
Debugger [candidate] (4.123 ms) : 0, 4123
Remote Config [baseline] (602.392 µs) : 0, 602
Remote Config [candidate] (597.947 µs) : 0, 598
Telemetry [baseline] (7.801 ms) : 0, 7801
Telemetry [candidate] (8.636 ms) : 0, 8636

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003565
Total [baseline] (10.419 s) : 0, 10419184
Agent [candidate] (1.053 s) : 0, 1053352
Total [candidate] (10.409 s) : 0, 10408967
section appsec
Agent [baseline] (1.148 s) : 0, 1148131
Total [baseline] (10.65 s) : 0, 10649811
Agent [candidate] (1.195 s) : 0, 1195485
Total [candidate] (10.789 s) : 0, 10789168
section iast
Agent [baseline] (1.135 s) : 0, 1134674
Total [baseline] (10.858 s) : 0, 10857797
Agent [candidate] (1.175 s) : 0, 1175297
Total [candidate] (11.02 s) : 0, 11019688
section profiling
Agent [baseline] (1.25 s) : 0, 1250485
Total [baseline] (10.713 s) : 0, 10713025
Agent [candidate] (1.271 s) : 0, 1270586
Total [candidate] (10.83 s) : 0, 10829988

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	appsec	1.148 s	144.566 ms (14.4%)
Agent	iast	1.135 s	131.109 ms (13.1%)
Agent	profiling	1.25 s	246.92 ms (24.6%)
Total	tracing	10.419 s	-
Total	appsec	10.65 s	230.627 ms (2.2%)
Total	iast	10.858 s	438.612 ms (4.2%)
Total	profiling	10.713 s	293.84 ms (2.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	appsec	1.195 s	142.133 ms (13.5%)
Agent	iast	1.175 s	121.945 ms (11.6%)
Agent	profiling	1.271 s	217.234 ms (20.6%)
Total	tracing	10.409 s	-
Total	appsec	10.789 s	380.201 ms (3.7%)
Total	iast	11.02 s	610.72 ms (5.9%)
Total	profiling	10.83 s	421.021 ms (4.0%)

gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.764 ms) : 0, 668764
BytebuddyAgent [candidate] (726.124 ms) : 0, 726124
GlobalTracer [baseline] (239.445 ms) : 0, 239445
GlobalTracer [candidate] (240.828 ms) : 0, 240828
AppSec [baseline] (54.496 ms) : 0, 54496
AppSec [candidate] (54.569 ms) : 0, 54569
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (4.359 ms) : 0, 4359
Remote Config [baseline] (715.36 µs) : 0, 715
Remote Config [candidate] (713.777 µs) : 0, 714
Telemetry [baseline] (10.598 ms) : 0, 10598
Telemetry [candidate] (10.639 ms) : 0, 10639
section appsec
BytebuddyAgent [baseline] (687.586 ms) : 0, 687586
BytebuddyAgent [candidate] (740.823 ms) : 0, 740823
GlobalTracer [baseline] (236.224 ms) : 0, 236224
GlobalTracer [candidate] (237.48 ms) : 0, 237480
AppSec [baseline] (175.843 ms) : 0, 175843
AppSec [candidate] (176.562 ms) : 0, 176562
Debugger [baseline] (5.873 ms) : 0, 5873
Debugger [candidate] (4.32 ms) : 0, 4320
Remote Config [baseline] (634.801 µs) : 0, 635
Remote Config [candidate] (645.359 µs) : 0, 645
Telemetry [baseline] (7.768 ms) : 0, 7768
Telemetry [candidate] (8.858 ms) : 0, 8858
IAST [baseline] (21.695 ms) : 0, 21695
IAST [candidate] (21.522 ms) : 0, 21522
section iast
BytebuddyAgent [baseline] (787.877 ms) : 0, 787877
BytebuddyAgent [candidate] (837.418 ms) : 0, 837418
GlobalTracer [baseline] (229.761 ms) : 0, 229761
GlobalTracer [candidate] (229.95 ms) : 0, 229950
AppSec [baseline] (56.44 ms) : 0, 56440
AppSec [candidate] (55.723 ms) : 0, 55723
Debugger [baseline] (5.815 ms) : 0, 5815
Debugger [candidate] (4.15 ms) : 0, 4150
Remote Config [baseline] (579.733 µs) : 0, 580
Remote Config [candidate] (587.15 µs) : 0, 587
Telemetry [baseline] (7.816 ms) : 0, 7816
Telemetry [candidate] (8.712 ms) : 0, 8712
IAST [baseline] (22.995 ms) : 0, 22995
IAST [candidate] (22.841 ms) : 0, 22841
section profiling
BytebuddyAgent [baseline] (661.447 ms) : 0, 661447
BytebuddyAgent [candidate] (709.288 ms) : 0, 709288
GlobalTracer [baseline] (373.671 ms) : 0, 373671
GlobalTracer [candidate] (350.69 ms) : 0, 350690
AppSec [baseline] (54.233 ms) : 0, 54233
AppSec [candidate] (53.521 ms) : 0, 53521
Debugger [baseline] (6.131 ms) : 0, 6131
Debugger [candidate] (4.245 ms) : 0, 4245
Remote Config [baseline] (645.335 µs) : 0, 645
Remote Config [candidate] (700.278 µs) : 0, 700
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.875 ms) : 0, 8875
ProfilingAgent [baseline] (96.313 ms) : 0, 96313
ProfilingAgent [candidate] (101.739 ms) : 0, 101739
Profiling [baseline] (96.337 ms) : 0, 96337
Profiling [candidate] (101.768 ms) : 0, 101768

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-04-28T19:36:29	2025-04-28T19:44:12
git_branch	master	nayeem-kamal/graphql-errors-2
git_commit_date	1745847396	1745867443
git_commit_sha	`bd7a9c8`	`175e6e4`
release_version	1.49.0-SNAPSHOT~bd7a9c8502	1.48.0-SNAPSHOT~175e6e4b57
start_time	2025-04-28T19:36:15	2025-04-28T19:43:58

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745869849	1745869849
ci_job_id	915843247	915843247
ci_pipeline_id	63549073	63549073
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-txxhdqe-project-304-concurrent-0-96u8ofm7 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-txxhdqe-project-304-concurrent-0-96u8ofm7 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (382.811 µs) : 362, 403
. : milestone, 383,
iast (528.006 µs) : 505, 551
. : milestone, 528,
iast_FULL (738.988 µs) : 716, 762
. : milestone, 739,
iast_GLOBAL (559.482 µs) : 536, 583
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (525.054 µs) : 502, 548
. : milestone, 525,
iast_INACTIVE (463.472 µs) : 441, 486
. : milestone, 463,
iast_TELEMETRY_OFF (515.834 µs) : 493, 539
. : milestone, 516,
tracing (458.569 µs) : 437, 481
. : milestone, 459,
section candidate
no_agent (382.401 µs) : 361, 404
. : milestone, 382,
iast (509.761 µs) : 488, 532
. : milestone, 510,
iast_FULL (732.539 µs) : 711, 754
. : milestone, 733,
iast_GLOBAL (557.567 µs) : 536, 579
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (511.599 µs) : 490, 533
. : milestone, 512,
iast_INACTIVE (465.044 µs) : 444, 486
. : milestone, 465,
iast_TELEMETRY_OFF (497.253 µs) : 475, 519
. : milestone, 497,
tracing (454.971 µs) : 434, 475
. : milestone, 455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.811 µs [362.224 µs, 403.398 µs]	-
iast	528.006 µs [504.928 µs, 551.084 µs]	145.195 µs (37.9%)
iast_FULL	738.988 µs [715.632 µs, 762.344 µs]	356.177 µs (93.0%)
iast_GLOBAL	559.482 µs [536.37 µs, 582.594 µs]	176.671 µs (46.2%)
iast_HARDCODED_SECRET_DISABLED	525.054 µs [502.432 µs, 547.677 µs]	142.243 µs (37.2%)
iast_INACTIVE	463.472 µs [441.294 µs, 485.649 µs]	80.661 µs (21.1%)
iast_TELEMETRY_OFF	515.834 µs [492.842 µs, 538.825 µs]	133.023 µs (34.7%)
tracing	458.569 µs [436.558 µs, 480.579 µs]	75.758 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.401 µs [360.96 µs, 403.842 µs]	-
iast	509.761 µs [487.963 µs, 531.56 µs]	127.36 µs (33.3%)
iast_FULL	732.539 µs [710.639 µs, 754.439 µs]	350.138 µs (91.6%)
iast_GLOBAL	557.567 µs [535.894 µs, 579.241 µs]	175.167 µs (45.8%)
iast_HARDCODED_SECRET_DISABLED	511.599 µs [489.883 µs, 533.315 µs]	129.198 µs (33.8%)
iast_INACTIVE	465.044 µs [443.782 µs, 486.305 µs]	82.643 µs (21.6%)
iast_TELEMETRY_OFF	497.253 µs [475.318 µs, 519.188 µs]	114.852 µs (30.0%)
tracing	454.971 µs [434.481 µs, 475.461 µs]	72.57 µs (19.0%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.728 ms) : 1704, 1752
. : milestone, 1728,
appsec_no_iast (1.745 ms) : 1722, 1769
. : milestone, 1745,
code_origins (1.683 ms) : 1656, 1709
. : milestone, 1683,
iast (1.514 ms) : 1489, 1539
. : milestone, 1514,
profiling (1.51 ms) : 1487, 1534
. : milestone, 1510,
tracing (1.494 ms) : 1469, 1518
. : milestone, 1494,
section candidate
no_agent (1.354 ms) : 1335, 1374
. : milestone, 1354,
appsec (1.727 ms) : 1704, 1751
. : milestone, 1727,
appsec_no_iast (1.764 ms) : 1741, 1787
. : milestone, 1764,
code_origins (1.665 ms) : 1638, 1692
. : milestone, 1665,
iast (1.519 ms) : 1495, 1543
. : milestone, 1519,
profiling (1.493 ms) : 1469, 1517
. : milestone, 1493,
tracing (1.519 ms) : 1494, 1544
. : milestone, 1519,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.336 ms, 1.375 ms]	-
appsec	1.728 ms [1.704 ms, 1.752 ms]	372.444 µs (27.5%)
appsec_no_iast	1.745 ms [1.722 ms, 1.769 ms]	389.92 µs (28.8%)
code_origins	1.683 ms [1.656 ms, 1.709 ms]	327.234 µs (24.1%)
iast	1.514 ms [1.489 ms, 1.539 ms]	158.39 µs (11.7%)
profiling	1.51 ms [1.487 ms, 1.534 ms]	155.029 µs (11.4%)
tracing	1.494 ms [1.469 ms, 1.518 ms]	138.141 µs (10.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.335 ms, 1.374 ms]	-
appsec	1.727 ms [1.704 ms, 1.751 ms]	372.921 µs (27.5%)
appsec_no_iast	1.764 ms [1.741 ms, 1.787 ms]	409.326 µs (30.2%)
code_origins	1.665 ms [1.638 ms, 1.692 ms]	310.7 µs (22.9%)
iast	1.519 ms [1.495 ms, 1.543 ms]	164.996 µs (12.2%)
profiling	1.493 ms [1.469 ms, 1.517 ms]	138.543 µs (10.2%)
tracing	1.519 ms [1.494 ms, 1.544 ms]	164.314 µs (12.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nayeem-kamal/graphql-errors-2
git_commit_date	1745847396	1745867443
git_commit_sha	`bd7a9c8`	`175e6e4`
release_version	1.49.0-SNAPSHOT~bd7a9c8502	1.48.0-SNAPSHOT~175e6e4b57

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1745870311	1745870311
ci_job_id	915843249	915843249
ci_pipeline_id	63549073	63549073
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-syfpehly-project-304-concurrent-1-k5rugwf3 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-syfpehly-project-304-concurrent-1-k5rugwf3 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
appsec (15.252 s) : 15252000, 15252000
. : milestone, 15252000,
iast (18.955 s) : 18955000, 18955000
. : milestone, 18955000,
iast_GLOBAL (18.056 s) : 18056000, 18056000
. : milestone, 18056000,
profiling (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
section candidate
no_agent (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
appsec (14.693 s) : 14693000, 14693000
. : milestone, 14693000,
iast (19.094 s) : 19094000, 19094000
. : milestone, 19094000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (14.849 s) : 14849000, 14849000
. : milestone, 14849000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.942 s [14.942 s, 14.942 s]	-
appsec	15.252 s [15.252 s, 15.252 s]	310.0 ms (2.1%)
iast	18.955 s [18.955 s, 18.955 s]	4.013 s (26.9%)
iast_GLOBAL	18.056 s [18.056 s, 18.056 s]	3.114 s (20.8%)
profiling	15.105 s [15.105 s, 15.105 s]	163.0 ms (1.1%)
tracing	14.948 s [14.948 s, 14.948 s]	6.0 ms (0.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.963 s [14.963 s, 14.963 s]	-
appsec	14.693 s [14.693 s, 14.693 s]	-270.0 ms (-1.8%)
iast	19.094 s [19.094 s, 19.094 s]	4.131 s (27.6%)
iast_GLOBAL	18.118 s [18.118 s, 18.118 s]	3.155 s (21.1%)
profiling	15.584 s [15.584 s, 15.584 s]	621.0 ms (4.2%)
tracing	14.849 s [14.849 s, 14.849 s]	-114.0 ms (-0.8%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.378 ms) : 2331, 2424
. : milestone, 2378,
iast (2.156 ms) : 2097, 2214
. : milestone, 2156,
iast_GLOBAL (2.204 ms) : 2144, 2263
. : milestone, 2204,
profiling (2.003 ms) : 1957, 2050
. : milestone, 2003,
tracing (1.988 ms) : 1943, 2033
. : milestone, 1988,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.385 ms) : 2339, 2431
. : milestone, 2385,
iast (2.156 ms) : 2098, 2215
. : milestone, 2156,
iast_GLOBAL (2.199 ms) : 2140, 2258
. : milestone, 2199,
profiling (2.012 ms) : 1966, 2059
. : milestone, 2012,
tracing (1.98 ms) : 1935, 2025
. : milestone, 1980,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.489 ms]	-
appsec	2.378 ms [2.331 ms, 2.424 ms]	899.882 µs (60.9%)
iast	2.156 ms [2.097 ms, 2.214 ms]	677.991 µs (45.9%)
iast_GLOBAL	2.204 ms [2.144 ms, 2.263 ms]	725.732 µs (49.1%)
profiling	2.003 ms [1.957 ms, 2.05 ms]	525.274 µs (35.5%)
tracing	1.988 ms [1.943 ms, 2.033 ms]	510.065 µs (34.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	2.385 ms [2.339 ms, 2.431 ms]	910.059 µs (61.7%)
iast	2.156 ms [2.098 ms, 2.215 ms]	681.468 µs (46.2%)
iast_GLOBAL	2.199 ms [2.14 ms, 2.258 ms]	724.045 µs (49.1%)
profiling	2.012 ms [1.966 ms, 2.059 ms]	537.552 µs (36.4%)
tracing	1.98 ms [1.935 ms, 2.025 ms]	504.837 µs (34.2%)

github-actions · 2025-08-01T03:35:24Z

This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it.

github-actions · 2025-09-01T03:25:49Z

This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it.

nayeem-kamaland others added 15 commits March 18, 2025 16:52

added span events functionality and tests
c6d2de6

added additional testing for span events
0bf493c

Apply suggestions from code review
d896cbb
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>

Add SpanNativeAttributes
1053c56

Merge branch 'master' into nayeem-kamal/graphql-errors
918a4b1

Remove unused methods
6a2ff8d

Fix some tests
fd61266

Improve testing
f68d11a

Lint
d99b87c

More tests
a10ae0e

Merge branch 'master' into nayeem-kamal/graphql-errors
930e07a

removed unused imports
572facc

Revert this local hack
4a2d5c5

added span events for graphql
351dc1f

added tests
52100f7

fixed tests
175e6e4

github-actionsBot added the tag: stale Stale pull requests label Aug 1, 2025

github-actionsBot closed this Sep 1, 2025

Navigation Menu

Uh oh!

Added graphql span events for errors - #8721

Added graphql span events for errors#8721
nayeem-kamal wants to merge 16 commits into
masterfrom
nayeem-kamal/graphql-errors-2

nayeem-kamal commented Apr 22, 2025

Uh oh!

pr-commenterBot commented Apr 22, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Aug 1, 2025

Uh oh!

github-actionsBot commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nayeem-kamal commented Apr 22, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Apr 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actionsBot commented Aug 1, 2025

Uh oh!

github-actionsBot commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pr-commenterBot commented Apr 22, 2025•
edited
Loading