Update trace sampling formula by genesor · Pull Request #8734 · DataDog/dd-trace-java

genesor · 2025-04-25T09:11:33Z

What Does This Do

The sampling formula has changed a bit to have an consistent one across all tracers. The change is relatively small in Java as it only require a change from < to <=

Motivation

We are aiming to have consistent sampling over all tracers.

Additional Notes

I added a new TraceID to the unit test that lands exactly on 0.5 * (2^64 -1) when multiplicated by the knuth

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-1262

pr-commenter · 2025-04-25T09:51:50Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ben.db/APMAPI-1262-adjust-sampling-formula
git_commit_date	1745533252	1745571566
git_commit_sha	`de593cc`	`fa8ffa9`
release_version	1.49.0-SNAPSHOT~de593cc116	1.49.0-SNAPSHOT~fa8ffa9139

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745574535	1745574535
ci_job_id	912336637	912336637
ci_pipeline_id	63310743	63310743
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-yxg9ttu8-project-304-concurrent-0-7wo1ymz4 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-yxg9ttu8-project-304-concurrent-0-7wo1ymz4 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069463
Total [baseline] (8.716 s) : 0, 8716150
Agent [candidate] (1.06 s) : 0, 1060095
Total [candidate] (8.691 s) : 0, 8691024
section iast
Agent [baseline] (1.195 s) : 0, 1194774
Total [baseline] (9.255 s) : 0, 9254948
Agent [candidate] (1.188 s) : 0, 1187906
Total [candidate] (9.233 s) : 0, 9233146
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.187 s) : 0, 1187249
Total [baseline] (9.228 s) : 0, 9228369
Agent [candidate] (1.188 s) : 0, 1188284
Total [candidate] (9.197 s) : 0, 9196879
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1193143
Total [baseline] (9.244 s) : 0, 9243727
Agent [candidate] (1.189 s) : 0, 1189424
Total [candidate] (9.323 s) : 0, 9323138

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	iast	1.195 s	125.311 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.187 s	117.786 ms (11.0%)
Agent	iast_TELEMETRY_OFF	1.193 s	123.68 ms (11.6%)
Total	tracing	8.716 s	-
Total	iast	9.255 s	538.798 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.228 s	512.219 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.244 s	527.577 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.188 s	127.811 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.188 s	128.189 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.189 s	129.328 ms (12.2%)
Total	tracing	8.691 s	-
Total	iast	9.233 s	542.122 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.197 s	505.855 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.323 s	632.114 ms (7.3%)

gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (730.028 ms) : 0, 730028
BytebuddyAgent [candidate] (723.179 ms) : 0, 723179
GlobalTracer [baseline] (241.957 ms) : 0, 241957
GlobalTracer [candidate] (239.803 ms) : 0, 239803
AppSec [baseline] (55.388 ms) : 0, 55388
AppSec [candidate] (56.25 ms) : 0, 56250
Debugger [baseline] (7.774 ms) : 0, 7774
Debugger [candidate] (6.993 ms) : 0, 6993
Remote Config [baseline] (708.973 µs) : 0, 709
Remote Config [candidate] (694.604 µs) : 0, 695
Telemetry [baseline] (9.973 ms) : 0, 9973
Telemetry [candidate] (9.795 ms) : 0, 9795
section iast
BytebuddyAgent [baseline] (846.903 ms) : 0, 846903
BytebuddyAgent [candidate] (841.705 ms) : 0, 841705
GlobalTracer [baseline] (230.826 ms) : 0, 230826
GlobalTracer [candidate] (229.33 ms) : 0, 229330
IAST [baseline] (23.682 ms) : 0, 23682
IAST [candidate] (23.448 ms) : 0, 23448
AppSec [baseline] (53.866 ms) : 0, 53866
AppSec [candidate] (54.887 ms) : 0, 54887
Debugger [baseline] (5.926 ms) : 0, 5926
Debugger [candidate] (5.927 ms) : 0, 5927
Remote Config [baseline] (593.755 µs) : 0, 594
Remote Config [candidate] (597.459 µs) : 0, 597
Telemetry [baseline] (7.971 ms) : 0, 7971
Telemetry [candidate] (7.894 ms) : 0, 7894
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.645 ms) : 0, 840645
BytebuddyAgent [candidate] (841.12 ms) : 0, 841120
GlobalTracer [baseline] (229.612 ms) : 0, 229612
GlobalTracer [candidate] (229.802 ms) : 0, 229802
IAST [baseline] (25.519 ms) : 0, 25519
IAST [candidate] (25.502 ms) : 0, 25502
AppSec [baseline] (51.276 ms) : 0, 51276
AppSec [candidate] (52.308 ms) : 0, 52308
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.93 ms) : 0, 5930
Remote Config [baseline] (601.197 µs) : 0, 601
Remote Config [candidate] (615.404 µs) : 0, 615
Telemetry [baseline] (7.961 ms) : 0, 7961
Telemetry [candidate] (7.959 ms) : 0, 7959
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (845.504 ms) : 0, 845504
BytebuddyAgent [candidate] (840.684 ms) : 0, 840684
GlobalTracer [baseline] (231.057 ms) : 0, 231057
GlobalTracer [candidate] (231.364 ms) : 0, 231364
IAST [baseline] (22.623 ms) : 0, 22623
IAST [candidate] (22.579 ms) : 0, 22579
AppSec [baseline] (55.456 ms) : 0, 55456
AppSec [candidate] (56.782 ms) : 0, 56782
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (6.013 ms) : 0, 6013
Remote Config [baseline] (606.798 µs) : 0, 607
Remote Config [candidate] (618.858 µs) : 0, 619
Telemetry [baseline] (7.787 ms) : 0, 7787
Telemetry [candidate] (7.989 ms) : 0, 7989

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061092
Total [baseline] (10.569 s) : 0, 10569051
Agent [candidate] (1.067 s) : 0, 1067212
Total [candidate] (10.615 s) : 0, 10615453
section appsec
Agent [baseline] (1.203 s) : 0, 1203331
Total [baseline] (10.705 s) : 0, 10705251
Agent [candidate] (1.2 s) : 0, 1199996
Total [candidate] (10.752 s) : 0, 10751535
section iast
Agent [baseline] (1.19 s) : 0, 1189681
Total [baseline] (10.893 s) : 0, 10892594
Agent [candidate] (1.189 s) : 0, 1188857
Total [candidate] (10.864 s) : 0, 10864262
section profiling
Agent [baseline] (1.32 s) : 0, 1319888
Total [baseline] (10.873 s) : 0, 10872936
Agent [candidate] (1.31 s) : 0, 1310345
Total [candidate] (10.834 s) : 0, 10833764

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.203 s	142.239 ms (13.4%)
Agent	iast	1.19 s	128.589 ms (12.1%)
Agent	profiling	1.32 s	258.796 ms (24.4%)
Total	tracing	10.569 s	-
Total	appsec	10.705 s	136.201 ms (1.3%)
Total	iast	10.893 s	323.543 ms (3.1%)
Total	profiling	10.873 s	303.885 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	appsec	1.2 s	132.784 ms (12.4%)
Agent	iast	1.189 s	121.645 ms (11.4%)
Agent	profiling	1.31 s	243.133 ms (22.8%)
Total	tracing	10.615 s	-
Total	appsec	10.752 s	136.082 ms (1.3%)
Total	iast	10.864 s	248.809 ms (2.3%)
Total	profiling	10.834 s	218.311 ms (2.1%)

gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.578 ms) : 0, 722578
BytebuddyAgent [candidate] (728.047 ms) : 0, 728047
GlobalTracer [baseline] (240.065 ms) : 0, 240065
GlobalTracer [candidate] (241.675 ms) : 0, 241675
AppSec [baseline] (57.459 ms) : 0, 57459
AppSec [candidate] (55.63 ms) : 0, 55630
Debugger [baseline] (7.701 ms) : 0, 7701
Debugger [candidate] (7.703 ms) : 0, 7703
Remote Config [baseline] (685.519 µs) : 0, 686
Remote Config [candidate] (700.669 µs) : 0, 701
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (9.827 ms) : 0, 9827
section appsec
BytebuddyAgent [baseline] (743.251 ms) : 0, 743251
BytebuddyAgent [candidate] (740.274 ms) : 0, 740274
GlobalTracer [baseline] (236.157 ms) : 0, 236157
GlobalTracer [candidate] (236.03 ms) : 0, 236030
AppSec [baseline] (174.716 ms) : 0, 174716
AppSec [candidate] (175.036 ms) : 0, 175036
Debugger [baseline] (6.639 ms) : 0, 6639
Debugger [candidate] (5.932 ms) : 0, 5932
Remote Config [baseline] (629.119 µs) : 0, 629
Remote Config [candidate] (637.247 µs) : 0, 637
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.742 ms) : 0, 7742
IAST [baseline] (21.86 ms) : 0, 21860
IAST [candidate] (21.678 ms) : 0, 21678
section iast
BytebuddyAgent [baseline] (842.765 ms) : 0, 842765
BytebuddyAgent [candidate] (841.846 ms) : 0, 841846
GlobalTracer [baseline] (230.095 ms) : 0, 230095
GlobalTracer [candidate] (230.184 ms) : 0, 230184
AppSec [baseline] (52.999 ms) : 0, 52999
AppSec [candidate] (52.054 ms) : 0, 52054
Debugger [baseline] (5.913 ms) : 0, 5913
Debugger [candidate] (5.937 ms) : 0, 5937
Remote Config [baseline] (593.58 µs) : 0, 594
Remote Config [candidate] (601.364 µs) : 0, 601
Telemetry [baseline] (7.936 ms) : 0, 7936
Telemetry [candidate] (7.919 ms) : 0, 7919
IAST [baseline] (22.778 ms) : 0, 22778
IAST [candidate] (23.667 ms) : 0, 23667
section profiling
ProfilingAgent [baseline] (103.576 ms) : 0, 103576
ProfilingAgent [candidate] (103.125 ms) : 0, 103125
BytebuddyAgent [baseline] (718.766 ms) : 0, 718766
BytebuddyAgent [candidate] (713.391 ms) : 0, 713391
GlobalTracer [baseline] (377.571 ms) : 0, 377571
GlobalTracer [candidate] (375.767 ms) : 0, 375767
AppSec [baseline] (54.356 ms) : 0, 54356
AppSec [candidate] (53.107 ms) : 0, 53107
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.156 ms) : 0, 6156
Remote Config [baseline] (675.793 µs) : 0, 676
Remote Config [candidate] (660.526 µs) : 0, 661
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.004 ms) : 0, 8004
Profiling [baseline] (103.601 ms) : 0, 103601
Profiling [candidate] (103.15 ms) : 0, 103150

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-04-25T09:19:12	2025-04-25T09:26:57
git_branch	master	ben.db/APMAPI-1262-adjust-sampling-formula
git_commit_date	1745533252	1745571566
git_commit_sha	`de593cc`	`fa8ffa9`
release_version	1.49.0-SNAPSHOT~de593cc116	1.49.0-SNAPSHOT~fa8ffa9139
start_time	2025-04-25T09:18:58	2025-04-25T09:26:43

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745573615	1745573615
ci_job_id	912336638	912336638
ci_pipeline_id	63310743	63310743
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-yxg9ttu8-project-304-concurrent-1-5ijqyvnk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-yxg9ttu8-project-304-concurrent-1-5ijqyvnk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 19 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-84.010µs; -32.643µs] or [-5.395%; -2.096%]	unstable [-466.935op/s; +694.855op/s] or [-15.759%; +23.451%]	1.499ms	3076.923op/s	1.557ms	2962.963op/s

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.74 ms) : 1717, 1763
. : milestone, 1740,
appsec_no_iast (1.719 ms) : 1697, 1742
. : milestone, 1719,
code_origins (1.684 ms) : 1656, 1711
. : milestone, 1684,
iast (1.513 ms) : 1488, 1538
. : milestone, 1513,
profiling (1.557 ms) : 1533, 1582
. : milestone, 1557,
tracing (1.507 ms) : 1482, 1532
. : milestone, 1507,
section candidate
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.724 ms) : 1700, 1748
. : milestone, 1724,
appsec_no_iast (1.712 ms) : 1689, 1736
. : milestone, 1712,
code_origins (1.695 ms) : 1669, 1722
. : milestone, 1695,
iast (1.522 ms) : 1496, 1547
. : milestone, 1522,
profiling (1.499 ms) : 1476, 1522
. : milestone, 1499,
tracing (1.49 ms) : 1465, 1514
. : milestone, 1490,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.37 ms]	-
appsec	1.74 ms [1.717 ms, 1.763 ms]	389.778 µs (28.9%)
appsec_no_iast	1.719 ms [1.697 ms, 1.742 ms]	369.238 µs (27.3%)
code_origins	1.684 ms [1.656 ms, 1.711 ms]	333.525 µs (24.7%)
iast	1.513 ms [1.488 ms, 1.538 ms]	163.17 µs (12.1%)
profiling	1.557 ms [1.533 ms, 1.582 ms]	207.101 µs (15.3%)
tracing	1.507 ms [1.482 ms, 1.532 ms]	156.754 µs (11.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.37 ms]	-
appsec	1.724 ms [1.7 ms, 1.748 ms]	373.396 µs (27.7%)
appsec_no_iast	1.712 ms [1.689 ms, 1.736 ms]	362.057 µs (26.8%)
code_origins	1.695 ms [1.669 ms, 1.722 ms]	345.109 µs (25.6%)
iast	1.522 ms [1.496 ms, 1.547 ms]	171.348 µs (12.7%)
profiling	1.499 ms [1.476 ms, 1.522 ms]	148.561 µs (11.0%)
tracing	1.49 ms [1.465 ms, 1.514 ms]	139.121 µs (10.3%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (378.468 µs) : 358, 398
. : milestone, 378,
iast (518.808 µs) : 497, 541
. : milestone, 519,
iast_FULL (736.033 µs) : 712, 760
. : milestone, 736,
iast_GLOBAL (573.282 µs) : 550, 597
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (520.729 µs) : 499, 543
. : milestone, 521,
iast_INACTIVE (463.586 µs) : 441, 487
. : milestone, 464,
iast_TELEMETRY_OFF (500.635 µs) : 478, 524
. : milestone, 501,
tracing (453.289 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (381.565 µs) : 362, 401
. : milestone, 382,
iast (522.652 µs) : 500, 545
. : milestone, 523,
iast_FULL (738.25 µs) : 715, 762
. : milestone, 738,
iast_GLOBAL (577.19 µs) : 553, 601
. : milestone, 577,
iast_HARDCODED_SECRET_DISABLED (505.328 µs) : 483, 527
. : milestone, 505,
iast_INACTIVE (469.248 µs) : 446, 492
. : milestone, 469,
iast_TELEMETRY_OFF (516.116 µs) : 492, 540
. : milestone, 516,
tracing (452.054 µs) : 431, 473
. : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.468 µs [358.49 µs, 398.445 µs]	-
iast	518.808 µs [496.711 µs, 540.905 µs]	140.34 µs (37.1%)
iast_FULL	736.033 µs [712.241 µs, 759.825 µs]	357.565 µs (94.5%)
iast_GLOBAL	573.282 µs [549.781 µs, 596.783 µs]	194.814 µs (51.5%)
iast_HARDCODED_SECRET_DISABLED	520.729 µs [498.887 µs, 542.571 µs]	142.261 µs (37.6%)
iast_INACTIVE	463.586 µs [440.657 µs, 486.515 µs]	85.118 µs (22.5%)
iast_TELEMETRY_OFF	500.635 µs [477.619 µs, 523.651 µs]	122.167 µs (32.3%)
tracing	453.289 µs [432.172 µs, 474.405 µs]	74.821 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.565 µs [362.056 µs, 401.073 µs]	-
iast	522.652 µs [499.939 µs, 545.366 µs]	141.088 µs (37.0%)
iast_FULL	738.25 µs [714.732 µs, 761.768 µs]	356.686 µs (93.5%)
iast_GLOBAL	577.19 µs [553.496 µs, 600.884 µs]	195.625 µs (51.3%)
iast_HARDCODED_SECRET_DISABLED	505.328 µs [483.206 µs, 527.45 µs]	123.763 µs (32.4%)
iast_INACTIVE	469.248 µs [446.198 µs, 492.298 µs]	87.683 µs (23.0%)
iast_TELEMETRY_OFF	516.116 µs [492.422 µs, 539.811 µs]	134.552 µs (35.3%)
tracing	452.054 µs [431.02 µs, 473.089 µs]	70.49 µs (18.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ben.db/APMAPI-1262-adjust-sampling-formula
git_commit_date	1745533252	1745571566
git_commit_sha	`de593cc`	`fa8ffa9`
release_version	1.49.0-SNAPSHOT~de593cc116	1.49.0-SNAPSHOT~fa8ffa9139

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1745574146	1745574146
ci_job_id	912336639	912336639
ci_pipeline_id	63310743	63310743
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-yxg9ttu8-project-304-concurrent-2-6cya0qmv 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-yxg9ttu8-project-304-concurrent-2-6cya0qmv 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (15.448 s) : 15448000, 15448000
. : milestone, 15448000,
appsec (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
iast (18.822 s) : 18822000, 18822000
. : milestone, 18822000,
iast_GLOBAL (17.751 s) : 17751000, 17751000
. : milestone, 17751000,
profiling (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
section candidate
no_agent (15.622 s) : 15622000, 15622000
. : milestone, 15622000,
appsec (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
iast (19.169 s) : 19169000, 19169000
. : milestone, 19169000,
iast_GLOBAL (18.166 s) : 18166000, 18166000
. : milestone, 18166000,
profiling (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
tracing (14.989 s) : 14989000, 14989000
. : milestone, 14989000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.448 s [15.448 s, 15.448 s]	-
appsec	14.865 s [14.865 s, 14.865 s]	-583.0 ms (-3.8%)
iast	18.822 s [18.822 s, 18.822 s]	3.374 s (21.8%)
iast_GLOBAL	17.751 s [17.751 s, 17.751 s]	2.303 s (14.9%)
profiling	15.219 s [15.219 s, 15.219 s]	-229.0 ms (-1.5%)
tracing	14.95 s [14.95 s, 14.95 s]	-498.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.622 s [15.622 s, 15.622 s]	-
appsec	15.103 s [15.103 s, 15.103 s]	-519.0 ms (-3.3%)
iast	19.169 s [19.169 s, 19.169 s]	3.547 s (22.7%)
iast_GLOBAL	18.166 s [18.166 s, 18.166 s]	2.544 s (16.3%)
profiling	15.13 s [15.13 s, 15.13 s]	-492.0 ms (-3.1%)
tracing	14.989 s [14.989 s, 14.989 s]	-633.0 ms (-4.1%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.393 ms) : 2346, 2441
. : milestone, 2393,
iast (2.167 ms) : 2108, 2227
. : milestone, 2167,
iast_GLOBAL (2.203 ms) : 2144, 2262
. : milestone, 2203,
profiling (2.041 ms) : 1992, 2089
. : milestone, 2041,
tracing (1.999 ms) : 1953, 2045
. : milestone, 1999,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.378 ms) : 2331, 2425
. : milestone, 2378,
iast (2.163 ms) : 2104, 2222
. : milestone, 2163,
iast_GLOBAL (2.207 ms) : 2148, 2267
. : milestone, 2207,
profiling (2.028 ms) : 1980, 2076
. : milestone, 2028,
tracing (1.987 ms) : 1941, 2032
. : milestone, 1987,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	2.393 ms [2.346 ms, 2.441 ms]	913.823 µs (61.8%)
iast	2.167 ms [2.108 ms, 2.227 ms]	687.77 µs (46.5%)
iast_GLOBAL	2.203 ms [2.144 ms, 2.262 ms]	723.595 µs (48.9%)
profiling	2.041 ms [1.992 ms, 2.089 ms]	561.094 µs (37.9%)
tracing	1.999 ms [1.953 ms, 2.045 ms]	519.32 µs (35.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	2.378 ms [2.331 ms, 2.425 ms]	903.954 µs (61.3%)
iast	2.163 ms [2.104 ms, 2.222 ms]	688.759 µs (46.7%)
iast_GLOBAL	2.207 ms [2.148 ms, 2.267 ms]	733.183 µs (49.7%)
profiling	2.028 ms [1.98 ms, 2.076 ms]	554.153 µs (37.6%)
tracing	1.987 ms [1.941 ms, 2.032 ms]	512.431 µs (34.8%)

Update trace sampling formula
fa8ffa9

genesor added type: feature Enhancements and improvements comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Apr 25, 2025

genesor requested a review from a team as a code owner April 25, 2025 09:11

genesor requested a review from smola April 25, 2025 09:11

genesor requested a review from mcculls April 25, 2025 10:07

PerfectSlayer approved these changes Apr 25, 2025
View reviewed changes

mcculls approved these changes Apr 25, 2025
View reviewed changes

genesor merged commit 2dd1774 into masterApr 28, 2025

genesor deleted the ben.db/APMAPI-1262-adjust-sampling-formula branch April 28, 2025 08:23

github-actionsBot added this to the 1.49.0 milestone Apr 28, 2025

Navigation Menu

Uh oh!

Update trace sampling formula - #8734

Update trace sampling formula#8734
genesor merged 1 commit into
masterfrom
ben.db/APMAPI-1262-adjust-sampling-formula

genesor commented Apr 25, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Apr 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

genesor commented Apr 25, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Apr 25, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

genesor commented Apr 25, 2025•
edited by atlassian Bot
Loading