Fix exclude identifiers normalization by jpbempel · Pull Request #8742 · DataDog/dd-trace-java

jpbempel · 2025-04-28T09:18:30Z

What Does This Do

exclude identifiers provided by configuration were not normalized

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3745

exclude identifiers provided by configuration were not normalized

pr-commenter · 2025-04-28T09:53:01Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1745833247	1745833616
end_time	2025-04-28T09:42:05	2025-04-28T09:48:14
git_branch	master	jpbempel/fix-redaction-exclude-norm
git_commit_sha	`d306e15`	`a4872d5`
start_time	2025-04-28T09:40:48	2025-04-28T09:46:57

See matching parameters

	Baseline	Candidate
ci_job_id	914504217	914504217
ci_pipeline_id	63464661	63464661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1745831845	1745831845

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-26.140µs; +29.372µs] or [-9.419%; +10.584%]	unstable [-40373.126ns; +41389.562ns] or [-12.653%; +12.972%]	unstable [-51.370µs; +53.735µs] or [-15.402%; +16.111%]	unstable [-126.642µs; +94.906µs] or [-20.507%; +15.368%]	same
scenario:basic	same	same	same	unstable [-31.656µs; +56.616µs] or [-5.984%; +10.702%]	unstable [-141.369op/s; +141.369op/s] or [-5.655%; +5.655%]
scenario:loop	unsure [+13.265µs; +36.015µs] or [+0.133%; +0.361%]	same	same	same	same

Request duration reports for reports

gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.078 µs) : 282, 356
. : milestone, 319,
basic (313.326 µs) : 303, 324
. : milestone, 313,
loop (10.129 ms) : 10089, 10168
. : milestone, 10129,
section candidate
noprobe (319.586 µs) : 279, 360
. : milestone, 320,
basic (314.167 µs) : 306, 323
. : milestone, 314,
loop (10.144 ms) : 10110, 10177
. : milestone, 10144,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	319.078 µs [282.099 µs, 356.056 µs]
basic	313.326 µs [302.763 µs, 323.89 µs]
loop	10.129 ms [10.089 ms, 10.168 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	319.586 µs [278.75 µs, 360.422 µs]
basic	314.167 µs [305.594 µs, 322.74 µs]
loop	10.144 ms [10.11 ms, 10.177 ms]

pr-commenter · 2025-04-28T10:10:37Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-redaction-exclude-norm
git_commit_date	1745829707	1745831845
git_commit_sha	`d306e15`	`a4872d5`
release_version	1.49.0-SNAPSHOT~d306e1530b	1.49.0-SNAPSHOT~a4872d5a41

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745834991	1745834991
ci_job_id	914504211	914504211
ci_pipeline_id	63464661	63464661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-u-qwygag-project-304-concurrent-0-h52ugjrt 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-u-qwygag-project-304-concurrent-0-h52ugjrt 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1005466
Total [baseline] (10.496 s) : 0, 10495671
Agent [candidate] (1.013 s) : 0, 1013257
Total [candidate] (10.54 s) : 0, 10540000
section appsec
Agent [baseline] (1.15 s) : 0, 1150406
Total [baseline] (10.703 s) : 0, 10702788
Agent [candidate] (1.15 s) : 0, 1150390
Total [candidate] (10.68 s) : 0, 10680162
section iast
Agent [baseline] (1.144 s) : 0, 1144337
Total [baseline] (10.972 s) : 0, 10971782
Agent [candidate] (1.147 s) : 0, 1146715
Total [candidate] (10.869 s) : 0, 10869301
section profiling
Agent [baseline] (1.255 s) : 0, 1254864
Total [baseline] (10.745 s) : 0, 10744918
Agent [candidate] (1.27 s) : 0, 1270055
Total [candidate] (10.78 s) : 0, 10780228

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.005 s	-
Agent	appsec	1.15 s	144.94 ms (14.4%)
Agent	iast	1.144 s	138.871 ms (13.8%)
Agent	profiling	1.255 s	249.398 ms (24.8%)
Total	tracing	10.496 s	-
Total	appsec	10.703 s	207.117 ms (2.0%)
Total	iast	10.972 s	476.111 ms (4.5%)
Total	profiling	10.745 s	249.247 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.013 s	-
Agent	appsec	1.15 s	137.133 ms (13.5%)
Agent	iast	1.147 s	133.458 ms (13.2%)
Agent	profiling	1.27 s	256.798 ms (25.3%)
Total	tracing	10.54 s	-
Total	appsec	10.68 s	140.162 ms (1.3%)
Total	iast	10.869 s	329.301 ms (3.1%)
Total	profiling	10.78 s	240.228 ms (2.3%)

gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.304 ms) : 0, 669304
BytebuddyAgent [candidate] (676.39 ms) : 0, 676390
GlobalTracer [baseline] (240.214 ms) : 0, 240214
GlobalTracer [candidate] (242.153 ms) : 0, 242153
AppSec [baseline] (54.397 ms) : 0, 54397
AppSec [candidate] (54.957 ms) : 0, 54957
Debugger [baseline] (6.125 ms) : 0, 6125
Debugger [candidate] (6.157 ms) : 0, 6157
Remote Config [baseline] (702.6 µs) : 0, 703
Remote Config [candidate] (702.623 µs) : 0, 703
Telemetry [baseline] (11.398 ms) : 0, 11398
Telemetry [candidate] (9.312 ms) : 0, 9312
section appsec
BytebuddyAgent [baseline] (689.137 ms) : 0, 689137
BytebuddyAgent [candidate] (689.821 ms) : 0, 689821
GlobalTracer [baseline] (236.805 ms) : 0, 236805
GlobalTracer [candidate] (236.514 ms) : 0, 236514
IAST [baseline] (21.824 ms) : 0, 21824
IAST [candidate] (21.727 ms) : 0, 21727
AppSec [baseline] (176.212 ms) : 0, 176212
AppSec [candidate] (175.501 ms) : 0, 175501
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.858 ms) : 0, 5858
Remote Config [baseline] (630.406 µs) : 0, 630
Remote Config [candidate] (629.74 µs) : 0, 630
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.702 ms) : 0, 7702
section iast
BytebuddyAgent [baseline] (793.487 ms) : 0, 793487
BytebuddyAgent [candidate] (797.46 ms) : 0, 797460
GlobalTracer [baseline] (233.032 ms) : 0, 233032
GlobalTracer [candidate] (231.679 ms) : 0, 231679
IAST [baseline] (23.191 ms) : 0, 23191
IAST [candidate] (23.035 ms) : 0, 23035
AppSec [baseline] (56.748 ms) : 0, 56748
AppSec [candidate] (56.601 ms) : 0, 56601
Debugger [baseline] (5.872 ms) : 0, 5872
Debugger [candidate] (5.863 ms) : 0, 5863
Remote Config [baseline] (584.892 µs) : 0, 585
Remote Config [candidate] (588.895 µs) : 0, 589
Telemetry [baseline] (7.923 ms) : 0, 7923
Telemetry [candidate] (7.894 ms) : 0, 7894
section profiling
BytebuddyAgent [baseline] (662.785 ms) : 0, 662785
BytebuddyAgent [candidate] (675.129 ms) : 0, 675129
GlobalTracer [baseline] (375.373 ms) : 0, 375373
GlobalTracer [candidate] (378.225 ms) : 0, 378225
AppSec [baseline] (54.625 ms) : 0, 54625
AppSec [candidate] (53.61 ms) : 0, 53610
Debugger [baseline] (6.178 ms) : 0, 6178
Debugger [candidate] (6.144 ms) : 0, 6144
Remote Config [baseline] (654.38 µs) : 0, 654
Remote Config [candidate] (644.896 µs) : 0, 645
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.192 ms) : 0, 8192
ProfilingAgent [baseline] (96.839 ms) : 0, 96839
ProfilingAgent [candidate] (97.052 ms) : 0, 97052
Profiling [baseline] (96.863 ms) : 0, 96863
Profiling [candidate] (97.076 ms) : 0, 97076

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1005284
Total [baseline] (8.62 s) : 0, 8619659
Agent [candidate] (1.004 s) : 0, 1003506
Total [candidate] (8.622 s) : 0, 8622366
section iast
Agent [baseline] (1.134 s) : 0, 1134289
Total [baseline] (9.173 s) : 0, 9173025
Agent [candidate] (1.135 s) : 0, 1134898
Total [candidate] (9.192 s) : 0, 9191885
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.135 s) : 0, 1135072
Total [baseline] (9.15 s) : 0, 9150406
Agent [candidate] (1.133 s) : 0, 1133371
Total [candidate] (9.152 s) : 0, 9152389
section iast_TELEMETRY_OFF
Agent [baseline] (1.13 s) : 0, 1130271
Total [baseline] (9.141 s) : 0, 9141473
Agent [candidate] (1.133 s) : 0, 1132610
Total [candidate] (9.178 s) : 0, 9177946

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.005 s	-
Agent	iast	1.134 s	129.005 ms (12.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.135 s	129.787 ms (12.9%)
Agent	iast_TELEMETRY_OFF	1.13 s	124.986 ms (12.4%)
Total	tracing	8.62 s	-
Total	iast	9.173 s	553.367 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.15 s	530.747 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.141 s	521.814 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	iast	1.135 s	131.391 ms (13.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.133 s	129.865 ms (12.9%)
Agent	iast_TELEMETRY_OFF	1.133 s	129.104 ms (12.9%)
Total	tracing	8.622 s	-
Total	iast	9.192 s	569.519 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.152 s	530.022 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.178 s	555.579 ms (6.4%)

gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.215 ms) : 0, 670215
BytebuddyAgent [candidate] (668.79 ms) : 0, 668790
GlobalTracer [baseline] (240.268 ms) : 0, 240268
GlobalTracer [candidate] (239.998 ms) : 0, 239998
AppSec [baseline] (54.656 ms) : 0, 54656
AppSec [candidate] (54.549 ms) : 0, 54549
Debugger [baseline] (6.858 ms) : 0, 6858
Debugger [candidate] (6.125 ms) : 0, 6125
Remote Config [baseline] (708.76 µs) : 0, 709
Remote Config [candidate] (697.527 µs) : 0, 698
Telemetry [baseline] (9.152 ms) : 0, 9152
Telemetry [candidate] (9.873 ms) : 0, 9873
section iast
BytebuddyAgent [baseline] (788.093 ms) : 0, 788093
BytebuddyAgent [candidate] (788.409 ms) : 0, 788409
GlobalTracer [baseline] (229.713 ms) : 0, 229713
GlobalTracer [candidate] (229.871 ms) : 0, 229871
IAST [baseline] (22.66 ms) : 0, 22660
IAST [candidate] (22.701 ms) : 0, 22701
AppSec [baseline] (56.232 ms) : 0, 56232
AppSec [candidate] (56.188 ms) : 0, 56188
Debugger [baseline] (5.858 ms) : 0, 5858
Debugger [candidate] (5.857 ms) : 0, 5857
Remote Config [baseline] (585.406 µs) : 0, 585
Remote Config [candidate] (586.02 µs) : 0, 586
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.86 ms) : 0, 7860
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.485 ms) : 0, 788485
BytebuddyAgent [candidate] (787.5 ms) : 0, 787500
GlobalTracer [baseline] (229.859 ms) : 0, 229859
GlobalTracer [candidate] (229.486 ms) : 0, 229486
IAST [baseline] (22.929 ms) : 0, 22929
IAST [candidate] (22.691 ms) : 0, 22691
AppSec [baseline] (55.991 ms) : 0, 55991
AppSec [candidate] (56.195 ms) : 0, 56195
Debugger [baseline] (5.932 ms) : 0, 5932
Debugger [candidate] (5.86 ms) : 0, 5860
Remote Config [baseline] (580.782 µs) : 0, 581
Remote Config [candidate] (577.904 µs) : 0, 578
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.818 ms) : 0, 7818
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.474 ms) : 0, 784474
BytebuddyAgent [candidate] (785.949 ms) : 0, 785949
GlobalTracer [baseline] (229.837 ms) : 0, 229837
GlobalTracer [candidate] (230.213 ms) : 0, 230213
IAST [baseline] (22.312 ms) : 0, 22312
IAST [candidate] (22.296 ms) : 0, 22296
AppSec [baseline] (56.186 ms) : 0, 56186
AppSec [candidate] (56.477 ms) : 0, 56477
Debugger [baseline] (5.892 ms) : 0, 5892
Debugger [candidate] (5.949 ms) : 0, 5949
Remote Config [baseline] (583.547 µs) : 0, 584
Remote Config [candidate] (602.315 µs) : 0, 602
Telemetry [baseline] (7.678 ms) : 0, 7678
Telemetry [candidate] (7.749 ms) : 0, 7749

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-04-28T09:40:18	2025-04-28T09:48:04
git_branch	master	jpbempel/fix-redaction-exclude-norm
git_commit_date	1745829707	1745831845
git_commit_sha	`d306e15`	`a4872d5`
release_version	1.49.0-SNAPSHOT~d306e1530b	1.49.0-SNAPSHOT~a4872d5a41
start_time	2025-04-28T09:40:04	2025-04-28T09:47:50

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745834082	1745834082
ci_job_id	914504212	914504212
ci_pipeline_id	63464661	63464661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-uvgw7qef-project-304-concurrent-0-11zlgj3x 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-uvgw7qef-project-304-concurrent-0-11zlgj3x 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1370
. : milestone, 1349,
appsec (1.75 ms) : 1726, 1774
. : milestone, 1750,
appsec_no_iast (1.743 ms) : 1720, 1767
. : milestone, 1743,
code_origins (1.69 ms) : 1662, 1717
. : milestone, 1690,
iast (1.51 ms) : 1486, 1534
. : milestone, 1510,
profiling (1.56 ms) : 1536, 1585
. : milestone, 1560,
tracing (1.504 ms) : 1480, 1529
. : milestone, 1504,
section candidate
no_agent (1.359 ms) : 1340, 1379
. : milestone, 1359,
appsec (1.738 ms) : 1715, 1762
. : milestone, 1738,
appsec_no_iast (1.73 ms) : 1707, 1754
. : milestone, 1730,
code_origins (1.683 ms) : 1655, 1710
. : milestone, 1683,
iast (1.521 ms) : 1496, 1545
. : milestone, 1521,
profiling (1.51 ms) : 1487, 1533
. : milestone, 1510,
tracing (1.507 ms) : 1483, 1532
. : milestone, 1507,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.329 ms, 1.37 ms]	-
appsec	1.75 ms [1.726 ms, 1.774 ms]	401.004 µs (29.7%)
appsec_no_iast	1.743 ms [1.72 ms, 1.767 ms]	394.247 µs (29.2%)
code_origins	1.69 ms [1.662 ms, 1.717 ms]	340.424 µs (25.2%)
iast	1.51 ms [1.486 ms, 1.534 ms]	160.299 µs (11.9%)
profiling	1.56 ms [1.536 ms, 1.585 ms]	210.91 µs (15.6%)
tracing	1.504 ms [1.48 ms, 1.529 ms]	155.032 µs (11.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.34 ms, 1.379 ms]	-
appsec	1.738 ms [1.715 ms, 1.762 ms]	378.977 µs (27.9%)
appsec_no_iast	1.73 ms [1.707 ms, 1.754 ms]	370.921 µs (27.3%)
code_origins	1.683 ms [1.655 ms, 1.71 ms]	323.231 µs (23.8%)
iast	1.521 ms [1.496 ms, 1.545 ms]	161.32 µs (11.9%)
profiling	1.51 ms [1.487 ms, 1.533 ms]	150.553 µs (11.1%)
tracing	1.507 ms [1.483 ms, 1.532 ms]	148.026 µs (10.9%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section baseline
no_agent (379.954 µs) : 360, 400
. : milestone, 380,
iast (527.562 µs) : 505, 550
. : milestone, 528,
iast_FULL (732.21 µs) : 709, 755
. : milestone, 732,
iast_GLOBAL (564.801 µs) : 541, 589
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (520.803 µs) : 497, 544
. : milestone, 521,
iast_INACTIVE (469.881 µs) : 448, 492
. : milestone, 470,
iast_TELEMETRY_OFF (506.047 µs) : 483, 529
. : milestone, 506,
tracing (457.292 µs) : 436, 478
. : milestone, 457,
section candidate
no_agent (386.308 µs) : 365, 407
. : milestone, 386,
iast (527.459 µs) : 504, 551
. : milestone, 527,
iast_FULL (738.612 µs) : 715, 762
. : milestone, 739,
iast_GLOBAL (572.928 µs) : 549, 597
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (524.099 µs) : 501, 548
. : milestone, 524,
iast_INACTIVE (465.453 µs) : 443, 488
. : milestone, 465,
iast_TELEMETRY_OFF (515.007 µs) : 492, 538
. : milestone, 515,
tracing (464.019 µs) : 442, 486
. : milestone, 464,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.954 µs [360.316 µs, 399.593 µs]	-
iast	527.562 µs [504.72 µs, 550.404 µs]	147.608 µs (38.8%)
iast_FULL	732.21 µs [709.121 µs, 755.3 µs]	352.256 µs (92.7%)
iast_GLOBAL	564.801 µs [540.841 µs, 588.761 µs]	184.847 µs (48.6%)
iast_HARDCODED_SECRET_DISABLED	520.803 µs [497.345 µs, 544.261 µs]	140.849 µs (37.1%)
iast_INACTIVE	469.881 µs [448.143 µs, 491.618 µs]	89.927 µs (23.7%)
iast_TELEMETRY_OFF	506.047 µs [482.904 µs, 529.189 µs]	126.092 µs (33.2%)
tracing	457.292 µs [436.397 µs, 478.187 µs]	77.338 µs (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.308 µs [365.39 µs, 407.225 µs]	-
iast	527.459 µs [504.365 µs, 550.553 µs]	141.151 µs (36.5%)
iast_FULL	738.612 µs [715.321 µs, 761.904 µs]	352.305 µs (91.2%)
iast_GLOBAL	572.928 µs [549.182 µs, 596.673 µs]	186.62 µs (48.3%)
iast_HARDCODED_SECRET_DISABLED	524.099 µs [500.653 µs, 547.544 µs]	137.791 µs (35.7%)
iast_INACTIVE	465.453 µs [443.14 µs, 487.767 µs]	79.146 µs (20.5%)
iast_TELEMETRY_OFF	515.007 µs [491.87 µs, 538.144 µs]	128.699 µs (33.3%)
tracing	464.019 µs [441.708 µs, 486.33 µs]	77.711 µs (20.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-redaction-exclude-norm
git_commit_date	1745829707	1745831845
git_commit_sha	`d306e15`	`a4872d5`
release_version	1.49.0-SNAPSHOT~d306e1530b	1.49.0-SNAPSHOT~a4872d5a41

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1745834573	1745834573
ci_job_id	914504213	914504213
ci_pipeline_id	63464661	63464661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nsrtnna7-project-304-concurrent-0-rfq0lli6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nsrtnna7-project-304-concurrent-0-rfq0lli6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.386 ms) : 2339, 2433
. : milestone, 2386,
iast (2.171 ms) : 2111, 2231
. : milestone, 2171,
iast_GLOBAL (2.206 ms) : 2146, 2266
. : milestone, 2206,
profiling (2.044 ms) : 1995, 2094
. : milestone, 2044,
tracing (1.983 ms) : 1937, 2029
. : milestone, 1983,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.387 ms) : 2340, 2434
. : milestone, 2387,
iast (2.164 ms) : 2105, 2223
. : milestone, 2164,
iast_GLOBAL (2.207 ms) : 2148, 2267
. : milestone, 2207,
profiling (2.002 ms) : 1955, 2049
. : milestone, 2002,
tracing (1.98 ms) : 1935, 2025
. : milestone, 1980,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	2.386 ms [2.339 ms, 2.433 ms]	906.779 µs (61.3%)
iast	2.171 ms [2.111 ms, 2.231 ms]	691.936 µs (46.8%)
iast_GLOBAL	2.206 ms [2.146 ms, 2.266 ms]	726.483 µs (49.1%)
profiling	2.044 ms [1.995 ms, 2.094 ms]	564.929 µs (38.2%)
tracing	1.983 ms [1.937 ms, 2.029 ms]	503.538 µs (34.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.387 ms [2.34 ms, 2.434 ms]	915.592 µs (62.2%)
iast	2.164 ms [2.105 ms, 2.223 ms]	692.489 µs (47.1%)
iast_GLOBAL	2.207 ms [2.148 ms, 2.267 ms]	735.529 µs (50.0%)
profiling	2.002 ms [1.955 ms, 2.049 ms]	529.885 µs (36.0%)
tracing	1.98 ms [1.935 ms, 2.025 ms]	508.048 µs (34.5%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~a4872d5a41, baseline=1.49.0-SNAPSHOT~d306e1530b
dateFormat X
axisFormat %s
section baseline
no_agent (15.427 s) : 15427000, 15427000
. : milestone, 15427000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.587 s) : 18587000, 18587000
. : milestone, 18587000,
iast_GLOBAL (18.079 s) : 18079000, 18079000
. : milestone, 18079000,
profiling (15.696 s) : 15696000, 15696000
. : milestone, 15696000,
tracing (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
section candidate
no_agent (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
appsec (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
iast (18.761 s) : 18761000, 18761000
. : milestone, 18761000,
iast_GLOBAL (18.091 s) : 18091000, 18091000
. : milestone, 18091000,
profiling (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
tracing (15.106 s) : 15106000, 15106000
. : milestone, 15106000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.427 s [15.427 s, 15.427 s]	-
appsec	14.96 s [14.96 s, 14.96 s]	-467.0 ms (-3.0%)
iast	18.587 s [18.587 s, 18.587 s]	3.16 s (20.5%)
iast_GLOBAL	18.079 s [18.079 s, 18.079 s]	2.652 s (17.2%)
profiling	15.696 s [15.696 s, 15.696 s]	269.0 ms (1.7%)
tracing	15.027 s [15.027 s, 15.027 s]	-400.0 ms (-2.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.33 s [15.33 s, 15.33 s]	-
appsec	15.151 s [15.151 s, 15.151 s]	-179.0 ms (-1.2%)
iast	18.761 s [18.761 s, 18.761 s]	3.431 s (22.4%)
iast_GLOBAL	18.091 s [18.091 s, 18.091 s]	2.761 s (18.0%)
profiling	14.973 s [14.973 s, 14.973 s]	-357.0 ms (-2.3%)
tracing	15.106 s [15.106 s, 15.106 s]	-224.0 ms (-1.5%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.22.2` -> `3.22.3` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.28.0` -> `2.28.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.48.2` -> `1.49.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | --- ### Release Notes <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.56.3 ([844f4fa](googleapis/java-logging@844f4fa)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3 ([#1801](googleapis/java-logging#1801)) ([d7aa7bc](googleapis/java-logging@d7aa7bc)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#1803](googleapis/java-logging#1803)) ([5967ffe](googleapis/java-logging@5967ffe)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#1804](googleapis/java-logging#1804)) ([e9a27ec](googleapis/java-logging@e9a27ec)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#1841](googleapis/java-datastore#1841)) ([ac393e6](googleapis/java-datastore@ac393e6)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#1842](googleapis/java-datastore#1842)) ([0745906](googleapis/java-datastore@0745906)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0): 1.49.0 ### Components #### Configuration at Runtime - ✨ Add process tags as list to remote config payload ([#8705](DataDog/dd-trace-java#8705) - [@amarziali](https://github.com/amarziali)) #### Continuous Integration Visibility - 🐛 Add span propagation for Pekko scheduled tasks ([#8765](DataDog/dd-trace-java#8765) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Update test.retry_reason to use full name of the feature ([#8689](DataDog/dd-trace-java#8689) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Remove unused TestEventsHandler methods ([#8674](DataDog/dd-trace-java#8674) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) #### Dynamic Instrumentation - 🐛 Fix exclude identifiers normalization ([#8742](DataDog/dd-trace-java#8742) - [@jpbempel](https://github.com/jpbempel)) - ✨ Make source file tracking asynchronous ([#8684](DataDog/dd-trace-java#8684) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add scope filtering for symbol extraction ([#8676](DataDog/dd-trace-java#8676) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add support for [@key](https://github.com/key) and [@value](https://github.com/value) for Map filtering ([#8669](DataDog/dd-trace-java#8669) - [@jpbempel](https://github.com/jpbempel)) #### Library Injection - ✨ Add system property to force injection of the tracing library even though multiple javaagents have been detected ([#8697](DataDog/dd-trace-java#8697) - [@cecile75](https://github.com/cecile75)) #### Metrics - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#8693](DataDog/dd-trace-java#8693) - [@randomanderson](https://github.com/randomanderson)) #### Profiling - ✨ Bump ddprof-java to 1.25.1 ([#8750](DataDog/dd-trace-java#8750) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Remove cleanup-on-shutdown for temporary files ([#8746](DataDog/dd-trace-java#8746) - [@jbachorik](https://github.com/jbachorik)) - ✨⚡ Replace a regex-based SMAP parser with a hand-crafted one ([#8730](DataDog/dd-trace-java#8730) - [@jbachorik](https://github.com/jbachorik)) - ✨ Improve error reporting on profiler startup ([#8714](DataDog/dd-trace-java#8714) - [@jbachorik](https://github.com/jbachorik)) - ✨ Exclude ProxyLeakTask exception from exception profiling ([#8666](DataDog/dd-trace-java#8666) - [@jbachorik](https://github.com/jbachorik)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#8641](DataDog/dd-trace-java#8641) - [@MattAlp](https://github.com/MattAlp)) #### Telemetry - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#8693](DataDog/dd-trace-java#8693) - [@randomanderson](https://github.com/randomanderson)) - 🐛 Fix appsec.waf.requests telemetry metric ([#8644](DataDog/dd-trace-java#8644) - [@jandro996](https://github.com/jandro996)) #### Tracer core - ✨ Exclude jackson afterburner dynamic classes from instrumentation ([#8747](DataDog/dd-trace-java#8747) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce Java 8 bytecode bridge for instrumentation API ([#8736](DataDog/dd-trace-java#8736) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ⚡🧹 Use byte-buddy classes optimized for Java8+ ([#8735](DataDog/dd-trace-java#8735) - [@mcculls](https://github.com/mcculls)) - 🐛 Do not set the hibernate or datanucleus span service name when disabled ([#8727](DataDog/dd-trace-java#8727) - [@ygree](https://github.com/ygree)) - ✨ Update bytebuddy and ASM to support JDK 24 ([#8720](DataDog/dd-trace-java#8720) - [@sarahchen6](https://github.com/sarahchen6)) - 🐛 Turn off JDK socket support by default ([#8715](DataDog/dd-trace-java#8715) - [@mcculls](https://github.com/mcculls)) - 🐛 Log warning when trace buffer overflow occurs ([#8712](DataDog/dd-trace-java#8712) - [@ygree](https://github.com/ygree)) - ✨🧪 Introducing an internal integration name ([#8708](DataDog/dd-trace-java#8708) - [@amarziali](https://github.com/amarziali)) - ✨ Add process tags to client stats payload ([#8704](DataDog/dd-trace-java#8704) - [@amarziali](https://github.com/amarziali)) - ✨ Collect process tags for tracing ([#8698](DataDog/dd-trace-java#8698) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config file: target system properties in process_arguments and support template variables in YamlParser ([#8690](DataDog/dd-trace-java#8690) - [@mtoffl01](https://github.com/mtoffl01)) - ✨⚡ Use prefix trie for proxy ignores ([#8678](DataDog/dd-trace-java#8678) - [@amarziali](https://github.com/amarziali)) - ✨ Allow agent to be automatically injected when running aside Log4J patch agent ([#8648](DataDog/dd-trace-java#8648) - [@paullegranddc](https://github.com/paullegranddc)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#8641](DataDog/dd-trace-java#8641) - [@MattAlp](https://github.com/MattAlp)) #### Tracer internal logging - 🐛 Delete print line ([#8686](DataDog/dd-trace-java#8686) - [@sarahchen6](https://github.com/sarahchen6)) ### Instrumentations #### Akka instrumentation - 🐛 Handle reentrant scope cleanup in Akka/Pekko actor instrumentations ([#8722](DataDog/dd-trace-java#8722) - [@mcculls](https://github.com/mcculls)) #### Apache Spark instrumentation - ✨ Use OpenLineage root parent information to generate trace id ([#8726](DataDog/dd-trace-java#8726) - [@mobuchowski](https://github.com/mobuchowski)) - ✨ Spark job cancellation no longer marks application as failed ([#8701](DataDog/dd-trace-java#8701) - [@paul-laffon-dd](https://github.com/paul-laffon-dd)) #### JDBC instrumentation - 💡 Add support for sybase tds jdbc driver ([#8764](DataDog/dd-trace-java#8764) - [@amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - 🐛 Take defensive copy of parent scope stack when closing nested coroutines ([#8749](DataDog/dd-trace-java#8749) - [@mcculls](https://github.com/mcculls)) #### Reactor instrumentation - ✨⚡ Do not inspect reactor context when not needed ([#8745](DataDog/dd-trace-java#8745) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea

Fix exclude identifiers normalization
a4872d5
exclude identifiers provided by configuration were not normalized

jpbempel added type: bug fix Bug fix comp: debugger Dynamic Instrumentation labels Apr 28, 2025

jpbempel requested a review from a team as a code owner April 28, 2025 09:18

jpbempel requested review from shatzi and removed request for a teamApril 28, 2025 09:18

jpbempel requested a review from tylfin April 28, 2025 12:01

tylfin approved these changes Apr 28, 2025
View reviewed changes

jpbempel merged commit bd7a9c8 into masterApr 28, 2025

jpbempel deleted the jpbempel/fix-redaction-exclude-norm branch April 28, 2025 13:36

github-actionsBot added this to the 1.49.0 milestone Apr 28, 2025

Navigation Menu

Uh oh!

Fix exclude identifiers normalization - #8742

Fix exclude identifiers normalization#8742
jpbempel merged 1 commit into
masterfrom
jpbempel/fix-redaction-exclude-norm

jpbempel commented Apr 28, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Apr 28, 2025

Uh oh!

pr-commenterBot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jpbempel commented Apr 28, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Apr 28, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenterBot commented Apr 28, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpbempel commented Apr 28, 2025•
edited by atlassian Bot
Loading