Skip to content

Convert some build file to kotlin dsl - #8743

Merged
bric3 merged 7 commits into
masterfrom
migrate-telemetry-build-to-kotlin-dsl
Jun 25, 2025
Merged

Convert some build file to kotlin dsl#8743
bric3 merged 7 commits into
masterfrom
migrate-telemetry-build-to-kotlin-dsl

Conversation

@bric3

Copy link
Copy Markdown
Contributor

What Does This Do

Converts the build.gradle to build.gradle.kts

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter

pr-commenterBot commented Apr 28, 2025

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermigrate-telemetry-build-to-kotlin-dsl
git_commit_date17508399071750848592
git_commit_shac5581ea4ecf4b5
release_version1.51.0-SNAPSHOT~c5581eae591.51.0-SNAPSHOT~4ecf4b5736
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17508503431750850343
ci_job_id997606699997606699
ci_pipeline_id6871345168713451
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-bziamzy-project-304-concurrent-0-93cgzcpr 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-bziamzy-project-304-concurrent-0-93cgzcpr 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics.

Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.477 ms) : 0, 997477
Total [baseline] (8.583 s) : 0, 8583020
Agent [candidate] (1.002 s) : 0, 1001967
Total [candidate] (8.652 s) : 0, 8652474
section iast
Agent [baseline] (1.128 s) : 0, 1128163
Total [baseline] (9.253 s) : 0, 9253143
Agent [candidate] (1.129 s) : 0, 1128927
Total [candidate] (9.267 s) : 0, 9267041
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing997.477 ms-
Agentiast1.128 s130.686 ms (13.1%)
Totaltracing8.583 s-
Totaliast9.253 s670.123 ms (7.8%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.002 s-
Agentiast1.129 s126.96 ms (12.7%)
Totaltracing8.652 s-
Totaliast9.267 s614.567 ms (7.1%)
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.743 ms) : 0, 688743
BytebuddyAgent [candidate] (691.768 ms) : 0, 691768
GlobalTracer [baseline] (242.587 ms) : 0, 242587
GlobalTracer [candidate] (243.77 ms) : 0, 243770
AppSec [baseline] (30.214 ms) : 0, 30214
AppSec [candidate] (30.412 ms) : 0, 30412
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (668.701 µs) : 0, 669
Remote Config [candidate] (666.156 µs) : 0, 666
Telemetry [baseline] (8.204 ms) : 0, 8204
Telemetry [candidate] (8.267 ms) : 0, 8267
section iast
BytebuddyAgent [baseline] (805.668 ms) : 0, 805668
BytebuddyAgent [candidate] (806.422 ms) : 0, 806422
GlobalTracer [baseline] (232.368 ms) : 0, 232368
GlobalTracer [candidate] (232.196 ms) : 0, 232196
AppSec [baseline] (27.631 ms) : 0, 27631
AppSec [candidate] (29.321 ms) : 0, 29321
Debugger [baseline] (5.754 ms) : 0, 5754
Debugger [candidate] (5.758 ms) : 0, 5758
Remote Config [baseline] (577.29 µs) : 0, 577
Remote Config [candidate] (577.199 µs) : 0, 577
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (7.886 ms) : 0, 7886
IAST [baseline] (27.522 ms) : 0, 27522
IAST [candidate] (26.01 ms) : 0, 26010
Loading
Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (993.796 ms) : 0, 993796
Total [baseline] (10.617 s) : 0, 10617088
Agent [candidate] (994.219 ms) : 0, 994219
Total [candidate] (10.747 s) : 0, 10746781
section appsec
Agent [baseline] (1.173 s) : 0, 1173446
Total [baseline] (10.707 s) : 0, 10707493
Agent [candidate] (1.18 s) : 0, 1179952
Total [candidate] (10.76 s) : 0, 10759521
section iast
Agent [baseline] (1.127 s) : 0, 1126900
Total [baseline] (10.796 s) : 0, 10796253
Agent [candidate] (1.129 s) : 0, 1129301
Total [candidate] (10.867 s) : 0, 10866769
section profiling
Agent [baseline] (1.244 s) : 0, 1243758
Total [baseline] (11.024 s) : 0, 11024299
Agent [candidate] (1.241 s) : 0, 1240810
Total [candidate] (11.028 s) : 0, 11028464
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing993.796 ms-
Agentappsec1.173 s179.65 ms (18.1%)
Agentiast1.127 s133.104 ms (13.4%)
Agentprofiling1.244 s249.963 ms (25.2%)
Totaltracing10.617 s-
Totalappsec10.707 s90.405 ms (0.9%)
Totaliast10.796 s179.165 ms (1.7%)
Totalprofiling11.024 s407.211 ms (3.8%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing994.219 ms-
Agentappsec1.18 s185.733 ms (18.7%)
Agentiast1.129 s135.083 ms (13.6%)
Agentprofiling1.241 s246.591 ms (24.8%)
Totaltracing10.747 s-
Totalappsec10.76 s12.74 ms (0.1%)
Totaliast10.867 s119.988 ms (1.1%)
Totalprofiling11.028 s281.682 ms (2.6%)
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.958 ms) : 0, 685958
BytebuddyAgent [candidate] (685.715 ms) : 0, 685715
GlobalTracer [baseline] (242.136 ms) : 0, 242136
GlobalTracer [candidate] (242.387 ms) : 0, 242387
AppSec [baseline] (30.002 ms) : 0, 30002
AppSec [candidate] (30.224 ms) : 0, 30224
Debugger [baseline] (6.069 ms) : 0, 6069
Debugger [candidate] (6.109 ms) : 0, 6109
Remote Config [baseline] (652.411 µs) : 0, 652
Remote Config [candidate] (680.728 µs) : 0, 681
Telemetry [baseline] (8.091 ms) : 0, 8091
Telemetry [candidate] (8.185 ms) : 0, 8185
section appsec
BytebuddyAgent [baseline] (710.74 ms) : 0, 710740
BytebuddyAgent [candidate] (714.435 ms) : 0, 714435
GlobalTracer [baseline] (235.961 ms) : 0, 235961
GlobalTracer [candidate] (237.337 ms) : 0, 237337
IAST [baseline] (21.848 ms) : 0, 21848
IAST [candidate] (22.173 ms) : 0, 22173
AppSec [baseline] (169.451 ms) : 0, 169451
AppSec [candidate] (170.27 ms) : 0, 170270
Debugger [baseline] (5.822 ms) : 0, 5822
Debugger [candidate] (5.893 ms) : 0, 5893
Remote Config [baseline] (612.296 µs) : 0, 612
Remote Config [candidate] (616.855 µs) : 0, 617
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.271 ms) : 0, 8271
section iast
BytebuddyAgent [baseline] (805.107 ms) : 0, 805107
BytebuddyAgent [candidate] (806.555 ms) : 0, 806555
GlobalTracer [baseline] (231.787 ms) : 0, 231787
GlobalTracer [candidate] (232.36 ms) : 0, 232360
IAST [baseline] (25.129 ms) : 0, 25129
IAST [candidate] (27.06 ms) : 0, 27060
AppSec [baseline] (29.842 ms) : 0, 29842
AppSec [candidate] (28.346 ms) : 0, 28346
Debugger [baseline] (5.732 ms) : 0, 5732
Debugger [candidate] (5.76 ms) : 0, 5760
Remote Config [baseline] (584.701 µs) : 0, 585
Remote Config [candidate] (562.347 µs) : 0, 562
Telemetry [baseline] (7.851 ms) : 0, 7851
Telemetry [candidate] (7.865 ms) : 0, 7865
section profiling
BytebuddyAgent [baseline] (678.478 ms) : 0, 678478
BytebuddyAgent [candidate] (676.828 ms) : 0, 676828
GlobalTracer [baseline] (361.871 ms) : 0, 361871
GlobalTracer [candidate] (360.783 ms) : 0, 360783
AppSec [baseline] (31.442 ms) : 0, 31442
AppSec [candidate] (30.592 ms) : 0, 30592
Debugger [baseline] (10.359 ms) : 0, 10359
Debugger [candidate] (8.923 ms) : 0, 8923
Remote Config [baseline] (656.803 µs) : 0, 657
Remote Config [candidate] (667.536 µs) : 0, 668
Telemetry [baseline] (10.124 ms) : 0, 10124
Telemetry [candidate] (11.546 ms) : 0, 11546
ProfilingAgent [baseline] (102.162 ms) : 0, 102162
ProfilingAgent [candidate] (102.892 ms) : 0, 102892
Profiling [baseline] (102.187 ms) : 0, 102187
Profiling [candidate] (102.918 ms) : 0, 102918
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermigrate-telemetry-build-to-kotlin-dsl
git_commit_date17508399071750848592
git_commit_shac5581ea4ecf4b5
release_version1.51.0-SNAPSHOT~c5581eae591.51.0-SNAPSHOT~4ecf4b5736
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17508500191750850019
ci_job_id997606701997606701
ci_pipeline_id6871345168713451
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-vaym2f8s-project-304-concurrent-0-9k513sns 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-vaym2f8s-project-304-concurrent-0-9k513sns 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenarioΔ mean http_req_durationΔ mean throughputcandidate mean http_req_durationcandidate mean throughputbaseline mean http_req_durationbaseline mean throughput
scenario:load:insecure-bank:no_agent:high_loadbetter
[-379.158µs; -273.744µs] or [-8.414%; -6.075%]
unstable
[-57.224op/s; +213.036op/s] or [-5.615%; +20.905%]
4.180ms1096.969op/s4.506ms1019.062op/s
scenario:load:petclinic:appsec:high_loadbetter
[-2.551ms; -1.665ms] or [-5.384%; -3.513%]
unstable
[-2.741op/s; +11.866op/s] or [-2.775%; +12.013%]
45.276ms103.338op/s47.384ms98.775op/s
scenario:load:petclinic:code_origins:high_loadbetter
[-1.975ms; -1.156ms] or [-4.295%; -2.515%]
unstable
[-3.727op/s; +10.977op/s] or [-3.665%; +10.793%]
44.418ms105.338op/s45.984ms101.713op/s
scenario:load:petclinic:profiling:high_loadworse
[+1.918ms; +2.968ms] or [+4.050%; +6.266%]
unstable
[-11.930op/s; +2.205op/s] or [-12.075%; +2.232%]
49.806ms93.938op/s47.363ms98.800op/s
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (37.338 ms) : 37041, 37635
. : milestone, 37338,
appsec (47.384 ms) : 46972, 47795
. : milestone, 47384,
code_origins (45.984 ms) : 45597, 46371
. : milestone, 45984,
iast (43.83 ms) : 43452, 44207
. : milestone, 43830,
profiling (47.363 ms) : 46882, 47843
. : milestone, 47363,
tracing (45.127 ms) : 44746, 45507
. : milestone, 45127,
section candidate
no_agent (37.655 ms) : 37352, 37957
. : milestone, 37655,
appsec (45.276 ms) : 44864, 45688
. : milestone, 45276,
code_origins (44.418 ms) : 44045, 44792
. : milestone, 44418,
iast (45.076 ms) : 44696, 45455
. : milestone, 45076,
profiling (49.806 ms) : 49311, 50300
. : milestone, 49806,
tracing (44.985 ms) : 44598, 45372
. : milestone, 44985,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent37.338 ms [37.041 ms, 37.635 ms]-
appsec47.384 ms [46.972 ms, 47.795 ms]10.046 ms (26.9%)
code_origins45.984 ms [45.597 ms, 46.371 ms]8.646 ms (23.2%)
iast43.83 ms [43.452 ms, 44.207 ms]6.492 ms (17.4%)
profiling47.363 ms [46.882 ms, 47.843 ms]10.025 ms (26.8%)
tracing45.127 ms [44.746 ms, 45.507 ms]7.789 ms (20.9%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent37.655 ms [37.352 ms, 37.957 ms]-
appsec45.276 ms [44.864 ms, 45.688 ms]7.621 ms (20.2%)
code_origins44.418 ms [44.045 ms, 44.792 ms]6.763 ms (18.0%)
iast45.076 ms [44.696 ms, 45.455 ms]7.421 ms (19.7%)
profiling49.806 ms [49.311 ms, 50.3 ms]12.151 ms (32.3%)
tracing44.985 ms [44.598 ms, 45.372 ms]7.33 ms (19.5%)
Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (4.506 ms) : 4454, 4558
. : milestone, 4506,
iast (9.435 ms) : 9274, 9596
. : milestone, 9435,
iast_FULL (13.92 ms) : 13648, 14192
. : milestone, 13920,
iast_GLOBAL (10.173 ms) : 9993, 10353
. : milestone, 10173,
profiling (8.581 ms) : 8449, 8712
. : milestone, 8581,
tracing (7.461 ms) : 7358, 7564
. : milestone, 7461,
section candidate
no_agent (4.18 ms) : 4134, 4226
. : milestone, 4180,
iast (9.176 ms) : 9030, 9322
. : milestone, 9176,
iast_FULL (13.732 ms) : 13463, 14002
. : milestone, 13732,
iast_GLOBAL (10.204 ms) : 10027, 10381
. : milestone, 10204,
profiling (8.716 ms) : 8585, 8847
. : milestone, 8716,
tracing (7.657 ms) : 7548, 7766
. : milestone, 7657,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent4.506 ms [4.454 ms, 4.558 ms]-
iast9.435 ms [9.274 ms, 9.596 ms]4.929 ms (109.4%)
iast_FULL13.92 ms [13.648 ms, 14.192 ms]9.414 ms (208.9%)
iast_GLOBAL10.173 ms [9.993 ms, 10.353 ms]5.667 ms (125.8%)
profiling8.581 ms [8.449 ms, 8.712 ms]4.074 ms (90.4%)
tracing7.461 ms [7.358 ms, 7.564 ms]2.955 ms (65.6%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent4.18 ms [4.134 ms, 4.226 ms]-
iast9.176 ms [9.03 ms, 9.322 ms]4.996 ms (119.5%)
iast_FULL13.732 ms [13.463 ms, 14.002 ms]9.553 ms (228.6%)
iast_GLOBAL10.204 ms [10.027 ms, 10.381 ms]6.024 ms (144.1%)
profiling8.716 ms [8.585 ms, 8.847 ms]4.536 ms (108.5%)
tracing7.657 ms [7.548 ms, 7.766 ms]3.477 ms (83.2%)

Dacapo

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermigrate-telemetry-build-to-kotlin-dsl
git_commit_date17508399071750848592
git_commit_shac5581ea4ecf4b5
release_version1.51.0-SNAPSHOT~c5581eae591.51.0-SNAPSHOT~4ecf4b5736
See matching parameters
BaselineCandidate
applicationbiojavabiojava
ci_job_date17508505141750850514
ci_job_id997606703997606703
ci_pipeline_id6871345168713451
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-pw1nxbd--project-304-concurrent-0-crlk30gl 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-pw1nxbd--project-304-concurrent-0-crlk30gl 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (18.588 s) : 18588000, 18588000
. : milestone, 18588000,
iast_GLOBAL (18.59 s) : 18590000, 18590000
. : milestone, 18590000,
profiling (15.812 s) : 15812000, 15812000
. : milestone, 15812000,
tracing (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
section candidate
no_agent (15.451 s) : 15451000, 15451000
. : milestone, 15451000,
appsec (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
iast (18.26 s) : 18260000, 18260000
. : milestone, 18260000,
iast_GLOBAL (17.876 s) : 17876000, 17876000
. : milestone, 17876000,
profiling (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.436 s [15.436 s, 15.436 s]-
appsec15.063 s [15.063 s, 15.063 s]-373.0 ms (-2.4%)
iast18.588 s [18.588 s, 18.588 s]3.152 s (20.4%)
iast_GLOBAL18.59 s [18.59 s, 18.59 s]3.154 s (20.4%)
profiling15.812 s [15.812 s, 15.812 s]376.0 ms (2.4%)
tracing15.078 s [15.078 s, 15.078 s]-358.0 ms (-2.3%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.451 s [15.451 s, 15.451 s]-
appsec14.718 s [14.718 s, 14.718 s]-733.0 ms (-4.7%)
iast18.26 s [18.26 s, 18.26 s]2.809 s (18.2%)
iast_GLOBAL17.876 s [17.876 s, 17.876 s]2.425 s (15.7%)
profiling15.224 s [15.224 s, 15.224 s]-227.0 ms (-1.5%)
tracing14.795 s [14.795 s, 14.795 s]-656.0 ms (-4.2%)
Execution time for tomcat
gantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.407 ms) : 2358, 2455
. : milestone, 2407,
iast (2.191 ms) : 2130, 2253
. : milestone, 2191,
iast_GLOBAL (2.227 ms) : 2166, 2288
. : milestone, 2227,
profiling (2.052 ms) : 2002, 2102
. : milestone, 2052,
tracing (2.014 ms) : 1967, 2062
. : milestone, 2014,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (2.409 ms) : 2361, 2458
. : milestone, 2409,
iast (2.195 ms) : 2133, 2256
. : milestone, 2195,
iast_GLOBAL (2.243 ms) : 2181, 2304
. : milestone, 2243,
profiling (2.05 ms) : 2001, 2100
. : milestone, 2050,
tracing (2.017 ms) : 1969, 2065
. : milestone, 2017,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.479 ms [1.468 ms, 1.491 ms]-
appsec2.407 ms [2.358 ms, 2.455 ms]927.157 µs (62.7%)
iast2.191 ms [2.13 ms, 2.253 ms]711.953 µs (48.1%)
iast_GLOBAL2.227 ms [2.166 ms, 2.288 ms]747.711 µs (50.5%)
profiling2.052 ms [2.002 ms, 2.102 ms]572.359 µs (38.7%)
tracing2.014 ms [1.967 ms, 2.062 ms]534.977 µs (36.2%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.486 ms [1.474 ms, 1.497 ms]-
appsec2.409 ms [2.361 ms, 2.458 ms]923.738 µs (62.2%)
iast2.195 ms [2.133 ms, 2.256 ms]708.823 µs (47.7%)
iast_GLOBAL2.243 ms [2.181 ms, 2.304 ms]756.832 µs (50.9%)
profiling2.05 ms [2.001 ms, 2.1 ms]564.794 µs (38.0%)
tracing2.017 ms [1.969 ms, 2.065 ms]531.384 µs (35.8%)

@bric3
bric3force-pushed the migrate-telemetry-build-to-kotlin-dsl branch 3 times, most recently from 84f5501 to 91c831aCompareMay 5, 2025 12:52
@bric3bric3 changed the title Convert :telemetry build file to kotlinConvert some build file to kotlin dslMay 23, 2025
@bric3
bric3force-pushed the migrate-telemetry-build-to-kotlin-dsl branch from 91c831a to 5119b96CompareMay 28, 2025 07:57
@bric3
bric3force-pushed the migrate-telemetry-build-to-kotlin-dsl branch from 5119b96 to e78114cCompareJune 12, 2025 15:56
@bric3bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 13, 2025
@bric3
bric3force-pushed the migrate-telemetry-build-to-kotlin-dsl branch 6 times, most recently from 5e42693 to 3909accCompareJune 19, 2025 12:44
@bric3
bric3force-pushed the migrate-telemetry-build-to-kotlin-dsl branch from 3909acc to ba255b8CompareJune 24, 2025 10:17
@bric3
bric3 marked this pull request as ready for review June 24, 2025 15:20
@bric3
bric3 requested review from a team as code ownersJune 24, 2025 15:20
@bric3
bric3 requested review from PerfectSlayer and dougqh and removed request for a teamJune 24, 2025 15:20

@PerfectSlayerPerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring! 👍
Left few comments


plugins {
`java-library`
idea

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this one have idea specifically enabled?

@bric3bric3Jun 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to force the jdk to 17 for this module. It was used before.

In order to not break anything at this point, so I kept the configuration. We can revisit this later.

Comment threadutils/socket-utils/build.gradle.kts Outdated
@PerfectSlayer

Copy link
Copy Markdown
Collaborator

In the meantime, load benchmark is totally flaky:

Found 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

@bric3
bric3 merged commit 2f749a9 into masterJun 25, 2025
@bric3
bric3 deleted the migrate-telemetry-build-to-kotlin-dsl branch June 25, 2025 13:17
@github-actionsgithub-actionsBot added this to the 1.51.0 milestone Jun 25, 2025
@bric3bric3 mentioned this pull request Jun 25, 2025
@PerfectSlayerPerfectSlayer added the type: feature Enhancements and improvements label Jun 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: toolingBuild & Toolingtag: no release notesChanges to exclude from release notestype: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bric3@PerfectSlayer