Fix incorrect use of Path.getRoot() by jbachorik · Pull Request #8751 · DataDog/dd-trace-java

jbachorik · 2025-04-29T14:57:52Z

What Does This Do

After #8714 the profiling tests started failing. The reason is that the Path.getRoot() will return null for a single element path because it considers it not having a root 🤷

Notes

As a part of this change I removed the testShortCircuit test - because the base temp directory is now created eagerly and not lazily so it can not happen that it will not exist, and this test was asserting that exact 'short-circuit' to avoid scanning the dir structure when there is guaranteed nothing in there.

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

pr-commenter · 2025-04-29T15:51:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/temp_files_fix
git_commit_date	1745935074	1745941933
git_commit_sha	`74633af`	`cf7859d`
release_version	1.49.0-SNAPSHOT~74633afbc6	1.49.0-SNAPSHOT~cf7859ddda

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745944981	1745944981
ci_job_id	917225118	917225118
ci_pipeline_id	63632394	63632394
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-fqkx7oxa-project-304-concurrent-0-4vza09a0 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-fqkx7oxa-project-304-concurrent-0-4vza09a0 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006320
Total [baseline] (10.554 s) : 0, 10553504
Agent [candidate] (1.004 s) : 0, 1004142
Total [candidate] (10.628 s) : 0, 10628195
section appsec
Agent [baseline] (1.146 s) : 0, 1146456
Total [baseline] (10.688 s) : 0, 10687645
Agent [candidate] (1.15 s) : 0, 1150211
Total [candidate] (10.718 s) : 0, 10718233
section iast
Agent [baseline] (1.139 s) : 0, 1139426
Total [baseline] (10.947 s) : 0, 10946642
Agent [candidate] (1.136 s) : 0, 1136415
Total [candidate] (10.91 s) : 0, 10909968
section profiling
Agent [baseline] (1.252 s) : 0, 1252407
Total [baseline] (10.827 s) : 0, 10827204
Agent [candidate] (1.255 s) : 0, 1255472
Total [candidate] (10.806 s) : 0, 10806233

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.006 s	-
Agent	appsec	1.146 s	140.135 ms (13.9%)
Agent	iast	1.139 s	133.105 ms (13.2%)
Agent	profiling	1.252 s	246.086 ms (24.5%)
Total	tracing	10.554 s	-
Total	appsec	10.688 s	134.141 ms (1.3%)
Total	iast	10.947 s	393.138 ms (3.7%)
Total	profiling	10.827 s	273.701 ms (2.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	appsec	1.15 s	146.069 ms (14.5%)
Agent	iast	1.136 s	132.273 ms (13.2%)
Agent	profiling	1.255 s	251.331 ms (25.0%)
Total	tracing	10.628 s	-
Total	appsec	10.718 s	90.039 ms (0.8%)
Total	iast	10.91 s	281.774 ms (2.7%)
Total	profiling	10.806 s	178.038 ms (1.7%)

gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.214 ms) : 0, 670214
BytebuddyAgent [candidate] (670.062 ms) : 0, 670062
GlobalTracer [baseline] (240.813 ms) : 0, 240813
GlobalTracer [candidate] (239.733 ms) : 0, 239733
AppSec [baseline] (54.965 ms) : 0, 54965
AppSec [candidate] (54.805 ms) : 0, 54805
Debugger [baseline] (6.187 ms) : 0, 6187
Debugger [candidate] (6.17 ms) : 0, 6170
Remote Config [baseline] (722.942 µs) : 0, 723
Remote Config [candidate] (701.732 µs) : 0, 702
Telemetry [baseline] (9.983 ms) : 0, 9983
Telemetry [candidate] (9.319 ms) : 0, 9319
section appsec
BytebuddyAgent [baseline] (686.974 ms) : 0, 686974
BytebuddyAgent [candidate] (688.135 ms) : 0, 688135
GlobalTracer [baseline] (235.792 ms) : 0, 235792
GlobalTracer [candidate] (236.944 ms) : 0, 236944
AppSec [baseline] (175.174 ms) : 0, 175174
AppSec [candidate] (176.573 ms) : 0, 176573
Debugger [baseline] (5.859 ms) : 0, 5859
Debugger [candidate] (5.83 ms) : 0, 5830
Remote Config [baseline] (628.034 µs) : 0, 628
Remote Config [candidate] (635.892 µs) : 0, 636
Telemetry [baseline] (7.786 ms) : 0, 7786
Telemetry [candidate] (7.758 ms) : 0, 7758
IAST [baseline] (21.729 ms) : 0, 21729
IAST [candidate] (21.885 ms) : 0, 21885
section iast
BytebuddyAgent [baseline] (790.566 ms) : 0, 790566
BytebuddyAgent [candidate] (789.85 ms) : 0, 789850
GlobalTracer [baseline] (230.811 ms) : 0, 230811
GlobalTracer [candidate] (229.96 ms) : 0, 229960
AppSec [baseline] (57.035 ms) : 0, 57035
AppSec [candidate] (56.321 ms) : 0, 56321
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (5.872 ms) : 0, 5872
Remote Config [baseline] (610.337 µs) : 0, 610
Remote Config [candidate] (593.5 µs) : 0, 593
Telemetry [baseline] (7.972 ms) : 0, 7972
Telemetry [candidate] (7.822 ms) : 0, 7822
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.606 ms) : 0, 22606
section profiling
BytebuddyAgent [baseline] (661.743 ms) : 0, 661743
BytebuddyAgent [candidate] (663.346 ms) : 0, 663346
GlobalTracer [baseline] (375.384 ms) : 0, 375384
GlobalTracer [candidate] (377.36 ms) : 0, 377360
AppSec [baseline] (53.968 ms) : 0, 53968
AppSec [candidate] (53.274 ms) : 0, 53274
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.167 ms) : 0, 6167
Remote Config [baseline] (654.697 µs) : 0, 655
Remote Config [candidate] (660.768 µs) : 0, 661
Telemetry [baseline] (8.104 ms) : 0, 8104
Telemetry [candidate] (8.181 ms) : 0, 8181
ProfilingAgent [baseline] (96.225 ms) : 0, 96225
ProfilingAgent [candidate] (96.245 ms) : 0, 96245
Profiling [baseline] (96.249 ms) : 0, 96249
Profiling [candidate] (96.268 ms) : 0, 96268

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.013 s) : 0, 1013356
Total [baseline] (8.669 s) : 0, 8668911
Agent [candidate] (1.005 s) : 0, 1004898
Total [candidate] (8.625 s) : 0, 8624847
section iast
Agent [baseline] (1.135 s) : 0, 1134538
Total [baseline] (9.186 s) : 0, 9185981
Agent [candidate] (1.135 s) : 0, 1134825
Total [candidate] (9.182 s) : 0, 9181915
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.134 s) : 0, 1134223
Total [baseline] (9.195 s) : 0, 9195036
Agent [candidate] (1.136 s) : 0, 1136100
Total [candidate] (9.19 s) : 0, 9189655
section iast_TELEMETRY_OFF
Agent [baseline] (1.132 s) : 0, 1132223
Total [baseline] (9.177 s) : 0, 9176603
Agent [candidate] (1.14 s) : 0, 1140155
Total [candidate] (9.178 s) : 0, 9178022

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.013 s	-
Agent	iast	1.135 s	121.182 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.134 s	120.867 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.132 s	118.866 ms (11.7%)
Total	tracing	8.669 s	-
Total	iast	9.186 s	517.069 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.195 s	526.124 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.177 s	507.691 ms (5.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.005 s	-
Agent	iast	1.135 s	129.927 ms (12.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.136 s	131.202 ms (13.1%)
Agent	iast_TELEMETRY_OFF	1.14 s	135.257 ms (13.5%)
Total	tracing	8.625 s	-
Total	iast	9.182 s	557.069 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.19 s	564.809 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.178 s	553.175 ms (6.4%)

gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.798 ms) : 0, 675798
BytebuddyAgent [candidate] (669.398 ms) : 0, 669398
GlobalTracer [baseline] (240.224 ms) : 0, 240224
GlobalTracer [candidate] (240.001 ms) : 0, 240001
AppSec [baseline] (54.808 ms) : 0, 54808
AppSec [candidate] (54.658 ms) : 0, 54658
Debugger [baseline] (6.871 ms) : 0, 6871
Debugger [candidate] (6.862 ms) : 0, 6862
Remote Config [baseline] (710.395 µs) : 0, 710
Remote Config [candidate] (691.389 µs) : 0, 691
Telemetry [baseline] (11.382 ms) : 0, 11382
Telemetry [candidate] (9.841 ms) : 0, 9841
section iast
BytebuddyAgent [baseline] (788.493 ms) : 0, 788493
BytebuddyAgent [candidate] (788.307 ms) : 0, 788307
GlobalTracer [baseline] (229.659 ms) : 0, 229659
GlobalTracer [candidate] (229.823 ms) : 0, 229823
AppSec [baseline] (56.034 ms) : 0, 56034
AppSec [candidate] (56.279 ms) : 0, 56279
Debugger [baseline] (5.836 ms) : 0, 5836
Debugger [candidate] (5.876 ms) : 0, 5876
Remote Config [baseline] (588.243 µs) : 0, 588
Remote Config [candidate] (586.388 µs) : 0, 586
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.902 ms) : 0, 7902
IAST [baseline] (22.674 ms) : 0, 22674
IAST [candidate] (22.753 ms) : 0, 22753
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.306 ms) : 0, 788306
BytebuddyAgent [candidate] (789.298 ms) : 0, 789298
GlobalTracer [baseline] (229.16 ms) : 0, 229160
GlobalTracer [candidate] (229.528 ms) : 0, 229528
AppSec [baseline] (56.357 ms) : 0, 56357
AppSec [candidate] (56.643 ms) : 0, 56643
Debugger [baseline] (5.828 ms) : 0, 5828
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (575.663 µs) : 0, 576
Remote Config [candidate] (591.308 µs) : 0, 591
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (7.931 ms) : 0, 7931
IAST [baseline] (22.741 ms) : 0, 22741
IAST [candidate] (22.775 ms) : 0, 22775
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.137 ms) : 0, 786137
BytebuddyAgent [candidate] (792.369 ms) : 0, 792369
GlobalTracer [baseline] (229.474 ms) : 0, 229474
GlobalTracer [candidate] (230.941 ms) : 0, 230941
AppSec [baseline] (56.614 ms) : 0, 56614
AppSec [candidate] (56.645 ms) : 0, 56645
Debugger [baseline] (5.915 ms) : 0, 5915
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (614.586 µs) : 0, 615
Remote Config [candidate] (604.691 µs) : 0, 605
Telemetry [baseline] (7.75 ms) : 0, 7750
Telemetry [candidate] (7.731 ms) : 0, 7731
IAST [baseline] (22.381 ms) : 0, 22381
IAST [candidate] (22.459 ms) : 0, 22459

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-04-29T16:13:28	2025-04-29T16:21:12
git_branch	master	jb/temp_files_fix
git_commit_date	1745935074	1745941933
git_commit_sha	`74633af`	`cf7859d`
release_version	1.49.0-SNAPSHOT~74633afbc6	1.49.0-SNAPSHOT~cf7859ddda
start_time	2025-04-29T16:13:14	2025-04-29T16:20:58

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745944069	1745944069
ci_job_id	917225119	917225119
ci_pipeline_id	63632394	63632394
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-uznlmb1g-project-304-concurrent-0-vxic2v21 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-uznlmb1g-project-304-concurrent-0-vxic2v21 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.729 ms) : 1706, 1753
. : milestone, 1729,
appsec_no_iast (1.726 ms) : 1703, 1749
. : milestone, 1726,
code_origins (1.694 ms) : 1667, 1720
. : milestone, 1694,
iast (1.52 ms) : 1495, 1545
. : milestone, 1520,
profiling (1.505 ms) : 1482, 1528
. : milestone, 1505,
tracing (1.494 ms) : 1470, 1519
. : milestone, 1494,
section candidate
no_agent (1.351 ms) : 1332, 1371
. : milestone, 1351,
appsec (1.72 ms) : 1697, 1743
. : milestone, 1720,
appsec_no_iast (1.728 ms) : 1704, 1751
. : milestone, 1728,
code_origins (1.693 ms) : 1666, 1719
. : milestone, 1693,
iast (1.518 ms) : 1493, 1543
. : milestone, 1518,
profiling (1.55 ms) : 1525, 1574
. : milestone, 1550,
tracing (1.473 ms) : 1449, 1498
. : milestone, 1473,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.37 ms]	-
appsec	1.729 ms [1.706 ms, 1.753 ms]	378.908 µs (28.1%)
appsec_no_iast	1.726 ms [1.703 ms, 1.749 ms]	375.37 µs (27.8%)
code_origins	1.694 ms [1.667 ms, 1.72 ms]	343.181 µs (25.4%)
iast	1.52 ms [1.495 ms, 1.545 ms]	169.31 µs (12.5%)
profiling	1.505 ms [1.482 ms, 1.528 ms]	154.442 µs (11.4%)
tracing	1.494 ms [1.47 ms, 1.519 ms]	143.881 µs (10.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.332 ms, 1.371 ms]	-
appsec	1.72 ms [1.697 ms, 1.743 ms]	369.029 µs (27.3%)
appsec_no_iast	1.728 ms [1.704 ms, 1.751 ms]	376.51 µs (27.9%)
code_origins	1.693 ms [1.666 ms, 1.719 ms]	341.757 µs (25.3%)
iast	1.518 ms [1.493 ms, 1.543 ms]	166.872 µs (12.4%)
profiling	1.55 ms [1.525 ms, 1.574 ms]	198.572 µs (14.7%)
tracing	1.473 ms [1.449 ms, 1.498 ms]	122.414 µs (9.1%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (380.095 µs) : 360, 400
. : milestone, 380,
iast (522.198 µs) : 499, 545
. : milestone, 522,
iast_FULL (734.802 µs) : 712, 758
. : milestone, 735,
iast_GLOBAL (572.726 µs) : 549, 596
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (526.946 µs) : 504, 550
. : milestone, 527,
iast_INACTIVE (466.331 µs) : 445, 488
. : milestone, 466,
iast_TELEMETRY_OFF (503.762 µs) : 481, 527
. : milestone, 504,
tracing (463.101 µs) : 441, 485
. : milestone, 463,
section candidate
no_agent (380.1 µs) : 361, 400
. : milestone, 380,
iast (519.029 µs) : 496, 542
. : milestone, 519,
iast_FULL (734.034 µs) : 711, 757
. : milestone, 734,
iast_GLOBAL (572.438 µs) : 549, 596
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (519.113 µs) : 496, 542
. : milestone, 519,
iast_INACTIVE (466.688 µs) : 444, 489
. : milestone, 467,
iast_TELEMETRY_OFF (502.967 µs) : 480, 526
. : milestone, 503,
tracing (459.462 µs) : 439, 480
. : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.095 µs [359.876 µs, 400.315 µs]	-
iast	522.198 µs [499.444 µs, 544.953 µs]	142.103 µs (37.4%)
iast_FULL	734.802 µs [711.51 µs, 758.095 µs]	354.707 µs (93.3%)
iast_GLOBAL	572.726 µs [549.118 µs, 596.334 µs]	192.631 µs (50.7%)
iast_HARDCODED_SECRET_DISABLED	526.946 µs [503.593 µs, 550.299 µs]	146.851 µs (38.6%)
iast_INACTIVE	466.331 µs [444.58 µs, 488.083 µs]	86.236 µs (22.7%)
iast_TELEMETRY_OFF	503.762 µs [480.918 µs, 526.607 µs]	123.667 µs (32.5%)
tracing	463.101 µs [441.067 µs, 485.136 µs]	83.006 µs (21.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.1 µs [360.531 µs, 399.67 µs]	-
iast	519.029 µs [495.918 µs, 542.139 µs]	138.928 µs (36.6%)
iast_FULL	734.034 µs [710.711 µs, 757.356 µs]	353.933 µs (93.1%)
iast_GLOBAL	572.438 µs [548.599 µs, 596.277 µs]	192.338 µs (50.6%)
iast_HARDCODED_SECRET_DISABLED	519.113 µs [495.879 µs, 542.346 µs]	139.012 µs (36.6%)
iast_INACTIVE	466.688 µs [444.307 µs, 489.07 µs]	86.588 µs (22.8%)
iast_TELEMETRY_OFF	502.967 µs [480.006 µs, 525.927 µs]	122.866 µs (32.3%)
tracing	459.462 µs [438.836 µs, 480.089 µs]	79.362 µs (20.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/temp_files_fix
git_commit_date	1745935074	1745941933
git_commit_sha	`74633af`	`cf7859d`
release_version	1.49.0-SNAPSHOT~74633afbc6	1.49.0-SNAPSHOT~cf7859ddda

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1745944465	1745944465
ci_job_id	917225121	917225121
ci_pipeline_id	63632394	63632394
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nzjrepv-project-304-concurrent-0-qmwye8xk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nzjrepv-project-304-concurrent-0-qmwye8xk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.384 ms) : 2338, 2431
. : milestone, 2384,
iast (2.169 ms) : 2110, 2228
. : milestone, 2169,
iast_GLOBAL (2.2 ms) : 2141, 2259
. : milestone, 2200,
profiling (2.05 ms) : 2001, 2099
. : milestone, 2050,
tracing (1.998 ms) : 1952, 2044
. : milestone, 1998,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.393 ms) : 2346, 2440
. : milestone, 2393,
iast (2.168 ms) : 2109, 2228
. : milestone, 2168,
iast_GLOBAL (2.209 ms) : 2149, 2269
. : milestone, 2209,
profiling (2.04 ms) : 1991, 2089
. : milestone, 2040,
tracing (2.008 ms) : 1962, 2054
. : milestone, 2008,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.469 ms, 1.492 ms]	-
appsec	2.384 ms [2.338 ms, 2.431 ms]	903.887 µs (61.1%)
iast	2.169 ms [2.11 ms, 2.228 ms]	688.736 µs (46.5%)
iast_GLOBAL	2.2 ms [2.141 ms, 2.259 ms]	719.527 µs (48.6%)
profiling	2.05 ms [2.001 ms, 2.099 ms]	569.664 µs (38.5%)
tracing	1.998 ms [1.952 ms, 2.044 ms]	517.84 µs (35.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.47 ms, 1.493 ms]	-
appsec	2.393 ms [2.346 ms, 2.44 ms]	911.5 µs (61.5%)
iast	2.168 ms [2.109 ms, 2.228 ms]	686.947 µs (46.4%)
iast_GLOBAL	2.209 ms [2.149 ms, 2.269 ms]	728.011 µs (49.2%)
profiling	2.04 ms [1.991 ms, 2.089 ms]	559.015 µs (37.7%)
tracing	2.008 ms [1.962 ms, 2.054 ms]	526.92 µs (35.6%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (18.499 s) : 18499000, 18499000
. : milestone, 18499000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
tracing (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
section candidate
no_agent (15.287 s) : 15287000, 15287000
. : milestone, 15287000,
appsec (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
iast (18.682 s) : 18682000, 18682000
. : milestone, 18682000,
iast_GLOBAL (18.14 s) : 18140000, 18140000
. : milestone, 18140000,
profiling (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
tracing (14.945 s) : 14945000, 14945000
. : milestone, 14945000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.248 s [15.248 s, 15.248 s]	-
appsec	14.838 s [14.838 s, 14.838 s]	-410.0 ms (-2.7%)
iast	18.499 s [18.499 s, 18.499 s]	3.251 s (21.3%)
iast_GLOBAL	17.994 s [17.994 s, 17.994 s]	2.746 s (18.0%)
profiling	15.195 s [15.195 s, 15.195 s]	-53.0 ms (-0.3%)
tracing	14.98 s [14.98 s, 14.98 s]	-268.0 ms (-1.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.287 s [15.287 s, 15.287 s]	-
appsec	15.005 s [15.005 s, 15.005 s]	-282.0 ms (-1.8%)
iast	18.682 s [18.682 s, 18.682 s]	3.395 s (22.2%)
iast_GLOBAL	18.14 s [18.14 s, 18.14 s]	2.853 s (18.7%)
profiling	14.985 s [14.985 s, 14.985 s]	-302.0 ms (-2.0%)
tracing	14.945 s [14.945 s, 14.945 s]	-342.0 ms (-2.2%)

Fix incorrect use of Path.getRoot()
b7ab377

jbachorik added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: profiling Profiling labels Apr 29, 2025

jbachorik force-pushed the jb/temp_files_fix branch from f469004 to b7ab377Compare April 29, 2025 14:57

jbachorik requested review from a team as code owners April 29, 2025 14:57

Adjust tests
cf7859d

mcculls approved these changes Apr 29, 2025
View reviewed changes

jbachorik merged commit 37f0190 into masterApr 29, 2025

jbachorik deleted the jb/temp_files_fix branch April 29, 2025 18:36

github-actionsBot added this to the 1.49.0 milestone Apr 29, 2025

Navigation Menu

Uh oh!

Fix incorrect use of Path.getRoot() - #8751

Fix incorrect use of Path.getRoot()#8751
jbachorik merged 2 commits into
masterfrom
jb/temp_files_fix

jbachorik commented Apr 29, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Apr 29, 2025•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jbachorik commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Notes

Uh oh!

pr-commenterBot commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jbachorik commented Apr 29, 2025•
edited
Loading

pr-commenterBot commented Apr 29, 2025•
edited
Loading