Skip to content

Revert "Implement APIGW Inferred Proxy Spans" - #8802

Merged
PerfectSlayer merged 1 commit into
masterfrom
revert-8336-inferred-span-tags
May 12, 2025
Merged

Revert "Implement APIGW Inferred Proxy Spans"#8802
PerfectSlayer merged 1 commit into
masterfrom
revert-8336-inferred-span-tags

Conversation

@PerfectSlayer

@PerfectSlayerPerfectSlayer commented May 12, 2025

Copy link
Copy Markdown
Collaborator

This PR reverts #8336

The reverted PR has multiples issues:

  • Design issue where context element and propagator dedicated to tracing landed on the common context component,
  • Performance issues:
    • context extraction will be run multiple time when receiving a web request: one as part of context extraction, then every time a new span start,
    • collection allocation where the context item is simply a glorified key/value store (like baggage) for headers

The part of the code is also heavily interacting with some refactoring in progress (baggage support) that was started earlier by @mhlidd. We (the guild) will revert it for now as it still reverts nicely, and started some clean up pull requests #8795 by @mcculls and #8801 by @PerfectSlayer.

In addition, this feature should be implementable using a single context extraction pass, and a context element to store the inferred span. No sub-classing of the agent span would be needed, only the HTTP_DECORATOR would update both tracing and inferred active spans (if any).

@PerfectSlayer
PerfectSlayer requested a review from a team as a code ownerMay 12, 2025 10:36
@github-actions

github-actionsBot commented May 12, 2025

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@PerfectSlayerPerfectSlayer added the tag: no release notes Changes to exclude from release notes label May 12, 2025
@PerfectSlayer
PerfectSlayer enabled auto-merge (squash) May 12, 2025 10:40
@PerfectSlayer
PerfectSlayer disabled auto-merge May 12, 2025 11:40
@PerfectSlayer
PerfectSlayer merged commit 8bfbf8e into masterMay 12, 2025
@PerfectSlayer
PerfectSlayer deleted the revert-8336-inferred-span-tags branch May 12, 2025 11:40
@github-actionsgithub-actionsBot added this to the 1.50.0 milestone May 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: no release notesChanges to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@PerfectSlayer@mcculls