Widen lazy coroutine matcher to cover all definitions of onStart by mcculls · Pull Request #8838 · DataDog/dd-trace-java

mcculls · 2025-05-16T11:40:27Z

Motivation

This covers coroutines that don't extend LazyDeferredCoroutine or that override onStart but don't call the overridden method. Eager coroutines are already covered by the base constructor advice that captures the context when the coroutine starts already activated.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: AIDM-602

pr-commenter · 2025-05-16T12:15:26Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/widen-lazy-coroutine-check
git_commit_date	1747400001	1747400451
git_commit_sha	`cd3218a`	`607894b`
release_version	1.50.0-SNAPSHOT~cd3218a06a	1.50.0-SNAPSHOT~607894bd2b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1747402941	1747402941
ci_job_id	941615752	941615752
ci_pipeline_id	65319142	65319142
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-thkehp5s-project-304-concurrent-2-hmwn88ws 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-thkehp5s-project-304-concurrent-2-hmwn88ws 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020074
Total [baseline] (10.524 s) : 0, 10523539
Agent [candidate] (1.028 s) : 0, 1027638
Total [candidate] (10.549 s) : 0, 10549008
section appsec
Agent [baseline] (1.16 s) : 0, 1160087
Total [baseline] (10.704 s) : 0, 10703648
Agent [candidate] (1.16 s) : 0, 1159543
Total [candidate] (10.647 s) : 0, 10647186
section iast
Agent [baseline] (1.156 s) : 0, 1155506
Total [baseline] (10.896 s) : 0, 10895619
Agent [candidate] (1.155 s) : 0, 1155145
Total [candidate] (10.957 s) : 0, 10957272
section profiling
Agent [baseline] (1.279 s) : 0, 1278587
Total [baseline] (10.919 s) : 0, 10918669
Agent [candidate] (1.276 s) : 0, 1276461
Total [candidate] (10.877 s) : 0, 10877077

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	appsec	1.16 s	140.013 ms (13.7%)
Agent	iast	1.156 s	135.431 ms (13.3%)
Agent	profiling	1.279 s	258.513 ms (25.3%)
Total	tracing	10.524 s	-
Total	appsec	10.704 s	180.109 ms (1.7%)
Total	iast	10.896 s	372.079 ms (3.5%)
Total	profiling	10.919 s	395.13 ms (3.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	appsec	1.16 s	131.905 ms (12.8%)
Agent	iast	1.155 s	127.507 ms (12.4%)
Agent	profiling	1.276 s	248.824 ms (24.2%)
Total	tracing	10.549 s	-
Total	appsec	10.647 s	98.178 ms (0.9%)
Total	iast	10.957 s	408.264 ms (3.9%)
Total	profiling	10.877 s	328.068 ms (3.1%)

gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.908 ms) : 0, 683908
BytebuddyAgent [candidate] (688.451 ms) : 0, 688451
GlobalTracer [baseline] (240.534 ms) : 0, 240534
GlobalTracer [candidate] (242.727 ms) : 0, 242727
AppSec [baseline] (55.378 ms) : 0, 55378
AppSec [candidate] (55.04 ms) : 0, 55040
Debugger [baseline] (7.657 ms) : 0, 7657
Debugger [candidate] (8.472 ms) : 0, 8472
Remote Config [baseline] (708.736 µs) : 0, 709
Remote Config [candidate] (707.62 µs) : 0, 708
Telemetry [baseline] (8.348 ms) : 0, 8348
Telemetry [candidate] (8.352 ms) : 0, 8352
section appsec
BytebuddyAgent [baseline] (699.245 ms) : 0, 699245
BytebuddyAgent [candidate] (698.995 ms) : 0, 698995
GlobalTracer [baseline] (236.61 ms) : 0, 236610
GlobalTracer [candidate] (236.484 ms) : 0, 236484
AppSec [baseline] (175.887 ms) : 0, 175887
AppSec [candidate] (174.632 ms) : 0, 174632
Debugger [baseline] (5.953 ms) : 0, 5953
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (618.81 µs) : 0, 619
Remote Config [candidate] (620.34 µs) : 0, 620
Telemetry [baseline] (7.433 ms) : 0, 7433
Telemetry [candidate] (8.489 ms) : 0, 8489
IAST [baseline] (21.703 ms) : 0, 21703
IAST [candidate] (21.591 ms) : 0, 21591
section iast
BytebuddyAgent [baseline] (806.579 ms) : 0, 806579
BytebuddyAgent [candidate] (806.369 ms) : 0, 806369
GlobalTracer [baseline] (231.882 ms) : 0, 231882
GlobalTracer [candidate] (231.597 ms) : 0, 231597
AppSec [baseline] (49.588 ms) : 0, 49588
AppSec [candidate] (49.76 ms) : 0, 49760
Debugger [baseline] (5.917 ms) : 0, 5917
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (606.001 µs) : 0, 606
Remote Config [candidate] (588.114 µs) : 0, 588
Telemetry [baseline] (7.957 ms) : 0, 7957
Telemetry [candidate] (7.948 ms) : 0, 7948
IAST [baseline] (28.529 ms) : 0, 28529
IAST [candidate] (29.345 ms) : 0, 29345
section profiling
BytebuddyAgent [baseline] (672.774 ms) : 0, 672774
BytebuddyAgent [candidate] (672.071 ms) : 0, 672071
GlobalTracer [baseline] (375.096 ms) : 0, 375096
GlobalTracer [candidate] (373.4 ms) : 0, 373400
AppSec [baseline] (62.026 ms) : 0, 62026
AppSec [candidate] (61.93 ms) : 0, 61930
Debugger [baseline] (6.26 ms) : 0, 6260
Debugger [candidate] (6.261 ms) : 0, 6261
Remote Config [baseline] (646.118 µs) : 0, 646
Remote Config [candidate] (648.912 µs) : 0, 649
Telemetry [baseline] (8.137 ms) : 0, 8137
Telemetry [candidate] (8.171 ms) : 0, 8171
ProfilingAgent [baseline] (102.827 ms) : 0, 102827
ProfilingAgent [candidate] (103.124 ms) : 0, 103124
Profiling [baseline] (102.852 ms) : 0, 102852
Profiling [candidate] (103.147 ms) : 0, 103147

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026298
Total [baseline] (8.65 s) : 0, 8650305
Agent [candidate] (1.026 s) : 0, 1026181
Total [candidate] (8.679 s) : 0, 8679184
section iast
Agent [baseline] (1.154 s) : 0, 1154390
Total [baseline] (9.224 s) : 0, 9223827
Agent [candidate] (1.154 s) : 0, 1154357
Total [candidate] (9.253 s) : 0, 9253422
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.156 s) : 0, 1155581
Total [baseline] (9.239 s) : 0, 9239225
Agent [candidate] (1.156 s) : 0, 1155999
Total [candidate] (9.232 s) : 0, 9232020
section iast_TELEMETRY_OFF
Agent [baseline] (1.149 s) : 0, 1149043
Total [baseline] (9.18 s) : 0, 9179925
Agent [candidate] (1.143 s) : 0, 1143168
Total [candidate] (9.181 s) : 0, 9181348

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	iast	1.154 s	128.092 ms (12.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.156 s	129.283 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.149 s	122.745 ms (12.0%)
Total	tracing	8.65 s	-
Total	iast	9.224 s	573.522 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.239 s	588.92 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.18 s	529.621 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	iast	1.154 s	128.177 ms (12.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.156 s	129.818 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.143 s	116.988 ms (11.4%)
Total	tracing	8.679 s	-
Total	iast	9.253 s	574.237 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.232 s	552.836 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.181 s	502.164 ms (5.8%)

gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.838 ms) : 0, 686838
BytebuddyAgent [candidate] (687.102 ms) : 0, 687102
GlobalTracer [baseline] (241.335 ms) : 0, 241335
GlobalTracer [candidate] (241.461 ms) : 0, 241461
AppSec [baseline] (54.772 ms) : 0, 54772
AppSec [candidate] (55.074 ms) : 0, 55074
Debugger [baseline] (9.062 ms) : 0, 9062
Debugger [candidate] (8.297 ms) : 0, 8297
Remote Config [baseline] (719.037 µs) : 0, 719
Remote Config [candidate] (707.573 µs) : 0, 708
Telemetry [baseline] (9.866 ms) : 0, 9866
Telemetry [candidate] (9.865 ms) : 0, 9865
section iast
BytebuddyAgent [baseline] (806.557 ms) : 0, 806557
BytebuddyAgent [candidate] (805.365 ms) : 0, 805365
GlobalTracer [baseline] (231.111 ms) : 0, 231111
GlobalTracer [candidate] (232.118 ms) : 0, 232118
IAST [baseline] (28.472 ms) : 0, 28472
IAST [candidate] (30.03 ms) : 0, 30030
AppSec [baseline] (50.329 ms) : 0, 50329
AppSec [candidate] (48.859 ms) : 0, 48859
Debugger [baseline] (5.929 ms) : 0, 5929
Debugger [candidate] (5.901 ms) : 0, 5901
Remote Config [baseline] (594.67 µs) : 0, 595
Remote Config [candidate] (591.233 µs) : 0, 591
Telemetry [baseline] (7.832 ms) : 0, 7832
Telemetry [candidate] (7.905 ms) : 0, 7905
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.624 ms) : 0, 806624
BytebuddyAgent [candidate] (807.064 ms) : 0, 807064
GlobalTracer [baseline] (231.538 ms) : 0, 231538
GlobalTracer [candidate] (231.53 ms) : 0, 231530
IAST [baseline] (28.7 ms) : 0, 28700
IAST [candidate] (29.476 ms) : 0, 29476
AppSec [baseline] (50.633 ms) : 0, 50633
AppSec [candidate] (49.713 ms) : 0, 49713
Debugger [baseline] (5.909 ms) : 0, 5909
Debugger [candidate] (5.957 ms) : 0, 5957
Remote Config [baseline] (604.966 µs) : 0, 605
Remote Config [candidate] (608.737 µs) : 0, 609
Telemetry [baseline] (7.975 ms) : 0, 7975
Telemetry [candidate] (7.987 ms) : 0, 7987
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.002 ms) : 0, 802002
BytebuddyAgent [candidate] (797.642 ms) : 0, 797642
GlobalTracer [baseline] (230.87 ms) : 0, 230870
GlobalTracer [candidate] (229.831 ms) : 0, 229831
IAST [baseline] (23.317 ms) : 0, 23317
IAST [candidate] (22.177 ms) : 0, 22177
AppSec [baseline] (55.124 ms) : 0, 55124
AppSec [candidate] (55.848 ms) : 0, 55848
Debugger [baseline] (5.937 ms) : 0, 5937
Debugger [candidate] (5.878 ms) : 0, 5878
Remote Config [baseline] (602.145 µs) : 0, 602
Remote Config [candidate] (590.339 µs) : 0, 590
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.703 ms) : 0, 7703

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-16T13:12:42	2025-05-16T13:20:28
git_branch	master	mcculls/widen-lazy-coroutine-check
git_commit_date	1747400001	1747400451
git_commit_sha	`cd3218a`	`607894b`
release_version	1.50.0-SNAPSHOT~cd3218a06a	1.50.0-SNAPSHOT~607894bd2b
start_time	2025-05-16T13:12:28	2025-05-16T13:20:14

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1747402027	1747402027
ci_job_id	941615753	941615753
ci_pipeline_id	65319142	65319142
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-thkehp5s-project-304-concurrent-3-6kaj488o 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-thkehp5s-project-304-concurrent-3-6kaj488o 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (383.831 µs) : 364, 404
. : milestone, 384,
iast (516.517 µs) : 495, 538
. : milestone, 517,
iast_FULL (730.539 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (568.14 µs) : 545, 592
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (516.653 µs) : 493, 540
. : milestone, 517,
iast_INACTIVE (466.171 µs) : 444, 489
. : milestone, 466,
iast_TELEMETRY_OFF (510.037 µs) : 486, 534
. : milestone, 510,
tracing (455.937 µs) : 434, 478
. : milestone, 456,
section candidate
no_agent (381.985 µs) : 362, 402
. : milestone, 382,
iast (517.018 µs) : 495, 539
. : milestone, 517,
iast_FULL (733.838 µs) : 712, 756
. : milestone, 734,
iast_GLOBAL (569.276 µs) : 547, 592
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (518.586 µs) : 496, 541
. : milestone, 519,
iast_INACTIVE (470.17 µs) : 447, 493
. : milestone, 470,
iast_TELEMETRY_OFF (517.636 µs) : 494, 541
. : milestone, 518,
tracing (464.94 µs) : 442, 488
. : milestone, 465,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.831 µs [363.673 µs, 403.99 µs]	-
iast	516.517 µs [494.628 µs, 538.406 µs]	132.686 µs (34.6%)
iast_FULL	730.539 µs [708.567 µs, 752.512 µs]	346.708 µs (90.3%)
iast_GLOBAL	568.14 µs [544.743 µs, 591.536 µs]	184.308 µs (48.0%)
iast_HARDCODED_SECRET_DISABLED	516.653 µs [493.274 µs, 540.032 µs]	132.821 µs (34.6%)
iast_INACTIVE	466.171 µs [443.655 µs, 488.687 µs]	82.34 µs (21.5%)
iast_TELEMETRY_OFF	510.037 µs [485.886 µs, 534.188 µs]	126.205 µs (32.9%)
tracing	455.937 µs [434.24 µs, 477.634 µs]	72.106 µs (18.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.985 µs [362.177 µs, 401.792 µs]	-
iast	517.018 µs [495.104 µs, 538.931 µs]	135.033 µs (35.4%)
iast_FULL	733.838 µs [712.047 µs, 755.629 µs]	351.853 µs (92.1%)
iast_GLOBAL	569.276 µs [546.898 µs, 591.654 µs]	187.292 µs (49.0%)
iast_HARDCODED_SECRET_DISABLED	518.586 µs [495.891 µs, 541.281 µs]	136.601 µs (35.8%)
iast_INACTIVE	470.17 µs [447.367 µs, 492.972 µs]	88.185 µs (23.1%)
iast_TELEMETRY_OFF	517.636 µs [494.458 µs, 540.814 µs]	135.652 µs (35.5%)
tracing	464.94 µs [442.268 µs, 487.612 µs]	82.956 µs (21.7%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (1.367 ms) : 1347, 1387
. : milestone, 1367,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.746 ms) : 1722, 1769
. : milestone, 1746,
code_origins (1.664 ms) : 1637, 1691
. : milestone, 1664,
iast (1.528 ms) : 1504, 1552
. : milestone, 1528,
profiling (1.513 ms) : 1489, 1537
. : milestone, 1513,
tracing (1.489 ms) : 1466, 1512
. : milestone, 1489,
section candidate
no_agent (1.372 ms) : 1352, 1391
. : milestone, 1372,
appsec (1.744 ms) : 1720, 1768
. : milestone, 1744,
appsec_no_iast (1.724 ms) : 1701, 1747
. : milestone, 1724,
code_origins (1.675 ms) : 1648, 1702
. : milestone, 1675,
iast (1.523 ms) : 1497, 1549
. : milestone, 1523,
profiling (1.511 ms) : 1487, 1534
. : milestone, 1511,
tracing (1.514 ms) : 1489, 1539
. : milestone, 1514,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.367 ms [1.347 ms, 1.387 ms]	-
appsec	1.739 ms [1.715 ms, 1.763 ms]	371.958 µs (27.2%)
appsec_no_iast	1.746 ms [1.722 ms, 1.769 ms]	378.728 µs (27.7%)
code_origins	1.664 ms [1.637 ms, 1.691 ms]	297.287 µs (21.7%)
iast	1.528 ms [1.504 ms, 1.552 ms]	160.763 µs (11.8%)
profiling	1.513 ms [1.489 ms, 1.537 ms]	146.122 µs (10.7%)
tracing	1.489 ms [1.466 ms, 1.512 ms]	122.071 µs (8.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.372 ms [1.352 ms, 1.391 ms]	-
appsec	1.744 ms [1.72 ms, 1.768 ms]	372.489 µs (27.2%)
appsec_no_iast	1.724 ms [1.701 ms, 1.747 ms]	352.594 µs (25.7%)
code_origins	1.675 ms [1.648 ms, 1.702 ms]	303.079 µs (22.1%)
iast	1.523 ms [1.497 ms, 1.549 ms]	151.594 µs (11.1%)
profiling	1.511 ms [1.487 ms, 1.534 ms]	138.944 µs (10.1%)
tracing	1.514 ms [1.489 ms, 1.539 ms]	142.397 µs (10.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/widen-lazy-coroutine-check
git_commit_date	1747400001	1747400451
git_commit_sha	`cd3218a`	`607894b`
release_version	1.50.0-SNAPSHOT~cd3218a06a	1.50.0-SNAPSHOT~607894bd2b

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1747402570	1747402570
ci_job_id	941615754	941615754
ci_pipeline_id	65319142	65319142
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-px6-mzwm-project-304-concurrent-1-vowv0aox 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-px6-mzwm-project-304-concurrent-1-vowv0aox 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
appsec (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
iast (18.941 s) : 18941000, 18941000
. : milestone, 18941000,
iast_GLOBAL (18.117 s) : 18117000, 18117000
. : milestone, 18117000,
profiling (15.399 s) : 15399000, 15399000
. : milestone, 15399000,
tracing (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
section candidate
no_agent (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
appsec (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
iast (18.212 s) : 18212000, 18212000
. : milestone, 18212000,
iast_GLOBAL (18.289 s) : 18289000, 18289000
. : milestone, 18289000,
profiling (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
tracing (15.177 s) : 15177000, 15177000
. : milestone, 15177000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.814 s [14.814 s, 14.814 s]	-
appsec	15.196 s [15.196 s, 15.196 s]	382.0 ms (2.6%)
iast	18.941 s [18.941 s, 18.941 s]	4.127 s (27.9%)
iast_GLOBAL	18.117 s [18.117 s, 18.117 s]	3.303 s (22.3%)
profiling	15.399 s [15.399 s, 15.399 s]	585.0 ms (3.9%)
tracing	14.833 s [14.833 s, 14.833 s]	19.0 ms (0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.938 s [14.938 s, 14.938 s]	-
appsec	15.1 s [15.1 s, 15.1 s]	162.0 ms (1.1%)
iast	18.212 s [18.212 s, 18.212 s]	3.274 s (21.9%)
iast_GLOBAL	18.289 s [18.289 s, 18.289 s]	3.351 s (22.4%)
profiling	14.999 s [14.999 s, 14.999 s]	61.0 ms (0.4%)
tracing	15.177 s [15.177 s, 15.177 s]	239.0 ms (1.6%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~607894bd2b, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.422 ms) : 2373, 2472
. : milestone, 2422,
iast (2.198 ms) : 2136, 2260
. : milestone, 2198,
iast_GLOBAL (2.244 ms) : 2182, 2306
. : milestone, 2244,
profiling (2.066 ms) : 2014, 2118
. : milestone, 2066,
tracing (2.031 ms) : 1983, 2079
. : milestone, 2031,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.42 ms) : 2371, 2470
. : milestone, 2420,
iast (2.198 ms) : 2136, 2260
. : milestone, 2198,
iast_GLOBAL (2.246 ms) : 2183, 2308
. : milestone, 2246,
profiling (2.048 ms) : 1998, 2098
. : milestone, 2048,
tracing (2.024 ms) : 1976, 2073
. : milestone, 2024,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	2.422 ms [2.373 ms, 2.472 ms]	943.207 µs (63.8%)
iast	2.198 ms [2.136 ms, 2.26 ms]	718.73 µs (48.6%)
iast_GLOBAL	2.244 ms [2.182 ms, 2.306 ms]	764.761 µs (51.7%)
profiling	2.066 ms [2.014 ms, 2.118 ms]	586.816 µs (39.7%)
tracing	2.031 ms [1.983 ms, 2.079 ms]	551.937 µs (37.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.469 ms, 1.493 ms]	-
appsec	2.42 ms [2.371 ms, 2.47 ms]	939.484 µs (63.4%)
iast	2.198 ms [2.136 ms, 2.26 ms]	717.289 µs (48.4%)
iast_GLOBAL	2.246 ms [2.183 ms, 2.308 ms]	764.666 µs (51.6%)
profiling	2.048 ms [1.998 ms, 2.098 ms]	566.621 µs (38.3%)
tracing	2.024 ms [1.976 ms, 2.073 ms]	543.18 µs (36.7%)

amarziali

Nice catch. Thank you!

mcculls added type: feature Enhancements and improvements inst: kotlin Kotlin instrumentation labels May 16, 2025

mcculls marked this pull request as ready for review May 16, 2025 11:49

mcculls requested a review from a team as a code owner May 16, 2025 11:49

mcculls requested a review from amarziali May 16, 2025 11:49

mcculls added the tag: no release notes Changes to exclude from release notes label May 16, 2025

amarziali approved these changes May 16, 2025
View reviewed changes

Widen lazy coroutine matcher to cover all definitions of onStart
607894b

mcculls force-pushed the mcculls/widen-lazy-coroutine-check branch from e95c9d1 to 607894bCompare May 16, 2025 13:01

mcculls merged commit b4aebf8 into masterMay 16, 2025

mcculls deleted the mcculls/widen-lazy-coroutine-check branch May 16, 2025 14:12

github-actionsBot added this to the 1.50.0 milestone May 16, 2025

Navigation Menu

Uh oh!

Widen lazy coroutine matcher to cover all definitions of onStart - #8838

Widen lazy coroutine matcher to cover all definitions of onStart#8838
mcculls merged 1 commit into
masterfrom
mcculls/widen-lazy-coroutine-check

mcculls commented May 16, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented May 16, 2025•
edited
Loading

Uh oh!

amarziali left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mcculls commented May 16, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Contributor Checklist

Uh oh!

pr-commenterBot commented May 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcculls commented May 16, 2025•
edited by atlassian Bot
Loading

pr-commenterBot commented May 16, 2025•
edited
Loading