Uh oh!
There was an error while loading. Please reload this page.
🍒 8902 - Ensure auto-detected service name is the same for every process in the same build - #8930
Closed
nikita-tkachenko-datadog wants to merge 1 commit into
Closed
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
June 5, 2025 11:43
daniel-mohedano
approved these changes
Jun 5, 2025
nikita-tkachenko-datadog
enabled auto-merge (squash)
June 5, 2025 11:47
BenchmarksStartupParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030102
Total [baseline] (8.543 s) : 0, 8542588
Agent [candidate] (1.006 s) : 0, 1005988
Total [candidate] (8.492 s) : 0, 8492313
section iast
Agent [baseline] (1.151 s) : 0, 1150900
Total [baseline] (9.194 s) : 0, 9193920
Agent [candidate] (1.136 s) : 0, 1136281
Total [candidate] (9.225 s) : 0, 9224936
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.149 s) : 0, 1148594
Total [baseline] (9.156 s) : 0, 9155855
Agent [candidate] (1.149 s) : 0, 1149300
Total [candidate] (9.276 s) : 0, 9275731
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1151552
Total [baseline] (9.211 s) : 0, 9210649
Agent [candidate] (1.134 s) : 0, 1134262
Total [candidate] (9.202 s) : 0, 9201979
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.804 ms) : 0, 687804
BytebuddyAgent [candidate] (669.08 ms) : 0, 669080
GlobalTracer [baseline] (241.541 ms) : 0, 241541
GlobalTracer [candidate] (239.457 ms) : 0, 239457
AppSec [baseline] (58.672 ms) : 0, 58672
AppSec [candidate] (54.757 ms) : 0, 54757
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.265 ms) : 0, 6265
Remote Config [baseline] (740.887 µs) : 0, 741
Remote Config [candidate] (738.911 µs) : 0, 739
Telemetry [baseline] (11.416 ms) : 0, 11416
Telemetry [candidate] (12.232 ms) : 0, 12232
section iast
BytebuddyAgent [baseline] (802.643 ms) : 0, 802643
BytebuddyAgent [candidate] (789.372 ms) : 0, 789372
GlobalTracer [baseline] (230.995 ms) : 0, 230995
GlobalTracer [candidate] (229.822 ms) : 0, 229822
IAST [baseline] (25.325 ms) : 0, 25325
IAST [candidate] (22.945 ms) : 0, 22945
AppSec [baseline] (53.979 ms) : 0, 53979
AppSec [candidate] (56.452 ms) : 0, 56452
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.882 ms) : 0, 5882
Remote Config [baseline] (603.928 µs) : 0, 604
Remote Config [candidate] (597.137 µs) : 0, 597
Telemetry [baseline] (7.878 ms) : 0, 7878
Telemetry [candidate] (7.85 ms) : 0, 7850
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.526 ms) : 0, 800526
BytebuddyAgent [candidate] (797.248 ms) : 0, 797248
GlobalTracer [baseline] (230.053 ms) : 0, 230053
GlobalTracer [candidate] (233.244 ms) : 0, 233244
IAST [baseline] (27.381 ms) : 0, 27381
IAST [candidate] (23.282 ms) : 0, 23282
AppSec [baseline] (52.624 ms) : 0, 52624
AppSec [candidate] (57.34 ms) : 0, 57340
Debugger [baseline] (5.967 ms) : 0, 5967
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (606.589 µs) : 0, 607
Remote Config [candidate] (606.664 µs) : 0, 607
Telemetry [baseline] (7.991 ms) : 0, 7991
Telemetry [candidate] (7.977 ms) : 0, 7977
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.108 ms) : 0, 803108
BytebuddyAgent [candidate] (787.656 ms) : 0, 787656
GlobalTracer [baseline] (230.832 ms) : 0, 230832
GlobalTracer [candidate] (230.46 ms) : 0, 230460
IAST [baseline] (27.429 ms) : 0, 27429
IAST [candidate] (22.352 ms) : 0, 22352
AppSec [baseline] (52.007 ms) : 0, 52007
AppSec [candidate] (56.054 ms) : 0, 56054
Debugger [baseline] (6.039 ms) : 0, 6039
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (628.039 µs) : 0, 628
Remote Config [candidate] (612.888 µs) : 0, 613
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.762 ms) : 0, 7762
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026978
Total [baseline] (11.172 s) : 0, 11171605
Agent [candidate] (1.014 s) : 0, 1014194
Total [candidate] (11.142 s) : 0, 11141969
section appsec
Agent [baseline] (1.169 s) : 0, 1168552
Total [baseline] (11.254 s) : 0, 11254311
Agent [candidate] (1.152 s) : 0, 1151742
Total [candidate] (11.209 s) : 0, 11208650
section iast
Agent [baseline] (1.151 s) : 0, 1150921
Total [baseline] (11.403 s) : 0, 11403396
Agent [candidate] (1.138 s) : 0, 1137857
Total [candidate] (11.285 s) : 0, 11284506
section profiling
Agent [baseline] (1.27 s) : 0, 1270398
Total [baseline] (11.514 s) : 0, 11514346
Agent [candidate] (1.265 s) : 0, 1265280
Total [candidate] (11.51 s) : 0, 11510090
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.363 ms) : 0, 684363
BytebuddyAgent [candidate] (674.38 ms) : 0, 674380
GlobalTracer [baseline] (240.937 ms) : 0, 240937
GlobalTracer [candidate] (239.997 ms) : 0, 239997
AppSec [baseline] (56.59 ms) : 0, 56590
AppSec [candidate] (54.746 ms) : 0, 54746
Debugger [baseline] (6.244 ms) : 0, 6244
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (749.145 µs) : 0, 749
Remote Config [candidate] (711.976 µs) : 0, 712
Telemetry [baseline] (14.427 ms) : 0, 14427
Telemetry [candidate] (14.405 ms) : 0, 14405
section appsec
BytebuddyAgent [baseline] (704.699 ms) : 0, 704699
BytebuddyAgent [candidate] (690.33 ms) : 0, 690330
GlobalTracer [baseline] (238.281 ms) : 0, 238281
GlobalTracer [candidate] (236.82 ms) : 0, 236820
AppSec [baseline] (176.353 ms) : 0, 176353
AppSec [candidate] (174.979 ms) : 0, 174979
Debugger [baseline] (5.998 ms) : 0, 5998
Debugger [candidate] (5.908 ms) : 0, 5908
Remote Config [baseline] (635.654 µs) : 0, 636
Remote Config [candidate] (616.521 µs) : 0, 617
Telemetry [baseline] (7.828 ms) : 0, 7828
Telemetry [candidate] (8.567 ms) : 0, 8567
IAST [baseline] (22.063 ms) : 0, 22063
IAST [candidate] (21.89 ms) : 0, 21890
section iast
BytebuddyAgent [baseline] (802.232 ms) : 0, 802232
BytebuddyAgent [candidate] (790.174 ms) : 0, 790174
GlobalTracer [baseline] (230.486 ms) : 0, 230486
GlobalTracer [candidate] (230.649 ms) : 0, 230649
AppSec [baseline] (53.0 ms) : 0, 53000
AppSec [candidate] (56.695 ms) : 0, 56695
Debugger [baseline] (6.015 ms) : 0, 6015
Debugger [candidate] (5.864 ms) : 0, 5864
Remote Config [baseline] (617.68 µs) : 0, 618
Remote Config [candidate] (584.44 µs) : 0, 584
Telemetry [baseline] (8.036 ms) : 0, 8036
Telemetry [candidate] (7.864 ms) : 0, 7864
IAST [baseline] (26.962 ms) : 0, 26962
IAST [candidate] (22.595 ms) : 0, 22595
section profiling
ProfilingAgent [baseline] (103.144 ms) : 0, 103144
ProfilingAgent [candidate] (96.431 ms) : 0, 96431
BytebuddyAgent [baseline] (679.019 ms) : 0, 679019
BytebuddyAgent [candidate] (667.434 ms) : 0, 667434
GlobalTracer [baseline] (361.0 ms) : 0, 361000
GlobalTracer [candidate] (382.042 ms) : 0, 382042
AppSec [baseline] (61.41 ms) : 0, 61410
AppSec [candidate] (53.947 ms) : 0, 53947
Debugger [baseline] (6.035 ms) : 0, 6035
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (653.587 µs) : 0, 654
Remote Config [candidate] (663.554 µs) : 0, 664
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (8.131 ms) : 0, 8131
Profiling [baseline] (103.167 ms) : 0, 103167
Profiling [candidate] (96.454 ms) : 0, 96454
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 5 metrics, 21 unstable metrics.
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.398 ms) : 2349, 2447
. : milestone, 2398,
iast (2.195 ms) : 2132, 2257
. : milestone, 2195,
iast_GLOBAL (2.228 ms) : 2166, 2291
. : milestone, 2228,
profiling (2.032 ms) : 1982, 2082
. : milestone, 2032,
tracing (2.018 ms) : 1970, 2067
. : milestone, 2018,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.4 ms) : 2350, 2449
. : milestone, 2400,
iast (2.183 ms) : 2122, 2245
. : milestone, 2183,
iast_GLOBAL (2.227 ms) : 2165, 2289
. : milestone, 2227,
profiling (2.026 ms) : 1977, 2076
. : milestone, 2026,
tracing (2.008 ms) : 1960, 2056
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (15.447 s) : 15447000, 15447000
. : milestone, 15447000,
appsec (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
iast (19.123 s) : 19123000, 19123000
. : milestone, 19123000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
. : milestone, 18022000,
profiling (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
tracing (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
section candidate
no_agent (15.534 s) : 15534000, 15534000
. : milestone, 15534000,
appsec (14.703 s) : 14703000, 14703000
. : milestone, 14703000,
iast (18.31 s) : 18310000, 18310000
. : milestone, 18310000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
. : milestone, 17981000,
profiling (15.38 s) : 15380000, 15380000
. : milestone, 15380000,
tracing (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
|
| } else { | ||
| serviceNameSetByUser = true; | ||
| // might be an auto-detected name propagated from instrumented parent process | ||
| serviceNameSetByUser = configProvider.getBoolean(SERVICE_NAME_SET_BY_USER, true); |
Contributor
There was a problem hiding this comment.
Why this has been parametrized with a config flag? This flag is controlling few mechanisms on the service naming and I'm not sure that should modified in this way. If the parent process propagates DD_SERVICE that flag will be set to true as expected. Would that fix have just worked without changing that?
auto-merge was automatically disabled
June 5, 2025 13:49
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8902 to release/v1.49.x