Fix AssertionError when ServiceTalk context captured with no activeSpan by ygree · Pull Request #8951 · DataDog/dd-trace-java

ygree · 2025-06-09T23:46:42Z

What Does This Do

Fixes

java.lang.AssertionError
at datadog.trace.core.scopemanager.ContinuableScopeManager.activate(ContinuableScopeManager.java:144)
at datadog.trace.core.scopemanager.ContinuableScopeManager.activateSpan(ContinuableScopeManager.java:94)
at datadog.trace.core.CoreTracer.activateSpan(CoreTracer.java:906)
at org.spockframework.mock.runtime.ByteBuddyMethodInvoker.respond(ByteBuddyMethodInvoker.java:20)
at org.spockframework.mock.runtime.MockInvocation.callRealMethod(MockInvocation.java:61)
at org.spockframework.mock.CallRealMethodResponse.respond(CallRealMethodResponse.java:30)
at org.spockframework.mock.runtime.MockController.handle(MockController.java:50)
at org.spockframework.mock.runtime.JavaMockInterceptor.intercept(JavaMockInterceptor.java:86)
at org.spockframework.mock.runtime.ByteBuddyInterceptorAdapter.interceptNonAbstract(ByteBuddyInterceptorAdapter.java:35)
at datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan(AgentTracer.java:87)
at datadog.trace.instrumentation.servicetalk0_42_56.DatadogCapturedContextProvider$WithDatadogCapturedContext.attachContext(DatadogCapturedContextProvider.java:43)
at ContextPreservingInstrumentationTest.capturedContext without activeSpan_closure4(ContextPreservingInstrumentationTest.groovy:37)
at ContextPreservingInstrumentationTest.capturedContext without activeSpan_closure4(ContextPreservingInstrumentationTest.groovy)
at groovy.lang.Closure.call(Closure.java:412)
at groovy.lang.Closure.call(Closure.java:406)
at groovy.lang.Closure.run(Closure.java:493)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)

Motivation

Fix for #8821

Additional Notes

Should be part of the 1.50.0 release as it's a critical fix for #8821

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-06-10T00:25:31Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/fix-servicetalk-assertion-error
git_commit_date	1750101616	1750101988
git_commit_sha	`3e93f43`	`140762e`
release_version	1.50.0-SNAPSHOT~3e93f43e63	1.50.0-SNAPSHOT~140762e689

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750104270	1750104270
ci_job_id	984503019	984503019
ci_pipeline_id	67904178	67904178
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xrgra1j9-project-304-concurrent-0-sxkt3vlk 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xrgra1j9-project-304-concurrent-0-sxkt3vlk 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031632
Total [baseline] (8.533 s) : 0, 8532521
Agent [candidate] (1.035 s) : 0, 1035314
Total [candidate] (8.548 s) : 0, 8547921
section iast
Agent [baseline] (1.16 s) : 0, 1160248
Total [baseline] (9.233 s) : 0, 9232822
Agent [candidate] (1.156 s) : 0, 1155903
Total [candidate] (9.228 s) : 0, 9227564
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.153 s) : 0, 1152745
Total [baseline] (9.171 s) : 0, 9170791
Agent [candidate] (1.161 s) : 0, 1161406
Total [candidate] (9.19 s) : 0, 9189652
section iast_TELEMETRY_OFF
Agent [baseline] (1.151 s) : 0, 1151491
Total [baseline] (9.18 s) : 0, 9179946
Agent [candidate] (1.157 s) : 0, 1157222
Total [candidate] (9.201 s) : 0, 9200673

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.032 s	-
Agent	iast	1.16 s	128.616 ms (12.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.153 s	121.112 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.151 s	119.858 ms (11.6%)
Total	tracing	8.533 s	-
Total	iast	9.233 s	700.301 ms (8.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.171 s	638.27 ms (7.5%)
Total	iast_TELEMETRY_OFF	9.18 s	647.425 ms (7.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.035 s	-
Agent	iast	1.156 s	120.589 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.161 s	126.092 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.157 s	121.908 ms (11.8%)
Total	tracing	8.548 s	-
Total	iast	9.228 s	679.643 ms (8.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.19 s	641.731 ms (7.5%)
Total	iast_TELEMETRY_OFF	9.201 s	652.752 ms (7.6%)

gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.268 ms) : 0, 688268
BytebuddyAgent [candidate] (689.071 ms) : 0, 689071
GlobalTracer [baseline] (241.975 ms) : 0, 241975
GlobalTracer [candidate] (242.431 ms) : 0, 242431
AppSec [baseline] (59.693 ms) : 0, 59693
AppSec [candidate] (60.21 ms) : 0, 60210
Debugger [baseline] (6.195 ms) : 0, 6195
Debugger [candidate] (6.207 ms) : 0, 6207
Remote Config [baseline] (738.511 µs) : 0, 739
Remote Config [candidate] (748.89 µs) : 0, 749
Telemetry [baseline] (11.244 ms) : 0, 11244
Telemetry [candidate] (12.969 ms) : 0, 12969
section iast
BytebuddyAgent [baseline] (808.486 ms) : 0, 808486
BytebuddyAgent [candidate] (805.064 ms) : 0, 805064
GlobalTracer [baseline] (231.878 ms) : 0, 231878
GlobalTracer [candidate] (231.132 ms) : 0, 231132
IAST [baseline] (26.245 ms) : 0, 26245
IAST [candidate] (28.581 ms) : 0, 28581
AppSec [baseline] (55.622 ms) : 0, 55622
AppSec [candidate] (53.155 ms) : 0, 53155
Debugger [baseline] (6.02 ms) : 0, 6020
Debugger [candidate] (6.017 ms) : 0, 6017
Remote Config [baseline] (609.96 µs) : 0, 610
Remote Config [candidate] (586.045 µs) : 0, 586
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.964 ms) : 0, 7964
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.289 ms) : 0, 802289
BytebuddyAgent [candidate] (808.817 ms) : 0, 808817
GlobalTracer [baseline] (230.638 ms) : 0, 230638
GlobalTracer [candidate] (232.107 ms) : 0, 232107
IAST [baseline] (28.666 ms) : 0, 28666
IAST [candidate] (27.925 ms) : 0, 27925
AppSec [baseline] (53.21 ms) : 0, 53210
AppSec [candidate] (54.431 ms) : 0, 54431
Debugger [baseline] (6.052 ms) : 0, 6052
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (592.526 µs) : 0, 593
Remote Config [candidate] (606.581 µs) : 0, 607
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.945 ms) : 0, 7945
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.254 ms) : 0, 801254
BytebuddyAgent [candidate] (805.499 ms) : 0, 805499
GlobalTracer [baseline] (231.325 ms) : 0, 231325
GlobalTracer [candidate] (232.361 ms) : 0, 232361
IAST [baseline] (27.893 ms) : 0, 27893
IAST [candidate] (28.939 ms) : 0, 28939
AppSec [baseline] (53.183 ms) : 0, 53183
AppSec [candidate] (52.379 ms) : 0, 52379
Debugger [baseline] (6.044 ms) : 0, 6044
Debugger [candidate] (6.027 ms) : 0, 6027
Remote Config [baseline] (590.366 µs) : 0, 590
Remote Config [candidate] (599.527 µs) : 0, 600
Telemetry [baseline] (7.791 ms) : 0, 7791
Telemetry [candidate] (7.909 ms) : 0, 7909

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029286
Total [baseline] (10.63 s) : 0, 10630175
Agent [candidate] (1.026 s) : 0, 1026114
Total [candidate] (10.689 s) : 0, 10688765
section appsec
Agent [baseline] (1.177 s) : 0, 1176874
Total [baseline] (10.678 s) : 0, 10678219
Agent [candidate] (1.177 s) : 0, 1177377
Total [candidate] (10.729 s) : 0, 10728833
section iast
Agent [baseline] (1.155 s) : 0, 1155499
Total [baseline] (10.854 s) : 0, 10854025
Agent [candidate] (1.154 s) : 0, 1154078
Total [candidate] (10.962 s) : 0, 10961828
section profiling
Agent [baseline] (1.28 s) : 0, 1280379
Total [baseline] (10.872 s) : 0, 10871975
Agent [candidate] (1.28 s) : 0, 1279647
Total [candidate] (10.968 s) : 0, 10967589

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.177 s	147.588 ms (14.3%)
Agent	iast	1.155 s	126.213 ms (12.3%)
Agent	profiling	1.28 s	251.092 ms (24.4%)
Total	tracing	10.63 s	-
Total	appsec	10.678 s	48.044 ms (0.5%)
Total	iast	10.854 s	223.85 ms (2.1%)
Total	profiling	10.872 s	241.8 ms (2.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	appsec	1.177 s	151.263 ms (14.7%)
Agent	iast	1.154 s	127.964 ms (12.5%)
Agent	profiling	1.28 s	253.533 ms (24.7%)
Total	tracing	10.689 s	-
Total	appsec	10.729 s	40.068 ms (0.4%)
Total	iast	10.962 s	273.063 ms (2.6%)
Total	profiling	10.968 s	278.824 ms (2.6%)

gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.388 ms) : 0, 684388
BytebuddyAgent [candidate] (683.786 ms) : 0, 683786
GlobalTracer [baseline] (241.441 ms) : 0, 241441
GlobalTracer [candidate] (240.564 ms) : 0, 240564
AppSec [baseline] (61.174 ms) : 0, 61174
AppSec [candidate] (60.336 ms) : 0, 60336
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (718.948 µs) : 0, 719
Remote Config [candidate] (730.317 µs) : 0, 730
Telemetry [baseline] (11.981 ms) : 0, 11981
Telemetry [candidate] (11.266 ms) : 0, 11266
section appsec
BytebuddyAgent [baseline] (705.231 ms) : 0, 705231
BytebuddyAgent [candidate] (705.17 ms) : 0, 705170
GlobalTracer [baseline] (234.304 ms) : 0, 234304
GlobalTracer [candidate] (234.426 ms) : 0, 234426
IAST [baseline] (21.694 ms) : 0, 21694
IAST [candidate] (21.773 ms) : 0, 21773
AppSec [baseline] (178.342 ms) : 0, 178342
AppSec [candidate] (178.991 ms) : 0, 178991
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.84 ms) : 0, 5840
Remote Config [baseline] (600.963 µs) : 0, 601
Remote Config [candidate] (604.213 µs) : 0, 604
Telemetry [baseline] (7.286 ms) : 0, 7286
Telemetry [candidate] (7.198 ms) : 0, 7198
section iast
BytebuddyAgent [baseline] (804.004 ms) : 0, 804004
BytebuddyAgent [candidate] (803.298 ms) : 0, 803298
GlobalTracer [baseline] (231.451 ms) : 0, 231451
GlobalTracer [candidate] (231.05 ms) : 0, 231050
IAST [baseline] (27.771 ms) : 0, 27771
IAST [candidate] (26.975 ms) : 0, 26975
AppSec [baseline] (54.221 ms) : 0, 54221
AppSec [candidate] (54.851 ms) : 0, 54851
Debugger [baseline] (6.023 ms) : 0, 6023
Debugger [candidate] (5.995 ms) : 0, 5995
Remote Config [baseline] (579.517 µs) : 0, 580
Remote Config [candidate] (587.364 µs) : 0, 587
Telemetry [baseline] (7.905 ms) : 0, 7905
Telemetry [candidate] (7.895 ms) : 0, 7895
section profiling
BytebuddyAgent [baseline] (679.499 ms) : 0, 679499
BytebuddyAgent [candidate] (679.624 ms) : 0, 679624
GlobalTracer [baseline] (362.682 ms) : 0, 362682
GlobalTracer [candidate] (361.485 ms) : 0, 361485
AppSec [baseline] (64.942 ms) : 0, 64942
AppSec [candidate] (64.626 ms) : 0, 64626
Debugger [baseline] (6.208 ms) : 0, 6208
Debugger [candidate] (6.119 ms) : 0, 6119
Remote Config [baseline] (677.398 µs) : 0, 677
Remote Config [candidate] (643.768 µs) : 0, 644
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.111 ms) : 0, 8111
ProfilingAgent [baseline] (107.123 ms) : 0, 107123
ProfilingAgent [candidate] (107.944 ms) : 0, 107944
Profiling [baseline] (107.148 ms) : 0, 107148
Profiling [candidate] (107.97 ms) : 0, 107970

Load

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section baseline
no_agent (8.68 ms) : 8657, 8703
. : milestone, 8680,
appsec (40.846 ms) : 40305, 41386
. : milestone, 40846,
code_origins (54.774 ms) : 53622, 55926
. : milestone, 54774,
iast (48.884 ms) : 48188, 49580
. : milestone, 48884,
profiling (10.793 ms) : 10717, 10870
. : milestone, 10793,
tracing (7.858 ms) : 7833, 7883
. : milestone, 7858,
section candidate
no_agent (76.469 ms) : 74740, 78198
. : milestone, 76469,
appsec (96.64 ms) : 93597, 99683
. : milestone, 96640,
code_origins (109.693 ms) : 102985, 116401
. : milestone, 109693,
iast (104.249 ms) : 99888, 108611
. : milestone, 104249,
profiling (89.686 ms) : 87329, 92043
. : milestone, 89686,
tracing (82.518 ms) : 80547, 84488
. : milestone, 82518,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	8.68 ms [8.657 ms, 8.703 ms]	-
appsec	40.846 ms [40.305 ms, 41.386 ms]	32.166 ms (370.6%)
code_origins	54.774 ms [53.622 ms, 55.926 ms]	46.094 ms (531.0%)
iast	48.884 ms [48.188 ms, 49.58 ms]	40.204 ms (463.2%)
profiling	10.793 ms [10.717 ms, 10.87 ms]	2.113 ms (24.3%)
tracing	7.858 ms [7.833 ms, 7.883 ms]	-821.683 µs (-9.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	76.469 ms [74.74 ms, 78.198 ms]	-
appsec	96.64 ms [93.597 ms, 99.683 ms]	20.171 ms (26.4%)
code_origins	109.693 ms [102.985 ms, 116.401 ms]	33.224 ms (43.4%)
iast	104.249 ms [99.888 ms, 108.611 ms]	27.78 ms (36.3%)
profiling	89.686 ms [87.329 ms, 92.043 ms]	13.217 ms (17.3%)
tracing	82.518 ms [80.547 ms, 84.488 ms]	6.049 ms (7.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/fix-servicetalk-assertion-error
git_commit_date	1750101616	1750101988
git_commit_sha	`3e93f43`	`140762e`
release_version	1.50.0-SNAPSHOT~3e93f43e63	1.50.0-SNAPSHOT~140762e689

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1750104043	1750104043
ci_job_id	984503021	984503021
ci_pipeline_id	67904178	67904178
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xrgra1j9-project-304-concurrent-1-uz5i6itt 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xrgra1j9-project-304-concurrent-1-uz5i6itt 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section baseline
no_agent (15.348 s) : 15348000, 15348000
. : milestone, 15348000,
appsec (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
iast (18.398 s) : 18398000, 18398000
. : milestone, 18398000,
iast_GLOBAL (18.27 s) : 18270000, 18270000
. : milestone, 18270000,
profiling (15.883 s) : 15883000, 15883000
. : milestone, 15883000,
tracing (14.714 s) : 14714000, 14714000
. : milestone, 14714000,
section candidate
no_agent (15.455 s) : 15455000, 15455000
. : milestone, 15455000,
appsec (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
iast (18.591 s) : 18591000, 18591000
. : milestone, 18591000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
profiling (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
tracing (14.913 s) : 14913000, 14913000
. : milestone, 14913000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.348 s [15.348 s, 15.348 s]	-
appsec	14.928 s [14.928 s, 14.928 s]	-420.0 ms (-2.7%)
iast	18.398 s [18.398 s, 18.398 s]	3.05 s (19.9%)
iast_GLOBAL	18.27 s [18.27 s, 18.27 s]	2.922 s (19.0%)
profiling	15.883 s [15.883 s, 15.883 s]	535.0 ms (3.5%)
tracing	14.714 s [14.714 s, 14.714 s]	-634.0 ms (-4.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.455 s [15.455 s, 15.455 s]	-
appsec	14.907 s [14.907 s, 14.907 s]	-548.0 ms (-3.5%)
iast	18.591 s [18.591 s, 18.591 s]	3.136 s (20.3%)
iast_GLOBAL	18.089 s [18.089 s, 18.089 s]	2.634 s (17.0%)
profiling	15.343 s [15.343 s, 15.343 s]	-112.0 ms (-0.7%)
tracing	14.913 s [14.913 s, 14.913 s]	-542.0 ms (-3.5%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.413 ms) : 2364, 2463
. : milestone, 2413,
iast (2.198 ms) : 2136, 2261
. : milestone, 2198,
iast_GLOBAL (2.237 ms) : 2174, 2299
. : milestone, 2237,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (2.013 ms) : 1964, 2061
. : milestone, 2013,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.416 ms) : 2367, 2465
. : milestone, 2416,
iast (2.21 ms) : 2148, 2273
. : milestone, 2210,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.031 ms) : 1981, 2081
. : milestone, 2031,
tracing (2.009 ms) : 1962, 2057
. : milestone, 2009,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	2.413 ms [2.364 ms, 2.463 ms]	933.96 µs (63.1%)
iast	2.198 ms [2.136 ms, 2.261 ms]	719.039 µs (48.6%)
iast_GLOBAL	2.237 ms [2.174 ms, 2.299 ms]	757.185 µs (51.2%)
profiling	2.04 ms [1.99 ms, 2.09 ms]	560.634 µs (37.9%)
tracing	2.013 ms [1.964 ms, 2.061 ms]	533.397 µs (36.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.467 ms, 1.49 ms]	-
appsec	2.416 ms [2.367 ms, 2.465 ms]	937.233 µs (63.4%)
iast	2.21 ms [2.148 ms, 2.273 ms]	731.835 µs (49.5%)
iast_GLOBAL	2.244 ms [2.181 ms, 2.307 ms]	765.211 µs (51.8%)
profiling	2.031 ms [1.981 ms, 2.081 ms]	552.526 µs (37.4%)
tracing	2.009 ms [1.962 ms, 2.057 ms]	530.711 µs (35.9%)

Fix AssertionError when ServiceTalk context captured with no activeSpan
5d5bac8

ygree added this to the 1.50.0 milestone Jun 9, 2025

ygree self-assigned this Jun 9, 2025

ygree added type: bug fix Bug fix inst: others All other instrumentations labels Jun 9, 2025

ygree marked this pull request as ready for review June 9, 2025 23:47

ygree requested a review from a team as a code owner June 9, 2025 23:47

ygree added 4 commits June 10, 2025 09:24

Merge branch 'master' into ygree/fix-servicetalk-assertion-error
aeeac4a

Merge branch 'master' into ygree/fix-servicetalk-assertion-error
75f78ff

Merge branch 'master' into ygree/fix-servicetalk-assertion-error
d86a4cd

Merge branch 'master' into ygree/fix-servicetalk-assertion-error
39c27f5

ygree added the tag: no release notes Changes to exclude from release notes label Jun 16, 2025

Merge branch 'master' into ygree/fix-servicetalk-assertion-error
140762e

amarziali approved these changes Jun 17, 2025
View reviewed changes

amarziali merged commit 7d0a7e8 into masterJun 17, 2025

amarziali deleted the ygree/fix-servicetalk-assertion-error branch June 17, 2025 07:08

Navigation Menu

Uh oh!

Fix AssertionError when ServiceTalk context captured with no activeSpan - #8951

Fix AssertionError when ServiceTalk context captured with no activeSpan#8951
amarziali merged 6 commits into
masterfrom
ygree/fix-servicetalk-assertion-error

ygree commented Jun 9, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Jun 10, 2025•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ygree commented Jun 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Jun 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ygree commented Jun 9, 2025•
edited
Loading

pr-commenterBot commented Jun 10, 2025•
edited
Loading