Uh oh!
There was an error while loading. Please reload this page.
Fix integration with the Tests observability product - #9008
Merged
Conversation
TovRudyyforce-pushed
the
olek.rudyy/overwrite-git-repository-url
branch
from
June 19, 2025 08:32
a0634d6 to
69c0d85CompareTovRudyyforce-pushed
the
olek.rudyy/overwrite-git-repository-url
branch
from
June 19, 2025 08:51
9e68999 to
4fd86dcCompareBenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026828
Total [baseline] (10.431 s) : 0, 10431352
Agent [candidate] (1.023 s) : 0, 1023342
Total [candidate] (10.558 s) : 0, 10557735
section appsec
Agent [baseline] (1.177 s) : 0, 1176681
Total [baseline] (10.694 s) : 0, 10693519
Agent [candidate] (1.179 s) : 0, 1179398
Total [candidate] (10.708 s) : 0, 10708297
section iast
Agent [baseline] (1.153 s) : 0, 1153064
Total [baseline] (10.849 s) : 0, 10849146
Agent [candidate] (1.153 s) : 0, 1152831
Total [candidate] (10.877 s) : 0, 10876873
section profiling
Agent [baseline] (1.264 s) : 0, 1263607
Total [baseline] (10.884 s) : 0, 10883823
Agent [candidate] (1.269 s) : 0, 1269425
Total [candidate] (10.908 s) : 0, 10908127
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.416 ms) : 0, 685416
BytebuddyAgent [candidate] (683.657 ms) : 0, 683657
GlobalTracer [baseline] (241.65 ms) : 0, 241650
GlobalTracer [candidate] (241.196 ms) : 0, 241196
AppSec [baseline] (59.899 ms) : 0, 59899
AppSec [candidate] (57.641 ms) : 0, 57641
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (6.863 ms) : 0, 6863
Remote Config [baseline] (721.152 µs) : 0, 721
Remote Config [candidate] (725.419 µs) : 0, 725
Telemetry [baseline] (9.511 ms) : 0, 9511
Telemetry [candidate] (9.819 ms) : 0, 9819
section appsec
BytebuddyAgent [baseline] (706.163 ms) : 0, 706163
BytebuddyAgent [candidate] (707.739 ms) : 0, 707739
GlobalTracer [baseline] (235.036 ms) : 0, 235036
GlobalTracer [candidate] (235.953 ms) : 0, 235953
IAST [baseline] (21.805 ms) : 0, 21805
IAST [candidate] (21.778 ms) : 0, 21778
AppSec [baseline] (176.405 ms) : 0, 176405
AppSec [candidate] (176.51 ms) : 0, 176510
Debugger [baseline] (5.927 ms) : 0, 5927
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (614.765 µs) : 0, 615
Remote Config [candidate] (641.983 µs) : 0, 642
Telemetry [baseline] (7.353 ms) : 0, 7353
Telemetry [candidate] (7.328 ms) : 0, 7328
section iast
BytebuddyAgent [baseline] (804.372 ms) : 0, 804372
BytebuddyAgent [candidate] (804.408 ms) : 0, 804408
GlobalTracer [baseline] (231.071 ms) : 0, 231071
GlobalTracer [candidate] (231.659 ms) : 0, 231659
IAST [baseline] (26.415 ms) : 0, 26415
IAST [candidate] (27.57 ms) : 0, 27570
AppSec [baseline] (53.26 ms) : 0, 53260
AppSec [candidate] (50.544 ms) : 0, 50544
Debugger [baseline] (5.937 ms) : 0, 5937
Debugger [candidate] (5.95 ms) : 0, 5950
Remote Config [baseline] (613.311 µs) : 0, 613
Remote Config [candidate] (589.851 µs) : 0, 590
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (7.925 ms) : 0, 7925
section profiling
BytebuddyAgent [baseline] (673.449 ms) : 0, 673449
BytebuddyAgent [candidate] (677.376 ms) : 0, 677376
GlobalTracer [baseline] (359.852 ms) : 0, 359852
GlobalTracer [candidate] (360.985 ms) : 0, 360985
AppSec [baseline] (61.886 ms) : 0, 61886
AppSec [candidate] (61.799 ms) : 0, 61799
Debugger [baseline] (6.154 ms) : 0, 6154
Debugger [candidate] (6.196 ms) : 0, 6196
Remote Config [baseline] (644.4 µs) : 0, 644
Remote Config [candidate] (656.31 µs) : 0, 656
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.193 ms) : 0, 8193
ProfilingAgent [baseline] (102.746 ms) : 0, 102746
ProfilingAgent [candidate] (103.322 ms) : 0, 103322
Profiling [baseline] (102.77 ms) : 0, 102770
Profiling [candidate] (103.347 ms) : 0, 103347
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024060
Total [baseline] (8.557 s) : 0, 8557320
Agent [candidate] (1.023 s) : 0, 1023369
Total [candidate] (8.553 s) : 0, 8552788
section iast
Agent [baseline] (1.151 s) : 0, 1150836
Total [baseline] (9.223 s) : 0, 9222589
Agent [candidate] (1.154 s) : 0, 1153515
Total [candidate] (9.25 s) : 0, 9250068
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.72 ms) : 0, 684720
BytebuddyAgent [candidate] (683.94 ms) : 0, 683940
GlobalTracer [baseline] (241.098 ms) : 0, 241098
GlobalTracer [candidate] (240.717 ms) : 0, 240717
AppSec [baseline] (58.242 ms) : 0, 58242
AppSec [candidate] (60.322 ms) : 0, 60322
Debugger [baseline] (6.847 ms) : 0, 6847
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (736.251 µs) : 0, 736
Remote Config [candidate] (732.755 µs) : 0, 733
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.113 ms) : 0, 8113
section iast
BytebuddyAgent [baseline] (802.995 ms) : 0, 802995
BytebuddyAgent [candidate] (805.165 ms) : 0, 805165
GlobalTracer [baseline] (231.119 ms) : 0, 231119
GlobalTracer [candidate] (231.533 ms) : 0, 231533
IAST [baseline] (27.766 ms) : 0, 27766
IAST [candidate] (29.927 ms) : 0, 29927
AppSec [baseline] (51.053 ms) : 0, 51053
AppSec [candidate] (48.918 ms) : 0, 48918
Debugger [baseline] (5.94 ms) : 0, 5940
Debugger [candidate] (5.926 ms) : 0, 5926
Remote Config [baseline] (656.727 µs) : 0, 657
Remote Config [candidate] (608.289 µs) : 0, 608
Telemetry [baseline] (7.925 ms) : 0, 7925
Telemetry [candidate] (7.98 ms) : 0, 7980
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (4.458 ms) : 4403, 4513
. : milestone, 4458,
iast (9.434 ms) : 9269, 9598
. : milestone, 9434,
iast_FULL (13.541 ms) : 13273, 13810
. : milestone, 13541,
iast_GLOBAL (10.049 ms) : 9873, 10225
. : milestone, 10049,
profiling (8.438 ms) : 8299, 8576
. : milestone, 8438,
tracing (7.866 ms) : 7752, 7980
. : milestone, 7866,
section candidate
no_agent (4.377 ms) : 4327, 4428
. : milestone, 4377,
iast (9.238 ms) : 9087, 9389
. : milestone, 9238,
iast_FULL (13.922 ms) : 13646, 14198
. : milestone, 13922,
iast_GLOBAL (10.17 ms) : 9995, 10346
. : milestone, 10170,
profiling (8.86 ms) : 8722, 8998
. : milestone, 8860,
tracing (7.324 ms) : 7217, 7431
. : milestone, 7324,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (37.903 ms) : 37595, 38211
. : milestone, 37903,
appsec (47.911 ms) : 47491, 48331
. : milestone, 47911,
code_origins (44.42 ms) : 44056, 44785
. : milestone, 44420,
iast (45.699 ms) : 45299, 46099
. : milestone, 45699,
profiling (49.638 ms) : 49195, 50082
. : milestone, 49638,
tracing (43.787 ms) : 43416, 44159
. : milestone, 43787,
section candidate
no_agent (39.005 ms) : 38687, 39323
. : milestone, 39005,
appsec (48.872 ms) : 48431, 49314
. : milestone, 48872,
code_origins (44.322 ms) : 43969, 44675
. : milestone, 44322,
iast (42.951 ms) : 42572, 43329
. : milestone, 42951,
profiling (47.744 ms) : 47307, 48182
. : milestone, 47744,
tracing (44.448 ms) : 44085, 44812
. : milestone, 44448,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (1.494 ms) : 1482, 1506
. : milestone, 1494,
appsec (2.429 ms) : 2380, 2478
. : milestone, 2429,
iast (2.212 ms) : 2150, 2274
. : milestone, 2212,
iast_GLOBAL (2.255 ms) : 2192, 2317
. : milestone, 2255,
profiling (2.078 ms) : 2027, 2129
. : milestone, 2078,
tracing (2.017 ms) : 1970, 2065
. : milestone, 2017,
section candidate
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (2.433 ms) : 2384, 2482
. : milestone, 2433,
iast (2.212 ms) : 2150, 2273
. : milestone, 2212,
iast_GLOBAL (2.251 ms) : 2189, 2314
. : milestone, 2251,
profiling (2.055 ms) : 2006, 2105
. : milestone, 2055,
tracing (2.028 ms) : 1980, 2076
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (15.414 s) : 15414000, 15414000
. : milestone, 15414000,
appsec (14.603 s) : 14603000, 14603000
. : milestone, 14603000,
iast (18.888 s) : 18888000, 18888000
. : milestone, 18888000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
. : milestone, 18036000,
profiling (15.753 s) : 15753000, 15753000
. : milestone, 15753000,
tracing (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
section candidate
no_agent (15.22 s) : 15220000, 15220000
. : milestone, 15220000,
appsec (14.717 s) : 14717000, 14717000
. : milestone, 14717000,
iast (18.749 s) : 18749000, 18749000
. : milestone, 18749000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
. : milestone, 18006000,
profiling (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
tracing (14.585 s) : 14585000, 14585000
. : milestone, 14585000,
|
TovRudyyforce-pushed
the
olek.rudyy/overwrite-git-repository-url
branch
from
June 19, 2025 09:52
4fd86dc to
8ec7561CompareTovRudyyforce-pushed
the
olek.rudyy/overwrite-git-repository-url
branch
from
June 19, 2025 10:53
8ec7561 to
f645ea6CompareTovRudyy
commented
Jun 19, 2025
ContributorAuthor
Contributor
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
PerfectSlayer
left a comment
Collaborator
There was a problem hiding this comment.
Interesting fix indeed.
I guess this kind of change will also break all existing monitors and dashboard?
TovRudyy
commented
Jun 19, 2025
ContributorAuthor
Correct. For monitors, I took a look and found these ones: https://app.datadoghq.com/monitors/manage?q=dd-trace-java%20type%3Aci-tests and as a fact this PR will fix them, not break, because they rely on GitHub's ID ( For dashboards, not sure if you have something custom set up, but if you do you will want to check if you filter by the |
Collaborator
Oh yeah, that will definitely break most of my widgets! I will update them then. I let the team know about it and will merge the PR later today. Thanks! |
PerfectSlayer
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Overwriting the
git.repository_urltag in thedatadog-ci junit uploadcommand to point to the GitHub URL of thedd-trace-javarepository.Motivation
Some features of the Test Optimization product currently don't work because the repository name of
dd-trace-javadiffers between GitLab and GitHub.This causes requests to the GitHub API to fail because the
DataDog/apm-reliability/dd-trace-javarepo does not exist. As a result, some features of Test Optimization don't work such as tagging test runs with the@test.codeownerstag.Additional Notes
dd-trace-javarepository. In other words, test runs ofdd-trace-javawill start being reported with a new repository ID.I believe this breaking change is worth it for a proper integration with the Test Optimization product.