Uh oh!
There was an error while loading. Please reload this page.
Ignore mise and asdf configuration files - #9108
Merged
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.21 ms) : 0, 997210
Total [baseline] (10.77 s) : 0, 10769928
Agent [candidate] (995.075 ms) : 0, 995075
Total [candidate] (10.731 s) : 0, 10731288
section appsec
Agent [baseline] (1.171 s) : 0, 1171350
Total [baseline] (10.738 s) : 0, 10737599
Agent [candidate] (1.175 s) : 0, 1174529
Total [candidate] (10.748 s) : 0, 10748259
section iast
Agent [baseline] (1.134 s) : 0, 1133978
Total [baseline] (10.913 s) : 0, 10912705
Agent [candidate] (1.134 s) : 0, 1134388
Total [candidate] (10.843 s) : 0, 10843286
section profiling
Agent [baseline] (1.245 s) : 0, 1244727
Total [baseline] (10.918 s) : 0, 10918159
Agent [candidate] (1.245 s) : 0, 1244852
Total [candidate] (10.91 s) : 0, 10910156
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.418 ms) : 0, 687418
BytebuddyAgent [candidate] (686.531 ms) : 0, 686531
GlobalTracer [baseline] (243.474 ms) : 0, 243474
GlobalTracer [candidate] (242.544 ms) : 0, 242544
AppSec [baseline] (30.495 ms) : 0, 30495
AppSec [candidate] (30.305 ms) : 0, 30305
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (685.412 µs) : 0, 685
Remote Config [candidate] (681.036 µs) : 0, 681
Telemetry [baseline] (8.248 ms) : 0, 8248
Telemetry [candidate] (8.191 ms) : 0, 8191
section appsec
BytebuddyAgent [baseline] (708.428 ms) : 0, 708428
BytebuddyAgent [candidate] (709.888 ms) : 0, 709888
GlobalTracer [baseline] (234.753 ms) : 0, 234753
GlobalTracer [candidate] (235.334 ms) : 0, 235334
AppSec [baseline] (169.897 ms) : 0, 169897
AppSec [candidate] (170.809 ms) : 0, 170809
Debugger [baseline] (5.752 ms) : 0, 5752
Debugger [candidate] (5.752 ms) : 0, 5752
Remote Config [baseline] (609.044 µs) : 0, 609
Remote Config [candidate] (605.718 µs) : 0, 606
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (8.027 ms) : 0, 8027
IAST [baseline] (23.059 ms) : 0, 23059
IAST [candidate] (23.241 ms) : 0, 23241
section iast
BytebuddyAgent [baseline] (807.681 ms) : 0, 807681
BytebuddyAgent [candidate] (808.397 ms) : 0, 808397
GlobalTracer [baseline] (232.997 ms) : 0, 232997
GlobalTracer [candidate] (233.615 ms) : 0, 233615
AppSec [baseline] (29.282 ms) : 0, 29282
AppSec [candidate] (27.769 ms) : 0, 27769
Debugger [baseline] (6.69 ms) : 0, 6690
Debugger [candidate] (5.861 ms) : 0, 5861
Remote Config [baseline] (594.127 µs) : 0, 594
Remote Config [candidate] (594.654 µs) : 0, 595
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.024 ms) : 0, 8024
IAST [baseline] (27.85 ms) : 0, 27850
IAST [candidate] (29.354 ms) : 0, 29354
section profiling
ProfilingAgent [baseline] (103.228 ms) : 0, 103228
ProfilingAgent [candidate] (103.533 ms) : 0, 103533
BytebuddyAgent [baseline] (677.825 ms) : 0, 677825
BytebuddyAgent [candidate] (677.615 ms) : 0, 677615
GlobalTracer [baseline] (361.961 ms) : 0, 361961
GlobalTracer [candidate] (361.693 ms) : 0, 361693
AppSec [baseline] (30.991 ms) : 0, 30991
AppSec [candidate] (31.75 ms) : 0, 31750
Debugger [baseline] (13.602 ms) : 0, 13602
Debugger [candidate] (12.367 ms) : 0, 12367
Remote Config [baseline] (656.201 µs) : 0, 656
Remote Config [candidate] (665.54 µs) : 0, 666
Telemetry [baseline] (8.046 ms) : 0, 8046
Telemetry [candidate] (8.771 ms) : 0, 8771
Profiling [baseline] (103.252 ms) : 0, 103252
Profiling [candidate] (103.557 ms) : 0, 103557
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (998.526 ms) : 0, 998526
Total [baseline] (8.656 s) : 0, 8655590
Agent [candidate] (990.592 ms) : 0, 990592
Total [candidate] (8.576 s) : 0, 8576305
section iast
Agent [baseline] (1.131 s) : 0, 1131268
Total [baseline] (9.271 s) : 0, 9270951
Agent [candidate] (1.132 s) : 0, 1132311
Total [candidate] (9.261 s) : 0, 9260765
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.875 ms) : 0, 690875
BytebuddyAgent [candidate] (684.104 ms) : 0, 684104
GlobalTracer [baseline] (241.681 ms) : 0, 241681
GlobalTracer [candidate] (240.619 ms) : 0, 240619
AppSec [baseline] (30.196 ms) : 0, 30196
AppSec [candidate] (30.117 ms) : 0, 30117
Debugger [baseline] (6.099 ms) : 0, 6099
Debugger [candidate] (6.005 ms) : 0, 6005
Remote Config [baseline] (675.694 µs) : 0, 676
Remote Config [candidate] (679.802 µs) : 0, 680
Telemetry [baseline] (8.158 ms) : 0, 8158
Telemetry [candidate] (8.261 ms) : 0, 8261
section iast
BytebuddyAgent [baseline] (806.578 ms) : 0, 806578
BytebuddyAgent [candidate] (806.701 ms) : 0, 806701
GlobalTracer [baseline] (232.486 ms) : 0, 232486
GlobalTracer [candidate] (232.762 ms) : 0, 232762
AppSec [baseline] (28.487 ms) : 0, 28487
AppSec [candidate] (29.663 ms) : 0, 29663
Debugger [baseline] (5.854 ms) : 0, 5854
Debugger [candidate] (5.81 ms) : 0, 5810
Remote Config [baseline] (586.984 µs) : 0, 587
Remote Config [candidate] (581.484 µs) : 0, 581
Telemetry [baseline] (7.984 ms) : 0, 7984
Telemetry [candidate] (7.971 ms) : 0, 7971
IAST [baseline] (28.473 ms) : 0, 28473
IAST [candidate] (28.042 ms) : 0, 28042
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section baseline
no_agent (36.565 ms) : 36268, 36862
. : milestone, 36565,
appsec (47.063 ms) : 46646, 47480
. : milestone, 47063,
code_origins (44.193 ms) : 43813, 44573
. : milestone, 44193,
iast (44.374 ms) : 43980, 44768
. : milestone, 44374,
profiling (50.721 ms) : 50201, 51241
. : milestone, 50721,
tracing (44.247 ms) : 43872, 44621
. : milestone, 44247,
section candidate
no_agent (36.159 ms) : 35865, 36453
. : milestone, 36159,
appsec (48.819 ms) : 48372, 49266
. : milestone, 48819,
code_origins (45.07 ms) : 44687, 45452
. : milestone, 45070,
iast (44.772 ms) : 44377, 45166
. : milestone, 44772,
profiling (48.763 ms) : 48289, 49236
. : milestone, 48763,
tracing (42.224 ms) : 41868, 42580
. : milestone, 42224,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section baseline
no_agent (4.44 ms) : 4390, 4490
. : milestone, 4440,
iast (9.665 ms) : 9504, 9826
. : milestone, 9665,
iast_FULL (13.9 ms) : 13624, 14176
. : milestone, 13900,
iast_GLOBAL (10.344 ms) : 10160, 10528
. : milestone, 10344,
profiling (8.866 ms) : 8725, 9008
. : milestone, 8866,
tracing (7.952 ms) : 7832, 8073
. : milestone, 7952,
section candidate
no_agent (4.333 ms) : 4285, 4381
. : milestone, 4333,
iast (9.274 ms) : 9124, 9424
. : milestone, 9274,
iast_FULL (14.064 ms) : 13787, 14341
. : milestone, 14064,
iast_GLOBAL (10.413 ms) : 10229, 10596
. : milestone, 10413,
profiling (8.443 ms) : 8300, 8585
. : milestone, 8443,
tracing (7.571 ms) : 7462, 7679
. : milestone, 7571,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section baseline
no_agent (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
appsec (14.789 s) : 14789000, 14789000
. : milestone, 14789000,
iast (18.18 s) : 18180000, 18180000
. : milestone, 18180000,
iast_GLOBAL (18.196 s) : 18196000, 18196000
. : milestone, 18196000,
profiling (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
tracing (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
appsec (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
iast (18.556 s) : 18556000, 18556000
. : milestone, 18556000,
iast_GLOBAL (18.175 s) : 18175000, 18175000
. : milestone, 18175000,
profiling (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
tracing (14.822 s) : 14822000, 14822000
. : milestone, 14822000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.393 ms) : 2344, 2442
. : milestone, 2393,
iast (2.182 ms) : 2120, 2244
. : milestone, 2182,
iast_GLOBAL (2.219 ms) : 2157, 2281
. : milestone, 2219,
profiling (2.05 ms) : 1999, 2101
. : milestone, 2050,
tracing (2.001 ms) : 1953, 2049
. : milestone, 2001,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.391 ms) : 2342, 2439
. : milestone, 2391,
iast (2.18 ms) : 2118, 2242
. : milestone, 2180,
iast_GLOBAL (2.228 ms) : 2166, 2290
. : milestone, 2228,
profiling (2.033 ms) : 1983, 2083
. : milestone, 2033,
tracing (1.999 ms) : 1951, 2047
. : milestone, 1999,
|
smola
reviewed
Jul 7, 2025
Member
There was a problem hiding this comment.
Perhaps we could also provide .config/mise.toml in the repo for easier setup? Can it setup JAVA_XX_HOME env vars?
ContributorAuthor
There was a problem hiding this comment.
Good idea, I never looked into that.
Collaborator
There was a problem hiding this comment.
If we start adding custom config tool, we will end up having support for dozen of tools and not many people to maintain it :/
I would rather add support to install JDK from the setup scripts. Windows is already supported.
Linux and MacOS still needed. The tough part is to do it the more generic way without assuming nor requiring some specific tool.
ContributorAuthor
There was a problem hiding this comment.
THis is very similar to any other env tool in many other languages.
I would rather add support to install JDK from the setup scripts.
My counterpoint is that setup script don;t manage JDK install well, other tools do that much better. For example the advantage of mise or asdf is they patch the PATH in the shell to the wanted JDK.
Also I wonder if we could leverage Gradle's JDK toolchain resolver (usually the foojay one), which hopefully don't preclude, other tools like mise or sdkman ?
Can it setup
JAVA_XX_HOMEenv vars?
I believe it's possible, however, it won't work in IntelliJ, as IJ captures environment variables produces by your ~/.zshrc. What I do have in mine is
export JAVA_8_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-8
export JAVA_11_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-11
export JAVA_17_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-17
export JAVA_21_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-21
export JAVA_GRAALVM17_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/graalvm-community-17.0.9
Does are symlinks pointing to the latest installed JDK installed my mise.
FYI the mise configuration doc
ContributorAuthor
There was a problem hiding this comment.
On the point of using .gitignore, is that it will be available for any clone, and thus avoiding accidental commit.
smola
approved these changes
Jul 7, 2025
bric3
enabled auto-merge (squash)
July 7, 2025 07:58
bric3
disabled auto-merge
July 7, 2025 07:59
PerfectSlayer
left a comment
Collaborator
There was a problem hiding this comment.
May an unpopular opinion but I would rather avoid adding many custom tools to the common ignore list.
If you have some specific file to exclude related to your setup, the .git/info/exclude seems more appropriate.
Collaborator
There was a problem hiding this comment.
If we start adding custom config tool, we will end up having support for dozen of tools and not many people to maintain it :/
I would rather add support to install JDK from the setup scripts. Windows is already supported.
Linux and MacOS still needed. The tough part is to do it the more generic way without assuming nor requiring some specific tool.
amarziali
approved these changes
Jul 8, 2025
bric3
commented
Jul 8, 2025
ContributorAuthor
@PerfectSlayer I'd like to go ahead with the gitignore. We'll revise that if that's an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]