chore: Cleaning up HttpServerDecorator by mhlidd · Pull Request #9139 · DataDog/dd-trace-java

mhlidd · 2025-07-09T18:31:12Z

What Does This Do

Previously, we supported ways to extract span contexts and start spans with span contexts. During our migration to Context API, we maintained support for span contexts while migrating all instrumentations to extract and start spans using generic contexts. This PR removes support for extracting and starting spans with span contexts alone.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-09T19:03:43Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/httpserverdecorator_cleanup
git_commit_date	1752163579	1752168523
git_commit_sha	`a90ccbc`	`a4f6a9a`
release_version	1.52.0-SNAPSHOT~a90ccbcd72	1.52.0-SNAPSHOT~a4f6a9a2b3

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1752170348	1752170348
ci_job_id	1023494663	1023494663
ci_pipeline_id	70212518	70212518
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-6lcgrk8w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-6lcgrk8w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.659 ms) : 0, 995659
Total [baseline] (8.582 s) : 0, 8581910
Agent [candidate] (996.986 ms) : 0, 996986
Total [candidate] (8.585 s) : 0, 8584939
section iast
Agent [baseline] (1.133 s) : 0, 1133377
Total [baseline] (9.328 s) : 0, 9327760
Agent [candidate] (1.135 s) : 0, 1134876
Total [candidate] (9.302 s) : 0, 9301798

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	995.659 ms	-
Agent	iast	1.133 s	137.718 ms (13.8%)
Total	tracing	8.582 s	-
Total	iast	9.328 s	745.851 ms (8.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	996.986 ms	-
Agent	iast	1.135 s	137.89 ms (13.8%)
Total	tracing	8.585 s	-
Total	iast	9.302 s	716.859 ms (8.4%)

gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.954 ms) : 0, 687954
BytebuddyAgent [candidate] (688.472 ms) : 0, 688472
GlobalTracer [baseline] (242.024 ms) : 0, 242024
GlobalTracer [candidate] (242.437 ms) : 0, 242437
AppSec [baseline] (30.13 ms) : 0, 30130
AppSec [candidate] (30.353 ms) : 0, 30353
Debugger [baseline] (5.943 ms) : 0, 5943
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (682.31 µs) : 0, 682
Remote Config [candidate] (676.416 µs) : 0, 676
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.301 ms) : 0, 8301
section iast
BytebuddyAgent [baseline] (808.326 ms) : 0, 808326
BytebuddyAgent [candidate] (809.164 ms) : 0, 809164
GlobalTracer [baseline] (232.169 ms) : 0, 232169
GlobalTracer [candidate] (232.56 ms) : 0, 232560
IAST [baseline] (26.511 ms) : 0, 26511
IAST [candidate] (27.512 ms) : 0, 27512
AppSec [baseline] (31.348 ms) : 0, 31348
AppSec [candidate] (29.787 ms) : 0, 29787
Debugger [baseline] (5.8 ms) : 0, 5800
Debugger [candidate] (6.583 ms) : 0, 6583
Remote Config [baseline] (592.02 µs) : 0, 592
Remote Config [candidate] (578.455 µs) : 0, 578
Telemetry [baseline] (7.94 ms) : 0, 7940
Telemetry [candidate] (7.968 ms) : 0, 7968

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.638 ms) : 0, 997638
Total [baseline] (10.695 s) : 0, 10694504
Agent [candidate] (1.002 s) : 0, 1002371
Total [candidate] (10.712 s) : 0, 10711743
section appsec
Agent [baseline] (1.185 s) : 0, 1185203
Total [baseline] (10.867 s) : 0, 10866783
Agent [candidate] (1.176 s) : 0, 1176373
Total [candidate] (10.732 s) : 0, 10731612
section iast
Agent [baseline] (1.143 s) : 0, 1143207
Total [baseline] (10.984 s) : 0, 10984168
Agent [candidate] (1.133 s) : 0, 1133139
Total [candidate] (10.903 s) : 0, 10903427
section profiling
Agent [baseline] (1.246 s) : 0, 1245748
Total [baseline] (10.946 s) : 0, 10945610
Agent [candidate] (1.247 s) : 0, 1246990
Total [candidate] (11.057 s) : 0, 11057007

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.638 ms	-
Agent	appsec	1.185 s	187.566 ms (18.8%)
Agent	iast	1.143 s	145.569 ms (14.6%)
Agent	profiling	1.246 s	248.11 ms (24.9%)
Total	tracing	10.695 s	-
Total	appsec	10.867 s	172.279 ms (1.6%)
Total	iast	10.984 s	289.664 ms (2.7%)
Total	profiling	10.946 s	251.105 ms (2.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.002 s	-
Agent	appsec	1.176 s	174.001 ms (17.4%)
Agent	iast	1.133 s	130.768 ms (13.0%)
Agent	profiling	1.247 s	244.619 ms (24.4%)
Total	tracing	10.712 s	-
Total	appsec	10.732 s	19.869 ms (0.2%)
Total	iast	10.903 s	191.684 ms (1.8%)
Total	profiling	11.057 s	345.264 ms (3.2%)

gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.319 ms) : 0, 688319
BytebuddyAgent [candidate] (692.347 ms) : 0, 692347
GlobalTracer [baseline] (242.998 ms) : 0, 242998
GlobalTracer [candidate] (243.63 ms) : 0, 243630
AppSec [baseline] (30.49 ms) : 0, 30490
AppSec [candidate] (30.422 ms) : 0, 30422
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.082 ms) : 0, 6082
Remote Config [baseline] (685.579 µs) : 0, 686
Remote Config [candidate] (678.438 µs) : 0, 678
Telemetry [baseline] (8.259 ms) : 0, 8259
Telemetry [candidate] (8.272 ms) : 0, 8272
section appsec
BytebuddyAgent [baseline] (716.709 ms) : 0, 716709
BytebuddyAgent [candidate] (711.407 ms) : 0, 711407
GlobalTracer [baseline] (236.853 ms) : 0, 236853
GlobalTracer [candidate] (235.351 ms) : 0, 235351
IAST [baseline] (23.822 ms) : 0, 23822
IAST [candidate] (23.504 ms) : 0, 23504
AppSec [baseline] (172.278 ms) : 0, 172278
AppSec [candidate] (171.032 ms) : 0, 171032
Debugger [baseline] (5.762 ms) : 0, 5762
Debugger [candidate] (5.69 ms) : 0, 5690
Remote Config [baseline] (630.324 µs) : 0, 630
Remote Config [candidate] (598.785 µs) : 0, 599
Telemetry [baseline] (8.127 ms) : 0, 8127
Telemetry [candidate] (7.948 ms) : 0, 7948
section iast
BytebuddyAgent [baseline] (815.24 ms) : 0, 815240
BytebuddyAgent [candidate] (807.86 ms) : 0, 807860
GlobalTracer [baseline] (233.772 ms) : 0, 233772
GlobalTracer [candidate] (232.304 ms) : 0, 232304
IAST [baseline] (25.862 ms) : 0, 25862
IAST [candidate] (29.01 ms) : 0, 29010
AppSec [baseline] (32.937 ms) : 0, 32937
AppSec [candidate] (28.855 ms) : 0, 28855
Debugger [baseline] (5.816 ms) : 0, 5816
Debugger [candidate] (5.776 ms) : 0, 5776
Remote Config [baseline] (617.46 µs) : 0, 617
Remote Config [candidate] (586.447 µs) : 0, 586
Telemetry [baseline] (8.023 ms) : 0, 8023
Telemetry [candidate] (7.975 ms) : 0, 7975
section profiling
BytebuddyAgent [baseline] (678.466 ms) : 0, 678466
BytebuddyAgent [candidate] (679.086 ms) : 0, 679086
GlobalTracer [baseline] (361.748 ms) : 0, 361748
GlobalTracer [candidate] (362.151 ms) : 0, 362151
AppSec [baseline] (33.413 ms) : 0, 33413
AppSec [candidate] (32.434 ms) : 0, 32434
Debugger [baseline] (9.672 ms) : 0, 9672
Debugger [candidate] (10.491 ms) : 0, 10491
Remote Config [baseline] (659.014 µs) : 0, 659
Remote Config [candidate] (659.332 µs) : 0, 659
Telemetry [baseline] (9.58 ms) : 0, 9580
Telemetry [candidate] (8.768 ms) : 0, 8768
ProfilingAgent [baseline] (103.698 ms) : 0, 103698
ProfilingAgent [candidate] (104.568 ms) : 0, 104568
Profiling [baseline] (103.722 ms) : 0, 103722
Profiling [candidate] (104.592 ms) : 0, 104592

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/httpserverdecorator_cleanup
git_commit_date	1752163579	1752168523
git_commit_sha	`a90ccbc`	`a4f6a9a`
release_version	1.52.0-SNAPSHOT~a90ccbcd72	1.52.0-SNAPSHOT~a4f6a9a2b3

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1752169950	1752169950
ci_job_id	1023494664	1023494664
ci_pipeline_id	70212518	70212518
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-4yin3wkh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-4yin3wkh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load	worse [+214.595µs; +321.938µs] or [+5.017%; +7.527%]	unstable [-179.361op/s; +55.236op/s] or [-16.725%; +5.151%]	4.545ms	1010.344op/s	4.277ms	1072.406op/s
scenario:load:petclinic:no_agent:high_load	better [-1.539ms; -0.887ms] or [-4.068%; -2.343%]	unstable [-2.968op/s; +14.323op/s] or [-2.402%; +11.594%]	36.625ms	129.215op/s	37.838ms	123.537op/s
scenario:load:petclinic:code_origins:high_load	worse [+2.080ms; +2.906ms] or [+4.771%; +6.667%]	unstable [-13.392op/s; +1.742op/s] or [-12.475%; +1.623%]	46.075ms	101.525op/s	43.582ms	107.350op/s
scenario:load:petclinic:appsec:high_load	better [-4.335ms; -3.439ms] or [-8.737%; -6.931%]	unstable [+0.719op/s; +15.281op/s] or [+0.762%; +16.201%]	45.735ms	102.325op/s	49.623ms	94.325op/s
scenario:load:petclinic:tracing:high_load	better [-1.905ms; -1.121ms] or [-4.326%; -2.546%]	unstable [-2.519op/s; +12.829op/s] or [-2.371%; +12.075%]	42.512ms	111.405op/s	44.025ms	106.250op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section baseline
no_agent (4.277 ms) : 4229, 4325
. : milestone, 4277,
iast (9.464 ms) : 9303, 9626
. : milestone, 9464,
iast_FULL (13.652 ms) : 13377, 13926
. : milestone, 13652,
iast_GLOBAL (10.559 ms) : 10371, 10747
. : milestone, 10559,
profiling (8.486 ms) : 8350, 8622
. : milestone, 8486,
tracing (7.55 ms) : 7441, 7658
. : milestone, 7550,
section candidate
no_agent (4.545 ms) : 4494, 4597
. : milestone, 4545,
iast (9.318 ms) : 9164, 9473
. : milestone, 9318,
iast_FULL (13.774 ms) : 13499, 14049
. : milestone, 13774,
iast_GLOBAL (10.266 ms) : 10086, 10445
. : milestone, 10266,
profiling (8.576 ms) : 8434, 8718
. : milestone, 8576,
tracing (7.679 ms) : 7568, 7789
. : milestone, 7679,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.277 ms [4.229 ms, 4.325 ms]	-
iast	9.464 ms [9.303 ms, 9.626 ms]	5.187 ms (121.3%)
iast_FULL	13.652 ms [13.377 ms, 13.926 ms]	9.375 ms (219.2%)
iast_GLOBAL	10.559 ms [10.371 ms, 10.747 ms]	6.282 ms (146.9%)
profiling	8.486 ms [8.35 ms, 8.622 ms]	4.209 ms (98.4%)
tracing	7.55 ms [7.441 ms, 7.658 ms]	3.273 ms (76.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.545 ms [4.494 ms, 4.597 ms]	-
iast	9.318 ms [9.164 ms, 9.473 ms]	4.773 ms (105.0%)
iast_FULL	13.774 ms [13.499 ms, 14.049 ms]	9.229 ms (203.0%)
iast_GLOBAL	10.266 ms [10.086 ms, 10.445 ms]	5.72 ms (125.9%)
profiling	8.576 ms [8.434 ms, 8.718 ms]	4.031 ms (88.7%)
tracing	7.679 ms [7.568 ms, 7.789 ms]	3.133 ms (68.9%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section baseline
no_agent (37.838 ms) : 37527, 38149
. : milestone, 37838,
appsec (49.623 ms) : 49190, 50056
. : milestone, 49623,
code_origins (43.582 ms) : 43214, 43951
. : milestone, 43582,
iast (44.716 ms) : 44320, 45112
. : milestone, 44716,
profiling (48.135 ms) : 47717, 48552
. : milestone, 48135,
tracing (44.025 ms) : 43649, 44400
. : milestone, 44025,
section candidate
no_agent (36.625 ms) : 36330, 36920
. : milestone, 36625,
appsec (45.735 ms) : 45336, 46134
. : milestone, 45735,
code_origins (46.075 ms) : 45676, 46474
. : milestone, 46075,
iast (44.665 ms) : 44267, 45063
. : milestone, 44665,
profiling (48.978 ms) : 48520, 49435
. : milestone, 48978,
tracing (42.512 ms) : 42160, 42864
. : milestone, 42512,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.838 ms [37.527 ms, 38.149 ms]	-
appsec	49.623 ms [49.19 ms, 50.056 ms]	11.785 ms (31.1%)
code_origins	43.582 ms [43.214 ms, 43.951 ms]	5.744 ms (15.2%)
iast	44.716 ms [44.32 ms, 45.112 ms]	6.878 ms (18.2%)
profiling	48.135 ms [47.717 ms, 48.552 ms]	10.297 ms (27.2%)
tracing	44.025 ms [43.649 ms, 44.4 ms]	6.187 ms (16.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.625 ms [36.33 ms, 36.92 ms]	-
appsec	45.735 ms [45.336 ms, 46.134 ms]	9.11 ms (24.9%)
code_origins	46.075 ms [45.676 ms, 46.474 ms]	9.45 ms (25.8%)
iast	44.665 ms [44.267 ms, 45.063 ms]	8.04 ms (22.0%)
profiling	48.978 ms [48.52 ms, 49.435 ms]	12.353 ms (33.7%)
tracing	42.512 ms [42.16 ms, 42.864 ms]	5.887 ms (16.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/httpserverdecorator_cleanup
git_commit_date	1752163579	1752168523
git_commit_sha	`a90ccbc`	`a4f6a9a`
release_version	1.52.0-SNAPSHOT~a90ccbcd72	1.52.0-SNAPSHOT~a4f6a9a2b3

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1752170436	1752170436
ci_job_id	1023494665	1023494665
ci_pipeline_id	70212518	70212518
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-g8lgwuch 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-g8lgwuch 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section baseline
no_agent (15.332 s) : 15332000, 15332000
. : milestone, 15332000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (18.332 s) : 18332000, 18332000
. : milestone, 18332000,
iast_GLOBAL (18.083 s) : 18083000, 18083000
. : milestone, 18083000,
profiling (15.363 s) : 15363000, 15363000
. : milestone, 15363000,
tracing (14.552 s) : 14552000, 14552000
. : milestone, 14552000,
section candidate
no_agent (15.3 s) : 15300000, 15300000
. : milestone, 15300000,
appsec (14.638 s) : 14638000, 14638000
. : milestone, 14638000,
iast (18.552 s) : 18552000, 18552000
. : milestone, 18552000,
iast_GLOBAL (18.261 s) : 18261000, 18261000
. : milestone, 18261000,
profiling (15.356 s) : 15356000, 15356000
. : milestone, 15356000,
tracing (15.055 s) : 15055000, 15055000
. : milestone, 15055000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.332 s [15.332 s, 15.332 s]	-
appsec	14.959 s [14.959 s, 14.959 s]	-373.0 ms (-2.4%)
iast	18.332 s [18.332 s, 18.332 s]	3.0 s (19.6%)
iast_GLOBAL	18.083 s [18.083 s, 18.083 s]	2.751 s (17.9%)
profiling	15.363 s [15.363 s, 15.363 s]	31.0 ms (0.2%)
tracing	14.552 s [14.552 s, 14.552 s]	-780.0 ms (-5.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.3 s [15.3 s, 15.3 s]	-
appsec	14.638 s [14.638 s, 14.638 s]	-662.0 ms (-4.3%)
iast	18.552 s [18.552 s, 18.552 s]	3.252 s (21.3%)
iast_GLOBAL	18.261 s [18.261 s, 18.261 s]	2.961 s (19.4%)
profiling	15.356 s [15.356 s, 15.356 s]	56.0 ms (0.4%)
tracing	15.055 s [15.055 s, 15.055 s]	-245.0 ms (-1.6%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~a4f6a9a2b3, baseline=1.52.0-SNAPSHOT~a90ccbcd72
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.416 ms) : 2365, 2466
. : milestone, 2416,
iast (2.203 ms) : 2140, 2265
. : milestone, 2203,
iast_GLOBAL (2.242 ms) : 2180, 2305
. : milestone, 2242,
profiling (2.494 ms) : 2319, 2669
. : milestone, 2494,
tracing (2.006 ms) : 1958, 2055
. : milestone, 2006,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.428 ms) : 2378, 2478
. : milestone, 2428,
iast (2.196 ms) : 2134, 2259
. : milestone, 2196,
iast_GLOBAL (2.238 ms) : 2174, 2301
. : milestone, 2238,
profiling (2.061 ms) : 2010, 2112
. : milestone, 2061,
tracing (2.014 ms) : 1966, 2063
. : milestone, 2014,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.416 ms [2.365 ms, 2.466 ms]	941.917 µs (63.9%)
iast	2.203 ms [2.14 ms, 2.265 ms]	728.949 µs (49.5%)
iast_GLOBAL	2.242 ms [2.18 ms, 2.305 ms]	768.719 µs (52.2%)
profiling	2.494 ms [2.319 ms, 2.669 ms]	1.021 ms (69.3%)
tracing	2.006 ms [1.958 ms, 2.055 ms]	532.687 µs (36.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	2.428 ms [2.378 ms, 2.478 ms]	953.612 µs (64.7%)
iast	2.196 ms [2.134 ms, 2.259 ms]	722.011 µs (49.0%)
iast_GLOBAL	2.238 ms [2.174 ms, 2.301 ms]	763.243 µs (51.8%)
profiling	2.061 ms [2.01 ms, 2.112 ms]	586.279 µs (39.8%)
tracing	2.014 ms [1.966 ms, 2.063 ms]	539.99 µs (36.6%)

github-actions · 2025-07-09T20:41:29Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

PerfectSlayer

Thanks for the clean up!

Cleaning up HttpServerDecorator
cc9beea

mhlidd marked this pull request as ready for review July 9, 2025 20:41

mhlidd requested a review from a team as a code owner July 9, 2025 20:41

mhlidd added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: api Tracer public API labels Jul 9, 2025

mhlidd requested review from PerfectSlayer and mcculls July 10, 2025 13:25

PerfectSlayer approved these changes Jul 10, 2025
View reviewed changes

Merge branch 'master' into mhlidd/httpserverdecorator_cleanup
a4f6a9a

mhlidd merged commit ad6d6b9 into masterJul 10, 2025
507 checks passed

mhlidd deleted the mhlidd/httpserverdecorator_cleanup branch July 10, 2025 18:48

github-actionsBot added this to the 1.52.0 milestone Jul 10, 2025

Navigation Menu

Uh oh!

chore: Cleaning up HttpServerDecorator - #9139

chore: Cleaning up HttpServerDecorator#9139
mhlidd merged 2 commits into
masterfrom
mhlidd/httpserverdecorator_cleanup

mhlidd commented Jul 9, 2025

Uh oh!

pr-commenterBot commented Jul 9, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Jul 9, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mhlidd commented Jul 9, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actionsBot commented Jul 9, 2025

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pr-commenterBot commented Jul 9, 2025•
edited
Loading