Fix base branch SHA usage in GitHub Actions by daniel-mohedano · Pull Request #9257 · DataDog/dd-trace-java

daniel-mohedano · 2025-07-28T14:32:18Z

What Does This Do

Sets the pull_request.base.sha value provided by GitHub Actions as git.pull_request.base_branch_head_sha instead of git.pull_request.base_branch_sha
When calculating the PR diff and base_branch_sha is not present, tries to use the merge base with base_branch_head_sha to compute it

Motivation

Using pull_request.base.sha, which is the head commit SHA for the base branch, meant that the git diff calculated was inaccurate (base branch head sha - head sha, instead of base commit sha - head sha)

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: SDTEST-2351

pr-commenter · 2025-07-28T15:28:05Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/base-branch-head-sha
git_commit_date	1753791092	1753795952
git_commit_sha	`dc91a2c`	`21ae796`
release_version	1.51.1-SNAPSHOT~dc91a2c678	1.51.1-SNAPSHOT~21ae796d80

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1753797808	1753797808
ci_job_id	1052810449	1052810449
ci_pipeline_id	72022453	72022453
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-35iqpjl6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-35iqpjl6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046089
Total [baseline] (10.703 s) : 0, 10702922
Agent [candidate] (1.05 s) : 0, 1050026
Total [candidate] (10.788 s) : 0, 10788297
section appsec
Agent [baseline] (1.216 s) : 0, 1216115
Total [baseline] (10.725 s) : 0, 10725292
Agent [candidate] (1.226 s) : 0, 1226014
Total [candidate] (10.817 s) : 0, 10817121
section iast
Agent [baseline] (1.174 s) : 0, 1173661
Total [baseline] (10.944 s) : 0, 10943602
Agent [candidate] (1.18 s) : 0, 1179689
Total [candidate] (10.875 s) : 0, 10874578
section profiling
Agent [baseline] (1.192 s) : 0, 1191841
Total [baseline] (10.889 s) : 0, 10889386
Agent [candidate] (1.19 s) : 0, 1189683
Total [candidate] (10.828 s) : 0, 10828098

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.216 s	170.026 ms (16.3%)
Agent	iast	1.174 s	127.571 ms (12.2%)
Agent	profiling	1.192 s	145.752 ms (13.9%)
Total	tracing	10.703 s	-
Total	appsec	10.725 s	22.37 ms (0.2%)
Total	iast	10.944 s	240.681 ms (2.2%)
Total	profiling	10.889 s	186.464 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.226 s	175.988 ms (16.8%)
Agent	iast	1.18 s	129.663 ms (12.3%)
Agent	profiling	1.19 s	139.656 ms (13.3%)
Total	tracing	10.788 s	-
Total	appsec	10.817 s	28.824 ms (0.3%)
Total	iast	10.875 s	86.281 ms (0.8%)
Total	profiling	10.828 s	39.801 ms (0.4%)

gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (734.2 ms) : 0, 734200
BytebuddyAgent [candidate] (736.326 ms) : 0, 736326
GlobalTracer [baseline] (242.824 ms) : 0, 242824
GlobalTracer [candidate] (243.033 ms) : 0, 243033
AppSec [baseline] (30.575 ms) : 0, 30575
AppSec [candidate] (30.606 ms) : 0, 30606
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.096 ms) : 0, 6096
Remote Config [baseline] (650.635 µs) : 0, 651
Remote Config [candidate] (661.557 µs) : 0, 662
Telemetry [baseline] (9.267 ms) : 0, 9267
Telemetry [candidate] (9.96 ms) : 0, 9960
section appsec
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (750.73 ms) : 0, 750730
BytebuddyAgent [candidate] (757.009 ms) : 0, 757009
GlobalTracer [baseline] (234.076 ms) : 0, 234076
GlobalTracer [candidate] (235.958 ms) : 0, 235958
AppSec [baseline] (168.487 ms) : 0, 168487
AppSec [candidate] (171.082 ms) : 0, 171082
Debugger [baseline] (8.046 ms) : 0, 8046
Debugger [candidate] (6.527 ms) : 0, 6527
Remote Config [baseline] (611.83 µs) : 0, 612
Remote Config [candidate] (630.456 µs) : 0, 630
Telemetry [baseline] (8.28 ms) : 0, 8280
Telemetry [candidate] (8.404 ms) : 0, 8404
IAST [baseline] (23.402 ms) : 0, 23402
IAST [candidate] (23.555 ms) : 0, 23555
section iast
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (846.796 ms) : 0, 846796
BytebuddyAgent [candidate] (852.05 ms) : 0, 852050
GlobalTracer [baseline] (231.345 ms) : 0, 231345
GlobalTracer [candidate] (232.027 ms) : 0, 232027
AppSec [baseline] (28.175 ms) : 0, 28175
AppSec [candidate] (26.89 ms) : 0, 26890
Debugger [baseline] (7.539 ms) : 0, 7539
Debugger [candidate] (8.406 ms) : 0, 8406
Remote Config [baseline] (581.295 µs) : 0, 581
Remote Config [candidate] (593.08 µs) : 0, 593
Telemetry [baseline] (8.16 ms) : 0, 8160
Telemetry [candidate] (8.202 ms) : 0, 8202
IAST [baseline] (28.492 ms) : 0, 28492
IAST [candidate] (29.053 ms) : 0, 29053
section profiling
crashtracking [baseline] (1.398 ms) : 0, 1398
crashtracking [candidate] (1.385 ms) : 0, 1385
BytebuddyAgent [baseline] (759.557 ms) : 0, 759557
BytebuddyAgent [candidate] (758.22 ms) : 0, 758220
GlobalTracer [baseline] (220.26 ms) : 0, 220260
GlobalTracer [candidate] (220.543 ms) : 0, 220543
AppSec [baseline] (30.303 ms) : 0, 30303
AppSec [candidate] (30.146 ms) : 0, 30146
Debugger [baseline] (6.284 ms) : 0, 6284
Debugger [candidate] (6.243 ms) : 0, 6243
Remote Config [baseline] (720.202 µs) : 0, 720
Remote Config [candidate] (676.763 µs) : 0, 677
Telemetry [baseline] (15.977 ms) : 0, 15977
Telemetry [candidate] (15.838 ms) : 0, 15838
ProfilingAgent [baseline] (108.039 ms) : 0, 108039
ProfilingAgent [candidate] (107.525 ms) : 0, 107525
Profiling [baseline] (108.679 ms) : 0, 108679
Profiling [candidate] (108.159 ms) : 0, 108159

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052650
Total [baseline] (8.643 s) : 0, 8643360
Agent [candidate] (1.041 s) : 0, 1041488
Total [candidate] (8.556 s) : 0, 8556079
section iast
Agent [baseline] (1.184 s) : 0, 1184201
Total [baseline] (9.384 s) : 0, 9384140
Agent [candidate] (1.172 s) : 0, 1172454
Total [candidate] (9.36 s) : 0, 9359673

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.184 s	131.551 ms (12.5%)
Total	tracing	8.643 s	-
Total	iast	9.384 s	740.779 ms (8.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.172 s	130.966 ms (12.6%)
Total	tracing	8.556 s	-
Total	iast	9.36 s	803.594 ms (9.4%)

gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (736.946 ms) : 0, 736946
BytebuddyAgent [candidate] (729.874 ms) : 0, 729874
GlobalTracer [baseline] (243.024 ms) : 0, 243024
GlobalTracer [candidate] (241.086 ms) : 0, 241086
AppSec [baseline] (30.595 ms) : 0, 30595
AppSec [candidate] (30.332 ms) : 0, 30332
Debugger [baseline] (6.089 ms) : 0, 6089
Debugger [candidate] (6.052 ms) : 0, 6052
Remote Config [baseline] (652.83 µs) : 0, 653
Remote Config [candidate] (649.521 µs) : 0, 650
Telemetry [baseline] (12.753 ms) : 0, 12753
Telemetry [candidate] (11.136 ms) : 0, 11136
section iast
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (854.867 ms) : 0, 854867
BytebuddyAgent [candidate] (846.573 ms) : 0, 846573
GlobalTracer [baseline] (233.164 ms) : 0, 233164
GlobalTracer [candidate] (231.311 ms) : 0, 231311
AppSec [baseline] (30.232 ms) : 0, 30232
AppSec [candidate] (27.34 ms) : 0, 27340
Debugger [baseline] (7.523 ms) : 0, 7523
Debugger [candidate] (6.598 ms) : 0, 6598
Remote Config [baseline] (592.942 µs) : 0, 593
Remote Config [candidate] (579.622 µs) : 0, 580
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.066 ms) : 0, 8066
IAST [baseline] (27.022 ms) : 0, 27022
IAST [candidate] (29.659 ms) : 0, 29659

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/base-branch-head-sha
git_commit_date	1753791092	1753795952
git_commit_sha	`dc91a2c`	`21ae796`
release_version	1.51.1-SNAPSHOT~dc91a2c678	1.51.1-SNAPSHOT~21ae796d80

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1753797486	1753797486
ci_job_id	1052810450	1052810450
ci_pipeline_id	72022453	72022453
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-8d4dchiy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-8d4dchiy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	worse [+182.059µs; +425.296µs] or [+2.402%; +5.612%]	unstable [-100.350op/s; +53.288op/s] or [-16.417%; +8.718%]	7.882ms	587.719op/s	7.578ms	611.250op/s
scenario:load:petclinic:iast:high_load	worse [+1.065ms; +1.912ms] or [+2.425%; +4.354%]	unstable [-13.781op/s; +1.713op/s] or [-12.774%; +1.587%]	45.401ms	101.852op/s	43.913ms	107.886op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section baseline
no_agent (4.416 ms) : 4363, 4470
. : milestone, 4416,
iast (9.317 ms) : 9160, 9474
. : milestone, 9317,
iast_FULL (14.073 ms) : 13791, 14355
. : milestone, 14073,
iast_GLOBAL (10.056 ms) : 9879, 10232
. : milestone, 10056,
profiling (8.619 ms) : 8488, 8750
. : milestone, 8619,
tracing (7.578 ms) : 7474, 7682
. : milestone, 7578,
section candidate
no_agent (4.52 ms) : 4467, 4573
. : milestone, 4520,
iast (9.26 ms) : 9109, 9412
. : milestone, 9260,
iast_FULL (13.791 ms) : 13522, 14061
. : milestone, 13791,
iast_GLOBAL (10.288 ms) : 10106, 10471
. : milestone, 10288,
profiling (8.599 ms) : 8450, 8747
. : milestone, 8599,
tracing (7.882 ms) : 7760, 8003
. : milestone, 7882,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.416 ms [4.363 ms, 4.47 ms]	-
iast	9.317 ms [9.16 ms, 9.474 ms]	4.901 ms (111.0%)
iast_FULL	14.073 ms [13.791 ms, 14.355 ms]	9.657 ms (218.7%)
iast_GLOBAL	10.056 ms [9.879 ms, 10.232 ms]	5.639 ms (127.7%)
profiling	8.619 ms [8.488 ms, 8.75 ms]	4.203 ms (95.2%)
tracing	7.578 ms [7.474 ms, 7.682 ms]	3.162 ms (71.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.52 ms [4.467 ms, 4.573 ms]	-
iast	9.26 ms [9.109 ms, 9.412 ms]	4.74 ms (104.9%)
iast_FULL	13.791 ms [13.522 ms, 14.061 ms]	9.271 ms (205.1%)
iast_GLOBAL	10.288 ms [10.106 ms, 10.471 ms]	5.768 ms (127.6%)
profiling	8.599 ms [8.45 ms, 8.747 ms]	4.078 ms (90.2%)
tracing	7.882 ms [7.76 ms, 8.003 ms]	3.361 ms (74.4%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section baseline
no_agent (38.082 ms) : 37776, 38387
. : milestone, 38082,
appsec (47.781 ms) : 47372, 48189
. : milestone, 47781,
code_origins (44.014 ms) : 43630, 44397
. : milestone, 44014,
iast (43.913 ms) : 43524, 44302
. : milestone, 43913,
profiling (49.127 ms) : 48673, 49580
. : milestone, 49127,
tracing (43.89 ms) : 43517, 44264
. : milestone, 43890,
section candidate
no_agent (37.496 ms) : 37201, 37792
. : milestone, 37496,
appsec (46.956 ms) : 46546, 47366
. : milestone, 46956,
code_origins (45.249 ms) : 44846, 45653
. : milestone, 45249,
iast (45.401 ms) : 45003, 45799
. : milestone, 45401,
profiling (49.24 ms) : 48784, 49697
. : milestone, 49240,
tracing (43.479 ms) : 43117, 43842
. : milestone, 43479,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.082 ms [37.776 ms, 38.387 ms]	-
appsec	47.781 ms [47.372 ms, 48.189 ms]	9.699 ms (25.5%)
code_origins	44.014 ms [43.63 ms, 44.397 ms]	5.932 ms (15.6%)
iast	43.913 ms [43.524 ms, 44.302 ms]	5.831 ms (15.3%)
profiling	49.127 ms [48.673 ms, 49.58 ms]	11.045 ms (29.0%)
tracing	43.89 ms [43.517 ms, 44.264 ms]	5.809 ms (15.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.496 ms [37.201 ms, 37.792 ms]	-
appsec	46.956 ms [46.546 ms, 47.366 ms]	9.459 ms (25.2%)
code_origins	45.249 ms [44.846 ms, 45.653 ms]	7.753 ms (20.7%)
iast	45.401 ms [45.003 ms, 45.799 ms]	7.905 ms (21.1%)
profiling	49.24 ms [48.784 ms, 49.697 ms]	11.744 ms (31.3%)
tracing	43.479 ms [43.117 ms, 43.842 ms]	5.983 ms (16.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/base-branch-head-sha
git_commit_date	1753791092	1753795952
git_commit_sha	`dc91a2c`	`21ae796`
release_version	1.51.1-SNAPSHOT~dc91a2c678	1.51.1-SNAPSHOT~21ae796d80

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1753797972	1753797972
ci_job_id	1052810451	1052810451
ci_pipeline_id	72022453	72022453
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-0ez7cc16 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-0ez7cc16 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section baseline
no_agent (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.223 s) : 18223000, 18223000
. : milestone, 18223000,
iast_GLOBAL (18.275 s) : 18275000, 18275000
. : milestone, 18275000,
profiling (15.388 s) : 15388000, 15388000
. : milestone, 15388000,
tracing (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
section candidate
no_agent (15.602 s) : 15602000, 15602000
. : milestone, 15602000,
appsec (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
iast (18.549 s) : 18549000, 18549000
. : milestone, 18549000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.342 s) : 15342000, 15342000
. : milestone, 15342000,
tracing (15.066 s) : 15066000, 15066000
. : milestone, 15066000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.09 s [15.09 s, 15.09 s]	-
appsec	15.026 s [15.026 s, 15.026 s]	-64.0 ms (-0.4%)
iast	18.223 s [18.223 s, 18.223 s]	3.133 s (20.8%)
iast_GLOBAL	18.275 s [18.275 s, 18.275 s]	3.185 s (21.1%)
profiling	15.388 s [15.388 s, 15.388 s]	298.0 ms (2.0%)
tracing	14.904 s [14.904 s, 14.904 s]	-186.0 ms (-1.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.602 s [15.602 s, 15.602 s]	-
appsec	14.85 s [14.85 s, 14.85 s]	-752.0 ms (-4.8%)
iast	18.549 s [18.549 s, 18.549 s]	2.947 s (18.9%)
iast_GLOBAL	17.83 s [17.83 s, 17.83 s]	2.228 s (14.3%)
profiling	15.342 s [15.342 s, 15.342 s]	-260.0 ms (-1.7%)
tracing	15.066 s [15.066 s, 15.066 s]	-536.0 ms (-3.4%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~21ae796d80, baseline=1.51.1-SNAPSHOT~dc91a2c678
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.414 ms) : 2364, 2463
. : milestone, 2414,
iast (2.19 ms) : 2128, 2252
. : milestone, 2190,
iast_GLOBAL (2.234 ms) : 2171, 2296
. : milestone, 2234,
profiling (2.031 ms) : 1982, 2081
. : milestone, 2031,
tracing (2.006 ms) : 1958, 2054
. : milestone, 2006,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.649 ms) : 3433, 3864
. : milestone, 3649,
iast (2.193 ms) : 2131, 2255
. : milestone, 2193,
iast_GLOBAL (2.238 ms) : 2175, 2301
. : milestone, 2238,
profiling (2.045 ms) : 1994, 2095
. : milestone, 2045,
tracing (2.006 ms) : 1958, 2055
. : milestone, 2006,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.414 ms [2.364 ms, 2.463 ms]	944.337 µs (64.3%)
iast	2.19 ms [2.128 ms, 2.252 ms]	720.687 µs (49.1%)
iast_GLOBAL	2.234 ms [2.171 ms, 2.296 ms]	764.28 µs (52.0%)
profiling	2.031 ms [1.982 ms, 2.081 ms]	562.019 µs (38.3%)
tracing	2.006 ms [1.958 ms, 2.054 ms]	536.631 µs (36.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	3.649 ms [3.433 ms, 3.864 ms]	2.17 ms (146.8%)
iast	2.193 ms [2.131 ms, 2.255 ms]	714.473 µs (48.3%)
iast_GLOBAL	2.238 ms [2.175 ms, 2.301 ms]	759.651 µs (51.4%)
profiling	2.045 ms [1.994 ms, 2.095 ms]	566.498 µs (38.3%)
tracing	2.006 ms [1.958 ms, 2.055 ms]	528.283 µs (35.7%)

nikita-tkachenko-datadog · 2025-07-29T10:22:19Z

- Strings.isNotBlank(info.pullRequestBaseBranchSha)
- ? info.pullRequestBaseBranchSha
- : fallback.pullRequestBaseBranchSha,
+ Strings.isNotBlank(info.baseBranch) ? info.baseBranch : fallback.baseBranch,


Perhaps we could extract this into a utility method (or maybe there is one already) to make this more concise, e.g. coalesce(info.baseBranch, fallback.baseBranch) instead of the ternary operator here and below

I like the idea given that this isn't the only place were we combine information, addressed in 18a659b

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` | | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.59.2` -> `2.60.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.68.2` -> `2.69.0` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.51.2` -> `1.52.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0): 6.1.0 ### Changes #### 🚀 New Features - Add support for SVS-VAMANA vector indexing ([#4222](redis/jedis#4222)) - Clarify why new stream entries aren't deleted with XDELEX ([#4218](redis/jedis#4218)) - Add support for new stream commands ([#4211](redis/jedis#4211)) - Add Support for New BITOP Operations in Redis 8.2 ([#4188](redis/jedis#4188)) ([#4190](redis/jedis#4190)) - Add binary stream support for XREAD and XREADGROUP ([#3566](redis/jedis#3566)) ([#4152](redis/jedis#4152)) - Run pipeline in current thread if all the keys on same node ([#4149](redis/jedis#4149)) #### 🐛 Bug Fixes - Restore binary compatibility of SetParams ([#4225](redis/jedis#4225)) - Fix memory leak in JedisClusterInfoCache - replica nodes not cleared ([#4205](redis/jedis#4205)) - Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0 ([#4186](redis/jedis#4186)) #### 🧰 Maintenance - DOC-5471 time series doc examples ([#4210](redis/jedis#4210)) - Bump jackson.version from 2.19.1 to 2.19.2 ([#4208](redis/jedis#4208)) - Fix flaky test ClientCommandsTest.killSkipmeYesNo ([#4206](redis/jedis#4206)) - Bump org.junit:junit-bom from 5.13.2 to 5.13.3 ([#4198](redis/jedis#4198)) - Migrate publishing to Maven Central Portal ([#4199](redis/jedis#4199)) - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#4197](redis/jedis#4197)) - Bump org.junit:junit-bom from 5.13.1 to 5.13.2 ([#4192](redis/jedis#4192)) - DOC-5227 added probabilistic data type examples ([#4184](redis/jedis#4184)) - Bump jackson.version from 2.19.0 to 2.19.1 ([#4180](redis/jedis#4180)) - Update test infra to use latest Redis ([#4179](redis/jedis#4179)) - Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1 ([#4174](redis/jedis#4174)) - Bump org.json:json from [`2025010`](redis/jedis@20250107) to [`2025051`](redis/jedis@20250517) ([#4171](redis/jedis#4171)) - Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4 to 5.5 ([#4170](redis/jedis#4170)) - Fix flaky tests in DocumentTest ([#3617](redis/jedis#3617)) - Add retryable command execution example ([#3780](redis/jedis#3780)) - Bump jackson.version from 2.18.3 to 2.19.0 ([#4160](redis/jedis#4160)) - Bump com.google.code.gson:gson from 2.12.1 to 2.13.1 ([#4161](redis/jedis#4161)) #### Contributors We'd like to thank all the contributors who worked on this release! [@219sansim](https://github.com/219sansim), [@YoHanKi](https://github.com/YoHanKi), [@andy-stark-redis](https://github.com/andy-stark-redis), [@ggivo](https://github.com/ggivo), [@jujn](https://github.com/jujn), [@thachlp](https://github.com/thachlp), [@uglide](https://github.com/uglide) and [@xrayw](https://github.com/xrayw) </details> <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23) ##### Features - handle auto pagination for BigQuery v2 ([#3829](googleapis/sdk-platform-java#3829)) ([025c84c](googleapis/sdk-platform-java@025c84c)) ##### Dependencies - update google auth library dependencies to v1.37.1 ([#3846](googleapis/sdk-platform-java#3846)) ([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5)) - update google http client dependencies to v1.47.1 ([#3848](googleapis/sdk-platform-java#3848)) ([a9a39d7](googleapis/sdk-platform-java@a9a39d7)) </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536) [Compare Source](square/wire@5.3.5...5.3.6) *2025-08-05* ##### CLI - New CLI option `--ignore_unused_roots_and_prunes` ([#3354](square/wire#3354)) ##### JVM - Fix: Handle negative hexadecimal in default values ([#3355](square/wire#3355)) - Optimization: Avoid copying of repeated and map types when mutableTypes are being used ([#3352](square/wire#3352) by \[Rahul Ravikumar]\[tikurahul]) ##### Swift - Fix: Properly disambiguate OneOf enum if it has the same name as enclosing type ([#3350](square/wire#3350) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0): 1.52.0 ### Components #### Application Security Management (WAF) - ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when AppSec is enabled ([#9260](DataDog/dd-trace-java#9260) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#9165](DataDog/dd-trace-java#9165) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#9160](DataDog/dd-trace-java#9160) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Build & Tooling - ✨📖 Automatically register crashtracking via native extensions ([#8851](DataDog/dd-trace-java#8851) - [@MattAlp](https://github.com/MattAlp)) #### Configuration at Runtime - ✨ Create activation origin config for telemetry ([#9064](DataDog/dd-trace-java#9064) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Continuous Integration Visibility - ✨ Update GitLab provided tags ([#9275](DataDog/dd-trace-java#9275) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Fix base branch SHA usage in GitHub Actions ([#9257](DataDog/dd-trace-java#9257) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add `ci.job.id` tag ([#9256](DataDog/dd-trace-java#9256) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add new org to Weaver instrumentation ([#9235](DataDog/dd-trace-java#9235) - [@daniel-mohedano](https://github.com/daniel-mohedano) - thanks for the contribution!) - ✨ Improve Git commit info building ([#9210](DataDog/dd-trace-java#9210) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update Attempt to Fix to v5 ([#9145](DataDog/dd-trace-java#9145) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - ✨📖 Automatically register crashtracking via native extensions ([#8851](DataDog/dd-trace-java#8851) - [@MattAlp](https://github.com/MattAlp)) #### Data Streams Monitoring - ✨ Reduce DSM CPU overheard ([#9151](DataDog/dd-trace-java#9151) - [@kr-igor](https://github.com/kr-igor)) - ✨⚡ DSM optimizations for high throughput scenarios ([#9137](DataDog/dd-trace-java#9137) - [@kr-igor](https://github.com/kr-igor)) #### Database Monitoring - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#9224](DataDog/dd-trace-java#9224) - [@lu-zhengda](https://github.com/lu-zhengda)) #### Dynamic Instrumentation - 🐛 Add URI in string primitives ([#9285](DataDog/dd-trace-java#9285) - [@jpbempel](https://github.com/jpbempel)) - ✨ Increase SourceFile tracking max queue size ([#9271](DataDog/dd-trace-java#9271) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add capping on SourceFile tracking queue ([#9245](DataDog/dd-trace-java#9245) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add third-party filtering in SourceFile tracking ([#9205](DataDog/dd-trace-java#9205) - [@jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - ✨ Add methods to capture embedding and retrieval spans ([#9297](DataDog/dd-trace-java#9297) - [@nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - ✨ Change primary client stats configuration key ([#9196](DataDog/dd-trace-java#9196) - [@amarziali](https://github.com/amarziali)) - ✨ Calculate client stats also if the span kind is eligible ([#9157](DataDog/dd-trace-java#9157) - [@amarziali](https://github.com/amarziali)) - ✨ Backpropagate peer tags ([#9144](DataDog/dd-trace-java#9144) - [@bric3](https://github.com/bric3)) - 🐛 Make client stats reliable in case of downgrade ([#9136](DataDog/dd-trace-java#9136) - [@amarziali](https://github.com/amarziali)) #### Platform components - 🐛 Fix VM options parsing from /proc/fs ([#9255](DataDog/dd-trace-java#9255) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - ✨ Switch profile compression to zstd default ([#9293](DataDog/dd-trace-java#9293) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.29.0 ([#9262](DataDog/dd-trace-java#9262) - [@zhengyu123](https://github.com/zhengyu123)) - Potential memory leak and race with the JVMTI wallclock sampler by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#234 - Downport async-profiler no-allocation changes by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#245 - Adopt openjdk safefetch by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#246 - Safe fetch 64-bit value and pointer by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#247 - Rebase on Async-Profiler 4.1 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#252 - Patch upstream stackWalker.cpp not to fail on unaligned access by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#218 - Remap thread id to avoid bitmap contention by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#229 - Improve performance using Unsafe to activate/deactivate thread filter by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#230 - Unify context propagation by [@zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#231 - 🐛 Fix the profiler stackdepth setting propagation in recent (22+) Java versions ([#9130](DataDog/dd-trace-java#9130) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - ✨ Wrap servlet original PrintWriter on rum injector ([#9146](DataDog/dd-trace-java#9146) - [@amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Create activation origin config for telemetry ([#9064](DataDog/dd-trace-java#9064) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Tracer core - ✨⚡ Reduce span construction overhead by switching to optimized TagMap ([#8589](DataDog/dd-trace-java#8589) - [@dougqh](https://github.com/dougqh)) - 🐛 Match Hands Off Config selectors on process\_arguments value ([#9201](DataDog/dd-trace-java#9201) - [@paullegranddc](https://github.com/paullegranddc)) - ✨ Move JSON generation to sender thread to improve startup time. ([#9197](DataDog/dd-trace-java#9197) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - ✨ Improve agent to avoid loading global config on main thread ([#9190](DataDog/dd-trace-java#9190) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ add injection metadata fields to telemetry forwarder ([#9185](DataDog/dd-trace-java#9185) - [@sydney-tung](https://github.com/sydney-tung)) - 🐛 Avoid race conditions on feature discovery during Writer creation ([#9173](DataDog/dd-trace-java#9173) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Surface potential root cause when agent initialization errors ([#9170](DataDog/dd-trace-java#9170) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Support adding W3C baggage as span tags ([#9169](DataDog/dd-trace-java#9169) - [@rachelyangdog](https://github.com/rachelyangdog)) - ✨⚡ Align our default classloader excludes with OTel ([#9161](DataDog/dd-trace-java#9161) - [@mcculls](https://github.com/mcculls)) - ✨ Backpropagate container tags hash coming from the info endpoint ([#9156](DataDog/dd-trace-java#9156) - [@amarziali](https://github.com/amarziali)) - 🐛 Avoid race conditions and multiple agent discovery feature states ([#9135](DataDog/dd-trace-java#9135) - [@amarziali](https://github.com/amarziali)) ### Instrumentations #### AWS SDK instrumentation - ✨ Enhance Service Representation for Serverless ([#9203](DataDog/dd-trace-java#9203) - [@zarirhamza](https://github.com/zarirhamza)) #### gRPC instrumentation - 🐛 Add check to prevent injection of repeated GRPC headers ([#9246](DataDog/dd-trace-java#9246) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#9224](DataDog/dd-trace-java#9224) - [@lu-zhengda](https://github.com/lu-zhengda)) #### Play Framework instrumentation - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#9160](DataDog/dd-trace-java#9160) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29

fix: use base SHA value in GHA as base branch head sha
cff7170

daniel-mohedano added type: bug fix Bug fix comp: ci visibility Continuous Integration Visibility labels Jul 28, 2025

Merge branch 'master' into daniel.mohedano/base-branch-head-sha
f5db27a

daniel-mohedano marked this pull request as ready for review July 29, 2025 09:03

daniel-mohedano requested review from a team as code owners July 29, 2025 09:03

daniel-mohedano requested review from manuel-alvarez-alvarez and nikita-tkachenko-datadog July 29, 2025 09:03

nikita-tkachenko-datadog approved these changes Jul 29, 2025
View reviewed changes

daniel-mohedano added 2 commits July 29, 2025 14:40

feat: unify coalesce behavior
18a659b

style: spotless
21ae796

daniel-mohedano merged commit bf6c156 into masterJul 30, 2025
504 checks passed

daniel-mohedano deleted the daniel.mohedano/base-branch-head-sha branch July 30, 2025 08:00

github-actionsBot added this to the 1.52.0 milestone Jul 30, 2025

daniel-mohedano mentioned this pull request Jul 30, 2025
Update GitLab provided tags #9275
Merged

Navigation Menu

Uh oh!

Fix base branch SHA usage in GitHub Actions - #9257

Fix base branch SHA usage in GitHub Actions#9257
daniel-mohedano merged 4 commits into
masterfrom
daniel.mohedano/base-branch-head-sha

daniel-mohedano commented Jul 28, 2025•
edited by atlassian Bot
Loading

Uh oh!

pr-commenterBot commented Jul 28, 2025•
edited
Loading

Uh oh!

nikita-tkachenko-datadogJul 29, 2025

Uh oh!

daniel-mohedanoJul 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

daniel-mohedano commented Jul 28, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Contributor Checklist

Uh oh!

pr-commenterBot commented Jul 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

nikita-tkachenko-datadogJul 29, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-mohedanoJul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

daniel-mohedano commented Jul 28, 2025•
edited by atlassian Bot
Loading

pr-commenterBot commented Jul 28, 2025•
edited
Loading