Skip to content

Clean up telemetry messages. Add more profiling flare data. - #9490

Merged
jbachorik merged 2 commits into
masterfrom
jb/prof_telemetry_cleanup
Sep 18, 2025
Merged

Clean up telemetry messages. Add more profiling flare data.#9490
jbachorik merged 2 commits into
masterfrom
jb/prof_telemetry_cleanup

Conversation

@jbachorik

@jbachorikjbachorik commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

Do not use the instrumentation telemetry to report non-error data.
Enhance the profiler flare reporting to allow capturing configuration errors with all details.

Motivation

Improve the supportability of the profiler, especially in cases when the culprit is the environment/configuration.

Additional Notes

Contributor Checklist

JIRA: PROF-12440

@jbachorikjbachorik added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: profiling Profiling labels Sep 8, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

🎯 Code Coverage
Patch Coverage: 69.81%
Total Coverage: 59.77% (+0.09%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2ef935d | Docs | Was this helpful? Give us feedback!

@pr-commenter

pr-commenterBot commented Sep 8, 2025

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterjb/prof_telemetry_cleanup
git_commit_date17581344521758184284
git_commit_shac2aec922ef935d
release_version1.54.0-SNAPSHOT~c2aec92b861.54.0-SNAPSHOT~2ef935db50
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17581859941758185994
ci_job_id11355466851135546685
ci_pipeline_id7683742276837422
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-0-pslh8ess 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-0-pslh8ess 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics.

Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063024
Total [baseline] (10.808 s) : 0, 10807576
Agent [candidate] (1.061 s) : 0, 1061239
Total [candidate] (10.713 s) : 0, 10713381
section appsec
Agent [baseline] (1.234 s) : 0, 1234451
Total [baseline] (10.961 s) : 0, 10960962
Agent [candidate] (1.232 s) : 0, 1232338
Total [candidate] (10.99 s) : 0, 10990271
section iast
Agent [baseline] (1.197 s) : 0, 1196515
Total [baseline] (11.071 s) : 0, 11071058
Agent [candidate] (1.191 s) : 0, 1190762
Total [candidate] (11.155 s) : 0, 11155492
section profiling
Agent [baseline] (1.208 s) : 0, 1208251
Total [baseline] (10.97 s) : 0, 10970361
Agent [candidate] (1.21 s) : 0, 1209531
Total [candidate] (10.992 s) : 0, 10992150
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.063 s-
Agentappsec1.234 s171.426 ms (16.1%)
Agentiast1.197 s133.49 ms (12.6%)
Agentprofiling1.208 s145.227 ms (13.7%)
Totaltracing10.808 s-
Totalappsec10.961 s153.386 ms (1.4%)
Totaliast11.071 s263.482 ms (2.4%)
Totalprofiling10.97 s162.785 ms (1.5%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.061 s-
Agentappsec1.232 s171.099 ms (16.1%)
Agentiast1.191 s129.523 ms (12.2%)
Agentprofiling1.21 s148.292 ms (14.0%)
Totaltracing10.713 s-
Totalappsec10.99 s276.89 ms (2.6%)
Totaliast11.155 s442.111 ms (4.1%)
Totalprofiling10.992 s278.768 ms (2.6%)
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (732.91 ms) : 0, 732910
BytebuddyAgent [candidate] (731.771 ms) : 0, 731771
GlobalTracer [baseline] (254.07 ms) : 0, 254070
GlobalTracer [candidate] (252.902 ms) : 0, 252902
AppSec [baseline] (30.8 ms) : 0, 30800
AppSec [candidate] (30.595 ms) : 0, 30595
Debugger [baseline] (6.472 ms) : 0, 6472
Debugger [candidate] (6.445 ms) : 0, 6445
Remote Config [baseline] (708.64 µs) : 0, 709
Remote Config [candidate] (692.484 µs) : 0, 692
Telemetry [baseline] (15.471 ms) : 0, 15471
Telemetry [candidate] (16.294 ms) : 0, 16294
section appsec
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (754.582 ms) : 0, 754582
BytebuddyAgent [candidate] (754.159 ms) : 0, 754159
GlobalTracer [baseline] (246.609 ms) : 0, 246609
GlobalTracer [candidate] (245.328 ms) : 0, 245328
AppSec [baseline] (170.82 ms) : 0, 170820
AppSec [candidate] (171.293 ms) : 0, 171293
Debugger [baseline] (6.008 ms) : 0, 6008
Debugger [candidate] (5.937 ms) : 0, 5937
Remote Config [baseline] (633.217 µs) : 0, 633
Remote Config [candidate] (622.915 µs) : 0, 623
Telemetry [baseline] (9.25 ms) : 0, 9250
Telemetry [candidate] (8.473 ms) : 0, 8473
IAST [baseline] (23.899 ms) : 0, 23899
IAST [candidate] (23.793 ms) : 0, 23793
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (857.909 ms) : 0, 857909
BytebuddyAgent [candidate] (851.965 ms) : 0, 851965
GlobalTracer [baseline] (247.846 ms) : 0, 247846
GlobalTracer [candidate] (246.311 ms) : 0, 246311
AppSec [baseline] (24.686 ms) : 0, 24686
AppSec [candidate] (26.203 ms) : 0, 26203
Debugger [baseline] (6.085 ms) : 0, 6085
Debugger [candidate] (6.028 ms) : 0, 6028
Remote Config [baseline] (589.467 µs) : 0, 589
Remote Config [candidate] (598.091 µs) : 0, 598
Telemetry [baseline] (8.176 ms) : 0, 8176
Telemetry [candidate] (8.099 ms) : 0, 8099
IAST [baseline] (28.623 ms) : 0, 28623
IAST [candidate] (28.976 ms) : 0, 28976
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (761.466 ms) : 0, 761466
BytebuddyAgent [candidate] (760.755 ms) : 0, 760755
GlobalTracer [baseline] (232.901 ms) : 0, 232901
GlobalTracer [candidate] (232.74 ms) : 0, 232740
AppSec [baseline] (31.213 ms) : 0, 31213
AppSec [candidate] (30.624 ms) : 0, 30624
Debugger [baseline] (13.518 ms) : 0, 13518
Debugger [candidate] (9.77 ms) : 0, 9770
Remote Config [baseline] (767.97 µs) : 0, 768
Remote Config [candidate] (718.273 µs) : 0, 718
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (13.46 ms) : 0, 13460
ProfilingAgent [baseline] (106.98 ms) : 0, 106980
ProfilingAgent [candidate] (108.72 ms) : 0, 108720
Profiling [baseline] (107.609 ms) : 0, 107609
Profiling [candidate] (109.36 ms) : 0, 109360
Loading
Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060933
Total [baseline] (8.626 s) : 0, 8626252
Agent [candidate] (1.061 s) : 0, 1060850
Total [candidate] (8.633 s) : 0, 8632761
section iast
Agent [baseline] (1.194 s) : 0, 1194119
Total [baseline] (9.312 s) : 0, 9312312
Agent [candidate] (1.188 s) : 0, 1188159
Total [candidate] (9.366 s) : 0, 9365835
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.061 s-
Agentiast1.194 s133.186 ms (12.6%)
Totaltracing8.626 s-
Totaliast9.312 s686.06 ms (8.0%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.061 s-
Agentiast1.188 s127.31 ms (12.0%)
Totaltracing8.633 s-
Totaliast9.366 s733.074 ms (8.5%)
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (732.015 ms) : 0, 732015
BytebuddyAgent [candidate] (732.174 ms) : 0, 732174
GlobalTracer [baseline] (252.185 ms) : 0, 252185
GlobalTracer [candidate] (252.275 ms) : 0, 252275
AppSec [baseline] (30.635 ms) : 0, 30635
AppSec [candidate] (30.606 ms) : 0, 30606
Debugger [baseline] (6.399 ms) : 0, 6399
Debugger [candidate] (6.434 ms) : 0, 6434
Remote Config [baseline] (699.387 µs) : 0, 699
Remote Config [candidate] (691.738 µs) : 0, 692
Telemetry [baseline] (16.517 ms) : 0, 16517
Telemetry [candidate] (16.148 ms) : 0, 16148
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (854.126 ms) : 0, 854126
BytebuddyAgent [candidate] (850.649 ms) : 0, 850649
GlobalTracer [baseline] (248.183 ms) : 0, 248183
GlobalTracer [candidate] (247.005 ms) : 0, 247005
AppSec [baseline] (24.727 ms) : 0, 24727
AppSec [candidate] (25.598 ms) : 0, 25598
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.029 ms) : 0, 6029
Remote Config [baseline] (602.407 µs) : 0, 602
Remote Config [candidate] (601.949 µs) : 0, 602
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.172 ms) : 0, 8172
IAST [baseline] (29.646 ms) : 0, 29646
IAST [candidate] (27.756 ms) : 0, 27756
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterjb/prof_telemetry_cleanup
git_commit_date17581344521758184284
git_commit_shac2aec922ef935d
release_version1.54.0-SNAPSHOT~c2aec92b861.54.0-SNAPSHOT~2ef935db50
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17581856581758185658
ci_job_id11355466861135546686
ci_pipeline_id7683742276837422
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-1-dgai9u7m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-1-dgai9u7m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenarioΔ mean http_req_durationΔ mean throughputcandidate mean http_req_durationcandidate mean throughputbaseline mean http_req_durationbaseline mean throughput
scenario:load:petclinic:iast:high_loadbetter
[-1.895ms; -1.038ms] or [-4.121%; -2.258%]
unstable
[-4.096op/s; +10.746op/s] or [-4.024%; +10.556%]
44.505ms105.125op/s45.972ms101.800op/s
scenario:load:petclinic:tracing:high_loadworse
[+0.936ms; +1.743ms] or [+2.180%; +4.056%]
unstable
[-11.054op/s; +4.479op/s] or [-10.150%; +4.113%]
44.298ms105.625op/s42.959ms108.912op/s
scenario:load:petclinic:profiling:high_loadbetter
[-3.175ms; -2.225ms] or [-6.392%; -4.478%]
unstable
[-1.770op/s; +12.570op/s] or [-1.878%; +13.340%]
46.973ms99.625op/s49.673ms94.225op/s
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section baseline
no_agent (36.193 ms) : 35909, 36476
. : milestone, 36193,
appsec (48.452 ms) : 48034, 48871
. : milestone, 48452,
code_origins (45.751 ms) : 45357, 46145
. : milestone, 45751,
iast (45.972 ms) : 45565, 46378
. : milestone, 45972,
profiling (49.673 ms) : 49215, 50131
. : milestone, 49673,
tracing (42.959 ms) : 42588, 43329
. : milestone, 42959,
section candidate
no_agent (35.809 ms) : 35532, 36087
. : milestone, 35809,
appsec (48.137 ms) : 47730, 48543
. : milestone, 48137,
code_origins (45.129 ms) : 44722, 45536
. : milestone, 45129,
iast (44.505 ms) : 44116, 44895
. : milestone, 44505,
profiling (46.973 ms) : 46549, 47398
. : milestone, 46973,
tracing (44.298 ms) : 43919, 44677
. : milestone, 44298,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent36.193 ms [35.909 ms, 36.476 ms]-
appsec48.452 ms [48.034 ms, 48.871 ms]12.259 ms (33.9%)
code_origins45.751 ms [45.357 ms, 46.145 ms]9.558 ms (26.4%)
iast45.972 ms [45.565 ms, 46.378 ms]9.779 ms (27.0%)
profiling49.673 ms [49.215 ms, 50.131 ms]13.48 ms (37.2%)
tracing42.959 ms [42.588 ms, 43.329 ms]6.766 ms (18.7%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent35.809 ms [35.532 ms, 36.087 ms]-
appsec48.137 ms [47.73 ms, 48.543 ms]12.327 ms (34.4%)
code_origins45.129 ms [44.722 ms, 45.536 ms]9.32 ms (26.0%)
iast44.505 ms [44.116 ms, 44.895 ms]8.696 ms (24.3%)
profiling46.973 ms [46.549 ms, 47.398 ms]11.164 ms (31.2%)
tracing44.298 ms [43.919 ms, 44.677 ms]8.489 ms (23.7%)
Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section baseline
no_agent (4.5 ms) : 4443, 4557
. : milestone, 4500,
iast (9.721 ms) : 9562, 9881
. : milestone, 9721,
iast_FULL (14.646 ms) : 14348, 14943
. : milestone, 14646,
iast_GLOBAL (10.961 ms) : 10763, 11159
. : milestone, 10961,
profiling (9.098 ms) : 8954, 9242
. : milestone, 9098,
tracing (7.921 ms) : 7800, 8041
. : milestone, 7921,
section candidate
no_agent (4.398 ms) : 4342, 4453
. : milestone, 4398,
iast (9.576 ms) : 9414, 9739
. : milestone, 9576,
iast_FULL (14.111 ms) : 13830, 14392
. : milestone, 14111,
iast_GLOBAL (10.55 ms) : 10362, 10738
. : milestone, 10550,
profiling (9.199 ms) : 9053, 9344
. : milestone, 9199,
tracing (7.919 ms) : 7804, 8034
. : milestone, 7919,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent4.5 ms [4.443 ms, 4.557 ms]-
iast9.721 ms [9.562 ms, 9.881 ms]5.221 ms (116.0%)
iast_FULL14.646 ms [14.348 ms, 14.943 ms]10.145 ms (225.4%)
iast_GLOBAL10.961 ms [10.763 ms, 11.159 ms]6.461 ms (143.6%)
profiling9.098 ms [8.954 ms, 9.242 ms]4.598 ms (102.2%)
tracing7.921 ms [7.8 ms, 8.041 ms]3.42 ms (76.0%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent4.398 ms [4.342 ms, 4.453 ms]-
iast9.576 ms [9.414 ms, 9.739 ms]5.179 ms (117.8%)
iast_FULL14.111 ms [13.83 ms, 14.392 ms]9.714 ms (220.9%)
iast_GLOBAL10.55 ms [10.362 ms, 10.738 ms]6.152 ms (139.9%)
profiling9.199 ms [9.053 ms, 9.344 ms]4.801 ms (109.2%)
tracing7.919 ms [7.804 ms, 8.034 ms]3.522 ms (80.1%)

Dacapo

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterjb/prof_telemetry_cleanup
git_commit_date17581344521758184284
git_commit_shac2aec922ef935d
release_version1.54.0-SNAPSHOT~c2aec92b861.54.0-SNAPSHOT~2ef935db50
See matching parameters
BaselineCandidate
applicationbiojavabiojava
ci_job_date17581861471758186147
ci_job_id11355466871135546687
ci_pipeline_id7683742276837422
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-2-mjguubv1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-2-mjguubv1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenarioΔ mean execution_timecandidate mean execution_timebaseline mean execution_time
scenario:dacapo:tomcat:appsecbetter
[-1.469ms; -1.127ms] or [-39.039%; -29.950%]
2.465ms3.762ms
Execution time for tomcat
gantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.762 ms) : 3543, 3981
. : milestone, 3762,
iast (2.21 ms) : 2146, 2273
. : milestone, 2210,
iast_GLOBAL (2.253 ms) : 2189, 2318
. : milestone, 2253,
profiling (2.056 ms) : 2004, 2107
. : milestone, 2056,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.465 ms) : 2414, 2516
. : milestone, 2465,
iast (2.211 ms) : 2147, 2274
. : milestone, 2211,
iast_GLOBAL (2.255 ms) : 2191, 2318
. : milestone, 2255,
profiling (2.094 ms) : 2040, 2148
. : milestone, 2094,
tracing (2.04 ms) : 1989, 2090
. : milestone, 2040,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.475 ms [1.463 ms, 1.486 ms]-
appsec3.762 ms [3.543 ms, 3.981 ms]2.287 ms (155.1%)
iast2.21 ms [2.146 ms, 2.273 ms]734.967 µs (49.8%)
iast_GLOBAL2.253 ms [2.189 ms, 2.318 ms]778.416 µs (52.8%)
profiling2.056 ms [2.004 ms, 2.107 ms]580.905 µs (39.4%)
tracing2.038 ms [1.988 ms, 2.088 ms]563.162 µs (38.2%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.477 ms [1.465 ms, 1.488 ms]-
appsec2.465 ms [2.414 ms, 2.516 ms]987.947 µs (66.9%)
iast2.211 ms [2.147 ms, 2.274 ms]734.269 µs (49.7%)
iast_GLOBAL2.255 ms [2.191 ms, 2.318 ms]778.115 µs (52.7%)
profiling2.094 ms [2.04 ms, 2.148 ms]617.631 µs (41.8%)
tracing2.04 ms [1.989 ms, 2.09 ms]562.948 µs (38.1%)
Execution time for biojava
gantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2ef935db50, baseline=1.54.0-SNAPSHOT~c2aec92b86
dateFormat X
axisFormat %s
section baseline
no_agent (14.753 s) : 14753000, 14753000
. : milestone, 14753000,
appsec (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
iast (18.593 s) : 18593000, 18593000
. : milestone, 18593000,
iast_GLOBAL (17.921 s) : 17921000, 17921000
. : milestone, 17921000,
profiling (15.873 s) : 15873000, 15873000
. : milestone, 15873000,
tracing (14.88 s) : 14880000, 14880000
. : milestone, 14880000,
section candidate
no_agent (15.362 s) : 15362000, 15362000
. : milestone, 15362000,
appsec (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
iast (18.443 s) : 18443000, 18443000
. : milestone, 18443000,
iast_GLOBAL (18.126 s) : 18126000, 18126000
. : milestone, 18126000,
profiling (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent14.753 s [14.753 s, 14.753 s]-
appsec15.229 s [15.229 s, 15.229 s]476.0 ms (3.2%)
iast18.593 s [18.593 s, 18.593 s]3.84 s (26.0%)
iast_GLOBAL17.921 s [17.921 s, 17.921 s]3.168 s (21.5%)
profiling15.873 s [15.873 s, 15.873 s]1.12 s (7.6%)
tracing14.88 s [14.88 s, 14.88 s]127.0 ms (0.9%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.362 s [15.362 s, 15.362 s]-
appsec14.932 s [14.932 s, 14.932 s]-430.0 ms (-2.8%)
iast18.443 s [18.443 s, 18.443 s]3.081 s (20.1%)
iast_GLOBAL18.126 s [18.126 s, 18.126 s]2.764 s (18.0%)
profiling15.392 s [15.392 s, 15.392 s]30.0 ms (0.2%)
tracing14.916 s [14.916 s, 14.916 s]-446.0 ms (-2.9%)

@ygreeygree mentioned this pull request Sep 16, 2025
@jbachorik
jbachorikforce-pushed the jb/prof_telemetry_cleanup branch from 75b7182 to 3e5023bCompareSeptember 17, 2025 08:25
@jbachorik
jbachorik marked this pull request as ready for review September 17, 2025 08:29
@jbachorik
jbachorik requested review from a team as code ownersSeptember 17, 2025 08:29
@jbachorik
jbachorikforce-pushed the jb/prof_telemetry_cleanup branch from 4ff8c28 to 36f0745CompareSeptember 17, 2025 12:33

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover print?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really ... this is a CLI and I need to print the collected env report

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that going to expose sensitive information?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly - if we consider the ability to create and execute files in certain location a sensitive information.
But this needs to be invoked via our agent CLI by the user so I would argue that this can not be considered as an escape. It will not be printed until the user asks it to be printed.

Similarly, the flare. The contained information does not contain any known user secrets but if they consider eg. their java version or temp files location secret, which we need to debug issues, then, I guess they agree with sharing this with DD at the time of generating the flare.

@jbachorik
jbachorikforce-pushed the jb/prof_telemetry_cleanup branch 2 times, most recently from a53b31b to 47c218dCompareSeptember 17, 2025 15:28
@jbachorik
jbachorikforce-pushed the jb/prof_telemetry_cleanup branch from 47c218d to 7cad3ecCompareSeptember 18, 2025 08:15
…racking/Initializer.java
Co-authored-by: Andrea Marziali <andrea.marziali@datadoghq.com>
@jbachorik
jbachorik enabled auto-merge (squash) September 18, 2025 08:31
@jbachorik
jbachorik merged commit f44ec39 into masterSep 18, 2025
504 checks passed
@jbachorik
jbachorik deleted the jb/prof_telemetry_cleanup branch September 18, 2025 11:00
@github-actionsgithub-actionsBot added this to the 1.54.0 milestone Sep 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: profilingProfilingtag: no release notesChanges to exclude from release notestype: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jbachorik@dougqh@amarziali@MattAlp