Skip to content

Refactor RUM telemetry - #9526

Merged
sarahchen6 merged 16 commits into
masterfrom
sarahchen6/refactor-rum-telemetry
Sep 16, 2025
Merged

Refactor RUM telemetry#9526
sarahchen6 merged 16 commits into
masterfrom
sarahchen6/refactor-rum-telemetry

Conversation

@sarahchen6

@sarahchen6sarahchen6 commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

Refactor RUM telemetry to send telemetry metrics via HTTP instead of StatsDClient UDP.

Motivation

We want metrics to appear in our org, not on the customer side. This PR fixes#9267. See the screenshot below for metrics seen from a test application:
image

Additional Notes

This was tested by creating an application here, named "Java Injector Test." From there, a sample app was spun up (instructions), and dd.instrumentation_telemetry_data.rum.injection.initialization.succeed and other metrics for integration_name:servlet were checked for on the Metrics Explorer page.

Contributor Checklist

Jira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-679

@datadog-official

datadog-officialBot commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

🎯 Code Coverage
Patch Coverage: 94.74%
Total Coverage: 60.17% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d5dc373 | Docs | Was this helpful? Give us feedback!

@sarahchen6sarahchen6 added type: refactoring comp: telemetry Telemetry comp: rum Realtime User Monitoring labels Sep 13, 2025
@pr-commenter

pr-commenterBot commented Sep 13, 2025

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastersarahchen6/refactor-rum-telemetry
git_commit_date17580265541758030444
git_commit_sha9fc16bbd5dc373
release_version1.54.0-SNAPSHOT~9fc16bb0e51.54.0-SNAPSHOT~d5dc373c1d
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17580322921758032292
ci_job_id11314231051131423105
ci_pipeline_id7661172676611726
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-0-6zy52003 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-0-6zy52003 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 9 unstable metrics.

scenarioΔ mean execution_timecandidate mean execution_timebaseline mean execution_time
scenario:startup:insecure-bank:tracing:Remote Configbetter
[-31.018µs; -14.767µs] or [-4.436%; -2.112%]
676.303µs699.195µs
Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063127
Total [baseline] (8.635 s) : 0, 8634819
Agent [candidate] (1.06 s) : 0, 1059841
Total [candidate] (8.603 s) : 0, 8603242
section iast
Agent [baseline] (1.196 s) : 0, 1196249
Total [baseline] (9.299 s) : 0, 9299310
Agent [candidate] (1.184 s) : 0, 1183868
Total [candidate] (9.289 s) : 0, 9289354
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.063 s-
Agentiast1.196 s133.122 ms (12.5%)
Totaltracing8.635 s-
Totaliast9.299 s664.491 ms (7.7%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.06 s-
Agentiast1.184 s124.027 ms (11.7%)
Totaltracing8.603 s-
Totaliast9.289 s686.112 ms (8.0%)
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (733.682 ms) : 0, 733682
BytebuddyAgent [candidate] (731.828 ms) : 0, 731828
GlobalTracer [baseline] (252.696 ms) : 0, 252696
GlobalTracer [candidate] (251.786 ms) : 0, 251786
AppSec [baseline] (30.77 ms) : 0, 30770
AppSec [candidate] (30.565 ms) : 0, 30565
Debugger [baseline] (6.425 ms) : 0, 6425
Debugger [candidate] (6.331 ms) : 0, 6331
Remote Config [baseline] (699.195 µs) : 0, 699
Remote Config [candidate] (676.303 µs) : 0, 676
Telemetry [baseline] (16.387 ms) : 0, 16387
Telemetry [candidate] (16.268 ms) : 0, 16268
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (856.967 ms) : 0, 856967
BytebuddyAgent [candidate] (847.422 ms) : 0, 847422
GlobalTracer [baseline] (248.103 ms) : 0, 248103
GlobalTracer [candidate] (243.488 ms) : 0, 243488
IAST [baseline] (28.199 ms) : 0, 28199
IAST [candidate] (28.772 ms) : 0, 28772
AppSec [baseline] (25.644 ms) : 0, 25644
AppSec [candidate] (26.967 ms) : 0, 26967
Debugger [baseline] (6.064 ms) : 0, 6064
Debugger [candidate] (6.08 ms) : 0, 6080
Remote Config [baseline] (594.531 µs) : 0, 595
Remote Config [candidate] (610.714 µs) : 0, 611
Telemetry [baseline] (8.206 ms) : 0, 8206
Telemetry [candidate] (8.26 ms) : 0, 8260
Loading
Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061347
Total [baseline] (10.719 s) : 0, 10718870
Agent [candidate] (1.068 s) : 0, 1067531
Total [candidate] (10.734 s) : 0, 10733549
section appsec
Agent [baseline] (1.243 s) : 0, 1242556
Total [baseline] (11.165 s) : 0, 11165091
Agent [candidate] (1.236 s) : 0, 1236405
Total [candidate] (11.044 s) : 0, 11043810
section iast
Agent [baseline] (1.204 s) : 0, 1204244
Total [baseline] (11.114 s) : 0, 11113621
Agent [candidate] (1.2 s) : 0, 1200044
Total [candidate] (10.972 s) : 0, 10972244
section profiling
Agent [baseline] (1.216 s) : 0, 1216282
Total [baseline] (11.045 s) : 0, 11044767
Agent [candidate] (1.207 s) : 0, 1206998
Total [candidate] (10.878 s) : 0, 10877704
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.061 s-
Agentappsec1.243 s181.209 ms (17.1%)
Agentiast1.204 s142.897 ms (13.5%)
Agentprofiling1.216 s154.935 ms (14.6%)
Totaltracing10.719 s-
Totalappsec11.165 s446.221 ms (4.2%)
Totaliast11.114 s394.751 ms (3.7%)
Totalprofiling11.045 s325.897 ms (3.0%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.068 s-
Agentappsec1.236 s168.874 ms (15.8%)
Agentiast1.2 s132.512 ms (12.4%)
Agentprofiling1.207 s139.466 ms (13.1%)
Totaltracing10.734 s-
Totalappsec11.044 s310.262 ms (2.9%)
Totaliast10.972 s238.695 ms (2.2%)
Totalprofiling10.878 s144.156 ms (1.3%)
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (732.233 ms) : 0, 732233
BytebuddyAgent [candidate] (737.455 ms) : 0, 737455
GlobalTracer [baseline] (252.502 ms) : 0, 252502
GlobalTracer [candidate] (253.209 ms) : 0, 253209
AppSec [baseline] (30.594 ms) : 0, 30594
AppSec [candidate] (30.723 ms) : 0, 30723
Debugger [baseline] (6.397 ms) : 0, 6397
Debugger [candidate] (6.412 ms) : 0, 6412
Remote Config [baseline] (688.034 µs) : 0, 688
Remote Config [candidate] (698.456 µs) : 0, 698
Telemetry [baseline] (16.524 ms) : 0, 16524
Telemetry [candidate] (16.382 ms) : 0, 16382
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (761.141 ms) : 0, 761141
BytebuddyAgent [candidate] (757.394 ms) : 0, 757394
GlobalTracer [baseline] (246.816 ms) : 0, 246816
GlobalTracer [candidate] (246.073 ms) : 0, 246073
IAST [baseline] (24.081 ms) : 0, 24081
IAST [candidate] (23.802 ms) : 0, 23802
AppSec [baseline] (170.12 ms) : 0, 170120
AppSec [candidate] (171.468 ms) : 0, 171468
Debugger [baseline] (6.099 ms) : 0, 6099
Debugger [candidate] (5.977 ms) : 0, 5977
Remote Config [baseline] (640.48 µs) : 0, 640
Remote Config [candidate] (614.387 µs) : 0, 614
Telemetry [baseline] (10.878 ms) : 0, 10878
Telemetry [candidate] (8.357 ms) : 0, 8357
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (863.693 ms) : 0, 863693
BytebuddyAgent [candidate] (860.041 ms) : 0, 860041
GlobalTracer [baseline] (245.625 ms) : 0, 245625
GlobalTracer [candidate] (247.017 ms) : 0, 247017
IAST [baseline] (29.085 ms) : 0, 29085
IAST [candidate] (28.885 ms) : 0, 28885
AppSec [baseline] (28.102 ms) : 0, 28102
AppSec [candidate] (26.497 ms) : 0, 26497
Debugger [baseline] (6.094 ms) : 0, 6094
Debugger [candidate] (6.14 ms) : 0, 6140
Remote Config [baseline] (606.51 µs) : 0, 607
Remote Config [candidate] (591.502 µs) : 0, 592
Telemetry [baseline] (8.37 ms) : 0, 8370
Telemetry [candidate] (8.312 ms) : 0, 8312
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (767.468 ms) : 0, 767468
BytebuddyAgent [candidate] (760.633 ms) : 0, 760633
GlobalTracer [baseline] (232.946 ms) : 0, 232946
GlobalTracer [candidate] (232.35 ms) : 0, 232350
AppSec [baseline] (30.37 ms) : 0, 30370
AppSec [candidate] (30.435 ms) : 0, 30435
Debugger [baseline] (11.322 ms) : 0, 11322
Debugger [candidate] (7.412 ms) : 0, 7412
Remote Config [baseline] (731.168 µs) : 0, 731
Remote Config [candidate] (705.786 µs) : 0, 706
Telemetry [baseline] (11.871 ms) : 0, 11871
Telemetry [candidate] (15.646 ms) : 0, 15646
ProfilingAgent [baseline] (108.745 ms) : 0, 108745
ProfilingAgent [candidate] (107.568 ms) : 0, 107568
Profiling [baseline] (109.402 ms) : 0, 109402
Profiling [candidate] (108.215 ms) : 0, 108215
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastersarahchen6/refactor-rum-telemetry
git_commit_date17580265541758030444
git_commit_sha9fc16bbd5dc373
release_version1.54.0-SNAPSHOT~9fc16bb0e51.54.0-SNAPSHOT~d5dc373c1d
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17580318831758031883
ci_job_id11314231061131423106
ci_pipeline_id7661172676611726
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-1-n2ny10h5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-1-n2ny10h5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenarioΔ mean http_req_durationΔ mean throughputcandidate mean http_req_durationcandidate mean throughputbaseline mean http_req_durationbaseline mean throughput
scenario:load:petclinic:no_agent:high_loadworse
[+1.121ms; +1.756ms] or [+3.138%; +4.916%]
unstable
[-13.841op/s; +3.791op/s] or [-10.581%; +2.898%]
37.172ms125.787op/s35.733ms130.812op/s
scenario:load:petclinic:iast:high_loadworse
[+2.776ms; +3.626ms] or [+6.398%; +8.358%]
unstable
[-14.980op/s; +0.130op/s] or [-13.893%; +0.121%]
46.589ms100.400op/s43.388ms107.825op/s
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (35.733 ms) : 35448, 36018
. : milestone, 35733,
appsec (47.709 ms) : 47297, 48121
. : milestone, 47709,
code_origins (45.891 ms) : 45490, 46291
. : milestone, 45891,
iast (43.388 ms) : 43008, 43768
. : milestone, 43388,
profiling (49.196 ms) : 48664, 49727
. : milestone, 49196,
tracing (45.887 ms) : 45497, 46277
. : milestone, 45887,
section candidate
no_agent (37.172 ms) : 36867, 37477
. : milestone, 37172,
appsec (47.63 ms) : 47205, 48055
. : milestone, 47630,
code_origins (44.848 ms) : 44460, 45236
. : milestone, 44848,
iast (46.589 ms) : 46179, 46999
. : milestone, 46589,
profiling (50.126 ms) : 49637, 50615
. : milestone, 50126,
tracing (45.666 ms) : 45285, 46048
. : milestone, 45666,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent35.733 ms [35.448 ms, 36.018 ms]-
appsec47.709 ms [47.297 ms, 48.121 ms]11.976 ms (33.5%)
code_origins45.891 ms [45.49 ms, 46.291 ms]10.157 ms (28.4%)
iast43.388 ms [43.008 ms, 43.768 ms]7.655 ms (21.4%)
profiling49.196 ms [48.664 ms, 49.727 ms]13.462 ms (37.7%)
tracing45.887 ms [45.497 ms, 46.277 ms]10.154 ms (28.4%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent37.172 ms [36.867 ms, 37.477 ms]-
appsec47.63 ms [47.205 ms, 48.055 ms]10.458 ms (28.1%)
code_origins44.848 ms [44.46 ms, 45.236 ms]7.676 ms (20.7%)
iast46.589 ms [46.179 ms, 46.999 ms]9.417 ms (25.3%)
profiling50.126 ms [49.637 ms, 50.615 ms]12.954 ms (34.8%)
tracing45.666 ms [45.285 ms, 46.048 ms]8.494 ms (22.9%)
Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (4.39 ms) : 4340, 4440
. : milestone, 4390,
iast (9.715 ms) : 9555, 9875
. : milestone, 9715,
iast_FULL (14.105 ms) : 13828, 14382
. : milestone, 14105,
iast_GLOBAL (10.584 ms) : 10398, 10769
. : milestone, 10584,
profiling (8.902 ms) : 8753, 9050
. : milestone, 8902,
tracing (7.596 ms) : 7487, 7706
. : milestone, 7596,
section candidate
no_agent (4.426 ms) : 4371, 4480
. : milestone, 4426,
iast (9.489 ms) : 9322, 9656
. : milestone, 9489,
iast_FULL (13.998 ms) : 13720, 14277
. : milestone, 13998,
iast_GLOBAL (10.754 ms) : 10563, 10945
. : milestone, 10754,
profiling (9.08 ms) : 8924, 9237
. : milestone, 9080,
tracing (7.661 ms) : 7553, 7770
. : milestone, 7661,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent4.39 ms [4.34 ms, 4.44 ms]-
iast9.715 ms [9.555 ms, 9.875 ms]5.325 ms (121.3%)
iast_FULL14.105 ms [13.828 ms, 14.382 ms]9.715 ms (221.3%)
iast_GLOBAL10.584 ms [10.398 ms, 10.769 ms]6.194 ms (141.1%)
profiling8.902 ms [8.753 ms, 9.05 ms]4.512 ms (102.8%)
tracing7.596 ms [7.487 ms, 7.706 ms]3.206 ms (73.0%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent4.426 ms [4.371 ms, 4.48 ms]-
iast9.489 ms [9.322 ms, 9.656 ms]5.063 ms (114.4%)
iast_FULL13.998 ms [13.72 ms, 14.277 ms]9.573 ms (216.3%)
iast_GLOBAL10.754 ms [10.563 ms, 10.945 ms]6.328 ms (143.0%)
profiling9.08 ms [8.924 ms, 9.237 ms]4.654 ms (105.2%)
tracing7.661 ms [7.553 ms, 7.77 ms]3.236 ms (73.1%)

Dacapo

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastersarahchen6/refactor-rum-telemetry
git_commit_date17580265541758030444
git_commit_sha9fc16bbd5dc373
release_version1.54.0-SNAPSHOT~9fc16bb0e51.54.0-SNAPSHOT~d5dc373c1d
See matching parameters
BaselineCandidate
applicationbiojavabiojava
ci_job_date17580324131758032413
ci_job_id11314231071131423107
ci_pipeline_id7661172676611726
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-0-bz04brgh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-0-bz04brgh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (15.514 s) : 15514000, 15514000
. : milestone, 15514000,
appsec (14.667 s) : 14667000, 14667000
. : milestone, 14667000,
iast (18.245 s) : 18245000, 18245000
. : milestone, 18245000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
. : milestone, 17936000,
profiling (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
tracing (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
section candidate
no_agent (15.352 s) : 15352000, 15352000
. : milestone, 15352000,
appsec (14.859 s) : 14859000, 14859000
. : milestone, 14859000,
iast (18.468 s) : 18468000, 18468000
. : milestone, 18468000,
iast_GLOBAL (18.117 s) : 18117000, 18117000
. : milestone, 18117000,
profiling (15.62 s) : 15620000, 15620000
. : milestone, 15620000,
tracing (15.247 s) : 15247000, 15247000
. : milestone, 15247000,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.514 s [15.514 s, 15.514 s]-
appsec14.667 s [14.667 s, 14.667 s]-847.0 ms (-5.5%)
iast18.245 s [18.245 s, 18.245 s]2.731 s (17.6%)
iast_GLOBAL17.936 s [17.936 s, 17.936 s]2.422 s (15.6%)
profiling15.567 s [15.567 s, 15.567 s]53.0 ms (0.3%)
tracing15.208 s [15.208 s, 15.208 s]-306.0 ms (-2.0%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.352 s [15.352 s, 15.352 s]-
appsec14.859 s [14.859 s, 14.859 s]-493.0 ms (-3.2%)
iast18.468 s [18.468 s, 18.468 s]3.116 s (20.3%)
iast_GLOBAL18.117 s [18.117 s, 18.117 s]2.765 s (18.0%)
profiling15.62 s [15.62 s, 15.62 s]268.0 ms (1.7%)
tracing15.247 s [15.247 s, 15.247 s]-105.0 ms (-0.7%)
Execution time for tomcat
gantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d5dc373c1d, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.737 ms) : 3519, 3955
. : milestone, 3737,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.051 ms) : 2000, 2102
. : milestone, 2051,
tracing (2.038 ms) : 1989, 2088
. : milestone, 2038,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.712 ms) : 3495, 3930
. : milestone, 3712,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.251 ms) : 2188, 2315
. : milestone, 2251,
profiling (2.053 ms) : 2002, 2104
. : milestone, 2053,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.484 ms [1.472 ms, 1.495 ms]-
appsec3.737 ms [3.519 ms, 3.955 ms]2.253 ms (151.9%)
iast2.202 ms [2.139 ms, 2.265 ms]718.137 µs (48.4%)
iast_GLOBAL2.243 ms [2.18 ms, 2.306 ms]759.524 µs (51.2%)
profiling2.051 ms [2.0 ms, 2.102 ms]567.132 µs (38.2%)
tracing2.038 ms [1.989 ms, 2.088 ms]554.736 µs (37.4%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.48 ms [1.469 ms, 1.492 ms]-
appsec3.712 ms [3.495 ms, 3.93 ms]2.232 ms (150.8%)
iast2.208 ms [2.145 ms, 2.271 ms]728.24 µs (49.2%)
iast_GLOBAL2.251 ms [2.188 ms, 2.315 ms]771.191 µs (52.1%)
profiling2.053 ms [2.002 ms, 2.104 ms]572.955 µs (38.7%)
tracing2.028 ms [1.979 ms, 2.077 ms]548.112 µs (37.0%)

@sarahchen6
sarahchen6 marked this pull request as ready for review September 14, 2025 00:17
@sarahchen6
sarahchen6 requested review from a team as code ownersSeptember 14, 2025 00:17
@sarahchen6
sarahchen6 requested review from PerfectSlayer and amarziali and removed request for a teamSeptember 14, 2025 00:17

@amarzialiamarziali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having refactored the rum telemetry now pointing to the right set of metrics. The changes looks good. I left some items I'd like to clarify

Comment threadinternal-api/src/main/java/datadog/trace/api/rum/RumInjector.java Outdated
Comment threadtelemetry/src/main/java/datadog/telemetry/TelemetrySystem.java Outdated
Comment threadtelemetry/src/main/java/datadog/telemetry/rum/RumPeriodicAction.java Outdated
Comment threaddd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java Outdated

@PerfectSlayerPerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

🎯 suggestion: ‏Now the development is coming to an end, can you add all the RUM related code to the CODEOWNER files? That includes rum folder from internal module (both test and code) and telemetry files (both code and test too). Thanks!

Comment threadinternal-api/src/main/java/datadog/trace/api/rum/RumInjector.java Outdated
Comment threadinternal-api/src/main/java/datadog/trace/api/rum/RumInjectorMetrics.java Outdated
Comment threadinternal-api/src/main/java/datadog/trace/api/rum/RumInjectorMetrics.java Outdated
Comment threadinternal-api/src/main/java/datadog/trace/api/rum/RumInjectorMetrics.java Outdated
@sarahchen6

sarahchen6 commented Sep 15, 2025

Copy link
Copy Markdown
ContributorAuthor

🎯 suggestion: ‏Now the development is coming to an end, can you add all the RUM related code to the CODEOWNER files? That includes rum folder from internal module (both test and code) and telemetry files (both code and test too). Thanks!

Sounds good. I saw that /telemetry/ is already under LP, so I added the internal-api rum code + tests there as well. I know official ownership for RUM is still un-confirmed / not under LP, so let me know if I should place these elsewhere.

Comment thread.github/CODEOWNERS

@PerfectSlayerPerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Thanks for the telemetry fixes and follow up changes!

Sounds good. I saw that /telemetry/ is already under LP, so I added the internal-api rum code + tests there as well. I know official ownership for RUM is still un-confirmed / not under LP, so let me know if I should place these elsewhere.

I was thinking to assign those parts to the @DataDog/rum team 😅 Sorry for not being explicit enough in the first place.

@PerfectSlayerPerfectSlayer removed the comp: telemetry Telemetry label Sep 16, 2025
@sarahchen6
sarahchen6 merged commit 3039978 into masterSep 16, 2025
673 of 674 checks passed
@sarahchen6
sarahchen6 deleted the sarahchen6/refactor-rum-telemetry branch September 16, 2025 14:54
@github-actionsgithub-actionsBot added this to the 1.54.0 milestone Sep 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: rumRealtime User Monitoringtype: bug fixBug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sarahchen6@PerfectSlayer@amarziali