Uh oh!
There was an error while loading. Please reload this page.
Add a test for crash-recovery in the 'vm' stackwalker. - #216
Merged
Conversation
Contributor
Uh oh!
There was an error while loading. Please reload this page.
Contributor
🔧 Report generated by pr-comment-scanbuild |
| #ifdef DEBUG | ||
| #include <signal.h> | ||
| static const char* force_stackwalk_crash_env = getenv("DDPROF_FORCE_STACKWALK_CRASH"); |
| public abstract class AbstractProcessProfilerTest { | ||
| protected final boolean launch(String target, List<String> jvmArgs, String commands, Function<String, Boolean> onStdoutLine, Function<String, Boolean> onStderrLine) throws Exception { | ||
| public static final class LaunchResult { |
Contributor
There was a problem hiding this comment.
Nice to see we are investing in controlled behaviour tests.
If we want to extend these, we could discuss what would be a good structure.
Nothing blocking though it is hard to see the structure. I would expect something like:
TestProcessController controller = new TestProcessController(WorkloadType.CPU_INTENSIVE);
controller.launch();
controller.waitForReady();
controller.sendStartSignal();
controller.waitForWorkingOutput();
controller.assertProfilerDidX();
controller.shutdown();
I think we basically have different parts
- controller
- assertions
- workload
- protocol
jbachorikforce-pushed
the
jb/crashhandler_test
branch
from
May 27, 2025 11:38
bcb1591 to
ac3cd0dCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This adds a smoke test for the crash-recovery mechanism used in the 'vm' stackwalker
Motivation:
A followup for bugfix #214
How to test the change?:
The test runs automatically
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!