Skip to content

Add ThreadFilterBenchmark - #228

Merged
zhengyu123 merged 1 commit into
mainfrom
zgu/thread_filter_benchmark
Jun 18, 2025
Merged

Add ThreadFilterBenchmark#228
zhengyu123 merged 1 commit into
mainfrom
zgu/thread_filter_benchmark

Conversation

@zhengyu123

@zhengyu123zhengyu123 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?:
This benchmark is extracted from @r1viollet 's PR#209

Motivation:
I would like to merge this benchmark separately, so we can use it to experiment various ideas for improving thread filter.

Additional Notes:

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-11548

Unsure? Have a question? Request a review!

@github-actions

Copy link
Copy Markdown
Contributor

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Errors (2)

Warnings (4)

Style Violations (295)

@github-actions

Copy link
Copy Markdown
Contributor

🔧 Report generated by pr-comment-scanbuild

@jbachorikjbachorik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's start with this.
My only objection is that this is, technically, not a microbenchmark. The measured code does a lot of things so it will be highly susceptible to noise.

@zhengyu123
zhengyu123 merged commit d08dfea into mainJun 18, 2025
@zhengyu123
zhengyu123 deleted the zgu/thread_filter_benchmark branch June 18, 2025 14:06
@github-actionsgithub-actionsBot added this to the 1.28.0 milestone Jun 18, 2025
@zhengyu123

Copy link
Copy Markdown
ContributorAuthor

Ok, let's start with this. My only objection is that this is, technically, not a microbenchmark. The measured code does a lot of things so it will be highly susceptible to noise.

I agree. It is actually a stress test - name is a bit misleading.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zhengyu123@jbachorik