Skip to content

Bypass JDK-8313796 workaround for the fixed JDK versions - #273

Merged
zhengyu123 merged 2 commits into
mainfrom
zgu/JDK_8313796_workaround
Sep 16, 2025
Merged

Bypass JDK-8313796 workaround for the fixed JDK versions#273
zhengyu123 merged 2 commits into
mainfrom
zgu/JDK_8313796_workaround

Conversation

@zhengyu123

@zhengyu123zhengyu123 commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?:
Bypass workaround code for JDK-8313796 on JDK versions that already have the fix.

Motivation:
The code to workaround for JDK-8313796, is fragile. It depends on a couple of pattern to guess the offender, then patch loaded value. If it guesses wrong, it can affect correctness of the program.

We want to avoid the workaround if possible.

Additional Notes:

How to test the change?:

  • Regular tests
  • Benchmarks

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-12528

Unsure? Have a question? Request a review!

@pr-commenter

Copy link
Copy Markdown

Benchmarks [x86_64 memleak]

Parameters

BaselineCandidate
configbaselinecandidate
ddprof1.31.01.32.0-zgu_JDK_8313796_workaround-SNAPSHOT
See matching parameters
BaselineCandidate
allocoffoff
cpuoffoff
iterations55
java"11.0.28""11.0.28"
memleakonon
modesmemleakmemleak
walloffoff

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 24 unstable metrics.

@pr-commenter

Copy link
Copy Markdown

Benchmarks [x86_64 memleak,alloc]

Parameters

BaselineCandidate
configbaselinecandidate
ddprof1.31.01.32.0-zgu_JDK_8313796_workaround-SNAPSHOT
See matching parameters
BaselineCandidate
alloconon
cpuoffoff
iterations55
java"11.0.28""11.0.28"
memleakonon
modesmemleak,allocmemleak,alloc
walloffoff

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

@pr-commenter

Copy link
Copy Markdown

Benchmarks [x86_64 alloc]

Parameters

BaselineCandidate
configbaselinecandidate
ddprof1.31.01.32.0-zgu_JDK_8313796_workaround-SNAPSHOT
See matching parameters
BaselineCandidate
alloconon
cpuoffoff
iterations55
java"11.0.28""11.0.28"
memleakoffoff
modesallocalloc
walloffoff

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

@pr-commenter

Copy link
Copy Markdown

Benchmarks [x86_64 cpu,wall]

Parameters

BaselineCandidate
configbaselinecandidate
ddprof1.31.01.32.0-zgu_JDK_8313796_workaround-SNAPSHOT
See matching parameters
BaselineCandidate
allocoffoff
cpuonon
iterations55
java"11.0.28""11.0.28"
memleakoffoff
modescpu,wallcpu,wall
wallonon

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

@pr-commenter

Copy link
Copy Markdown

Benchmarks [aarch64 wall]

Parameters

BaselineCandidate
configbaselinecandidate
ddprof1.31.01.32.0-zgu_JDK_8313796_workaround-SNAPSHOT
See matching parameters
BaselineCandidate
allocoffoff
cpuoffoff
iterations55
java"11.0.28""11.0.28"
memleakoffoff
modeswallwall
wallonon

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

@pr-commenter

Copy link
Copy Markdown

Benchmarks [aarch64 cpu,wall,alloc,memleak]

Parameters

BaselineCandidate
configbaselinecandidate
ddprof1.31.01.32.0-zgu_JDK_8313796_workaround-SNAPSHOT
See matching parameters
BaselineCandidate
alloconon
cpuonon
iterations55
java"11.0.28""11.0.28"
memleakonon
modescpu,wall,alloc,memleakcpu,wall,alloc,memleak
wallonon

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

@zhengyu123
zhengyu123 marked this pull request as ready for review September 15, 2025 18:36
@zhengyu123
zhengyu123 merged commit f3ea224 into mainSep 16, 2025
94 checks passed
@zhengyu123
zhengyu123 deleted the zgu/JDK_8313796_workaround branch September 16, 2025 14:07
@github-actionsgithub-actionsBot added this to the 1.32.0 milestone Sep 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zhengyu123@jbachorik