Relax memory constraint on independent counters by zhengyu123 · Pull Request #275 · DataDog/java-profiler

zhengyu123 · 2025-09-15T18:38:24Z

What does this PR do?:
Relax memory constraints on independent counters.

Motivation:
Independent counter only requires atomic guarantee, stronger memory constraints can result unnecessary performance degradation.

Additional Notes:

How to test the change?:

Regular unit tests
Stress tests
Benchmarks

For Datadog employees:

If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
This PR doesn't touch any of that.
JIRA: PROF-12559

Unsure? Have a question? Request a review!

pr-commenter · 2025-09-15T18:51:13Z

Benchmarks [x86_64 cpu]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu	cpu
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2025-09-15T18:51:30Z

Benchmarks [x86_64 alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	alloc	alloc
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2025-09-15T18:51:35Z

Benchmarks [x86_64 memleak,alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak,alloc	memleak,alloc
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2025-09-15T18:51:49Z

Benchmarks [aarch64 alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	alloc	alloc
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

pr-commenter · 2025-09-15T18:52:18Z

Benchmarks [x86_64 cpu,wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu,wall	cpu,wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 22 unstable metrics.

pr-commenter · 2025-09-15T18:54:03Z

Benchmarks [aarch64 wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	wall	wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

pr-commenter · 2025-09-15T18:54:47Z

Benchmarks [aarch64 memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak	memleak
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

pr-commenter · 2025-09-15T18:54:49Z

Benchmarks [aarch64 cpu,wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu,wall	cpu,wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 22 unstable metrics.

pr-commenter · 2025-09-16T14:13:35Z

Benchmarks [x86_64 wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	wall	wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 22 unstable metrics.

pr-commenter · 2025-09-16T14:13:37Z

Benchmarks [x86_64 memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak	memleak
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 24 unstable metrics.

pr-commenter · 2025-09-16T14:14:02Z

Benchmarks [aarch64 memleak,alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak,alloc	memleak,alloc
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

pr-commenter · 2025-09-16T14:14:20Z

Benchmarks [x86_64 cpu,wall,alloc,memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	cpu,wall,alloc,memleak	cpu,wall,alloc,memleak
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2025-09-16T14:16:59Z

Benchmarks [aarch64 cpu]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu	cpu
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 20 unstable metrics.

pr-commenter · 2025-09-16T14:17:12Z

Benchmarks [aarch64 cpu,wall,alloc,memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.31.0	1.32.0-zgu_relaxing_counters-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	cpu,wall,alloc,memleak	cpu,wall,alloc,memleak
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

jbachorik · 2025-09-18T11:49:44Z

What would be the definition of Independent counter ?

zhengyu123 · 2025-09-18T19:34:37Z

What would be the definition of Independent counter ?

It means that no memory access depends on the counter value.

Relax memory constraint on counter
aec33f3

test
ddc9eb0

zhengyu123 added 4 commits September 16, 2025 11:57

Revert test
e61aa4f

Fixed heap
14c8158

additional counters
55a2844

One more
fd1af3b

zhengyu123 changed the title ~~Relax memory constraint on counter~~Relax memory constraint on countersSep 17, 2025

zhengyu123 changed the title ~~Relax memory constraint on counters~~Relax memory constraint on independent countersSep 17, 2025

zhengyu123 marked this pull request as ready for review September 17, 2025 16:45

zhengyu123 requested review from MattAlp, jbachorik and r1viollet September 17, 2025 16:46

jbachorik approved these changes Sep 19, 2025
View reviewed changes

zhengyu123 merged commit 7de6b47 into mainSep 19, 2025
183 of 184 checks passed

zhengyu123 deleted the zgu/relaxing_counters branch September 19, 2025 12:30

github-actionsBot added this to the 1.32.0 milestone Sep 19, 2025

zhengyu123 mentioned this pull request Sep 22, 2025
Bump ddprof to 1.32.0 DataDog/dd-trace-java#9584
Merged

Uh oh!

Conversation

zhengyu123 commented Sep 15, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 cpu]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 alloc]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 memleak,alloc]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [aarch64 alloc]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 cpu,wall]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [aarch64 wall]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [aarch64 memleak]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [aarch64 cpu,wall]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 wall]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 memleak]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [aarch64 memleak,alloc]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [x86_64 cpu,wall,alloc,memleak]

Parameters

Summary

Uh oh!

pr-commenterBot commented Sep 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [aarch64 cpu]

zhengyu123 commented Sep 15, 2025•
edited by atlassian Bot
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 15, 2025•
edited
Loading

pr-commenterBot commented Sep 16, 2025•
edited
Loading

pr-commenterBot commented Sep 16, 2025•
edited
Loading

pr-commenterBot commented Sep 16, 2025•
edited
Loading

pr-commenterBot commented Sep 16, 2025•
edited
Loading

pr-commenterBot commented Sep 16, 2025•
edited
Loading

pr-commenterBot commented Sep 16, 2025•
edited
Loading