Skip to content

fix: backport libgcc and invalid method pointer fixes to 1.48 - #711

Merged
kaahos merged 3 commits into
release/1.48._from
backport/pr-689-pr-699-release-1.48
Aug 3, 2026
Merged

fix: backport libgcc and invalid method pointer fixes to 1.48#711
kaahos merged 3 commits into
release/1.48._from
backport/pr-689-pr-699-release-1.48

Conversation

@kaahos

Copy link
Copy Markdown
Contributor

Summary

Why

These runtime fixes need to ship in the 1.48 patch line. The backport intentionally excludes the larger context-storage removal from PR #696 and all unrelated post-1.48 changes.

Validation

  • spotlessApply passed before each backport commit
  • affected debug GTests passed: faultInjection_ut (2), jvmSupport_ut (7), and hotspotMethodId_ut (1)
  • full testDebug completed 269 Java tests with 64 skipped and two acknowledged failures:
    • VtableReceiverFrameTest
    • LoadLibraryTest

The complete debug GTest aggregate passed during testDebug.

@datadog-prod-us1-5

This comment has been minimized.

@kaahos
kaahos marked this pull request as ready for review August 3, 2026 14:19
@kaahos
kaahos requested a review from a team as a code ownerAugust 3, 2026 14:19
@dd-octo-sts

dd-octo-stsBot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run:#30828232385 | Commit:2d110e2 | Duration: 14m 44s (longest job)

All 32 test jobs passed

Status Overview

JDKglibc-aarch64/debugglibc-amd64/debugmusl-aarch64/debugmusl-amd64/debug
8---
8-ibm---
8-j9--
8-librca--
8-orcl---
11---
11-j9--
11-librca--
17--
17-graal--
17-j9--
17-librca--
21--
21-graal--
21-librca--
25--
25-graal--
25-librca--

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-08-03 15:53:47 UTC

@zhengyu123

Copy link
Copy Markdown
Contributor

Do you really want to include fault-injection in this backport? You can easily strip it out.

@kaahos

Copy link
Copy Markdown
ContributorAuthor

@zhengyu123 you're right about that, thanks for the comment. I have removed this part in the latest commit. Let me know what you think.

@kaahos
kaahos requested a review from zhengyu123August 3, 2026 15:42
@dd-octo-sts

Copy link
Copy Markdown
Contributor

Benchmark Results (commit d0ba1b5)

Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128633509 Commit: d0ba1b5b421c744073e1192da6a8dd4293a64353

⚠️ Significant outliers

  • 🟢 future-genetic (JDK 21): runtime -3.4% (2129→2057 ms)
Runtime details (per benchmark × JDK)
BenchmarkJDKLatestDevΔ (dev vs latest)Issues L/D
akka-uct21✅ 10261 ms (21 iters)✅ 10341 ms (21 iters)≈ +0.8% (±12%)— / —
akka-uct25✅ 8763 ms (24 iters)✅ 8859 ms (24 iters)≈ +1.1% (±10.2%)— / —
finagle-chirper21✅ 5936 ms (33 iters)✅ 5912 ms (33 iters)≈ -0.4% (±24.4%)⚠️ W:3 / ⚠️ W:3
finagle-chirper25✅ 5428 ms (36 iters)✅ 5449 ms (36 iters)≈ +0.4% (±24.7%)⚠️ W:3 / ⚠️ W:3
fj-kmeans21✅ 2723 ms (69 iters)✅ 2671 ms (69 iters)≈ -1.9% (±2.6%)— / —
fj-kmeans25✅ 2774 ms (68 iters)✅ 2821 ms (66 iters)≈ +1.7% (±2.7%)— / —
future-genetic21✅ 2129 ms (87 iters)✅ 2057 ms (90 iters)🟢 -3.4%— / —
future-genetic25✅ 2034 ms (92 iters)✅ 2019 ms (93 iters)≈ -0.7% (±2.5%)— / —
naive-bayes21✅ 1256 ms (136 iters)✅ 1289 ms (132 iters)≈ +2.6% (±33.3%)— / —
naive-bayes25✅ 1024 ms (167 iters)✅ 1019 ms (168 iters)≈ -0.5% (±31.6%)— / —
reactors25✅ 18675 ms (15 iters)✅ 18585 ms (15 iters)≈ -0.5% (±4.6%)— / —
Internal counter details (ddprof)

ddprof internal counters, latest / dev (✅ = 0, · = unavailable):

BenchmarkJDKDropped recDropped jvmtiDropped traceSkipped WCAGCT failUnwind fail
akka-uct21✅ / ✅✅ / ✅4 / 12025 / 1909✅ / ✅✅ / ✅
akka-uct25✅ / ✅✅ / ✅1 / 12121 / 2256✅ / ✅✅ / ✅
finagle-chirper21✅ / ✅✅ / ✅3 / 28374 / 8354✅ / ✅✅ / ✅
finagle-chirper25✅ / ✅✅ / ✅1 / 28410 / 8329✅ / ✅✅ / ✅
fj-kmeans21✅ / ✅✅ / ✅✅ / 21242 / 1244✅ / ✅✅ / ✅
fj-kmeans25✅ / ✅✅ / ✅2 / 21269 / 1261✅ / ✅✅ / ✅
future-genetic21✅ / ✅✅ / ✅✅ / 12937 / 2949✅ / ✅✅ / ✅
future-genetic25✅ / ✅✅ / ✅✅ / 12937 / 2919✅ / ✅✅ / ✅
naive-bayes21✅ / ✅✅ / ✅1 / 23525 / 3509✅ / ✅✅ / ✅
naive-bayes25✅ / ✅✅ / ✅7 / 63458 / 3458✅ / ✅✅ / ✅
reactors21✅ / ·✅ / ·2 / ·1757 / ·✅ / ·✅ / ·
reactors25✅ / ✅✅ / ✅2 / ✅1924 / 1823✅ / ✅✅ / ✅

@zhengyu123zhengyu123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaahos
kaahos merged commit 085f4f4 into release/1.48._Aug 3, 2026
104 checks passed
@kaahos
kaahos deleted the backport/pr-689-pr-699-release-1.48 branch August 3, 2026 17:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaahos@zhengyu123