Uh oh!
There was an error while loading. Please reload this page.
feat: expose native pattern capabilities - #119
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an explicit, immutable “capabilities” surface for native named-LTS compiled patterns, and extends tests to ensure those capabilities remain stable across compilation paths and that interruptibility checks execute on the caller thread.
Changes:
- Add
ReggieNativeCapabilityenum to represent guaranteed properties of native named-LTS patterns. - Expose
ReggieCompiledPattern.capabilities()returning a shared immutable capability set. - Add/extend runtime tests covering capability stability (direct compile, cached compile, eviction/recompile, separate compiler instances) and verifying interrupt checks run on the matching caller thread.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| reggie-runtime/src/main/java/com/datadoghq/reggie/runtime/ReggieNativeCapability.java | Defines the stable capability enum and documents interruptibility/linearity guarantees. |
| reggie-runtime/src/main/java/com/datadoghq/reggie/runtime/ReggieCompiledPattern.java | Exposes an immutable capability set via capabilities(). |
| reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/ReggieNativeCapabilityTest.java | Adds coverage for capability immutability and stability across caching/eviction/compiler instances. |
| reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/InterruptibleCharSequenceTest.java | Adds a test asserting interruption checks run on the matching caller thread. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:d08019ddde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
d08019d to
2e68756CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## agent/logs-reggie-l1h #119 +/- ##
=======================================================
Coverage 84.4% 84.5% Complexity 1 1 =======================================================
Files 155 156 +1 Lines 43283 43277 -6 Branches 5910 5910 =======================================================
Hits 36571 36571 + Misses 4918 4913 -5 + Partials 1794 1793 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
6e38c24 to
64923c1Compare64923c1 to
c3fcc3eCompare
Summary
Exposes explicit immutable capabilities for native named-LTS compiled patterns:
CharSequencematching.The capability set is stable across direct compilation, bounded-cache hits, eviction/recompile, and independent compiler instances.
Validation
./gradlew :reggie-runtime:test --tests com.datadoghq.reggie.runtime.ReggieNativeCapabilityTest --tests com.datadoghq.reggie.runtime.InterruptibleCharSequenceTest./gradlew :reggie-runtime:test./gradlew spotlessApply