Skip to content

Don't use Nan in WallProfiler::GetContextsByNode - #190

Merged
szegedi merged 1 commit into
mainfrom
szegedi/stricter-checks
Jan 20, 2025
Merged

Don't use Nan in WallProfiler::GetContextsByNode#190
szegedi merged 1 commit into
mainfrom
szegedi/stricter-checks

Conversation

@szegedi

Copy link
Copy Markdown

Retrieves the Isolate and its current Context once and uses it for all operations in WallProfiler::GetContextsByNode

@github-actions

github-actionsBot commented Jan 17, 2025

Copy link
Copy Markdown

Overall package size

Self size: 9.53 MB
Deduped: 9.9 MB
No deduping: 9.9 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.4 | 226 kB | 226 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegediszegedi added the semver-patch Bug or security fixes, mainly label Jan 17, 2025
@szegedi
szegediforce-pushed the szegedi/stricter-checks branch 2 times, most recently from d7f84bf to 457e650CompareJanuary 17, 2025 10:41
@pr-commenter

pr-commenterBot commented Jan 17, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-17 15:11:09

Comparing candidate commit f8649b9 in PR branch szegedi/stricter-checks with baseline commit faee6c2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 89 metrics, 31 unstable metrics.

r1viollet
r1viollet previously approved these changes Jan 17, 2025

@r1violletr1viollet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nsavoire
nsavoire previously approved these changes Jan 17, 2025
Base automatically changed from szegedi/capture-async-id to mainJanuary 17, 2025 15:03
@szegedi
szegedi dismissed stale reviews from nsavoire and r1violletJanuary 17, 2025 15:03

The base branch was changed.

@szegedi
szegediforce-pushed the szegedi/stricter-checks branch from 4e1c4db to f8649b9CompareJanuary 17, 2025 15:06
@szegedi
szegedi merged commit e28fc06 into mainJan 20, 2025
@szegedi
szegedi deleted the szegedi/stricter-checks branch January 20, 2025 11:21
@szegediszegedi mentioned this pull request Jan 22, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patchBug or security fixes, mainly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@szegedi@nsavoire@r1viollet