Skip to content

Workaround for v8 crash - #212

Merged
nsavoire merged 1 commit into
mainfrom
nsavoire/workaround_v8_crash
May 10, 2025
Merged

Workaround for v8 crash#212
nsavoire merged 1 commit into
mainfrom
nsavoire/workaround_v8_crash

Conversation

@nsavoire

Copy link
Copy Markdown

What does this PR do?:

v8 destroys the heap profiler after the heap spaces which can cause crashes: https://github.com/nodejs/node/blob/v24.0.1/deps/v8/src/heap/heap.cc#L6227-L6246

This workaround stops the heap profiler before the heap spaces are destroyed.

v8 destroys the heap profiler after the heap spaces which can cause crashes:
https://github.com/nodejs/node/blob/v24.0.1/deps/v8/src/heap/heap.cc#L6227-L6246
This workaround stops the heap profiler before the heap spaces are destroyed.
@nsavoire
nsavoire requested a review from szegedi as a code ownerMay 9, 2025 13:20
@github-actions

Copy link
Copy Markdown

Overall package size

Self size: 9.54 MB
Deduped: 9.91 MB
No deduping: 9.91 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.4 | 226 kB | 226 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@nsavoirensavoire added the semver-minor Usually minor non-breaking improvements label May 9, 2025
@pr-commenter

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-09 13:24:29

Comparing candidate commit b542f64 in PR branch nsavoire/workaround_v8_crash with baseline commit da7e7b4 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 28 unstable metrics.

scenario:profiler-idle-with-wall-profiler-18

  • 🟩 cpu_user_time [-6.794ms; -1.374ms] or [-9.598%; -1.942%]

scenario:profiler-light-load-with-wall-profiler-20

  • 🟩 cpu_user_time [-11.801ms; -4.589ms] or [-11.166%; -4.342%]

@nsavoire
nsavoire merged commit 55ac3fa into mainMay 10, 2025
@nsavoire
nsavoire deleted the nsavoire/workaround_v8_crash branch May 10, 2025 00:57
nsavoire added a commit that referenced this pull request May 10, 2025
v8 destroys the heap profiler after the heap spaces which can cause crashes:
https://github.com/nodejs/node/blob/v24.0.1/deps/v8/src/heap/heap.cc#L6227-L6246
This workaround stops the heap profiler before the heap spaces are destroyed.
nsavoire added a commit that referenced this pull request May 10, 2025
v8 destroys the heap profiler after the heap spaces which can cause crashes:
https://github.com/nodejs/node/blob/v24.0.1/deps/v8/src/heap/heap.cc#L6227-L6246
This workaround stops the heap profiler before the heap spaces are destroyed.
@nsavoirensavoire mentioned this pull request Dec 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minorUsually minor non-breaking improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nsavoire@szegedi