Uh oh!
There was an error while loading. Please reload this page.
Switch time profiling to use lazy load stop and collect method by default - #305
Merged
Conversation
Overall package sizeSelf size: 2.01 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
IlyasShabi
marked this pull request as ready for review
March 23, 2026 10:28
Uh oh!
There was an error while loading. Please reload this page.
szegedi pushed a commit
that referenced
this pull request
Mar 27, 2026
Merged
szegedi pushed a commit
that referenced
this pull request
Mar 27, 2026
szegedi added a commit
that referenced
this pull request
May 19, 2026
…#329) * Revert "use stop and collect on time profiler (#305)" This reverts commit 85f2457. * Revert "Switch heap profiling to use lazy allocation profile method by default (#281)" This reverts commit fb3d75d. * Touchup for TS6 changes introduced after the reverted commits. Specifically enforcing TS2883 under `composite: true`: any function whose inferred return type names a non-imported type must be annotated explicitly.
IlyasShabi pushed a commit
that referenced
this pull request
May 19, 2026
…#329) * Revert "use stop and collect on time profiler (#305)" This reverts commit 85f2457. * Revert "Switch heap profiling to use lazy allocation profile method by default (#281)" This reverts commit fb3d75d. * Touchup for TS6 changes introduced after the reverted commits. Specifically enforcing TS2883 under `composite: true`: any function whose inferred return type names a non-imported type must be annotated explicitly.
IlyasShabi added a commit
that referenced
this pull request
May 19, 2026
* use trusted publishing for dev releases (#310) * use trusted publishing for dev releases * use release publisher file to release dev tag too (#311) use release publisher file to release dev tag * chore(deps): minor: sinon · patch: @types/node, @types/sinon (#317) Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com> * build(deps-dev): bump typescript from 5.9.3 to 6.0.3 (#315) * build(deps-dev): bump typescript from 5.9.3 to 6.0.3 Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.3. - [Commits](microsoft/TypeScript@v5.9.3...v6.0.3) --- updated-dependencies: - dependency-name: typescript dependency-version: 6.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix(ts): explicit types in tsconfig and bump @types/node to 25.6.0 TypeScript 6.0 no longer auto-loads @types/* by default with this project's tsconfig setup, so Node and Mocha globals (Buffer, process, __dirname, describe, it, ...) became unresolved. Pin "types" to ["node", "mocha"] so the compiler picks them up explicitly. Also bumps @types/node from 25.5.2 to 25.6.0, superseding #314. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Attila Szegedi <attila.szegedi@datadoghq.com> * chore(deps): node-gyp-build (major → 4.8.4) (#316) Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 25.6.0 to 25.7.0 (#324) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 25.6.0 to 25.7.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.7.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint-plugin-n from 17.24.0 to 18.0.1 (#320) Bumps [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) from 17.24.0 to 18.0.1. - [Release notes](https://github.com/eslint-community/eslint-plugin-n/releases) - [Changelog](https://github.com/eslint-community/eslint-plugin-n/blob/master/CHANGELOG.md) - [Commits](eslint-community/eslint-plugin-n@v17.24.0...v18.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-n dependency-version: 18.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump node-gyp-build from 3.9.0 to 4.8.4 (#284) Bumps [node-gyp-build](https://github.com/prebuild/node-gyp-build) from 3.9.0 to 4.8.4. - [Commits](prebuild/node-gyp-build@v3.9.0...v4.8.4) --- updated-dependencies: - dependency-name: node-gyp-build dependency-version: 4.8.4 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Attila Szegedi <szegedi@users.noreply.github.com> * build(deps-dev): bump semver from 7.7.4 to 7.8.0 (#323) Bumps [semver](https://github.com/npm/node-semver) from 7.7.4 to 7.8.0. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.7.4...v7.8.0) --- updated-dependencies: - dependency-name: semver dependency-version: 7.8.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump sinon from 21.1.2 to 22.0.0 (#325) Bumps [sinon](https://github.com/sinonjs/sinon) from 21.1.2 to 22.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v21.1.2...v22.0.0) --- updated-dependencies: - dependency-name: sinon dependency-version: 22.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Node.js v25 to benchmarks (#326) * support Node.js v26 (#327) * support Node.js v26 * Revert lazy profile-tree changes to mitigate CpuProfile::Delete crash (#329) * Revert "use stop and collect on time profiler (#305)" This reverts commit 85f2457. * Revert "Switch heap profiling to use lazy allocation profile method by default (#281)" This reverts commit fb3d75d. * Touchup for TS6 changes introduced after the reverted commits. Specifically enforcing TS2883 under `composite: true`: any function whose inferred return type names a non-imported type must be annotated explicitly. * v14.5.2 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Attila Szegedi <attila.szegedi@datadoghq.com> Co-authored-by: Attila Szegedi <szegedi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Switch time profiling to use
stopAndCollectinstead of the legacystop, and remove the old code path.Motivation:
PR #287 showed (via CI benchmarks) that stopAndCollect cuts memory usage by ~52% for a significant profile size. This change makes using stop and collect as the default for time profiling.