Uh oh!
There was an error while loading. Please reload this page.
Update zstd to 1.3.0 - #18
Merged
Merged
Conversation
Viq111
approved these changes
Aug 10, 2017
Viq111
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
Benchmarks (same payload as #1):
Current branch:
local:~/datadog/zstd (1.x✔) ᐅeval"$(gimme 1.8.3)"goversiongo1.8.3darwin/amd64local:~/datadog/zstd (1.x✔) ᐅgotest-bench . -benchtime10sBenchmarkStreamCompression-4100130811864ns/op76.22MB/sBenchmarkStreamDecompression-450032245337ns/op309.21MB/sBenchmarkCompression-4100119040542ns/op83.76MB/sBenchmarkDecompression-4100021742581ns/op458.57MB/s---BENCH: BenchmarkDecompression-4
zstd_test.go:156: Reducedfrom9970564to3444121
zstd_test.go:156: Reducedfrom9970564to3444121
zstd_test.go:156: Reducedfrom9970564to3444121local:~/datadog/zstd (1.x✔) ᐅeval"$(gimme 1.9rc2)"goversiongo1.9rc2darwin/amd64local:~/datadog/zstd (1.x✔) ᐅgotest-bench . -benchtime10s
goos: darwin
goarch: amd64BenchmarkStreamCompression-4100122424710ns/op81.44MB/sBenchmarkStreamDecompression-450031619403ns/op315.33MB/sBenchmarkCompression-4100118267762ns/op84.31MB/sBenchmarkDecompression-450022691712ns/op439.39MB/s---BENCH: BenchmarkDecompression-4
zstd_test.go:156: Reducedfrom9970564to3444121
zstd_test.go:156: Reducedfrom9970564to3444121
zstd_test.go:156: Reducedfrom9970564to3444121Yourbranch (zstd1.3.0):
local:~/datadog/zstd (elijah/1.3.0✔) ᐅeval"$(gimme 1.8.3)"goversiongo1.8.3darwin/amd64local:~/datadog/zstd (elijah/1.3.0✔) ᐅgotest-bench . -benchtime10sBenchmarkStreamCompression-4100133005398ns/op74.96MB/sBenchmarkStreamDecompression-450031422800ns/op317.30MB/sBenchmarkCompression-4100126352613ns/op78.91MB/sBenchmarkDecompression-4100020781138ns/op479.79MB/s---BENCH: BenchmarkDecompression-4
zstd_test.go:156: Reducedfrom9970564to3429982
zstd_test.go:156: Reducedfrom9970564to3429982
zstd_test.go:156: Reducedfrom9970564to3429982local:~/datadog/zstd (elijah/1.3.0✔) ᐅeval"$(gimme 1.9rc2)"goversiongo1.9rc2darwin/amd64local:~/datadog/zstd (elijah/1.3.0✔) ᐅgotest-bench . -benchtime10sgoos: darwingoarch: amd64BenchmarkStreamCompression-4100143386144ns/op69.54MB/sBenchmarkStreamDecompression-450031575229ns/op315.77MB/sBenchmarkCompression-4100128747846ns/op77.44MB/sBenchmarkDecompression-4100020747701ns/op480.56MB/s---BENCH: BenchmarkDecompression-4
zstd_test.go:156: Reducedfrom9970564to3429982
zstd_test.go:156: Reducedfrom9970564to3429982
zstd_test.go:156: Reducedfrom9970564to3429982So overall compression seems a tiny bit slower (~2-5%), decompression faster (~10%) and compression ratio (just tested on mr payload though) is roughtly the same (change: -0.4%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.