Uh oh!
There was an error while loading. Please reload this page.
keybase: catch input errors - #238
Open
KhasMek wants to merge 1 commit into
Open
Conversation
Certain input errors were causing errors from keybase. Let's catch them and feed them to the console output for the user. In most cases, this isn't too critical for the user to see. However, I feel it's more important to show than nothing at all. This way the result can not be considered a false negative by anyone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain input errors were causing errors from keybase. Let's catch them and feed them to the console output for the user.
In most cases, this isn't too critical for the user to see. However, I feel it's more important to show than nothing at all. This way the result can not be considered a false negative by anyone.
I know this is somewhat a duplicate of #237, but I think it's important to catch the exception and show it to the user.