Land preserved DMX output + app-shell/UITests work (preservation/plotforge-dmx-20260711) - #5
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:793c483def
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (command.type === "auth" && !session.authenticated) { | ||
| handleAuth(session, command); | ||
| } else { | ||
| void handleCommand(session, command); |
There was a problem hiding this comment.
When a client sends a frame immediately followed by blackout or disconnects while the UDP send is pending, this fire-and-forget call runs both handlers concurrently. The blackout path can observe an empty activeOutputs, acknowledge without emitting zeros, and then the frame handler can finish later and register the nonzero output; ongoing heartbeats then prevent the watchdog from clearing it. Process each session's commands in order, or register/coordinate pending outputs before allowing blackout and close cleanup.
Useful? React with 👍 / 👎.
| private func disarmOutput() { | ||
| isArmed = false | ||
| status = "Output disarmed. Send blackout before disconnecting if nonzero values were active." | ||
| errorMessage = "" |
There was a problem hiding this comment.
After a nonzero test frame has been sent, pressing Disarm only flips local UI state and emits no zero frame. Lighting nodes configured to hold their last look can therefore leave the fixture active, while the resulting isArmed = false also disables the Blackout action that the status text tells the user to perform. Disarm should send the blackout burst before transitioning to the idle state, with equivalent cleanup when the panel disappears or the app backgrounds.
Useful? React with 👍 / 👎.
| try { | ||
| const frame = validateFrameCommand(command, session.config); | ||
| const bytesSent = await emitFrame(session, frame, frame.data, frame.sequence); | ||
| session.activeOutputs.set(activeOutputKey(frame), frame); |
There was a problem hiding this comment.
When an authenticated client submits frames faster than config.maxFps, every command is forwarded directly to UDP because the configured limit is never consulted on this send path. The relay advertises maxFps during authentication and clamps the setting to 44, but currently permits an unlimited packet rate, which can exceed a gateway's supported refresh rate; rate-limit or coalesce frames per output key before calling emitFrame.
Useful? React with 👍 / 👎.
…obile-dock conflicts: keep TOOL_DEFINITIONS-driven dock + flex layout; DMX output tool renders via TOOL_DEFINITIONS)
Uh oh!
There was an error while loading. Please reload this page.
Lands the three commits that have existed only on the local
preservation/plotforge-dmx-20260711checkout (now pushed):fd3dc35[feat] Preserve DMX output implementation2bec163[merge] Integrate remote main after DMX preservation793c483[feat] Standalone app-shell session/workspace work + UITests target (checkpoint before repo relocation)55 files, +9359 / −55 vs
main. Opened as part of the 2026-08-16 iOS build hardening sweep so this work is reviewable and not at risk of being lost with a local checkout. No history rewritten; merge (don't squash) to keep the preservation commits intact.Note:
native/**builds clean at bothmainand this branch on Xcode 26.5 (verified locally 2026-08-16). PR #4 adds aniOS Buildworkflow; once merged, this PR will get the same check.