Uh oh!
There was an error while loading. Please reload this page.
add manual climb - #59
Conversation
dfang314
left a comment
There was a problem hiding this comment.
Code failed on stop build day. Are fixes incorporated in this pr? Also, SmartDashboard keys don't match current naming convention (same as if it were a book title).
dfang314
commented
Mar 3, 2019
Resolves #72 |
mustangzr1
commented
Mar 3, 2019
@kevinzwang Please address the merge conflict here. |
SaltyJoke
commented
Mar 5, 2019
Resolves #84 |
It would make more sense and be cleaner code to negate climber.getEncDistance() instead of all the places where it is called, no? |
kevinzwang
commented
Mar 5, 2019
@SaltyJoke WPILib has a function to reverse encoder values |
SaltyJoke
commented
Mar 5, 2019
|
There was a problem hiding this comment.
The smartdashboard key values still need to be fixed (first letter of each important word is capitalized)
Also, this would take away our ability to run the auto-climb. We should have separate buttons for autoclimb and manual climb. Otherwise, looks good.
Also merge conflicts
SaltyJoke
commented
Mar 5, 2019
Which button do you want for auto climb, which for manual climb? |
@doawelul fixed buttons and merge conflicts. please approve |
kevinzwang
commented
Mar 9, 2019
wait before you do that @SaltyJoke do the angle calculations work now? |
SaltyJoke
commented
Mar 9, 2019
The angle calculations work now if my geometry is correct. |
(also because I'm adding hatch buttons but ignore that)
I'd like to run this first because the numbers on the auto climb command has ambiguous numbers for tilt and for distance that we can narrow down with this command