Use WPILib logging - #2
Merged
Merged
Conversation
brettle
requested changes
May 9, 2022
brettle
left a comment
Member
There was a problem hiding this comment.
After making the one suggested change, I recommend merging this change independently of the lib199 changes since they don't seem to be required.
CoolSpy3
marked this pull request as ready for review
May 9, 2022 05:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPILib has released its own logging API. It will likely be more efficient and better maintained than the one in lib199. This pull request removes the references to lib199's logging API and enables logging via. WPILib. I would like to merge the corresponding lib199 changes in this PR, so I will mark it as review until that request is merged.