Skip to content

Use names for sim CAN devices and data that conform to spec #93

Description

@brettle

Based on my reading of the spec, we should make the following changes:

  1. SparkMax[id] -> CANMotor:CANSparkMax[id] with Speed -> percentOutput and Current Draw -> motorCurrent
  2. SparkFlex[id] -> CANMotor:CANSparkMax[id] with Speed -> percentOutput and Current Draw -> motorCurrent
  3. Spark*[id]_RelativeEncoder -> CANEncoder:CANSpark*[id] with Position -> position (w/ units changed to rotations) and Velocity -> velocity (w/ units changed to rps)
  4. Spark*[id]_AbsoluteEncoder -> CANDutyCycle:CANSpark*[id] with Position -> position (w/ units changed to rotations)
  5. CANCoder[i] -> CANDutyCycle:CANCoder[id] with count -> position (w/ units changed to rotations)
  6. (maybe?) PlayingWithFusionTimeOfFlight[i] -> CANAIn:PlayingWithFusionTimeOfFlight[i]-rangeVoltsIsMM with range->voltage and CANAIn:PlayingWithFusionTimeOfFlight[i]-ambientLightLevelVoltsIsMcps with ambientLightLevel->voltage.
  7. Change other data names to camel case for consistency (e.g. "Neutral Deadband" -> neutralDeadband).

Thoughts @CoolSpy3?

I would especially like to get the units changed so that simulation code don't need to jump through hoops to undo the various calculations that lib199 then redoes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions