Skip to content

Fix-error-when-accessing-SparkBase.getAbsoluteEncoder().getVelocity() - #103

Merged
brettle merged 3 commits into
masterfrom
fix-error-when-accessing-SparkBase.getAbsoluteEncoder().getVelocity()
Jun 20, 2024
Merged

Fix-error-when-accessing-SparkBase.getAbsoluteEncoder().getVelocity()#103
brettle merged 3 commits into
masterfrom
fix-error-when-accessing-SparkBase.getAbsoluteEncoder().getVelocity()

Conversation

@brettle

@brettle brettle commented Jun 20, 2024

Copy link
Copy Markdown
Member

Workaround access error when calling getVelocity() on and absolute encoder by moving the functionality from an anonymous subclass to MockedEncoder.

@brettle
brettle requested a review from a team as a code owner June 20, 2024 20:13
@brettle
brettle enabled auto-merge June 20, 2024 20:13

@CoolSpy3 CoolSpy3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small documentation note.

Comment thread src/main/java/org/carlmontrobotics/lib199/sim/MockedEncoder.java
@brettle
brettle merged commit 400693b into master Jun 20, 2024
@brettle
brettle deleted the fix-error-when-accessing-SparkBase.getAbsoluteEncoder().getVelocity() branch June 20, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants