Better Safe-Mode Commands - #60
Merged
Merged
Conversation
FriedLongJohns
approved these changes
Jul 21, 2023
FriedLongJohns
left a comment
Contributor
There was a problem hiding this comment.
Looks like the documentation bits have been updated as well, muy bien.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a number of improvements to safe-mode commands:
end()will no longer be called on safe commands which are immediately terminated.end(true)will be called if a command is stopped due to a safe-mode change.WrapperCommand. This means their name changes to that of the underlying command, and the code is more readable.