Fix MockedCANCoder test to be reliable. - #83
Merged
Conversation
Support running the tests repeatedly. That includes making sure that the CANcoder is closed after each test. Wait for the desired value to be set instead of just waiting for an update. Shorten the timeout to 2x the default robot period.
CoolSpy3
approved these changes
Apr 29, 2024
CoolSpy3
left a comment
Member
There was a problem hiding this comment.
✔️ Verified with NUM_REPS = 10000
It didn't look like InterruptedException was thrown anywhere, so I took out the throws clause. Feel free to add it back if that was in error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support running the tests repeatedly. That includes making sure that the CANcoder is closed after each test.
Wait for the desired value to be set instead of just waiting for an update.
Shorten the timeout to 2x the default robot period.
This is an alternative to PR #82.