Skip to content

[plotly.js] added typed array to scatter data - #25608

Merged
sheetalkamat merged 1 commit into
DefinitelyTyped:masterfrom
veggiesaurus:plotly.js-typedarray
May 8, 2018
Merged

[plotly.js] added typed array to scatter data#25608
sheetalkamat merged 1 commit into
DefinitelyTyped:masterfrom
veggiesaurus:plotly.js-typedarray

Conversation

@veggiesaurus

@veggiesaurusveggiesaurus commented May 8, 2018

Copy link
Copy Markdown
Contributor

Typed arrays were added as a possible scatter data type in version 1.35. This PR updates the type definition to allow the x, y, or z fields of the ScatterData interface to be populated by a typed array.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot

typescript-bot commented May 8, 2018

Copy link
Copy Markdown
Contributor

@veggiesaurus Thank you for submitting this PR!

🔔 @chrisgervang@martinduparc@frederikaalund@taoqf@Dadstart@szechyjs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bottypescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels May 8, 2018
@typescript-bot

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@sheetalkamat
sheetalkamat merged commit fdd6013 into DefinitelyTyped:masterMay 8, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner ApprovedA listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@veggiesaurus@typescript-bot@szechyjs@sheetalkamat