Uh oh!
There was an error while loading. Please reload this page.
Add type definitions for netlify-identity-widget - #30689
Conversation
c29bcfa to
403330eComparenaveenkumarsangi
commented
Nov 20, 2018
As suggested by the package maintainer (@sw-yx) of netlify-identity-widget, the type definitions are expected to be maintained here. |
@nkprince007 Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
Uh oh!
There was an error while loading. Please reload this page.
typescript-bot
commented
Nov 20, 2018
@nkprince007 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you! |
403330e to
9317b40Comparenaveenkumarsangi
commented
Nov 21, 2018
Thanks for the early review @uniqueiniquity. The response has been extremely timely. 👍 |
typescript-bot
commented
Nov 21, 2018
🔔 @uniqueiniquity - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
uniqueiniquity
commented
Nov 21, 2018
Congratulations on your first DefinitelyTyped contribution! |
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.