[chai-quantifiers] Remove, bundles its own types

[BendingBender]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@BendingBender Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

• chai-quantifiers (probably deleted!) — on npm, on unpkg
• Infra files
  • notNeededPackages.json

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
"type": "info",
"now": "-",
"pr_number": 53046,
"author": "BendingBender",
"headCommitOid": "9fd82dd09e57103a4b1d88666ef7750470367b10",
"lastPushDate": "2021-05-18T18:33:32.000Z",
"lastActivityDate": "2021-05-18T18:33:48.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "chai-quantifiers",
"kind": "delete",
"files": [
{
"path": "types/chai-quantifiers/chai-quantifiers-tests.ts",
"kind": "test"
},
{
"path": "types/chai-quantifiers/index.d.ts",
"kind": "definition"
},
{
"path": "types/chai-quantifiers/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/chai-quantifiers/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"tpluscode"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"ciResult": "pass"
}

[typescript-bot]

🔔 @tpluscode — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[tpluscode]

Thanks @BendingBender

I am aware that the types are available in that package, however they are not really equivalent. Please see funny-bytes/chai-quantifiers#13

I propose we first submit a PR to alleviate the differences:

1. I would expect the bundled types to work out of the box, without importing
2. Add the generic argument so that the callback argument can be fully typed

[BendingBender]

Yeah, you're right with this. It's definitely premature to remove the types here. I'll close the PR and maybe resubmit later, after the types in the package were improved.

[tpluscode]

Here's my PR for the second point: funny-bytes/chai-quantifiers#14

Unfortunately, I am yet to figure out the other