5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
5 changes: 4 additions & 1 deletion apps/desktop/src/settings/DesktopClientSettings.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ const clientSettings: ClientSettings = {
planModeEnabled: false,
providerModelPreferences: {},
sidebarAutoSettleAfterDays: 3,
sidebarAutoSettleCompletedChangeRequests: false,
sidebarProjectGroupingMode: "repository_path",
sidebarProjectGroupingOverrides: {
"environment-1:/tmp/project-a": "separate",
Expand DownExpand Up@@ -201,7 +202,9 @@ describe("DesktopClientSettings", () => {
yield* fileSystem.makeDirectory(environment.stateDir, { recursive: true });
yield* fileSystem.writeFileString(environment.clientSettingsPath, "{}\n");

assert.deepEqual(yield* settings.get, Option.some(yield* decodeClientSettingsJson("{}")));
const persisted = yield* settings.get;
assert.deepEqual(persisted, Option.some(yield* decodeClientSettingsJson("{}")));
assert.isTrue(Option.getOrThrow(persisted).sidebarAutoSettleCompletedChangeRequests);
}),
),
);
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/home/HomeScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ import { scopedProjectKey } from "../../lib/scopedEntities";
import { NATIVE_LIQUID_GLASS_SUPPORTED } from "../../native/native-glass";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import type { PendingNewTask } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -207,6 +208,7 @@ export function HomeScreen(props: HomeScreenProps) {
>(() => new Map());
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const openSwipeableRef = useRef<SwipeableMethods | null>(null);
const listRef = useRef<LegendListRef | null>(null);
Expand DownExpand Up@@ -665,6 +667,7 @@ export function HomeScreen(props: HomeScreenProps) {
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -675,6 +678,7 @@ export function HomeScreen(props: HomeScreenProps) {
selectedThreadKey: null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
19 changes: 19 additions & 0 deletions apps/mobile/src/features/settings/SettingsRouteScreen.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ import { WorkspaceSidebarToolbar } from "../layout/workspace-sidebar-toolbar";
import { runtime } from "../../lib/runtime";
import { useThemeColor } from "../../lib/useThemeColor";
import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
import { useAutoSettleCompletedChangeRequests } from "../threads/use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "../threads/use-thread-list-v2-enabled";
import {
type AppUpdateCheckState,
Expand All@@ -46,6 +47,7 @@ import { useSavedRemoteConnections } from "../../state/use-remote-environment-re
import { SettingsRow } from "./components/SettingsRow";
import { SettingsSection } from "./components/SettingsSection";
import { SettingsSwitchRow } from "./components/SettingsSwitchRow";
import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

type NotificationStatus = "checking" | "enabled" | "disabled" | "unsupported";
type LiveActivityStatus = "checking" | "enabled" | "disabled" | "signed-out" | "linking";
Expand DownExpand Up@@ -522,10 +524,27 @@ function ConfiguredSettingsRouteScreen() {
}

function GeneralSettingsSection() {
const preferencesResult = useAtomValue(mobilePreferencesAtom);
const savePreferences = useAtomSet(updateMobilePreferencesAtom);
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const preferencesLoaded = AsyncResult.isSuccess(preferencesResult) && !preferencesResult.waiting;

return (
<SettingsSection title="General">
<SettingsRow icon="folder" label="Project Grouping" target="SettingsProjectGrouping" />
<SettingsRow icon="chart.bar.xaxis" label="Usage" target="SettingsUsage" />
{shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded,
threadListV2Enabled,
}) ? (
<SettingsSwitchRow
icon="checkmark.circle"
label="Auto-settle completed pull requests"
value={autoSettleCompletedChangeRequests}
onValueChange={(value) => savePreferences({ autoSettleCompletedChangeRequests: value })}
/>
) : null}
</SettingsSection>
);
}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { describe, expect, it } from "vite-plus/test";

import { shouldShowAutoSettleCompletedChangeRequestsSetting } from "./autoSettleCompletedChangeRequests";

describe("shouldShowAutoSettleCompletedChangeRequestsSetting", () => {
it("shows the control only after preferences load for the list it changes", () => {
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: false,
threadListV2Enabled: true,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: false,
}),
).toBe(false);
expect(
shouldShowAutoSettleCompletedChangeRequestsSetting({
preferencesLoaded: true,
threadListV2Enabled: true,
}),
).toBe(true);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
export function shouldShowAutoSettleCompletedChangeRequestsSetting(input: {
readonly preferencesLoaded: boolean;
readonly threadListV2Enabled: boolean;
}): boolean {
return input.preferencesLoaded && input.threadListV2Enabled;
}
4 changes: 4 additions & 0 deletions apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@ import { scopedProjectKey, scopedThreadKey } from "../../lib/scopedEntities";
import { useThemeColor } from "../../lib/useThemeColor";
import { useProjects, useThreadShells } from "../../state/entities";
import { useThreadSearch } from "../../state/queries";
import { useAutoSettleCompletedChangeRequests } from "./use-auto-settle-completed-change-requests";
import { useThreadListV2Enabled } from "./use-thread-list-v2-enabled";
import { environmentServerConfigsAtom } from "../../state/server";
import { usePendingNewTasks } from "../../state/use-pending-new-tasks";
Expand DownExpand Up@@ -214,6 +215,7 @@ function ThreadNavigationSidebarPane(
regenerateThreadTitle,
} = useThreadListActions();
const threadListV2Enabled = useThreadListV2Enabled();
const autoSettleCompletedChangeRequests = useAutoSettleCompletedChangeRequests();
const pendingTasks = usePendingNewTasks();
const { openPendingTask, confirmDeletePendingTask } = usePendingTaskListActions();
const environments = useMemo(
Expand DownExpand Up@@ -546,6 +548,7 @@ function ThreadNavigationSidebarPane(
searchQuery: props.searchQuery,
matchedThreadKeys,
changeRequestStateByKey,
autoSettleCompletedChangeRequests,
settlementEnvironmentIds,
snoozeEnvironmentIds,
settledLimit: settledVisibleCount,
Expand All@@ -556,6 +559,7 @@ function ThreadNavigationSidebarPane(
selectedThreadKey: props.selectedThreadKey ?? null,
});
}, [
autoSettleCompletedChangeRequests,
changeRequestStateByKey,
nowMinute,
snoozeWakeTick,
Expand Down
126 changes: 126 additions & 0 deletions apps/mobile/src/features/threads/threadListV2.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-searc
import { resolveSnoozePresets } from "@t3tools/client-runtime/state/thread-settled";
import {
CommandId,
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
EnvironmentId,
MessageId,
ProjectId,
Expand All@@ -16,6 +17,7 @@ import type { PendingNewTask } from "../../state/use-pending-new-tasks";
import {
buildThreadListV2Items,
buildThreadListV2ListItems,
resolveAutoSettleCompletedChangeRequests,
resolveThreadListV2Enabled,
resolveThreadListV2SnoozeMenuSelection,
resolveThreadListV2SnoozeGateExpiryMs,
Expand DownExpand Up@@ -125,6 +127,29 @@ describe("resolveThreadListV2Enabled", () => {
});
});

describe("resolveAutoSettleCompletedChangeRequests", () => {
it("preserves an explicit disabled preference", () => {
expect(
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded: true }),
).toBe(false);
});

it("uses the shared completed-PR auto-settle default when the preference is absent", () => {
expect(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS).toBe(true);
expect(
resolveAutoSettleCompletedChangeRequests({ preference: undefined, preferencesLoaded: true }),
).toBe(DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS);
});

it("keeps a saved disabled preference disabled through hydration", () => {
const resolvedStates = [false, true].map((preferencesLoaded) =>
resolveAutoSettleCompletedChangeRequests({ preference: false, preferencesLoaded }),
);

expect(resolvedStates).toEqual([false, false]);
});
});

describe("resolveThreadListV2Status", () => {
it("prioritizes approval over a running session", () => {
const thread = makeThread({
Expand DownExpand Up@@ -315,6 +340,107 @@ describe("buildThreadListV2Items", () => {
expect(layout.settledCount).toBe(0);
});

it("keeps fresh completed-PR threads active when completed-PR auto-settle is off", () => {
const fresh = makeThread({
id: ThreadId.make("fresh-completed-pr"),
title: "Fresh completed PR",
latestUserMessageAt: "2026-06-01T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("fresh-completed-pr-turn"),
state: "completed",
requestedAt: "2026-06-01T12:00:00.000Z",
startedAt: "2026-06-01T12:00:00.000Z",
completedAt: "2026-06-01T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["fresh-completed-pr", "card"],
]);
expect(layout.settledCount).toBe(0);
});

it("does not briefly settle a saved-disabled completed pull request while preferences hydrate", () => {
const fresh = makeThread({
id: ThreadId.make("saved-disabled-completed-pr"),
title: "Saved disabled completed PR",
});
const layouts = [false, true].map((preferencesLoaded) =>
buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleCompletedChangeRequests: resolveAutoSettleCompletedChangeRequests({
preference: false,
preferencesLoaded,
}),
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "closed"]]),
}),
);

expect(layouts.map((layout) => layout.items[0]?.variant)).toEqual(["card", "card"]);
expect(layouts.map((layout) => layout.settledCount)).toEqual([0, 0]);
});

it("defaults completed-PR auto-settle on for existing mobile installs", () => {
const fresh = makeThread({
id: ThreadId.make("default-completed-pr"),
title: "Default completed PR",
});
const layout = buildThreadListV2Items({
threads: [fresh],
environmentId: null,
searchQuery: "",
now: NOW,
changeRequestStateByKey: new Map([[`${environmentId}:${fresh.id}`, "merged"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["default-completed-pr", "slim"],
]);
});

it("keeps inactivity settlement independent when completed-PR auto-settle is off", () => {
const stale = makeThread({
id: ThreadId.make("stale-completed-pr"),
title: "Stale completed PR",
latestUserMessageAt: "2026-05-28T12:00:00.000Z",
latestTurn: {
turnId: TurnId.make("stale-completed-pr-turn"),
state: "completed",
requestedAt: "2026-05-28T12:00:00.000Z",
startedAt: "2026-05-28T12:00:00.000Z",
completedAt: "2026-05-28T12:10:00.000Z",
assistantMessageId: null,
},
});
const layout = buildThreadListV2Items({
threads: [stale],
environmentId: null,
searchQuery: "",
now: NOW,
autoSettleAfterDays: 3,
autoSettleCompletedChangeRequests: false,
changeRequestStateByKey: new Map([[`${environmentId}:${stale.id}`, "closed"]]),
});

expect(layout.items.map((item) => [item.thread.id, item.variant])).toEqual([
["stale-completed-pr", "slim"],
]);
expect(layout.settledCount).toBe(1);
});

it("snooze hides a pinned thread and wake restores it to the pinned block", () => {
const snoozedInput = {
threads: [
Expand Down
35 changes: 31 additions & 4 deletions apps/mobile/src/features/threads/threadListV2.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,11 @@ import type { SnoozePreset } from "@t3tools/client-runtime/state/thread-settled"
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
import { threadSearchMatchKey } from "@t3tools/client-runtime/state/thread-search";
import { sortPinnedThreadsByOrderKey } from "@t3tools/client-runtime/state/thread-sort";
import type { EnvironmentId, ProjectId } from "@t3tools/contracts";
import {
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS,
type EnvironmentId,
type ProjectId,
} from "@t3tools/contracts";

import type { PendingNewTask } from "../../state/use-pending-new-tasks";

Expand DownExpand Up@@ -122,6 +126,20 @@ export function resolveThreadListV2Enabled(input: {
return input.legacyPreference !== true;
}

/**
* Existing installs had completed-PR auto-settlement before this preference
* existed, so an absent loaded value preserves that behavior. Until mobile
* preferences load, keep every thread visible rather than temporarily settling
* a thread whose stored device-local preference is false.
*/
export function resolveAutoSettleCompletedChangeRequests(input: {
readonly preference: boolean | undefined;
readonly preferencesLoaded: boolean;
}): boolean {
if (!input.preferencesLoaded) return false;
return input.preference ?? DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
}

export function resolveThreadListV2Status(
thread: Pick<EnvironmentThreadShell, "hasPendingApprovals" | "hasPendingUserInput" | "session">,
): ThreadListV2Status {
Expand DownExpand Up@@ -307,8 +325,8 @@ export function buildThreadListV2ListItems(input: {
/**
* Partitions visible threads into the active card block (creation order) and
* the settled recency tail, matching the web v2 list. `autoSettleAfterDays`
* mirrors the web default of 3 — mobile has no client-settings sync yet, so
* the default is fixed here rather than user-configurable.
* mirrors the web default of 3. Completed-change-request auto-settlement is
* configurable through a device-local mobile preference.
*/
export function buildThreadListV2Items(input: {
readonly threads: ReadonlyArray<EnvironmentThreadShell>;
Expand All@@ -329,6 +347,7 @@ export function buildThreadListV2Items(input: {
contract as settlementEnvironmentIds. */
readonly snoozeEnvironmentIds?: ReadonlySet<EnvironmentId>;
readonly autoSettleAfterDays?: number;
readonly autoSettleCompletedChangeRequests?: boolean;
/** Max settled rows to render; the rest are counted, not built. */
readonly settledLimit?: number;
/** Injectable for tests; defaults to now. */
Expand All@@ -349,6 +368,9 @@ export function buildThreadListV2Items(input: {
const now = input.now ?? new Date().toISOString();
const snoozeNow = input.snoozeNow ?? now;
const autoSettleAfterDays = input.autoSettleAfterDays ?? 3;
const autoSettleCompletedChangeRequests =
input.autoSettleCompletedChangeRequests ??
DEFAULT_SIDEBAR_AUTO_SETTLE_COMPLETED_CHANGE_REQUESTS;
const query = input.searchQuery.trim().toLocaleLowerCase();
const projectKeys = input.projectRefs
? new Set(input.projectRefs.map((ref) => `${ref.environmentId}:${ref.projectId}`))
Expand DownExpand Up@@ -405,7 +427,12 @@ export function buildThreadListV2Items(input: {
}
if (
supportsSettlement &&
effectiveSettled(thread, { now, autoSettleAfterDays, changeRequestState })
effectiveSettled(thread, {
now,
autoSettleAfterDays,
autoSettleCompletedChangeRequests,
changeRequestState,
})
) {
settled.push(thread);
} else {
Expand Down
Loading
Loading