fix(examples): refresh the committed engine-deck-v2 asset - #460
Merged
Conversation
The banner fix corrected the source and the hero PNG, but this deck's page one is the same banner and its committed copy was never regenerated — it still showed the v2.0.0 pill, the "2.0 MODULE-FIRST" kicker, and a module row without render-pptx. Regenerated at 2.1.0 to match the published release rather than the working SNAPSHOT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#458 fixed the banner source and regenerated the hero PNG. It missed that page one of
engine-deck-v2.pdfis that same banner, and the committed PDF was never re-rendered.The asset linked from the examples gallery therefore still showed exactly the defect that PR set out to remove:
v2.0.0v2.1.0GRAPHCOMPOSE 2.0 / MODULE-FIRSTGRAPHCOMPOSE 2.1 / MODULE-FIRSTTHE 2.0 MODULE GRAPHTHE 2.1 MODULE GRAPHrender-pdf·render-docxrender-pdf·render-pptx·render-docxStamped
2.1.0rather than the working2.1.1-SNAPSHOT, matching the published release — same handling as the hero PNG and the engine deck in the release commit.Verified on the committed file: 5 pages, all four values above now read correctly.
The gap this keeps falling through
cut-release.ps1regenerates exactly one committed asset —assets/readme/repository_showcase_render.png. There are 82 files underassets/readme/, and every other one is frozen at whatever commit last touched it by hand. That is why the same banner had to be fixed three times in a row, in three different files.Tracked in more detail alongside #454.