Uh oh!
There was an error while loading. Please reload this page.
Merge chore/ruff-pylint-precommit into main - #4
Open
Tokarzewski wants to merge 3 commits into
Open
Conversation
Bring db-cli in line with the other db-* repos: - add a build-system, a uv dev dependency group, and ruff + pylint config; add .pre-commit-config.yaml (ruff + pylint + pytest hooks) and a uv-based lint + test CI workflow with a private-dependency auth step (the schema is installed from a private repo, so CI uses a DB_SCHEMA_TOKEN secret) - fix the broken schema integration so the package imports again: the package was renamed (designbuilder_schema -> db_schema) and the old file_to_dict/dict_to_file helpers were removed, so get_version now uses load_model(...).version (as validate_file already does); drop the obsolete sys.path hack and unused imports - fix the genuine lint findings (unused run_async results, missing docstrings, intentional broad-except) Note: the sample-dependent tests are skipped — EmptySite.xml is missing and the checked-in Shoebox*.xml samples are malformed (lxml cannot parse them). A valid dsbXML fixture is needed to re-enable them (tracked separately). ruff check + format clean, pylint 10.00/10, tests pass (2 skipped); all pre-commit hooks pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…o merge/chore-ruff-pylint-precommit # Conflicts: # db_cli/cli.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chore/ruff-pylint-precommitbranch (adds ruff/pylint/pre-commit tooling) intomaindb_cli/cli.py— kept main's tested dict-basedget_version()logic, layered on the branch's genuine lint fixes (import ordering, unused import removal)dict_to_fileimport, unsorted import inconftest.py, and an unnecessaryelseafterreturnTest plan
uv run ruff check/uv run ruff format --check— cleanuv run pylint db_cli— 10.00/10pytest— 53 passed (verified on Python 3.10 and 3.13)