Uh oh!
There was an error while loading. Please reload this page.
Fix meter results returning key='None' for NULL KeyValue (#12) - #21
Merged
Conversation
Since EnergyPlus 23.1 the KeyValue of meter outputs is stored as NULL instead of an empty string. to_string() ran str() over every field, so a NULL KeyValue surfaced as the literal string 'None' in the returned Variable. Normalize None fields to an empty string so meters present a key of '' as before. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes#12 — meter results came back with the literal string
key='None'.Since EnergyPlus 23.1, the
KeyValueof meter outputs is stored asNULLin the.sqlfile instead of an empty string.to_string()mappedstr()over every field, so aNULLKeyValue surfaced as the string"None":Fix
to_string()now normalizes aNonefield to an empty string, restoring the prior meter representation (key=""). Wildcard matching withVariable(None, ...)is unaffected —Nonefields are still skipped in the query builder.Tests
Added
test_meter_null_keyvalue_is_empty_stringasserting a meter request returnskey == ""with non-empty data. Full suite green;ruff check/format --checkclean.🤖 Generated with Claude Code