Uh oh!
There was an error while loading. Please reload this page.
(1) Fix/legend - #389
Merged
Merged
Conversation
| this.text.rowIndices = []; | ||
| try { | ||
| this.text.draw(context); | ||
| } catch (TypeError) {} |
Collaborator
There was a problem hiding this comment.
It seems weird to do nothing when catching an error. What is the usecase, here ?
CollaboratorAuthor
There was a problem hiding this comment.
It is to avoid a bug when objects are too small and their dimensions cannot be handled anymore by canvas.
Catching this error allows to play from very wide pics to very small not drawn pics without crashing web browser
Collaborator
There was a problem hiding this comment.
Alright, I think stating it as a comment in the catch statement could help next devs to understand it
GhislainJ
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing text writing in legend.
Fix is quite dirty